Issues in LabelSetter.php (master) - Issues in master - addwiki/wikibase-api - Measure and Improve Code Quality continuously with Scrutinizer

Issues (24)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Api/Service/LabelSetter.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Wikibase\Api\Service;

use Mediawiki\DataModel\EditInfo;
use UnexpectedValueException;
use Wikibase\Api\WikibaseApi;
use Wikibase\DataModel\Entity\EntityId;
use Wikibase\DataModel\Entity\Item;
use Wikibase\DataModel\Entity\Property;
use Wikibase\DataModel\SiteLink;
use Wikibase\DataModel\Term\Term;

/**
 * @access private
 *
 * @author Addshore
 */
class LabelSetter {


	/**
	 * @var WikibaseApi
	 */
	private $api;

	/**
	 * @param WikibaseApi $api
	 */
	public function __construct( WikibaseApi $api ) {
		$this->api = $api;
	}

	/**
	 * @since 0.2
	 *
	 * @param Term $label
	 * @param EntityId|Item|Property|SiteLink $target
	 * @param EditInfo|null $editInfo
	 *
	 * @return bool
	 */
	public function set( Term $label, $target, EditInfo $editInfo = null ) {
		$this->throwExceptionsOnBadTarget( $target );

		$params = $this->getTargetParamsFromTarget(
			$this->getEntityIdentifierFromTarget( $target )

		);

		$params['language'] = $label->getLanguageCode();
		$params['value'] = $label->getText();

		$this->api->postRequest( 'wbsetlabel', $params, $editInfo );
		return true;
	}

	/**
	 * @param mixed $target
	 *
	 * @throws UnexpectedValueException
	 *
	 * @todo Fix duplicated code
	 */
	private function throwExceptionsOnBadTarget( $target ) {
		if ( !$target instanceof EntityId && !$target instanceof Item && !$target instanceof Property && !$target instanceof SiteLink ) {
			throw new UnexpectedValueException( '$target needs to be an EntityId, Item, Property or SiteLink' );
		}
		if ( ( $target instanceof Item || $target instanceof Property ) && $target->getId() === null ) {
			throw new UnexpectedValueException( '$target Entity object needs to have an Id set' );
		}
	}

	/**
	 * @param EntityId|Item|Property $target
	 *
	 * @throws UnexpectedValueException
	 * @return EntityId|SiteLink
	 *
	 * @todo Fix duplicated code
	 */
	private function getEntityIdentifierFromTarget( $target ) {
		if ( $target instanceof Item || $target instanceof Property ) {
			return $target->getId();
		} else {
			return $target;
		}
	}

	/**
	 * @param EntityId|SiteLink $target
	 *
	 * @throws UnexpectedValueException
	 * @return array
	 *
	 * @todo Fix duplicated code
	 */
	private function getTargetParamsFromTarget( $target ) {
		if ( $target instanceof EntityId ) {
			return [ 'id' => $target->getSerialization() ];
		} elseif ( $target instanceof SiteLink ) {
			return [
				'site' => $target->getSiteId(),
				'title' => $target->getPageName(),
			];
		} else {
			throw new UnexpectedValueException( '$target needs to be an EntityId or SiteLink' );
		}
	}

}


1		<?php
2
3		namespace Wikibase\Api\Service;
4
5		use Mediawiki\DataModel\EditInfo;
6		use UnexpectedValueException;
7		use Wikibase\Api\WikibaseApi;
8		use Wikibase\DataModel\Entity\EntityId;
9		use Wikibase\DataModel\Entity\Item;
10		use Wikibase\DataModel\Entity\Property;
11		use Wikibase\DataModel\SiteLink;
12		use Wikibase\DataModel\Term\Term;
13
14		/**
15		* @access private
16		*
17		* @author Addshore
18		*/
19	View Code Duplication	class LabelSetter {
		0 ignored issues – show Duplication introduced 2021-01-24 16:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
20
21		/**
22		* @var WikibaseApi
23		*/
24		private $api;
25
26		/**
27		* @param WikibaseApi $api
28		*/
29		public function __construct( WikibaseApi $api ) {
30		$this->api = $api;
31		}
32
33		/**
34		* @since 0.2
35		*
36		* @param Term $label
37		* @param EntityId\|Item\|Property\|SiteLink $target
38		* @param EditInfo\|null $editInfo
39		*
40		* @return bool
41		*/
42		public function set( Term $label, $target, EditInfo $editInfo = null ) {
43		$this->throwExceptionsOnBadTarget( $target );
44
45		$params = $this->getTargetParamsFromTarget(
46		$this->getEntityIdentifierFromTarget( $target )
		0 ignored issues – show Bug introduced 2016-02-10 10:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$target` defined by parameter `$target` on line 42 can also be of type `object<Wikibase\DataModel\SiteLink>`; however, `Wikibase\Api\Service\Lab...yIdentifierFromTarget()` does only seem to accept `object<Wikibase\DataMode...aModel\Entity\Property>`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
47		);
48
49		$params['language'] = $label->getLanguageCode();
50		$params['value'] = $label->getText();
51
52		$this->api->postRequest( 'wbsetlabel', $params, $editInfo );
53		return true;
54		}
55
56		/**
57		* @param mixed $target
58		*
59		* @throws UnexpectedValueException
60		*
61		* @todo Fix duplicated code
62		*/
63		private function throwExceptionsOnBadTarget( $target ) {
64		if ( !$target instanceof EntityId && !$target instanceof Item && !$target instanceof Property && !$target instanceof SiteLink ) {
65		throw new UnexpectedValueException( '$target needs to be an EntityId, Item, Property or SiteLink' );
66		}
67		if ( ( $target instanceof Item \|\| $target instanceof Property ) && $target->getId() === null ) {
68		throw new UnexpectedValueException( '$target Entity object needs to have an Id set' );
69		}
70		}
71
72		/**
73		* @param EntityId\|Item\|Property $target
74		*
75		* @throws UnexpectedValueException
76		* @return EntityId\|SiteLink
77		*
78		* @todo Fix duplicated code
79		*/
80		private function getEntityIdentifierFromTarget( $target ) {
81		if ( $target instanceof Item \|\| $target instanceof Property ) {
82		return $target->getId();
83		} else {
84		return $target;
85		}
86		}
87
88		/**
89		* @param EntityId\|SiteLink $target
90		*
91		* @throws UnexpectedValueException
92		* @return array
93		*
94		* @todo Fix duplicated code
95		*/
96		private function getTargetParamsFromTarget( $target ) {
97		if ( $target instanceof EntityId ) {
98		return [ 'id' => $target->getSerialization() ];
99		} elseif ( $target instanceof SiteLink ) {
100		return [
101		'site' => $target->getSiteId(),
102		'title' => $target->getPageName(),
103		];
104		} else {
105		throw new UnexpectedValueException( '$target needs to be an EntityId or SiteLink' );
106		}
107		}
108
109		}
110

addwiki / wikibase-api

Issues (24)

Security Analysis no request data

src/Api/Service/LabelSetter.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like