adamjakab / SuiteCRM

modules/Favorites/views/view.edit.php

Spacing +5 added lines, -5 removed lines

@@ -1,19 +1,19 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 
 require_once('include/MVC/View/views/view.edit.php');
 
 class FavoritesViewEdit extends ViewEdit {
-	function __construct(){
+	function __construct() {
  		parent::__construct();
  	}
 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    function FavoritesViewEdit(){
+    function FavoritesViewEdit() {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {
@@ -23,7 +23,7 @@ 
     }
 
 
-	function display(){
+	function display() {
 		parent::display();
 	}
 

Braces +4 added lines, -3 removed lines

@@ -43,7 +43,9 @@ 
  * Date: 06/03/15
  * Comments
  */
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 
 class CasesController extends SugarController {
 
@@ -90,8 +92,7 @@ 
                 $count++;
             }
             echo '</table>';
-        }
-        else {
+        } else {
             echo $mod_strings['LBL_NO_SUGGESTIONS'];
         }
         die();

modules/Favorites/Dashlets/Favorites/FavoritesDashlet.php

Spacing +4 added lines, -4 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -56,7 +56,7 @@ 
 
         parent::__construct($id, $def);
 
-        if(empty($def['title'])) $this->title = translate('LBL_HOMEPAGE_TITLE', 'Favorites');
+        if (empty($def['title'])) $this->title = translate('LBL_HOMEPAGE_TITLE', 'Favorites');
 
         $this->searchFields = $dashletData['FavoritesDashlet']['searchFields'];
         $this->columns = $dashletData['FavoritesDashlet']['columns'];
@@ -67,9 +67,9 @@ 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    function FavoritesDashlet($id, $def = null){
+    function FavoritesDashlet($id, $def = null) {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {

Braces +7 added lines, -4 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -56,7 +58,9 @@ 
 
         parent::__construct($id, $def);
 
-        if(empty($def['title'])) $this->title = translate('LBL_HOMEPAGE_TITLE', 'Favorites');
+        if(empty($def['title'])) {
+            $this->title = translate('LBL_HOMEPAGE_TITLE', 'Favorites');
+        }
 
         $this->searchFields = $dashletData['FavoritesDashlet']['searchFields'];
         $this->columns = $dashletData['FavoritesDashlet']['columns'];
@@ -71,8 +75,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct($id, $def);

modules/Accounts/Dashlets/MyAccountsDashlet/MyAccountsDashlet.php

Spacing +6 added lines, -6 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -52,7 +52,7 @@ 
 
         parent::__construct($id, $def);
 
-        if(empty($def['title'])) $this->title = translate('LBL_HOMEPAGE_TITLE', 'Accounts');
+        if (empty($def['title'])) $this->title = translate('LBL_HOMEPAGE_TITLE', 'Accounts');
 
         $this->searchFields = $dashletData['MyAccountsDashlet']['searchFields'];
         $this->columns = $dashletData['MyAccountsDashlet']['columns'];
@@ -63,9 +63,9 @@ 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    function MyAccountsDashlet($id, $def = null){
+    function MyAccountsDashlet($id, $def = null) {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {
@@ -92,8 +92,8 @@ 
     	}
 
         if (isset($this->displayColumns) && array_search('parent_name', $this->displayColumns) !== false) {
-	    	$lvsParams['custom_select'] = empty($lvsParams['custom_select']) ? ', a1.name as parent_name ' : $lvsParams['custom_select'] . ', a1.name as parent_name ';
-	    	$lvsParams['custom_from'] = empty($lvsParams['custom_from']) ? ' LEFT JOIN accounts a1 on a1.id = accounts.parent_id' : $lvsParams['custom_from'] . ' LEFT JOIN accounts a1 on a1.id = accounts.parent_id';
+	    	$lvsParams['custom_select'] = empty($lvsParams['custom_select']) ? ', a1.name as parent_name ' : $lvsParams['custom_select'].', a1.name as parent_name ';
+	    	$lvsParams['custom_from'] = empty($lvsParams['custom_from']) ? ' LEFT JOIN accounts a1 on a1.id = accounts.parent_id' : $lvsParams['custom_from'].' LEFT JOIN accounts a1 on a1.id = accounts.parent_id';
     	}
 
     	parent::process($lvsParams);

Braces +7 added lines, -4 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -52,7 +54,9 @@ 
 
         parent::__construct($id, $def);
 
-        if(empty($def['title'])) $this->title = translate('LBL_HOMEPAGE_TITLE', 'Accounts');
+        if(empty($def['title'])) {
+            $this->title = translate('LBL_HOMEPAGE_TITLE', 'Accounts');
+        }
 
         $this->searchFields = $dashletData['MyAccountsDashlet']['searchFields'];
         $this->columns = $dashletData['MyAccountsDashlet']['columns'];
@@ -67,8 +71,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct($id, $def);

modules/Accounts/Account.php

Indentation +226 added lines, -226 removed lines

@@ -48,43 +48,43 @@ 
 
 // Account is used to store account information.
 class Account extends Company {
-	var $field_name_map = array();
-	// Stored fields
-	var $date_entered;
-	var $date_modified;
-	var $modified_user_id;
-	var $assigned_user_id;
-	var $annual_revenue;
-	var $billing_address_street;
-	var $billing_address_city;
-	var $billing_address_state;
-	var $billing_address_country;
-	var $billing_address_postalcode;
+    var $field_name_map = array();
+    // Stored fields
+    var $date_entered;
+    var $date_modified;
+    var $modified_user_id;
+    var $assigned_user_id;
+    var $annual_revenue;
+    var $billing_address_street;
+    var $billing_address_city;
+    var $billing_address_state;
+    var $billing_address_country;
+    var $billing_address_postalcode;
 
     var $billing_address_street_2;
     var $billing_address_street_3;
     var $billing_address_street_4;
 
-	var $description;
-	var $email1;
-	var $email2;
-	var $email_opt_out;
-	var $invalid_email;
-	var $employees;
-	var $id;
-	var $industry;
-	var $name;
-	var $ownership;
-	var $parent_id;
-	var $phone_alternate;
-	var $phone_fax;
-	var $phone_office;
-	var $rating;
-	var $shipping_address_street;
-	var $shipping_address_city;
-	var $shipping_address_state;
-	var $shipping_address_country;
-	var $shipping_address_postalcode;
+    var $description;
+    var $email1;
+    var $email2;
+    var $email_opt_out;
+    var $invalid_email;
+    var $employees;
+    var $id;
+    var $industry;
+    var $name;
+    var $ownership;
+    var $parent_id;
+    var $phone_alternate;
+    var $phone_fax;
+    var $phone_office;
+    var $rating;
+    var $shipping_address_street;
+    var $shipping_address_city;
+    var $shipping_address_state;
+    var $shipping_address_country;
+    var $shipping_address_postalcode;
 
     var $shipping_address_street_2;
     var $shipping_address_street_3;
@@ -92,204 +92,204 @@ 
 
     var $campaign_id;
 
-	var $sic_code;
-	var $ticker_symbol;
-	var $account_type;
-	var $website;
-	var $custom_fields;
-
-	var $created_by;
-	var $created_by_name;
-	var $modified_by_name;
-
-	// These are for related fields
-	var $opportunity_id;
-	var $case_id;
-	var $contact_id;
-	var $task_id;
-	var $note_id;
-	var $meeting_id;
-	var $call_id;
-	var $email_id;
-	var $member_id;
-	var $parent_name;
-	var $assigned_user_name;
-	var $account_id = '';
-	var $account_name = '';
-	var $bug_id ='';
-	var $module_dir = 'Accounts';
-	var $emailAddress;
-
-
-	var $table_name = "accounts";
-	var $object_name = "Account";
-	var $importable = true;
-	var $new_schema = true;
-	// This is used to retrieve related fields from form posts.
-	var $additional_column_fields = Array('assigned_user_name', 'assigned_user_id', 'opportunity_id', 'bug_id', 'case_id', 'contact_id', 'task_id', 'note_id', 'meeting_id', 'call_id', 'email_id', 'parent_name', 'member_id'
-	);
-	var $relationship_fields = Array('opportunity_id'=>'opportunities', 'bug_id' => 'bugs', 'case_id'=>'cases',
-									'contact_id'=>'contacts', 'task_id'=>'tasks', 'note_id'=>'notes',
-									'meeting_id'=>'meetings', 'call_id'=>'calls', 'email_id'=>'emails','member_id'=>'members',
-									'project_id'=>'project',
-									);
+    var $sic_code;
+    var $ticker_symbol;
+    var $account_type;
+    var $website;
+    var $custom_fields;
+
+    var $created_by;
+    var $created_by_name;
+    var $modified_by_name;
+
+    // These are for related fields
+    var $opportunity_id;
+    var $case_id;
+    var $contact_id;
+    var $task_id;
+    var $note_id;
+    var $meeting_id;
+    var $call_id;
+    var $email_id;
+    var $member_id;
+    var $parent_name;
+    var $assigned_user_name;
+    var $account_id = '';
+    var $account_name = '';
+    var $bug_id ='';
+    var $module_dir = 'Accounts';
+    var $emailAddress;
+
+
+    var $table_name = "accounts";
+    var $object_name = "Account";
+    var $importable = true;
+    var $new_schema = true;
+    // This is used to retrieve related fields from form posts.
+    var $additional_column_fields = Array('assigned_user_name', 'assigned_user_id', 'opportunity_id', 'bug_id', 'case_id', 'contact_id', 'task_id', 'note_id', 'meeting_id', 'call_id', 'email_id', 'parent_name', 'member_id'
+    );
+    var $relationship_fields = Array('opportunity_id'=>'opportunities', 'bug_id' => 'bugs', 'case_id'=>'cases',
+                                    'contact_id'=>'contacts', 'task_id'=>'tasks', 'note_id'=>'notes',
+                                    'meeting_id'=>'meetings', 'call_id'=>'calls', 'email_id'=>'emails','member_id'=>'members',
+                                    'project_id'=>'project',
+                                    );
 
     //Meta-Data Framework fields
     var $push_billing;
     var $push_shipping;
 
-	public function __construct() {
+    public function __construct() {
         parent::__construct();
 
 
         $this->setupCustomFields('Accounts');
 
-		foreach ($this->field_defs as $field)
-		{
-			if(isset($field['name']))
-			{
-				$this->field_name_map[$field['name']] = $field;
-			}
-		}
+        foreach ($this->field_defs as $field)
+        {
+            if(isset($field['name']))
+            {
+                $this->field_name_map[$field['name']] = $field;
+            }
+        }
 
 
         //Email logic
-		if (!empty($_REQUEST['parent_id']) && !empty($_REQUEST['parent_type']) && $_REQUEST['parent_type'] == 'Emails'
-        	&& !empty($_REQUEST['return_module']) && $_REQUEST['return_module'] == 'Emails') {
-			$_REQUEST['parent_name'] = '';
-			$_REQUEST['parent_id'] = '';
-		}
-	}
-
-	/**
-	 * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
-	 */
-	public function Account(){
-		$deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-		if(isset($GLOBALS['log'])) {
-			$GLOBALS['log']->deprecated($deprecatedMessage);
-		}
-		else {
-			trigger_error($deprecatedMessage, E_USER_DEPRECATED);
-		}
-		self::__construct();
-	}
-
-	function get_summary_text()
-	{
-		return $this->name;
-	}
-
-	function get_contacts() {
-		return $this->get_linked_beans('contacts','Contact');
-	}
-
-
-
-	function clear_account_case_relationship($account_id='', $case_id='')
-	{
-		if (empty($case_id)) $where = '';
-		else $where = " and id = '$case_id'";
-		$query = "UPDATE cases SET account_name = '', account_id = '' WHERE account_id = '$account_id' AND deleted = 0 " . $where;
-		$this->db->query($query,true,"Error clearing account to case relationship: ");
-	}
-
-	/**
-	* This method is used to provide backward compatibility with old data that was prefixed with http://
-	* We now automatically prefix http://
-	* @deprecated.
- 	*/
-	function remove_redundant_http()
-	{	/*
+        if (!empty($_REQUEST['parent_id']) && !empty($_REQUEST['parent_type']) && $_REQUEST['parent_type'] == 'Emails'
+            && !empty($_REQUEST['return_module']) && $_REQUEST['return_module'] == 'Emails') {
+            $_REQUEST['parent_name'] = '';
+            $_REQUEST['parent_id'] = '';
+        }
+    }
+
+    /**
+     * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
+     */
+    public function Account(){
+        $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
+        if(isset($GLOBALS['log'])) {
+            $GLOBALS['log']->deprecated($deprecatedMessage);
+        }
+        else {
+            trigger_error($deprecatedMessage, E_USER_DEPRECATED);
+        }
+        self::__construct();
+    }
+
+    function get_summary_text()
+    {
+        return $this->name;
+    }
+
+    function get_contacts() {
+        return $this->get_linked_beans('contacts','Contact');
+    }
+
+
+
+    function clear_account_case_relationship($account_id='', $case_id='')
+    {
+        if (empty($case_id)) $where = '';
+        else $where = " and id = '$case_id'";
+        $query = "UPDATE cases SET account_name = '', account_id = '' WHERE account_id = '$account_id' AND deleted = 0 " . $where;
+        $this->db->query($query,true,"Error clearing account to case relationship: ");
+    }
+
+    /**
+     * This method is used to provide backward compatibility with old data that was prefixed with http://
+     * We now automatically prefix http://
+     * @deprecated.
+     */
+    function remove_redundant_http()
+    {	/*
 		if(preg_match("@http://@", $this->website))
 		{
 			$this->website = substr($this->website, 7);
 		}
 		*/
-	}
+    }
 
-	function fill_in_additional_list_fields()
-	{
-		parent::fill_in_additional_list_fields();
-	// Fill in the assigned_user_name
-	//	$this->assigned_user_name = get_assigned_user_name($this->assigned_user_id);
+    function fill_in_additional_list_fields()
+    {
+        parent::fill_in_additional_list_fields();
+    // Fill in the assigned_user_name
+    //	$this->assigned_user_name = get_assigned_user_name($this->assigned_user_id);
 
-	}
+    }
 
-	function fill_in_additional_detail_fields()
-	{
+    function fill_in_additional_detail_fields()
+    {
         parent::fill_in_additional_detail_fields();
 
         //rrs bug: 28184 - instead of removing this code altogether just adding this check to ensure that if the parent_name
         //is empty then go ahead and fill it.
         if(empty($this->parent_name) && !empty($this->id)){
-			$query = "SELECT a1.name from accounts a1, accounts a2 where a1.id = a2.parent_id and a2.id = '$this->id' and a1.deleted=0";
-			$result = $this->db->query($query,true," Error filling in additional detail fields: ");
-
-			// Get the id and the name.
-			$row = $this->db->fetchByAssoc($result);
-
-			if($row != null)
-			{
-				$this->parent_name = $row['name'];
-			}
-			else
-			{
-				$this->parent_name = '';
-			}
+            $query = "SELECT a1.name from accounts a1, accounts a2 where a1.id = a2.parent_id and a2.id = '$this->id' and a1.deleted=0";
+            $result = $this->db->query($query,true," Error filling in additional detail fields: ");
+
+            // Get the id and the name.
+            $row = $this->db->fetchByAssoc($result);
+
+            if($row != null)
+            {
+                $this->parent_name = $row['name'];
+            }
+            else
+            {
+                $this->parent_name = '';
+            }
         }
 
         // Set campaign name if there is a campaign id
-		if( !empty($this->campaign_id)){
+        if( !empty($this->campaign_id)){
 
-			$camp = new Campaign();
-		    $where = "campaigns.id='{$this->campaign_id}'";
-		    $campaign_list = $camp->get_full_list("campaigns.name", $where, true);
-		    $this->campaign_name = $campaign_list[0]->name;
-		}
-	}
+            $camp = new Campaign();
+            $where = "campaigns.id='{$this->campaign_id}'";
+            $campaign_list = $camp->get_full_list("campaigns.name", $where, true);
+            $this->campaign_name = $campaign_list[0]->name;
+        }
+    }
 
-	function get_list_view_data(){
+    function get_list_view_data(){
 
-		$temp_array = parent::get_list_view_data();
+        $temp_array = parent::get_list_view_data();
 
-		$temp_array["ENCODED_NAME"] = $this->name;
+        $temp_array["ENCODED_NAME"] = $this->name;
 
-		if(!empty($this->billing_address_state))
-		{
-			$temp_array["CITY"] = $this->billing_address_city . ', '. $this->billing_address_state;
-		}
-		else
-		{
-			$temp_array["CITY"] = $this->billing_address_city;
-		}
-		$temp_array["BILLING_ADDRESS_STREET"]  = $this->billing_address_street;
-		$temp_array["SHIPPING_ADDRESS_STREET"] = $this->shipping_address_street;
+        if(!empty($this->billing_address_state))
+        {
+            $temp_array["CITY"] = $this->billing_address_city . ', '. $this->billing_address_state;
+        }
+        else
+        {
+            $temp_array["CITY"] = $this->billing_address_city;
+        }
+        $temp_array["BILLING_ADDRESS_STREET"]  = $this->billing_address_street;
+        $temp_array["SHIPPING_ADDRESS_STREET"] = $this->shipping_address_street;
 
-		return $temp_array;
-	}
-	/**
+        return $temp_array;
+    }
+    /**
 		builds a generic search based on the query string using or
 		do not include any $this-> because this is called on without having the class instantiated
-	*/
-	function build_generic_where_clause ($the_query_string) {
-	$where_clauses = Array();
-	$the_query_string = $this->db->quote($the_query_string);
-	array_push($where_clauses, "accounts.name like '$the_query_string%'");
-	if (is_numeric($the_query_string)) {
-		array_push($where_clauses, "accounts.phone_alternate like '%$the_query_string%'");
-		array_push($where_clauses, "accounts.phone_fax like '%$the_query_string%'");
-		array_push($where_clauses, "accounts.phone_office like '%$the_query_string%'");
-	}
-
-	$the_where = "";
-	foreach($where_clauses as $clause)
-	{
-		if(!empty($the_where)) $the_where .= " or ";
-		$the_where .= $clause;
-	}
-
-	return $the_where;
+     */
+    function build_generic_where_clause ($the_query_string) {
+    $where_clauses = Array();
+    $the_query_string = $this->db->quote($the_query_string);
+    array_push($where_clauses, "accounts.name like '$the_query_string%'");
+    if (is_numeric($the_query_string)) {
+        array_push($where_clauses, "accounts.phone_alternate like '%$the_query_string%'");
+        array_push($where_clauses, "accounts.phone_fax like '%$the_query_string%'");
+        array_push($where_clauses, "accounts.phone_office like '%$the_query_string%'");
+    }
+
+    $the_where = "";
+    foreach($where_clauses as $clause)
+    {
+        if(!empty($the_where)) $the_where .= " or ";
+        $the_where .= $clause;
+    }
+
+    return $the_where;
 }
 
 
@@ -297,24 +297,24 @@ 
         {
             $custom_join = $this->getCustomJoin(true, true, $where);
             $custom_join['join'] .= $relate_link_join;
-                         $query = "SELECT
+                            $query = "SELECT
                                 accounts.*,
                                 email_addresses.email_address email_address,
                                 '' email_addresses_non_primary, " . // email_addresses_non_primary needed for get_field_order_mapping()
                                 "accounts.name as account_name,
                                 users.user_name as assigned_user_name ";
             $query .= $custom_join['select'];
-						 $query .= " FROM accounts ";
-                         $query .= "LEFT JOIN users
+                            $query .= " FROM accounts ";
+                            $query .= "LEFT JOIN users
 	                                ON accounts.assigned_user_id=users.id ";
 
-						//join email address table too.
-						$query .=  ' LEFT JOIN  email_addr_bean_rel on accounts.id = email_addr_bean_rel.bean_id and email_addr_bean_rel.bean_module=\'Accounts\' and email_addr_bean_rel.deleted=0 and email_addr_bean_rel.primary_address=1 ';
-						$query .=  ' LEFT JOIN email_addresses on email_addresses.id = email_addr_bean_rel.email_address_id ' ;
+                        //join email address table too.
+                        $query .=  ' LEFT JOIN  email_addr_bean_rel on accounts.id = email_addr_bean_rel.bean_id and email_addr_bean_rel.bean_module=\'Accounts\' and email_addr_bean_rel.deleted=0 and email_addr_bean_rel.primary_address=1 ';
+                        $query .=  ' LEFT JOIN email_addresses on email_addresses.id = email_addr_bean_rel.email_address_id ' ;
 
             $query .= $custom_join['join'];
 
-		        $where_auto = "( accounts.deleted IS NULL OR accounts.deleted=0 )";
+                $where_auto = "( accounts.deleted IS NULL OR accounts.deleted=0 )";
 
                 if($where != "")
                         $query .= "where ($where) AND ".$where_auto;
@@ -329,32 +329,32 @@ 
                 return $query;
         }
 
-	function set_notification_body($xtpl, $account)
-	{
-		$xtpl->assign("ACCOUNT_NAME", $account->name);
-		$xtpl->assign("ACCOUNT_TYPE", $account->account_type);
-		$xtpl->assign("ACCOUNT_DESCRIPTION", $account->description);
+    function set_notification_body($xtpl, $account)
+    {
+        $xtpl->assign("ACCOUNT_NAME", $account->name);
+        $xtpl->assign("ACCOUNT_TYPE", $account->account_type);
+        $xtpl->assign("ACCOUNT_DESCRIPTION", $account->description);
 
-		return $xtpl;
-	}
+        return $xtpl;
+    }
 
-	function bean_implements($interface){
-		switch($interface){
-			case 'ACL':return true;
-		}
-		return false;
-	}
-	function get_unlinked_email_query($type=array()) {
-
-		return get_unlinked_email_query($type, $this);
-	}
-
-	/**
-	 * Create a query string for select Products/Services Purchased list from database.
-	 * @return string final query
-	 */
-	public function getProductsServicesPurchasedQuery() {
-		$query = "
+    function bean_implements($interface){
+        switch($interface){
+            case 'ACL':return true;
+        }
+        return false;
+    }
+    function get_unlinked_email_query($type=array()) {
+
+        return get_unlinked_email_query($type, $this);
+    }
+
+    /**
+     * Create a query string for select Products/Services Purchased list from database.
+     * @return string final query
+     */
+    public function getProductsServicesPurchasedQuery() {
+        $query = "
 			SELECT
 				aos_products_quotes.*
 			FROM
@@ -363,7 +363,7 @@ 
 			JOIN accounts ON accounts.id = aos_quotes.billing_account_id AND accounts.id = '{$this->id}'
 
 			";
-		return $query;
-	}
+        return $query;
+    }
 
 }

Spacing +28 added lines, -28 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -116,7 +116,7 @@ 
 	var $assigned_user_name;
 	var $account_id = '';
 	var $account_name = '';
-	var $bug_id ='';
+	var $bug_id = '';
 	var $module_dir = 'Accounts';
 	var $emailAddress;
 
@@ -130,7 +130,7 @@ 
 	);
 	var $relationship_fields = Array('opportunity_id'=>'opportunities', 'bug_id' => 'bugs', 'case_id'=>'cases',
 									'contact_id'=>'contacts', 'task_id'=>'tasks', 'note_id'=>'notes',
-									'meeting_id'=>'meetings', 'call_id'=>'calls', 'email_id'=>'emails','member_id'=>'members',
+									'meeting_id'=>'meetings', 'call_id'=>'calls', 'email_id'=>'emails', 'member_id'=>'members',
 									'project_id'=>'project',
 									);
 
@@ -146,7 +146,7 @@ 
 
 		foreach ($this->field_defs as $field)
 		{
-			if(isset($field['name']))
+			if (isset($field['name']))
 			{
 				$this->field_name_map[$field['name']] = $field;
 			}
@@ -164,9 +164,9 @@ 
 	/**
 	 * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
 	 */
-	public function Account(){
+	public function Account() {
 		$deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-		if(isset($GLOBALS['log'])) {
+		if (isset($GLOBALS['log'])) {
 			$GLOBALS['log']->deprecated($deprecatedMessage);
 		}
 		else {
@@ -181,17 +181,17 @@ 
 	}
 
 	function get_contacts() {
-		return $this->get_linked_beans('contacts','Contact');
+		return $this->get_linked_beans('contacts', 'Contact');
 	}
 
 
 
-	function clear_account_case_relationship($account_id='', $case_id='')
+	function clear_account_case_relationship($account_id = '', $case_id = '')
 	{
 		if (empty($case_id)) $where = '';
 		else $where = " and id = '$case_id'";
-		$query = "UPDATE cases SET account_name = '', account_id = '' WHERE account_id = '$account_id' AND deleted = 0 " . $where;
-		$this->db->query($query,true,"Error clearing account to case relationship: ");
+		$query = "UPDATE cases SET account_name = '', account_id = '' WHERE account_id = '$account_id' AND deleted = 0 ".$where;
+		$this->db->query($query, true, "Error clearing account to case relationship: ");
 	}
 
 	/**
@@ -222,14 +222,14 @@ 
 
         //rrs bug: 28184 - instead of removing this code altogether just adding this check to ensure that if the parent_name
         //is empty then go ahead and fill it.
-        if(empty($this->parent_name) && !empty($this->id)){
+        if (empty($this->parent_name) && !empty($this->id)) {
 			$query = "SELECT a1.name from accounts a1, accounts a2 where a1.id = a2.parent_id and a2.id = '$this->id' and a1.deleted=0";
-			$result = $this->db->query($query,true," Error filling in additional detail fields: ");
+			$result = $this->db->query($query, true, " Error filling in additional detail fields: ");
 
 			// Get the id and the name.
 			$row = $this->db->fetchByAssoc($result);
 
-			if($row != null)
+			if ($row != null)
 			{
 				$this->parent_name = $row['name'];
 			}
@@ -240,7 +240,7 @@ 
         }
 
         // Set campaign name if there is a campaign id
-		if( !empty($this->campaign_id)){
+		if (!empty($this->campaign_id)) {
 
 			$camp = new Campaign();
 		    $where = "campaigns.id='{$this->campaign_id}'";
@@ -249,15 +249,15 @@ 
 		}
 	}
 
-	function get_list_view_data(){
+	function get_list_view_data() {
 
 		$temp_array = parent::get_list_view_data();
 
 		$temp_array["ENCODED_NAME"] = $this->name;
 
-		if(!empty($this->billing_address_state))
+		if (!empty($this->billing_address_state))
 		{
-			$temp_array["CITY"] = $this->billing_address_city . ', '. $this->billing_address_state;
+			$temp_array["CITY"] = $this->billing_address_city.', '.$this->billing_address_state;
 		}
 		else
 		{
@@ -272,7 +272,7 @@ 
 		builds a generic search based on the query string using or
 		do not include any $this-> because this is called on without having the class instantiated
 	*/
-	function build_generic_where_clause ($the_query_string) {
+	function build_generic_where_clause($the_query_string) {
 	$where_clauses = Array();
 	$the_query_string = $this->db->quote($the_query_string);
 	array_push($where_clauses, "accounts.name like '$the_query_string%'");
@@ -283,9 +283,9 @@ 
 	}
 
 	$the_where = "";
-	foreach($where_clauses as $clause)
+	foreach ($where_clauses as $clause)
 	{
-		if(!empty($the_where)) $the_where .= " or ";
+		if (!empty($the_where)) $the_where .= " or ";
 		$the_where .= $clause;
 	}
 
@@ -293,7 +293,7 @@ 
 }
 
 
-        function create_export_query($order_by, $where, $relate_link_join='')
+        function create_export_query($order_by, $where, $relate_link_join = '')
         {
             $custom_join = $this->getCustomJoin(true, true, $where);
             $custom_join['join'] .= $relate_link_join;
@@ -309,21 +309,21 @@ 
 	                                ON accounts.assigned_user_id=users.id ";
 
 						//join email address table too.
-						$query .=  ' LEFT JOIN  email_addr_bean_rel on accounts.id = email_addr_bean_rel.bean_id and email_addr_bean_rel.bean_module=\'Accounts\' and email_addr_bean_rel.deleted=0 and email_addr_bean_rel.primary_address=1 ';
-						$query .=  ' LEFT JOIN email_addresses on email_addresses.id = email_addr_bean_rel.email_address_id ' ;
+						$query .= ' LEFT JOIN  email_addr_bean_rel on accounts.id = email_addr_bean_rel.bean_id and email_addr_bean_rel.bean_module=\'Accounts\' and email_addr_bean_rel.deleted=0 and email_addr_bean_rel.primary_address=1 ';
+						$query .= ' LEFT JOIN email_addresses on email_addresses.id = email_addr_bean_rel.email_address_id ';
 
             $query .= $custom_join['join'];
 
 		        $where_auto = "( accounts.deleted IS NULL OR accounts.deleted=0 )";
 
-                if($where != "")
+                if ($where != "")
                         $query .= "where ($where) AND ".$where_auto;
                 else
                         $query .= "where ".$where_auto;
 
         $order_by = $this->process_order_by($order_by);
         if (!empty($order_by)) {
-            $query .= ' ORDER BY ' . $order_by;
+            $query .= ' ORDER BY '.$order_by;
         }
 
                 return $query;
@@ -338,13 +338,13 @@ 
 		return $xtpl;
 	}
 
-	function bean_implements($interface){
-		switch($interface){
+	function bean_implements($interface) {
+		switch ($interface) {
 			case 'ACL':return true;
 		}
 		return false;
 	}
-	function get_unlinked_email_query($type=array()) {
+	function get_unlinked_email_query($type = array()) {
 
 		return get_unlinked_email_query($type, $this);
 	}

Braces +19 added lines, -14 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -168,8 +170,7 @@ 
 		$deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
 		if(isset($GLOBALS['log'])) {
 			$GLOBALS['log']->deprecated($deprecatedMessage);
-		}
-		else {
+		} else {
 			trigger_error($deprecatedMessage, E_USER_DEPRECATED);
 		}
 		self::__construct();
@@ -188,8 +189,11 @@ 
 
 	function clear_account_case_relationship($account_id='', $case_id='')
 	{
-		if (empty($case_id)) $where = '';
-		else $where = " and id = '$case_id'";
+		if (empty($case_id)) {
+		    $where = '';
+		} else {
+		    $where = " and id = '$case_id'";
+		}
 		$query = "UPDATE cases SET account_name = '', account_id = '' WHERE account_id = '$account_id' AND deleted = 0 " . $where;
 		$this->db->query($query,true,"Error clearing account to case relationship: ");
 	}
@@ -232,8 +236,7 @@ 
 			if($row != null)
 			{
 				$this->parent_name = $row['name'];
-			}
-			else
+			} else
 			{
 				$this->parent_name = '';
 			}
@@ -258,8 +261,7 @@ 
 		if(!empty($this->billing_address_state))
 		{
 			$temp_array["CITY"] = $this->billing_address_city . ', '. $this->billing_address_state;
-		}
-		else
+		} else
 		{
 			$temp_array["CITY"] = $this->billing_address_city;
 		}
@@ -285,7 +287,9 @@ 
 	$the_where = "";
 	foreach($where_clauses as $clause)
 	{
-		if(!empty($the_where)) $the_where .= " or ";
+		if(!empty($the_where)) {
+		    $the_where .= " or ";
+		}
 		$the_where .= $clause;
 	}
 
@@ -316,10 +320,11 @@ 
 
 		        $where_auto = "( accounts.deleted IS NULL OR accounts.deleted=0 )";
 
-                if($where != "")
-                        $query .= "where ($where) AND ".$where_auto;
-                else
-                        $query .= "where ".$where_auto;
+                if($where != "") {
+                                        $query .= "where ($where) AND ".$where_auto;
+                } else {
+                                        $query .= "where ".$where_auto;
+                }
 
         $order_by = $this->process_order_by($order_by);
         if (!empty($order_by)) {

modules/AOP_Case_Events/AOP_Case_Events_sugar.php

Spacing +6 added lines, -6 removed lines

@@ -36,7 +36,7 @@ 
 	var $table_name = 'aop_case_events';
 	var $tracker_visibility = false;
 	var $importable = false;
-	var $disable_row_level_security = true ; // to ensure that modules created and deployed under CE will continue to function under team security if the instance is upgraded to PRO
+	var $disable_row_level_security = true; // to ensure that modules created and deployed under CE will continue to function under team security if the instance is upgraded to PRO
 		var $id;
 		var $name;
 		var $date_entered;
@@ -53,16 +53,16 @@ 
 		var $assigned_user_name;
 		var $assigned_user_link;
 
-    public function __construct(){
+    public function __construct() {
 		parent::__construct();
 	}
 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    public function AOP_Case_Events_sugar(){
+    public function AOP_Case_Events_sugar() {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {
@@ -72,8 +72,8 @@ 
     }
 
 
-	function bean_implements($interface){
-		switch($interface){
+	function bean_implements($interface) {
+		switch ($interface) {
 			case 'ACL': return true;
 		}
 		return false;

Braces +1 added lines, -2 removed lines

@@ -23,8 +23,7 @@
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct($seed, $module, $subPanel, $options);

modules/AOP_Case_Events/AOP_Case_Events.php

Indentation +3 added lines, -3 removed lines

@@ -40,9 +40,9 @@
 require_once('modules/AM_TaskTemplates/AM_TaskTemplates_sugar.php');
 class AM_TaskTemplates extends AM_TaskTemplates_sugar {
 
-	public function __construct(){
-		parent::__construct();
-	}
+    public function __construct(){
+        parent::__construct();
+    }
 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead

Spacing +3 added lines, -3 removed lines

@@ -28,16 +28,16 @@
 require_once('modules/AOP_Case_Events/AOP_Case_Events_sugar.php');
 class AOP_Case_Events extends AOP_Case_Events_sugar {
 
-	public function __construct(){
+	public function __construct() {
 		parent::__construct();
 	}
 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    public function AOP_Case_Events(){
+    public function AOP_Case_Events() {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {

Braces +1 added lines, -2 removed lines

@@ -23,8 +23,7 @@
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct($seed, $module, $subPanel, $options);

modules/Calls/Dashlets/MyCallsDashlet/MyCallsDashlet.php

Spacing +27 added lines, -27 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -51,11 +51,11 @@ 
 
         parent::__construct($id, $def);
 
-        if(empty($def['title'])) $this->title = translate('LBL_LIST_MY_CALLS', 'Calls');
+        if (empty($def['title'])) $this->title = translate('LBL_LIST_MY_CALLS', 'Calls');
         $this->searchFields = $dashletData['MyCallsDashlet']['searchFields'];
-        if(empty($def['filters'])){
-			if(isset($this->searchFields['status'])){
-				if(!empty($this->searchFields['status']['default'])){
+        if (empty($def['filters'])) {
+			if (isset($this->searchFields['status'])) {
+				if (!empty($this->searchFields['status']['default'])) {
                     $this->filters['status'] = $this->searchFields['status']['default'];
                 }
 			}
@@ -72,9 +72,9 @@ 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    function MyCallsDashlet($id, $def = null){
+    function MyCallsDashlet($id, $def = null) {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {
@@ -88,45 +88,45 @@ 
         $mod_strings = return_module_language($current_language, 'Calls');
 
         // handle myitems only differently --  set the custom query to show assigned meetings and invitee meetings
-        if($this->myItemsOnly) {
+        if ($this->myItemsOnly) {
         	//join with meeting_users table to process related users
        		$this->seedBean->listview_inner_join = array('LEFT JOIN  calls_users c_u on  c_u.call_id = calls.id');
 
         	//set the custom query to include assigned meetings
-            $lvsParams['custom_where'] = ' AND (calls.assigned_user_id = \'' . $current_user->id . '\' OR (c_u.user_id = \'' . $current_user->id . '\' AND c_u.deleted = 0  )) ';
+            $lvsParams['custom_where'] = ' AND (calls.assigned_user_id = \''.$current_user->id.'\' OR (c_u.user_id = \''.$current_user->id.'\' AND c_u.deleted = 0  )) ';
         }
 
         $this->myItemsOnly = false;
 		//query needs to be distinct to avoid multiple records being returned for the same meeting (one for each invited user),
 		//so we need to make sure date entered is also set so the sort can work with the group by
-		$lvsParams['custom_select']=', calls.date_entered ';
-		$lvsParams['distinct']=true;
+		$lvsParams['custom_select'] = ', calls.date_entered ';
+		$lvsParams['distinct'] = true;
 
         parent::process($lvsParams);
 
         $keys = array();
-        foreach($this->lvs->data['data'] as $num => $row) {
+        foreach ($this->lvs->data['data'] as $num => $row) {
             $keys[] = $row['ID'];
         }
 
 
-       if(!empty($keys)){
-            $query = "SELECT call_id, accept_status FROM calls_users WHERE deleted = 0 and user_id = '" . $current_user->id . "' AND call_id IN ('" . implode("','", $keys ). "')";
+       if (!empty($keys)) {
+            $query = "SELECT call_id, accept_status FROM calls_users WHERE deleted = 0 and user_id = '".$current_user->id."' AND call_id IN ('".implode("','", $keys)."')";
             $result = $GLOBALS['db']->query($query);
 
-            while($row = $GLOBALS['db']->fetchByAssoc($result)) {
+            while ($row = $GLOBALS['db']->fetchByAssoc($result)) {
                  $rowNums = $this->lvs->data['pageData']['idIndex'][$row['call_id']]; // figure out which rows have this guid
-                 foreach($rowNums as $rowNum) {
+                 foreach ($rowNums as $rowNum) {
                     $this->lvs->data['data'][$rowNum]['ACCEPT_STATUS'] = $row['accept_status'];
                  }
             }
        }
 
-        foreach($this->lvs->data['data'] as $rowNum => $row) {
-            if(empty($this->lvs->data['data'][$rowNum]['DURATION_HOURS']))  $this->lvs->data['data'][$rowNum]['DURATION'] = '0' . $mod_strings['LBL_HOURS_ABBREV'];
-            else $this->lvs->data['data'][$rowNum]['DURATION'] = $this->lvs->data['data'][$rowNum]['DURATION_HOURS'] . $mod_strings['LBL_HOURS_ABBREV'];
+        foreach ($this->lvs->data['data'] as $rowNum => $row) {
+            if (empty($this->lvs->data['data'][$rowNum]['DURATION_HOURS']))  $this->lvs->data['data'][$rowNum]['DURATION'] = '0'.$mod_strings['LBL_HOURS_ABBREV'];
+            else $this->lvs->data['data'][$rowNum]['DURATION'] = $this->lvs->data['data'][$rowNum]['DURATION_HOURS'].$mod_strings['LBL_HOURS_ABBREV'];
 
-            if(empty($this->lvs->data['data'][$rowNum]['DURATION_MINUTES']) || empty($this->seedBean->minutes_values[$this->lvs->data['data'][$rowNum]['DURATION_MINUTES']])) {
+            if (empty($this->lvs->data['data'][$rowNum]['DURATION_MINUTES']) || empty($this->seedBean->minutes_values[$this->lvs->data['data'][$rowNum]['DURATION_MINUTES']])) {
                 $this->lvs->data['data'][$rowNum]['DURATION'] .= '00';
             }
             else {
@@ -134,16 +134,16 @@ 
             }
             if ($this->lvs->data['data'][$rowNum]['STATUS'] == $app_list_strings['meeting_status_dom']['Planned'])
             {
-                if ($this->lvs->data['data'][$rowNum]['ACCEPT_STATUS'] == ''){
+                if ($this->lvs->data['data'][$rowNum]['ACCEPT_STATUS'] == '') {
 					//if no status has been set, then do not show accept options
 					$this->lvs->data['data'][$rowNum]['SET_ACCEPT_LINKS'] = "<div id=\"accept".$this->id."\" ></div>";
-				}elseif($this->lvs->data['data'][$rowNum]['ACCEPT_STATUS'] == 'none')
+				}elseif ($this->lvs->data['data'][$rowNum]['ACCEPT_STATUS'] == 'none')
                 {
                     $this->lvs->data['data'][$rowNum]['SET_ACCEPT_LINKS'] = "<div id=\"accept".$this->id."\"><a title=\"".$app_list_strings['dom_meeting_accept_options']['accept'].
-                        "\" href=\"javascript:SUGAR.util.retrieveAndFill('index.php?module=Activities&to_pdf=1&action=SetAcceptStatus&id=".$this->id."&object_type=Call&object_id=".$this->lvs->data['data'][$rowNum]['ID'] . "&accept_status=accept', null, null, SUGAR.mySugar.retrieveDashlet, '{$this->id}');\">".
-                        SugarThemeRegistry::current()->getImage("accept_inline","border='0'",null,null,'.gif',$app_list_strings['dom_meeting_accept_options']['accept']). "</a>&nbsp;<a title=\"".$app_list_strings['dom_meeting_accept_options']['tentative']."\" href=\"javascript:SUGAR.util.retrieveAndFill('index.php?module=Activities&to_pdf=1&action=SetAcceptStatus&id=".$this->id."&object_type=Call&object_id=".$this->lvs->data['data'][$rowNum]['ID'] . "&accept_status=tentative', null, null, SUGAR.mySugar.retrieveDashlet, '{$this->id}');\">".
-                        SugarThemeRegistry::current()->getImage("tentative_inline","border='0'", null,null,'.gif',$app_list_strings['dom_meeting_accept_options']['tentative'])."</a>&nbsp;<a title=\"".$app_list_strings['dom_meeting_accept_options']['decline']. "\" href=\"javascript:SUGAR.util.retrieveAndFill('index.php?module=Activities&to_pdf=1&action=SetAcceptStatus&id=".$this->id."&object_type=Call&object_id=".$this->lvs->data['data'][$rowNum]['ID'] . "&accept_status=decline', null, null, SUGAR.mySugar.retrieveDashlet, '{$this->id}');\">".
-                        SugarThemeRegistry::current()->getImage("decline_inline","border='0'", null,null,'.gif',$app_list_strings['dom_meeting_accept_options']['decline'])."</a></div>";
+                        "\" href=\"javascript:SUGAR.util.retrieveAndFill('index.php?module=Activities&to_pdf=1&action=SetAcceptStatus&id=".$this->id."&object_type=Call&object_id=".$this->lvs->data['data'][$rowNum]['ID']."&accept_status=accept', null, null, SUGAR.mySugar.retrieveDashlet, '{$this->id}');\">".
+                        SugarThemeRegistry::current()->getImage("accept_inline", "border='0'", null, null, '.gif', $app_list_strings['dom_meeting_accept_options']['accept'])."</a>&nbsp;<a title=\"".$app_list_strings['dom_meeting_accept_options']['tentative']."\" href=\"javascript:SUGAR.util.retrieveAndFill('index.php?module=Activities&to_pdf=1&action=SetAcceptStatus&id=".$this->id."&object_type=Call&object_id=".$this->lvs->data['data'][$rowNum]['ID']."&accept_status=tentative', null, null, SUGAR.mySugar.retrieveDashlet, '{$this->id}');\">".
+                        SugarThemeRegistry::current()->getImage("tentative_inline", "border='0'", null, null, '.gif', $app_list_strings['dom_meeting_accept_options']['tentative'])."</a>&nbsp;<a title=\"".$app_list_strings['dom_meeting_accept_options']['decline']."\" href=\"javascript:SUGAR.util.retrieveAndFill('index.php?module=Activities&to_pdf=1&action=SetAcceptStatus&id=".$this->id."&object_type=Call&object_id=".$this->lvs->data['data'][$rowNum]['ID']."&accept_status=decline', null, null, SUGAR.mySugar.retrieveDashlet, '{$this->id}');\">".
+                        SugarThemeRegistry::current()->getImage("decline_inline", "border='0'", null, null, '.gif', $app_list_strings['dom_meeting_accept_options']['decline'])."</a></div>";
                 }
                 else
                 {
@@ -154,7 +154,7 @@ 
 
             $this->lvs->data['data'][$rowNum]['DURATION'] .= $mod_strings['LBL_MINSS_ABBREV'];
         }
-      $this->displayColumns[]= "set_accept_links";
+      $this->displayColumns[] = "set_accept_links";
     }
 
     function displayOptions() {

Braces +15 added lines, -11 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -51,7 +53,9 @@ 
 
         parent::__construct($id, $def);
 
-        if(empty($def['title'])) $this->title = translate('LBL_LIST_MY_CALLS', 'Calls');
+        if(empty($def['title'])) {
+            $this->title = translate('LBL_LIST_MY_CALLS', 'Calls');
+        }
         $this->searchFields = $dashletData['MyCallsDashlet']['searchFields'];
         if(empty($def['filters'])){
 			if(isset($this->searchFields['status'])){
@@ -76,8 +80,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct($id, $def);
@@ -123,13 +126,15 @@ 
        }
 
         foreach($this->lvs->data['data'] as $rowNum => $row) {
-            if(empty($this->lvs->data['data'][$rowNum]['DURATION_HOURS']))  $this->lvs->data['data'][$rowNum]['DURATION'] = '0' . $mod_strings['LBL_HOURS_ABBREV'];
-            else $this->lvs->data['data'][$rowNum]['DURATION'] = $this->lvs->data['data'][$rowNum]['DURATION_HOURS'] . $mod_strings['LBL_HOURS_ABBREV'];
+            if(empty($this->lvs->data['data'][$rowNum]['DURATION_HOURS'])) {
+                $this->lvs->data['data'][$rowNum]['DURATION'] = '0' . $mod_strings['LBL_HOURS_ABBREV'];
+            } else {
+                $this->lvs->data['data'][$rowNum]['DURATION'] = $this->lvs->data['data'][$rowNum]['DURATION_HOURS'] . $mod_strings['LBL_HOURS_ABBREV'];
+            }
 
             if(empty($this->lvs->data['data'][$rowNum]['DURATION_MINUTES']) || empty($this->seedBean->minutes_values[$this->lvs->data['data'][$rowNum]['DURATION_MINUTES']])) {
                 $this->lvs->data['data'][$rowNum]['DURATION'] .= '00';
-            }
-            else {
+            } else {
                 $this->lvs->data['data'][$rowNum]['DURATION'] .= $this->seedBean->minutes_values[$this->lvs->data['data'][$rowNum]['DURATION_MINUTES']];
             }
             if ($this->lvs->data['data'][$rowNum]['STATUS'] == $app_list_strings['meeting_status_dom']['Planned'])
@@ -137,15 +142,14 @@ 
                 if ($this->lvs->data['data'][$rowNum]['ACCEPT_STATUS'] == ''){
 					//if no status has been set, then do not show accept options
 					$this->lvs->data['data'][$rowNum]['SET_ACCEPT_LINKS'] = "<div id=\"accept".$this->id."\" ></div>";
-				}elseif($this->lvs->data['data'][$rowNum]['ACCEPT_STATUS'] == 'none')
+				} elseif($this->lvs->data['data'][$rowNum]['ACCEPT_STATUS'] == 'none')
                 {
                     $this->lvs->data['data'][$rowNum]['SET_ACCEPT_LINKS'] = "<div id=\"accept".$this->id."\"><a title=\"".$app_list_strings['dom_meeting_accept_options']['accept'].
                         "\" href=\"javascript:SUGAR.util.retrieveAndFill('index.php?module=Activities&to_pdf=1&action=SetAcceptStatus&id=".$this->id."&object_type=Call&object_id=".$this->lvs->data['data'][$rowNum]['ID'] . "&accept_status=accept', null, null, SUGAR.mySugar.retrieveDashlet, '{$this->id}');\">".
                         SugarThemeRegistry::current()->getImage("accept_inline","border='0'",null,null,'.gif',$app_list_strings['dom_meeting_accept_options']['accept']). "</a>&nbsp;<a title=\"".$app_list_strings['dom_meeting_accept_options']['tentative']."\" href=\"javascript:SUGAR.util.retrieveAndFill('index.php?module=Activities&to_pdf=1&action=SetAcceptStatus&id=".$this->id."&object_type=Call&object_id=".$this->lvs->data['data'][$rowNum]['ID'] . "&accept_status=tentative', null, null, SUGAR.mySugar.retrieveDashlet, '{$this->id}');\">".
                         SugarThemeRegistry::current()->getImage("tentative_inline","border='0'", null,null,'.gif',$app_list_strings['dom_meeting_accept_options']['tentative'])."</a>&nbsp;<a title=\"".$app_list_strings['dom_meeting_accept_options']['decline']. "\" href=\"javascript:SUGAR.util.retrieveAndFill('index.php?module=Activities&to_pdf=1&action=SetAcceptStatus&id=".$this->id."&object_type=Call&object_id=".$this->lvs->data['data'][$rowNum]['ID'] . "&accept_status=decline', null, null, SUGAR.mySugar.retrieveDashlet, '{$this->id}');\">".
                         SugarThemeRegistry::current()->getImage("decline_inline","border='0'", null,null,'.gif',$app_list_strings['dom_meeting_accept_options']['decline'])."</a></div>";
-                }
-                else
+                } else
                 {
                     $this->lvs->data['data'][$rowNum]['SET_ACCEPT_LINKS'] = $app_list_strings['dom_meeting_accept_status'][$this->lvs->data['data'][$rowNum]['ACCEPT_STATUS']];
 

modules/Project/views/view.edit.php

Spacing +3 added lines, -3 removed lines

@@ -41,16 +41,16 @@
 
 class ProjectViewEdit extends ViewEdit {
 
- 	function __construct(){
+ 	function __construct() {
  		parent::__construct();
  	}
 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    function ProjectViewEdit(){
+    function ProjectViewEdit() {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {

Braces +1 added lines, -2 removed lines

@@ -23,8 +23,7 @@
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct($seed, $module, $subPanel, $options);

modules/Project/views/view.list.php

Spacing +8 added lines, -8 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
@@ -51,7 +51,7 @@ 
 require_once('include/MVC/View/views/view.list.php');
 require_once('modules/Project/ProjectListViewSmarty.php');
 
-class ProjectViewList extends ViewList{
+class ProjectViewList extends ViewList {
  	function __construct()
  	{
  		parent::__construct();
@@ -60,9 +60,9 @@ 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    function ProjectViewList(){
+    function ProjectViewList() {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {
@@ -82,18 +82,18 @@ 
 
         $this->lv->searchColumns = $this->searchForm->searchColumns;
 
-        if(!$this->headers)
+        if (!$this->headers)
             return;
 
-        if(empty($_REQUEST['search_form_only']) || $_REQUEST['search_form_only'] == false)
+        if (empty($_REQUEST['search_form_only']) || $_REQUEST['search_form_only'] == false)
         {
             $this->lv->setup($this->seed, 'include/ListView/ListViewGeneric.tpl', $this->where, $this->params);
-            $savedSearchName = empty($_REQUEST['saved_search_select_name']) ? '' : (' - ' . $_REQUEST['saved_search_select_name']);
+            $savedSearchName = empty($_REQUEST['saved_search_select_name']) ? '' : (' - '.$_REQUEST['saved_search_select_name']);
             echo $this->lv->display();
         }
     }
 
-    function preDisplay(){
+    function preDisplay() {
         $this->lv = new ProjectListViewSmarty();
     }
 

Braces +7 added lines, -5 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
@@ -64,8 +66,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct();
@@ -82,8 +83,9 @@ 
 
         $this->lv->searchColumns = $this->searchForm->searchColumns;
 
-        if(!$this->headers)
-            return;
+        if(!$this->headers) {
+                    return;
+        }
 
         if(empty($_REQUEST['search_form_only']) || $_REQUEST['search_form_only'] == false)
         {