adamjakab / SuiteCRM

modules/AOW_WorkFlow/AOW_WorkFlow.php

Spacing +153 added lines, -153 removed lines

@@ -30,7 +30,7 @@ 
 	var $object_name = 'AOW_WorkFlow';
 	var $table_name = 'aow_workflow';
 	var $importable = false;
-	var $disable_row_level_security = true ;
+	var $disable_row_level_security = true;
 
 	var $id;
 	var $name;
@@ -51,9 +51,9 @@ 
 	var $status;
 	var $run_when;
 
-	public function __construct($init=true){
+	public function __construct($init = true) {
 		parent::__construct();
-        if($init){
+        if ($init) {
             $this->load_flow_beans();
             require_once('modules/AOW_WorkFlow/aow_utils.php');
         }
@@ -62,9 +62,9 @@ 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    public function AOW_WorkFlow($init=true){
+    public function AOW_WorkFlow($init = true) {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {
@@ -73,15 +73,15 @@ 
         self::__construct($init);
     }
 
-	function bean_implements($interface){
-		switch($interface){
+	function bean_implements($interface) {
+		switch ($interface) {
 			case 'ACL': return true;
 		}
 		return false;
 	}
 
-    function save($check_notify = FALSE){
-        if (empty($this->id)){
+    function save($check_notify = FALSE) {
+        if (empty($this->id)) {
             unset($_POST['aow_conditions_id']);
             unset($_POST['aow_actions_id']);
         }
@@ -97,14 +97,14 @@ 
         $action->save_lines($_POST, $this, 'aow_actions_');
     }
 
-    function load_flow_beans(){
+    function load_flow_beans() {
         global $beanList, $app_list_strings;
 
         $app_list_strings['aow_moduleList'] = $app_list_strings['moduleList'];
 
-        if(!empty($app_list_strings['aow_moduleList'])){
-            foreach($app_list_strings['aow_moduleList'] as $mkey => $mvalue){
-                if(!isset($beanList[$mkey]) || str_begin($mkey, 'AOW_')){
+        if (!empty($app_list_strings['aow_moduleList'])) {
+            foreach ($app_list_strings['aow_moduleList'] as $mkey => $mvalue) {
+                if (!isset($beanList[$mkey]) || str_begin($mkey, 'AOW_')) {
                     unset($app_list_strings['aow_moduleList'][$mkey]);
                 }
             }
@@ -118,10 +118,10 @@ 
     /**
      * Select and run all active flows
      */
-	function run_flows(){
-		$flows = AOW_WorkFlow::get_full_list(''," aow_workflow.status = 'Active'  AND (aow_workflow.run_when = 'Always' OR aow_workflow.run_when = 'In_Scheduler' OR aow_workflow.run_when = 'Create') ");
+	function run_flows() {
+		$flows = AOW_WorkFlow::get_full_list('', " aow_workflow.status = 'Active'  AND (aow_workflow.run_when = 'Always' OR aow_workflow.run_when = 'In_Scheduler' OR aow_workflow.run_when = 'Create') ");
 
-        foreach($flows as $flow){
+        foreach ($flows as $flow) {
             $flow->run_flow();
         }
         return true;
@@ -130,11 +130,11 @@ 
     /**
      * Retrieve the beans to actioned and run the actions
      */
-    function run_flow(){
+    function run_flow() {
         $beans = $this->get_flow_beans();
-        if(!empty($beans)){
+        if (!empty($beans)) {
 
-            foreach($beans as $bean){
+            foreach ($beans as $bean) {
                 $bean->retrieve($bean->id);
                 $this->run_actions($bean);
             }
@@ -144,16 +144,16 @@ 
     /**
      * Select and run all active flows for the specified bean
      */
-    function run_bean_flows(SugarBean &$bean){
-        if(!isset($_REQUEST['module']) || $_REQUEST['module'] != 'Import'){
+    function run_bean_flows(SugarBean & $bean) {
+        if (!isset($_REQUEST['module']) || $_REQUEST['module'] != 'Import') {
 
             $query = "SELECT id FROM aow_workflow WHERE aow_workflow.flow_module = '".$bean->module_dir."' AND aow_workflow.status = 'Active' AND (aow_workflow.run_when = 'Always' OR aow_workflow.run_when = 'On_Save' OR aow_workflow.run_when = 'Create') AND aow_workflow.deleted = 0 ";
 
             $result = $this->db->query($query, false);
             $flow = new AOW_WorkFlow();
-            while (($row = $bean->db->fetchByAssoc($result)) != null){
+            while (($row = $bean->db->fetchByAssoc($result)) != null) {
                 $flow ->retrieve($row['id']);
-                if($flow->check_valid_bean($bean))
+                if ($flow->check_valid_bean($bean))
                     $flow->run_actions($bean, true);
             }
         }
@@ -163,10 +163,10 @@ 
     /**
      * Use the condition statements and processed table to build query to retrieve beans to be actioned
      */
-    function get_flow_beans(){
+    function get_flow_beans() {
         global $beanList;
 
-        if($beanList[$this->flow_module]){
+        if ($beanList[$this->flow_module]) {
             $module = new $beanList[$this->flow_module]();
 
             $query = '';
@@ -175,22 +175,22 @@ 
             $query_array['select'][] = $module->table_name.".id AS id";
             $query_array = $this->build_flow_query_where($query_array);
 
-            if(!empty($query_array)){
-                foreach ($query_array['select'] as $select){
-                    $query .=  ($query == '' ? 'SELECT ' : ', ').$select;
+            if (!empty($query_array)) {
+                foreach ($query_array['select'] as $select) {
+                    $query .= ($query == '' ? 'SELECT ' : ', ').$select;
                 }
 
                 $query .= ' FROM '.$module->table_name.' ';
 
-                if(isset($query_array['join'])){
-                    foreach ($query_array['join'] as $join){
+                if (isset($query_array['join'])) {
+                    foreach ($query_array['join'] as $join) {
                         $query .= $join;
                     }
                 }
-                if(isset($query_array['where'])){
+                if (isset($query_array['where'])) {
                     $query_where = '';
-                    foreach ($query_array['where'] as $where){
-                        $query_where .=  ($query_where == '' ? 'WHERE ' : ' AND ').$where;
+                    foreach ($query_array['where'] as $where) {
+                        $query_where .= ($query_where == '' ? 'WHERE ' : ' AND ').$where;
                     }
                     $query .= ' '.$query_where;
                 }
@@ -202,17 +202,17 @@ 
         return null;
     }
 
-    function build_flow_query_join($name, SugarBean $module, $type, $query = array()){
+    function build_flow_query_join($name, SugarBean $module, $type, $query = array()) {
 
-        if(!isset($query['join'][$name])){
+        if (!isset($query['join'][$name])) {
 
-            switch ($type){
+            switch ($type) {
                 case 'custom':
-                    $query['join'][$name] = 'LEFT JOIN '.$module->get_custom_table_name().' '.$name.' ON '.$module->table_name.'.id = '. $name.'.id_c ';
+                    $query['join'][$name] = 'LEFT JOIN '.$module->get_custom_table_name().' '.$name.' ON '.$module->table_name.'.id = '.$name.'.id_c ';
                     break;
 
                 case 'relationship':
-                    if($module->load_relationship($name)){
+                    if ($module->load_relationship($name)) {
                         $params['join_type'] = 'LEFT JOIN';
                         $params['join_table_alias'] = $name;
                         $join = $module->$name->getJoin($params, true);
@@ -230,10 +230,10 @@ 
         return $query;
     }
 
-    function build_flow_query_where($query = array()){
+    function build_flow_query_where($query = array()) {
         global $beanList;
 
-        if($beanList[$this->flow_module]){
+        if ($beanList[$this->flow_module]) {
             $module = new $beanList[$this->flow_module]();
 
             $sql = "SELECT id FROM aow_conditions WHERE aow_workflow_id = '".$this->id."' AND deleted = 0 ORDER BY condition_order ASC";
@@ -242,26 +242,26 @@ 
             while ($row = $this->db->fetchByAssoc($result)) {
                 $condition = new AOW_Condition();
                 $condition->retrieve($row['id']);
-                $query = $this->build_query_where($condition,$module,$query);
-                if(empty($query)){
+                $query = $this->build_query_where($condition, $module, $query);
+                if (empty($query)) {
                     return $query;
                 }
             }
-            if($this->flow_run_on){
-                switch($this->flow_run_on){
+            if ($this->flow_run_on) {
+                switch ($this->flow_run_on) {
 
                     case'New_Records':
-                        $query['where'][] = $module->table_name . '.' . 'date_entered' . ' > ' . "'" .$this->date_entered."'";
+                        $query['where'][] = $module->table_name.'.'.'date_entered'.' > '."'".$this->date_entered."'";
                         Break;
 
                     case'Modified_Records':
-                        $query['where'][] = $module->table_name . '.' . 'date_modified' . ' > ' . "'" .$this->date_entered."'" . ' AND ' . $module->table_name . '.' . 'date_entered' . ' <> ' . $module->table_name . '.' . 'date_modified';
+                        $query['where'][] = $module->table_name.'.'.'date_modified'.' > '."'".$this->date_entered."'".' AND '.$module->table_name.'.'.'date_entered'.' <> '.$module->table_name.'.'.'date_modified';
                         Break;
 
                 }
             }
 
-            if(!$this->multiple_runs){
+            if (!$this->multiple_runs) {
                 $query['where'][] .= "NOT EXISTS (SELECT * FROM aow_processed WHERE aow_processed.aow_workflow_id='".$this->id."' AND aow_processed.parent_id=".$module->table_name.".id AND aow_processed.status = 'Complete' AND aow_processed.deleted = 0)";
             }
 
@@ -271,48 +271,48 @@ 
         return $query;
     }
 
-    function build_query_where(AOW_Condition $condition, $module, $query = array()){
+    function build_query_where(AOW_Condition $condition, $module, $query = array()) {
         global $beanList, $app_list_strings, $sugar_config, $timedate;
         $path = unserialize(base64_decode($condition->module_path));
 
         $condition_module = $module;
         $table_alias = $condition_module->table_name;
-        if(isset($path[0]) && $path[0] != $module->module_dir){
-            foreach($path as $rel){
+        if (isset($path[0]) && $path[0] != $module->module_dir) {
+            foreach ($path as $rel) {
                 $query = $this->build_flow_query_join($rel, $condition_module, 'relationship', $query);
-                $condition_module = new $beanList[getRelatedModule($condition_module->module_dir,$rel)];
+                $condition_module = new $beanList[getRelatedModule($condition_module->module_dir, $rel)];
                 $table_alias = $rel;
             }
         }
 
-        if(isset($app_list_strings['aow_sql_operator_list'][$condition->operator])){
+        if (isset($app_list_strings['aow_sql_operator_list'][$condition->operator])) {
             $where_set = false;
 
             $data = $condition_module->field_defs[$condition->field];
 
-            if($data['type'] == 'relate' && isset($data['id_name'])) {
+            if ($data['type'] == 'relate' && isset($data['id_name'])) {
                 $condition->field = $data['id_name'];
             }
-            if(  (isset($data['source']) && $data['source'] == 'custom_fields')) {
+            if ((isset($data['source']) && $data['source'] == 'custom_fields')) {
                 $field = $table_alias.'_cstm.'.$condition->field;
                 $query = $this->build_flow_query_join($table_alias.'_cstm', $condition_module, 'custom', $query);
             } else {
                 $field = $table_alias.'.'.$condition->field;
             }
 
-            if($condition->operator == 'is_null'){
+            if ($condition->operator == 'is_null') {
                 $query['where'][] = '('.$field.' '.$app_list_strings['aow_sql_operator_list'][$condition->operator].' OR '.$field.' '.$app_list_strings['aow_sql_operator_list']['Equal_To']." '')";
                 return $query;
             }
 
-            switch($condition->value_type) {
+            switch ($condition->value_type) {
                 case 'Field':
                     $data = $module->field_defs[$condition->value];
 
-                    if($data['type'] == 'relate' && isset($data['id_name'])) {
+                    if ($data['type'] == 'relate' && isset($data['id_name'])) {
                         $condition->value = $data['id_name'];
                     }
-                    if(  (isset($data['source']) && $data['source'] == 'custom_fields')) {
+                    if ((isset($data['source']) && $data['source'] == 'custom_fields')) {
                         $value = $module->table_name.'_cstm.'.$condition->value;
                         $query = $this->build_flow_query_join($module->table_name.'_cstm', $module, 'custom', $query);
                     } else {
@@ -323,24 +323,24 @@ 
                     //can't detect in scheduler so return
                     return array();
                 case 'Date':
-                    $params =  unserialize(base64_decode($condition->value));
-                    if($params[0] == 'now'){
-                        if($sugar_config['dbconfig']['db_type'] == 'mssql'){
-                            $value  = 'GetUTCDate()';
+                    $params = unserialize(base64_decode($condition->value));
+                    if ($params[0] == 'now') {
+                        if ($sugar_config['dbconfig']['db_type'] == 'mssql') {
+                            $value = 'GetUTCDate()';
                         } else {
                             $value = 'UTC_TIMESTAMP()';
                         }
-                    } else if($params[0] == 'today'){
-                        if($sugar_config['dbconfig']['db_type'] == 'mssql'){
+                    } else if ($params[0] == 'today') {
+                        if ($sugar_config['dbconfig']['db_type'] == 'mssql') {
                             //$field =
-                            $value  = 'CAST(GETDATE() AS DATE)';
+                            $value = 'CAST(GETDATE() AS DATE)';
                         } else {
                             $field = 'DATE('.$field.')';
                             $value = 'Curdate()';
                         }
                     } else {
                         $data = $module->field_defs[$params[0]];
-                        if(  (isset($data['source']) && $data['source'] == 'custom_fields')) {
+                        if ((isset($data['source']) && $data['source'] == 'custom_fields')) {
                             $value = $module->table_name.'_cstm.'.$params[0];
                             $query = $this->build_flow_query_join($module->table_name.'_cstm', $module, 'custom', $query);
                         } else {
@@ -348,27 +348,27 @@ 
                         }
                     }
 
-                    if($params[1] != 'now'){
-                        switch($params[3]) {
+                    if ($params[1] != 'now') {
+                        switch ($params[3]) {
                             case 'business_hours';
-                                if(file_exists('modules/AOBH_BusinessHours/AOBH_BusinessHours.php') && $params[0] == 'now'){
+                                if (file_exists('modules/AOBH_BusinessHours/AOBH_BusinessHours.php') && $params[0] == 'now') {
                                     require_once('modules/AOBH_BusinessHours/AOBH_BusinessHours.php');
 
                                     $businessHours = new AOBH_BusinessHours();
 
                                     $amount = $params[2];
 
-                                    if($params[1] != "plus"){
-                                        $amount = 0-$amount;
+                                    if ($params[1] != "plus") {
+                                        $amount = 0 - $amount;
                                     }
                                     $value = $businessHours->addBusinessHours($amount);
-                                    $value = "'".$timedate->asDb( $value )."'";
+                                    $value = "'".$timedate->asDb($value)."'";
                                     break;
                                 }
                                 //No business hours module found - fall through.
                                 $params[3] = 'hour';
                             default:
-                                if($sugar_config['dbconfig']['db_type'] == 'mssql'){
+                                if ($sugar_config['dbconfig']['db_type'] == 'mssql') {
                                     $value = "DATEADD(".$params[3].",  ".$app_list_strings['aow_date_operator'][$params[1]]." $params[2], $value)";
                                 } else {
                                     $value = "DATE_ADD($value, INTERVAL ".$app_list_strings['aow_date_operator'][$params[1]]." $params[2] ".$params[3].")";
@@ -380,20 +380,20 @@ 
 
                 case 'Multi':
                     $sep = ' AND ';
-                    if($condition->operator == 'Equal_To') $sep = ' OR ';
+                    if ($condition->operator == 'Equal_To') $sep = ' OR ';
                     $multi_values = unencodeMultienum($condition->value);
-                    if(!empty($multi_values)){
+                    if (!empty($multi_values)) {
                         $value = '(';
-                        if($data['type'] == 'multienum'){
-                            $multi_operator =  $condition->operator == 'Equal_To' ? 'LIKE' : 'NOT LIKE';
-                            foreach($multi_values as $multi_value){
-                                if($value != '(') $value .= $sep;
+                        if ($data['type'] == 'multienum') {
+                            $multi_operator = $condition->operator == 'Equal_To' ? 'LIKE' : 'NOT LIKE';
+                            foreach ($multi_values as $multi_value) {
+                                if ($value != '(') $value .= $sep;
                                 $value .= $field." $multi_operator '%^".$multi_value."^%'";
                             }
                         }
                         else {
-                            foreach($multi_values as $multi_value){
-                                if($value != '(') $value .= $sep;
+                            foreach ($multi_values as $multi_value) {
+                                if ($value != '(') $value .= $sep;
                                 $value .= $field.' '.$app_list_strings['aow_sql_operator_list'][$condition->operator]." '".$multi_value."'";
                             }
                         }
@@ -403,7 +403,7 @@ 
                     $where_set = true;
                     break;
                 case 'SecurityGroup':
-                    if(file_exists('modules/SecurityGroups/SecurityGroup.php')){
+                    if (file_exists('modules/SecurityGroups/SecurityGroup.php')) {
                         //TODO check bean in group
                         return array();
                         break;
@@ -416,7 +416,7 @@ 
             }
 
             //handle like conditions
-            Switch($condition->operator) {
+            Switch ($condition->operator) {
                 case 'Contains':
                     $value = "CONCAT('%', ".$value." ,'%')";
                     break;
@@ -429,43 +429,43 @@ 
             }
 
 
-            if(!$where_set) $query['where'][] = $field.' '.$app_list_strings['aow_sql_operator_list'][$condition->operator].' '.$value;
+            if (!$where_set) $query['where'][] = $field.' '.$app_list_strings['aow_sql_operator_list'][$condition->operator].' '.$value;
         }
 
         return $query;
 
     }
 
-    function check_valid_bean(SugarBean &$bean){
+    function check_valid_bean(SugarBean & $bean) {
         global $app_list_strings, $timedate;
 
         require_once('modules/AOW_Processed/AOW_Processed.php');
         $processed = new AOW_Processed();
-        if(!$this->multiple_runs){
-            $processed->retrieve_by_string_fields(array('aow_workflow_id' => $this->id,'parent_id' => $bean->id));
+        if (!$this->multiple_runs) {
+            $processed->retrieve_by_string_fields(array('aow_workflow_id' => $this->id, 'parent_id' => $bean->id));
 
-            if($processed->status == 'Complete'){
+            if ($processed->status == 'Complete') {
                 //has already run so return false
                 return false;
             }
         }
 
-        if(!isset($bean->date_entered)){
+        if (!isset($bean->date_entered)) {
             $bean->date_entered = $bean->fetched_row['date_entered'];
         }
 
 
-        if($this->flow_run_on){
+        if ($this->flow_run_on) {
 
             // database time correction with the user's time-zoneqq
             $beanDateEnteredTimestamp = strtotime($timedate->asUser(new DateTime($timedate->fromDb($bean->date_entered))));
             $beanDateModifiedTimestamp = strtotime($timedate->asUser(new DateTime($timedate->fromDb($bean->date_modified))));
             $thisDateEnteredTimestamp = strtotime($this->date_entered);
 
-            switch($this->flow_run_on){
+            switch ($this->flow_run_on) {
                 case'New_Records':
                     // it is an invalid bean if the user modify it now because the affection need on new records only!
-                    if(!empty($bean->fetched_row) ||
+                    if (!empty($bean->fetched_row) ||
                         $beanDateEnteredTimestamp < $thisDateEnteredTimestamp) {
                         return false;
                     }
@@ -473,7 +473,7 @@ 
 
                 case'Modified_Records':
                     // it isn't a valid bean if the user create it now because the affection need on already exists records only!
-                    if(empty($bean->fetched_row) ||
+                    if (empty($bean->fetched_row) ||
                         ($beanDateModifiedTimestamp < $thisDateEnteredTimestamp && $beanDateModifiedTimestamp != $beanDateEnteredTimestamp)) {
                         return false;
                     }
@@ -495,7 +495,7 @@ 
 
             $condition_bean = $bean;
 
-            if(isset($path[0]) && $path[0] != $bean->module_dir){
+            if (isset($path[0]) && $path[0] != $bean->module_dir) {
                 $query_array = $this->build_query_where($condition, $condition_bean, $query_array);
                 continue;
             }
@@ -503,31 +503,31 @@ 
             $field = $condition->field;
             $value = $condition->value;
 
-            $dateFields = array('date','datetime', 'datetimecombo');
-            if(isset($app_list_strings['aow_sql_operator_list'][$condition->operator])){
+            $dateFields = array('date', 'datetime', 'datetimecombo');
+            if (isset($app_list_strings['aow_sql_operator_list'][$condition->operator])) {
 
                 $data = $condition_bean->field_defs[$field];
 
-                if($data['type'] == 'relate' && isset($data['id_name'])) {
+                if ($data['type'] == 'relate' && isset($data['id_name'])) {
                     $field = $data['id_name'];
                     $condition->field = $data['id_name'];
                 }
                 $field = $condition_bean->$field;
 
-                if(in_array($data['type'],$dateFields)) {
+                if (in_array($data['type'], $dateFields)) {
                     $field = strtotime($field);
                 }
 
-                switch($condition->value_type) {
+                switch ($condition->value_type) {
                     case 'Field':
                         $data = $condition_bean->field_defs[$value];
 
-                        if($data['type'] == 'relate' && isset($data['id_name'])) {
+                        if ($data['type'] == 'relate' && isset($data['id_name'])) {
                             $value = $data['id_name'];
                         }
                         $value = $condition_bean->$value;
 
-                        if(in_array($data['type'],$dateFields)) {
+                        if (in_array($data['type'], $dateFields)) {
                             $value = strtotime($value);
                         }
 
@@ -535,10 +535,10 @@ 
 
                     case 'Any_Change':
                         $value = $condition_bean->fetched_row[$condition->field];
-                        if(in_array($data['type'],$dateFields)) {
+                        if (in_array($data['type'], $dateFields)) {
                             $value = strtotime($value);
                         }
-                        switch($condition->operator) {
+                        switch ($condition->operator) {
                             case 'Not_Equal_To';
                                 $condition->operator = 'Equal_To';
                                 break;
@@ -550,11 +550,11 @@ 
                         break;
 
                     case 'Date':
-                        $params =  unserialize(base64_decode($value));
+                        $params = unserialize(base64_decode($value));
                         $dateType = 'datetime';
-                        if($params[0] == 'now'){
+                        if ($params[0] == 'now') {
                             $value = date('Y-m-d H:i:s');
-                        } else if($params[0] == 'today'){
+                        } else if ($params[0] == 'today') {
                             $dateType = 'date';
                             $value = date('Y-m-d');
                             $field = strtotime(date('Y-m-d', $field));
@@ -563,28 +563,28 @@ 
                             $value = $condition_bean->$fieldName;
                         }
 
-                        if($params[1] != 'now'){
-                            switch($params[3]) {
+                        if ($params[1] != 'now') {
+                            switch ($params[3]) {
                                 case 'business_hours';
-                                    if(file_exists('modules/AOBH_BusinessHours/AOBH_BusinessHours.php')){
+                                    if (file_exists('modules/AOBH_BusinessHours/AOBH_BusinessHours.php')) {
                                         require_once('modules/AOBH_BusinessHours/AOBH_BusinessHours.php');
 
                                         $businessHours = new AOBH_BusinessHours();
 
                                         $amount = $params[2];
-                                        if($params[1] != "plus"){
-                                            $amount = 0-$amount;
+                                        if ($params[1] != "plus") {
+                                            $amount = 0 - $amount;
                                         }
 
                                         $value = $businessHours->addBusinessHours($amount, $timedate->fromDb($value));
-                                        $value = strtotime($timedate->asDbType( $value, $dateType ));
+                                        $value = strtotime($timedate->asDbType($value, $dateType));
                                         break;
                                     }
                                     //No business hours module found - fall through.
                                     $params[3] = 'hours';
                                 default:
                                     $value = strtotime($value.' '.$app_list_strings['aow_date_operator'][$params[1]]." $params[2] ".$params[3]);
-                                    if($dateType == 'date') $value = strtotime(date('Y-m-d', $value));
+                                    if ($dateType == 'date') $value = strtotime(date('Y-m-d', $value));
                                     break;
                             }
                         } else {
@@ -595,8 +595,8 @@ 
                     case 'Multi':
 
                         $value = unencodeMultienum($value);
-                        if($data['type'] == 'multienum') $field = unencodeMultienum($field);
-                        switch($condition->operator) {
+                        if ($data['type'] == 'multienum') $field = unencodeMultienum($field);
+                        switch ($condition->operator) {
                             case 'Not_Equal_To';
                                 $condition->operator = 'Not_One_of';
                                 break;
@@ -607,9 +607,9 @@ 
                         }
                         break;
                     case 'SecurityGroup':
-                        if(file_exists('modules/SecurityGroups/SecurityGroup.php')){
+                        if (file_exists('modules/SecurityGroups/SecurityGroup.php')) {
                             $sg_module = $condition_bean->module_dir;
-                            if(isset($data['module']) && $data['module'] != ''){
+                            if (isset($data['module']) && $data['module'] != '') {
                                 $sg_module = $data['module'];
                             }
                             $value = $this->check_in_group($field, $sg_module, $value);
@@ -618,38 +618,38 @@ 
                         }
                     case 'Value':
                     default:
-                        if(in_array($data['type'],$dateFields) && trim($value) != '') {
+                        if (in_array($data['type'], $dateFields) && trim($value) != '') {
                             $value = strtotime($value);
                         }
                         break;
                 }
 
-                if(!($this->compare_condition($field, $value, $condition->operator))){
+                if (!($this->compare_condition($field, $value, $condition->operator))) {
                     return false;
                 }
 
             }
         }
 
-        if(isset($query_array['where'])){
+        if (isset($query_array['where'])) {
 
             $query = 'SELECT '.$bean->table_name.'.id AS id FROM '.$bean->table_name.' ';
 
-            if(isset($query_array['join'])){
-                foreach ($query_array['join'] as $join){
+            if (isset($query_array['join'])) {
+                foreach ($query_array['join'] as $join) {
                     $query .= $join;
                 }
             }
             $query_where = '';
             $query_array['where'][] = $bean->table_name.'.id = '."'".$bean->id."'";
-            foreach ($query_array['where'] as $where){
-                $query_where .=  ($query_where == '' ? 'WHERE ' : ' AND ').$where;
+            foreach ($query_array['where'] as $where) {
+                $query_where .= ($query_where == '' ? 'WHERE ' : ' AND ').$where;
             }
             $query .= ' '.$query_where;
 
             $rel_check = $bean->db->getOne($query);
 
-            if($rel_check == ''){
+            if ($rel_check == '') {
                 return false;
             }
 
@@ -658,57 +658,57 @@ 
         return true;
     }
 
-    function compare_condition($var1, $var2, $operator = 'Equal_To'){
+    function compare_condition($var1, $var2, $operator = 'Equal_To') {
         switch ($operator) {
             case "Not_Equal_To": return $var1 != $var2;
-            case "Greater_Than":  return $var1 >  $var2;
-            case "Less_Than":  return $var1 <  $var2;
+            case "Greater_Than":  return $var1 > $var2;
+            case "Less_Than":  return $var1 < $var2;
             case "Greater_Than_or_Equal_To": return $var1 >= $var2;
             case "Less_Than_or_Equal_To": return $var1 <= $var2;
-            case "Contains" : return strpos($var1,$var2);
-            case "Starts_With" : return strrpos($var1,$var2, -strlen($var1));
-            case "Ends_With" : return strpos($var1,$var2,strlen($var1) - strlen($var2));
+            case "Contains" : return strpos($var1, $var2);
+            case "Starts_With" : return strrpos($var1, $var2, -strlen($var1));
+            case "Ends_With" : return strpos($var1, $var2, strlen($var1) - strlen($var2));
             case "is_null": return $var1 == '';
             case "One_of":
-                if(is_array($var1)){
-                    foreach($var1 as $var){
-                        if(in_array($var,$var2)) return true;
+                if (is_array($var1)) {
+                    foreach ($var1 as $var) {
+                        if (in_array($var, $var2)) return true;
                     }
                     return false;
                 }
-                else return in_array($var1,$var2);
+                else return in_array($var1, $var2);
             case "Not_One_of":
-                if(is_array($var1)){
-                    foreach($var1 as $var){
-                        if(in_array($var,$var2)) return false;
+                if (is_array($var1)) {
+                    foreach ($var1 as $var) {
+                        if (in_array($var, $var2)) return false;
                     }
                     return true;
                 }
-                else return !in_array($var1,$var2);
+                else return !in_array($var1, $var2);
             case "Equal_To":
             default: return $var1 == $var2;
         }
     }
 
-    function check_in_group($bean_id, $module, $group){
+    function check_in_group($bean_id, $module, $group) {
         $sql = "SELECT id FROM securitygroups_records WHERE record_id = '".$bean_id."' AND module = '".$module."' AND securitygroup_id = '".$group."' AND deleted=0";
-        if($module == 'Users')  $sql = "SELECT id FROM securitygroups_users WHERE user_id = '".$bean_id."' AND securitygroup_id = '".$group."' AND deleted=0";
+        if ($module == 'Users')  $sql = "SELECT id FROM securitygroups_users WHERE user_id = '".$bean_id."' AND securitygroup_id = '".$group."' AND deleted=0";
         $id = $this->db->getOne($sql);
-        if($id != '') return true;
+        if ($id != '') return true;
         return false;
     }
 
     /**
      * Run the actions against the passed $bean
      */
-    function run_actions(SugarBean &$bean, $in_save = false){
+    function run_actions(SugarBean & $bean, $in_save = false) {
 
         require_once('modules/AOW_Processed/AOW_Processed.php');
         $processed = new AOW_Processed();
-        if(!$this->multiple_runs){
-            $processed->retrieve_by_string_fields(array('aow_workflow_id' => $this->id,'parent_id' => $bean->id));
+        if (!$this->multiple_runs) {
+            $processed->retrieve_by_string_fields(array('aow_workflow_id' => $this->id, 'parent_id' => $bean->id));
 
-            if($processed->status == 'Complete'){
+            if ($processed->status == 'Complete') {
                 //should not have gotten this far, so return
                 return true;
             }
@@ -729,25 +729,25 @@ 
             $action = new AOW_Action();
             $action->retrieve($row['id']);
 
-            if($this->multiple_runs || !$processed->db->getOne("select id from aow_processed_aow_actions where aow_processed_id = '".$processed->id."' AND aow_action_id = '".$action->id."' AND status = 'Complete'")){
+            if ($this->multiple_runs || !$processed->db->getOne("select id from aow_processed_aow_actions where aow_processed_id = '".$processed->id."' AND aow_action_id = '".$action->id."' AND status = 'Complete'")) {
                 $action_name = 'action'.$action->action;
 
-                if(file_exists('custom/modules/AOW_Actions/actions/'.$action_name.'.php')){
+                if (file_exists('custom/modules/AOW_Actions/actions/'.$action_name.'.php')) {
                     require_once('custom/modules/AOW_Actions/actions/'.$action_name.'.php');
-                } else if(file_exists('modules/AOW_Actions/actions/'.$action_name.'.php')){
+                } else if (file_exists('modules/AOW_Actions/actions/'.$action_name.'.php')) {
                     require_once('modules/AOW_Actions/actions/'.$action_name.'.php');
                 } else {
                     return false;
                 }
 
-                $custom_action_name = "custom" . $action_name;
-                if(class_exists($custom_action_name)){
+                $custom_action_name = "custom".$action_name;
+                if (class_exists($custom_action_name)) {
                     $action_name = $custom_action_name;
                 }
 
 
                 $flow_action = new $action_name($action->id);
-                if(!$flow_action->run_action($bean, unserialize(base64_decode($action->parameters)), $in_save)){
+                if (!$flow_action->run_action($bean, unserialize(base64_decode($action->parameters)), $in_save)) {
                     $pass = false;
                     $processed->aow_actions->add($action->id, array('status' => 'Failed'));
                 } else {
@@ -757,7 +757,7 @@ 
 
         }
 
-        if($pass) $processed->status = 'Complete';
+        if ($pass) $processed->status = 'Complete';
         else $processed->status = 'Failed';
         $processed->save(false);
 

Braces +44 added lines, -20 removed lines

@@ -66,8 +66,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct($init);
@@ -153,8 +152,9 @@ 
             $flow = new AOW_WorkFlow();
             while (($row = $bean->db->fetchByAssoc($result)) != null){
                 $flow ->retrieve($row['id']);
-                if($flow->check_valid_bean($bean))
-                    $flow->run_actions($bean, true);
+                if($flow->check_valid_bean($bean)) {
+                                    $flow->run_actions($bean, true);
+                }
             }
         }
         return true;
@@ -380,20 +380,25 @@ 
 
                 case 'Multi':
                     $sep = ' AND ';
-                    if($condition->operator == 'Equal_To') $sep = ' OR ';
+                    if($condition->operator == 'Equal_To') {
+                        $sep = ' OR ';
+                    }
                     $multi_values = unencodeMultienum($condition->value);
                     if(!empty($multi_values)){
                         $value = '(';
                         if($data['type'] == 'multienum'){
                             $multi_operator =  $condition->operator == 'Equal_To' ? 'LIKE' : 'NOT LIKE';
                             foreach($multi_values as $multi_value){
-                                if($value != '(') $value .= $sep;
+                                if($value != '(') {
+                                    $value .= $sep;
+                                }
                                 $value .= $field." $multi_operator '%^".$multi_value."^%'";
                             }
-                        }
-                        else {
+                        } else {
                             foreach($multi_values as $multi_value){
-                                if($value != '(') $value .= $sep;
+                                if($value != '(') {
+                                    $value .= $sep;
+                                }
                                 $value .= $field.' '.$app_list_strings['aow_sql_operator_list'][$condition->operator]." '".$multi_value."'";
                             }
                         }
@@ -429,7 +434,9 @@ 
             }
 
 
-            if(!$where_set) $query['where'][] = $field.' '.$app_list_strings['aow_sql_operator_list'][$condition->operator].' '.$value;
+            if(!$where_set) {
+                $query['where'][] = $field.' '.$app_list_strings['aow_sql_operator_list'][$condition->operator].' '.$value;
+            }
         }
 
         return $query;
@@ -584,7 +591,9 @@ 
                                     $params[3] = 'hours';
                                 default:
                                     $value = strtotime($value.' '.$app_list_strings['aow_date_operator'][$params[1]]." $params[2] ".$params[3]);
-                                    if($dateType == 'date') $value = strtotime(date('Y-m-d', $value));
+                                    if($dateType == 'date') {
+                                        $value = strtotime(date('Y-m-d', $value));
+                                    }
                                     break;
                             }
                         } else {
@@ -595,7 +604,9 @@ 
                     case 'Multi':
 
                         $value = unencodeMultienum($value);
-                        if($data['type'] == 'multienum') $field = unencodeMultienum($field);
+                        if($data['type'] == 'multienum') {
+                            $field = unencodeMultienum($field);
+                        }
                         switch($condition->operator) {
                             case 'Not_Equal_To';
                                 $condition->operator = 'Not_One_of';
@@ -672,19 +683,25 @@ 
             case "One_of":
                 if(is_array($var1)){
                     foreach($var1 as $var){
-                        if(in_array($var,$var2)) return true;
+                        if(in_array($var,$var2)) {
+                            return true;
+                        }
                     }
                     return false;
+                } else {
+                    return in_array($var1,$var2);
                 }
-                else return in_array($var1,$var2);
             case "Not_One_of":
                 if(is_array($var1)){
                     foreach($var1 as $var){
-                        if(in_array($var,$var2)) return false;
+                        if(in_array($var,$var2)) {
+                            return false;
+                        }
                     }
                     return true;
+                } else {
+                    return !in_array($var1,$var2);
                 }
-                else return !in_array($var1,$var2);
             case "Equal_To":
             default: return $var1 == $var2;
         }
@@ -692,9 +709,13 @@ 
 
     function check_in_group($bean_id, $module, $group){
         $sql = "SELECT id FROM securitygroups_records WHERE record_id = '".$bean_id."' AND module = '".$module."' AND securitygroup_id = '".$group."' AND deleted=0";
-        if($module == 'Users')  $sql = "SELECT id FROM securitygroups_users WHERE user_id = '".$bean_id."' AND securitygroup_id = '".$group."' AND deleted=0";
+        if($module == 'Users') {
+            $sql = "SELECT id FROM securitygroups_users WHERE user_id = '".$bean_id."' AND securitygroup_id = '".$group."' AND deleted=0";
+        }
         $id = $this->db->getOne($sql);
-        if($id != '') return true;
+        if($id != '') {
+            return true;
+        }
         return false;
     }
 
@@ -757,8 +778,11 @@ 
 
         }
 
-        if($pass) $processed->status = 'Complete';
-        else $processed->status = 'Failed';
+        if($pass) {
+            $processed->status = 'Complete';
+        } else {
+            $processed->status = 'Failed';
+        }
         $processed->save(false);
 
         return $pass;

modules/AOW_WorkFlow/Dashlets/AOW_WorkFlowDashlet/AOW_WorkFlowDashlet.php

Spacing +4 added lines, -4 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /**
  * Advanced OpenWorkflow, Automating SugarCRM.
  * @package Advanced OpenWorkflow for SugarCRM
@@ -34,7 +34,7 @@ 
 
         parent::__construct($id, $def);
 
-        if(empty($def['title'])) $this->title = translate('LBL_HOMEPAGE_TITLE', 'AOW_WorkFlow');
+        if (empty($def['title'])) $this->title = translate('LBL_HOMEPAGE_TITLE', 'AOW_WorkFlow');
 
         $this->searchFields = $dashletData['AOW_WorkFlowDashlet']['searchFields'];
         $this->columns = $dashletData['AOW_WorkFlowDashlet']['columns'];
@@ -45,9 +45,9 @@ 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    function AOW_WorkFlowDashlet($id, $def = null){
+    function AOW_WorkFlowDashlet($id, $def = null) {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {

Braces +7 added lines, -4 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /**
  * Advanced OpenWorkflow, Automating SugarCRM.
  * @package Advanced OpenWorkflow for SugarCRM
@@ -34,7 +36,9 @@ 
 
         parent::__construct($id, $def);
 
-        if(empty($def['title'])) $this->title = translate('LBL_HOMEPAGE_TITLE', 'AOW_WorkFlow');
+        if(empty($def['title'])) {
+            $this->title = translate('LBL_HOMEPAGE_TITLE', 'AOW_WorkFlow');
+        }
 
         $this->searchFields = $dashletData['AOW_WorkFlowDashlet']['searchFields'];
         $this->columns = $dashletData['AOW_WorkFlowDashlet']['columns'];
@@ -49,8 +53,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct($id, $def);

modules/Calendar/views/view.getgr.php

Spacing +5 added lines, -5 removed lines

@@ -41,16 +41,16 @@ 
 
 class CalendarViewGetGR extends SugarView {
 
-	function __construct(){
+	function __construct() {
  		parent::__construct();
 	}
 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    function CalendarViewGetGR(){
+    function CalendarViewGetGR() {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {
@@ -60,11 +60,11 @@ 
     }
 
 
-	function process(){
+	function process() {
 		$this->display();
 	}
 
-	function display(){
+	function display() {
 		error_reporting(0);
 		require_once('include/json_config.php');
 		global $json;

Braces +1 added lines, -2 removed lines

@@ -23,8 +23,7 @@
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct($seed, $module, $subPanel, $options);

modules/Calendar/views/view.getgrusers.php

Spacing +9 added lines, -9 removed lines

@@ -41,16 +41,16 @@ 
 
 class CalendarViewGetGRUsers extends SugarView {
 
-	function __construct(){
+	function __construct() {
  		parent::__construct();
 	}
 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    function CalendarViewGetGRUsers(){
+    function CalendarViewGetGRUsers() {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {
@@ -60,15 +60,15 @@ 
     }
 
 
-	function process(){
+	function process() {
 		$this->display();
 	}
 
-	function display(){
+	function display() {
 		$users_arr = array();
 		require_once("modules/Users/User.php");
 
-		$user_ids = explode(",", trim($_REQUEST['users'],','));
+		$user_ids = explode(",", trim($_REQUEST['users'], ','));
 		$user_ids = array_unique($user_ids);
 
 		require_once('include/json_config.php');
@@ -76,15 +76,15 @@ 
 		$json = getJSONobj();
 		$json_config = new json_config();
 
-		foreach($user_ids as $u_id){
-			if(empty($u_id))
+		foreach ($user_ids as $u_id) {
+			if (empty($u_id))
 				continue;
 			$bean = new User();
 			$bean->retrieve($u_id);
 			array_push($users_arr, $json_config->populateBean($bean));
 		}
 
-		$GRjavascript = "\n" . $json_config->global_registry_var_name."['focus'].users_arr = " . $json->encode($users_arr) . ";\n";
+		$GRjavascript = "\n".$json_config->global_registry_var_name."['focus'].users_arr = ".$json->encode($users_arr).";\n";
 		ob_clean();
 		echo $GRjavascript;
 	}

Braces +4 added lines, -4 removed lines

@@ -52,8 +52,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct();
@@ -77,8 +76,9 @@ 
 		$json_config = new json_config();
 
 		foreach($user_ids as $u_id){
-			if(empty($u_id))
-				continue;
+			if(empty($u_id)) {
+							continue;
+			}
 			$bean = new User();
 			$bean->retrieve($u_id);
 			array_push($users_arr, $json_config->populateBean($bean));

modules/Calendar/Dashlets/CalendarDashlet/CalendarDashlet.php

Spacing +15 added lines, -15 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -46,19 +46,19 @@ 
     var $view = 'week';
 
     function __construct($id, $def) {
-        $this->loadLanguage('CalendarDashlet','modules/Calendar/Dashlets/');
+        $this->loadLanguage('CalendarDashlet', 'modules/Calendar/Dashlets/');
 
 		parent::__construct($id);
 
 		$this->isConfigurable = true;
 		$this->hasScript = true;
 
-		if(empty($def['title']))
+		if (empty($def['title']))
 			$this->title = $this->dashletStrings['LBL_TITLE'];
 		else
 			$this->title = $def['title'];
 
-		if(!empty($def['view']))
+		if (!empty($def['view']))
 			$this->view = $def['view'];
 
     }
@@ -66,9 +66,9 @@ 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    function CalendarDashlet($id, $def){
+    function CalendarDashlet($id, $def) {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {
@@ -78,11 +78,11 @@ 
     }
 
 
-    function display(){
+    function display() {
 		ob_start();
 
-		if(isset($GLOBALS['cal_strings']))
-			return parent::display() . "Only one Calendar dashlet is allowed.";
+		if (isset($GLOBALS['cal_strings']))
+			return parent::display()."Only one Calendar dashlet is allowed.";
 
 		require_once('modules/Calendar/Calendar.php');
 		require_once('modules/Calendar/CalendarDisplay.php');
@@ -91,7 +91,7 @@ 
 		global $cal_strings, $current_language;
 		$cal_strings = return_module_language($current_language, 'Calendar');
 
-		if(!ACLController::checkAccess('Calendar', 'list', true))
+		if (!ACLController::checkAccess('Calendar', 'list', true))
 			ACLController::displayNoAccess(true);
 
 		$cal = new Calendar($this->view);
@@ -99,26 +99,26 @@ 
 		$cal->add_activities($GLOBALS['current_user']);
 		$cal->load_activities();
 
-		$display = new CalendarDisplay($cal,$this->id);
+		$display = new CalendarDisplay($cal, $this->id);
 		$display->display_calendar_header(false);
 		$display->display();
 
 		$str = ob_get_contents();
 		ob_end_clean();
 
-		return parent::display() . $str;
+		return parent::display().$str;
     }
 
 
     function displayOptions() {
-        global $app_strings,$mod_strings;
+        global $app_strings, $mod_strings;
         $ss = new Sugar_Smarty();
         $ss->assign('MOD', $this->dashletStrings);
         $ss->assign('title', $this->title);
         $ss->assign('view', $this->view);
         $ss->assign('id', $this->id);
 
-        return parent::displayOptions() . $ss->fetch('modules/Calendar/Dashlets/CalendarDashlet/CalendarDashletOptions.tpl');
+        return parent::displayOptions().$ss->fetch('modules/Calendar/Dashlets/CalendarDashlet/CalendarDashletOptions.tpl');
     }
 
     function saveOptions($req) {
@@ -130,7 +130,7 @@ 
         return $options;
     }
 
-    function displayScript(){
+    function displayScript() {
 	return "";
     }
 

Braces +18 added lines, -13 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -53,13 +55,15 @@ 
 		$this->isConfigurable = true;
 		$this->hasScript = true;
 
-		if(empty($def['title']))
-			$this->title = $this->dashletStrings['LBL_TITLE'];
-		else
-			$this->title = $def['title'];
+		if(empty($def['title'])) {
+					$this->title = $this->dashletStrings['LBL_TITLE'];
+		} else {
+					$this->title = $def['title'];
+		}
 
-		if(!empty($def['view']))
-			$this->view = $def['view'];
+		if(!empty($def['view'])) {
+					$this->view = $def['view'];
+		}
 
     }
 
@@ -70,8 +74,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct($id, $def);
@@ -81,8 +84,9 @@ 
     function display(){
 		ob_start();
 
-		if(isset($GLOBALS['cal_strings']))
-			return parent::display() . "Only one Calendar dashlet is allowed.";
+		if(isset($GLOBALS['cal_strings'])) {
+					return parent::display() . "Only one Calendar dashlet is allowed.";
+		}
 
 		require_once('modules/Calendar/Calendar.php');
 		require_once('modules/Calendar/CalendarDisplay.php');
@@ -91,8 +95,9 @@ 
 		global $cal_strings, $current_language;
 		$cal_strings = return_module_language($current_language, 'Calendar');
 
-		if(!ACLController::checkAccess('Calendar', 'list', true))
-			ACLController::displayNoAccess(true);
+		if(!ACLController::checkAccess('Calendar', 'list', true)) {
+					ACLController::displayNoAccess(true);
+		}
 
 		$cal = new Calendar($this->view);
 		$cal->dashlet = true;

modules/vCals/HTTP_WebDAV_Server_vCal.php

Spacing +35 added lines, -35 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -78,9 +78,9 @@ 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    function HTTP_WebDAV_Server_vCal(){
+    function HTTP_WebDAV_Server_vCal() {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {
@@ -100,7 +100,7 @@ 
         function ServeRequest($base = false)
         {
 
-            global $sugar_config,$current_language;
+            global $sugar_config, $current_language;
 
             if (!empty($sugar_config['session_dir']))
             {
@@ -129,35 +129,35 @@ 
             // set root directory, defaults to webserver document root if not set
             if ($base) {
                 $this->base = realpath($base); // TODO throw if not a directory
-            } else if(!$this->base) {
+            } else if (!$this->base) {
                 $this->base = $_SERVER['DOCUMENT_ROOT'];
             }
 
 
-            $query_arr =  array();
+            $query_arr = array();
              // set path
-            if ( empty($_SERVER["PATH_INFO"]))
+            if (empty($_SERVER["PATH_INFO"]))
             {
 				$this->path = "/";
-				if(strtolower($_SERVER["REQUEST_METHOD"]) == 'get'){
+				if (strtolower($_SERVER["REQUEST_METHOD"]) == 'get') {
 					$query_arr = $_REQUEST;
-				}else{
-					parse_str($_REQUEST['parms'],$query_arr);
+				} else {
+					parse_str($_REQUEST['parms'], $query_arr);
 				}
-            } else{
-              $this->path = $this->_urldecode( $_SERVER["PATH_INFO"]);
+            } else {
+              $this->path = $this->_urldecode($_SERVER["PATH_INFO"]);
 
-              if(ini_get("magic_quotes_gpc")) {
+              if (ini_get("magic_quotes_gpc")) {
                $this->path = stripslashes($this->path);
               }
 
-              $query_str = preg_replace('/^\//','',$this->path);
-              $query_arr =  array();
-              parse_str($query_str,$query_arr);
+              $query_str = preg_replace('/^\//', '', $this->path);
+              $query_arr = array();
+              parse_str($query_str, $query_arr);
             }
 
 
-            if ( ! empty($query_arr['type']))
+            if (!empty($query_arr['type']))
             {
               $this->vcal_type = $query_arr['type'];
             }
@@ -165,7 +165,7 @@ 
               $this->vcal_type = 'vfb';
             }
 
-            if ( ! empty($query_arr['source']))
+            if (!empty($query_arr['source']))
             {
               $this->source = $query_arr['source'];
             }
@@ -173,24 +173,24 @@ 
               $this->source = 'outlook';
             }
 
-            if ( ! empty($query_arr['key']))
+            if (!empty($query_arr['key']))
             {
               $this->publish_key = $query_arr['key'];
             }
 
             // select user by email
-            if ( ! empty($query_arr['email']))
+            if (!empty($query_arr['email']))
             {
 
 
               // clean the string!
               $query_arr['email'] = clean_string($query_arr['email']);
               //get user info
-              $this->user_focus->retrieve_by_email_address( $query_arr['email']);
+              $this->user_focus->retrieve_by_email_address($query_arr['email']);
 
             }
             // else select user by user_name
-            else if ( ! empty($query_arr['user_name']))
+            else if (!empty($query_arr['user_name']))
             {
               // clean the string!
               $query_arr['user_name'] = clean_string($query_arr['user_name']);
@@ -200,13 +200,13 @@ 
               $this->user_focus->retrieve_by_string_fields($arr);
             }
             // else select user by user id
-            else if ( ! empty($query_arr['user_id']))
+            else if (!empty($query_arr['user_id']))
             {
                 $this->user_focus->retrieve($query_arr['user_id']);
             }
 
             // if we haven't found a user, then return 404
-            if ( empty($this->user_focus->id) || $this->user_focus->id == -1)
+            if (empty($this->user_focus->id) || $this->user_focus->id == -1)
             {
                 $this->http_status('401 Unauthorized');
                 if (!isset($query_arr['noAuth'])) {
@@ -235,11 +235,11 @@ 
          */
         function check_auth($type, $user, $pass)
         {
-            if(isset($_SESSION['authenticated_user_id'])) {
+            if (isset($_SESSION['authenticated_user_id'])) {
                 // allow logged in users access to freebusy info
                 return true;
             }
-            if(!empty($this->publish_key) && !empty($this->user_focus) && $this->user_focus->getPreference('calendar_publish_key' ) == $this->publish_key) {
+            if (!empty($this->publish_key) && !empty($this->user_focus) && $this->user_focus->getPreference('calendar_publish_key') == $this->publish_key) {
                 return true;
             }
             return false;
@@ -357,8 +357,8 @@ 
             }
 
             // DO AUTHORIZATION for publishing Free/busy to Sugar:
-            if ( empty($this->publish_key) ||
-                $this->publish_key != $this->user_focus->getPreference('calendar_publish_key' ))
+            if (empty($this->publish_key) ||
+                $this->publish_key != $this->user_focus->getPreference('calendar_publish_key'))
             {
                     $this->http_status("401 not authorized");
                     return;
@@ -366,15 +366,15 @@ 
             }
 
             // retrieve
-            $arr = array('user_id'=>$this->user_focus->id,'type'=>'vfb','source'=>$this->source);
+            $arr = array('user_id'=>$this->user_focus->id, 'type'=>'vfb', 'source'=>$this->source);
             $this->vcal_focus->retrieve_by_string_fields($arr);
 
-            $isUpdate  = false;
+            $isUpdate = false;
 
-            if ( ! empty($this->vcal_focus->user_id ) &&
-                $this->vcal_focus->user_id != -1 )
+            if (!empty($this->vcal_focus->user_id) &&
+                $this->vcal_focus->user_id != -1)
             {
-              $isUpdate  = true;
+              $isUpdate = true;
             }
 
             // open input stream
@@ -395,7 +395,7 @@ 
             $this->vcal_focus->user_id = $this->user_focus->id;
             $this->vcal_focus->save();
 
-            if ( $isUpdate )
+            if ($isUpdate)
             {
                $this->http_status("204 No Content");
             } else {
@@ -423,7 +423,7 @@ 
         function lock(&$options)
         {
 
-            $options["timeout"] = time()+300; // 5min. hardcoded
+            $options["timeout"] = time() + 300; // 5min. hardcoded
             return true;
         }
 

Braces +10 added lines, -9 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -82,8 +84,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct();
@@ -141,7 +142,7 @@ 
 				$this->path = "/";
 				if(strtolower($_SERVER["REQUEST_METHOD"]) == 'get'){
 					$query_arr = $_REQUEST;
-				}else{
+				} else{
 					parse_str($_REQUEST['parms'],$query_arr);
 				}
             } else{
@@ -160,16 +161,14 @@ 
             if ( ! empty($query_arr['type']))
             {
               $this->vcal_type = $query_arr['type'];
-            }
-            else {
+            } else {
               $this->vcal_type = 'vfb';
             }
 
             if ( ! empty($query_arr['source']))
             {
               $this->source = $query_arr['source'];
-            }
-            else {
+            } else {
               $this->source = 'outlook';
             }
 
@@ -308,7 +307,9 @@ 
                (Not Implemented) response in such cases."
             */
             foreach ($_SERVER as $key => $val) {
-                if (strncmp($key, "HTTP_CONTENT", 11)) continue;
+                if (strncmp($key, "HTTP_CONTENT", 11)) {
+                    continue;
+                }
                 switch ($key) {
                 case 'HTTP_CONTENT_ENCODING': // RFC 2616 14.11
                     // TODO support this if ext/zlib filters are available

modules/vCals/vCal.php

Spacing +23 added lines, -23 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -79,9 +79,9 @@ 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    public function vCal(){
+    public function vCal() {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {
@@ -136,10 +136,10 @@ 
 	function create_sugar_freebusy($user_bean, $start_date_time, $end_date_time)
 	{
         $ical_array = array();
-		global $DO_USER_TIME_OFFSET,$timedate;
+		global $DO_USER_TIME_OFFSET, $timedate;
 
 		$DO_USER_TIME_OFFSET = true;
-		if(empty($GLOBALS['current_user']) || empty($GLOBALS['current_user']->id)) {
+		if (empty($GLOBALS['current_user']) || empty($GLOBALS['current_user']->id)) {
 		    $GLOBALS['current_user'] = $user_bean;
 		}
 		// get activities.. queries Meetings and Calls
@@ -151,12 +151,12 @@ 
 			'freebusy');
 
 		// loop thru each activity, get start/end time in UTC, and return FREEBUSY strings
-		foreach($acts_arr as $act)
+		foreach ($acts_arr as $act)
 		{
             $ID = $act->sugar_bean->id;
 			$startTimeUTC = $act->start_time->format(self::UTC_FORMAT);
 			$endTimeUTC = $act->end_time->format(self::UTC_FORMAT);
-            $ical_array[] = array("FREEBUSY", $startTimeUTC ."/". $endTimeUTC);
+            $ical_array[] = array("FREEBUSY", $startTimeUTC."/".$endTimeUTC);
             $ical_array[] = array("X-FREEBUSY-ID", $ID);
             $ical_array[] = array("X-FREEBUSY-TYPE", get_class($act->sugar_bean));
             //$ical_array[] = array(array("X-FREEBUSYID", $ID), array("FREEBUSY", $startTimeUTC ."/". $endTimeUTC));
@@ -167,7 +167,7 @@ 
 	}
 
         // return a freebusy vcal string
-        function get_vcal_freebusy($user_focus,$cached=true)
+        function get_vcal_freebusy($user_focus, $cached = true)
         {
            global $locale, $timedate;
            $ical_array = array();
@@ -227,7 +227,7 @@ 
            }
 
            // UID:20030724T213406Z-10358-1000-1-12@phoenix
-           $str .= self::fold_ical_lines("DTSTAMP", $utc_now_time) . self::EOL;
+           $str .= self::fold_ical_lines("DTSTAMP", $utc_now_time).self::EOL;
            $str .= "END:VFREEBUSY".self::EOL;
            $str .= "END:VCALENDAR".self::EOL;
            return $str;
@@ -247,11 +247,11 @@ 
         {
             $focus = new vCal();
             // set freebusy members and save
-            $arr = array('user_id'=>$user_focus->id,'type'=>'vfb','source'=>'sugar');
+            $arr = array('user_id'=>$user_focus->id, 'type'=>'vfb', 'source'=>'sugar');
             $focus->retrieve_by_string_fields($arr);
 
 
-            $focus->content = $focus->get_vcal_freebusy($user_focus,false);
+            $focus->content = $focus->get_vcal_freebusy($user_focus, false);
             $focus->type = 'vfb';
             $focus->date_modified = null;
             $focus->source = 'sugar';
@@ -265,7 +265,7 @@ 
      */
     public static function fold_ical_lines($key, $value)
     {
-        $iCalValue = $key . ":" . $value;
+        $iCalValue = $key.":".$value;
 
         if (strlen($iCalValue) <= self::CHARSPERLINE) {
             return $iCalValue;
@@ -273,11 +273,11 @@ 
 
         $firstchars = substr($iCalValue, 0, self::CHARSPERLINE);
         $remainingchars = substr($iCalValue, self::CHARSPERLINE);
-        $end = self::EOL . self::TAB;
+        $end = self::EOL.self::TAB;
 
         $remainingchars = substr(
             chunk_split(
-                $end . $remainingchars,
+                $end.$remainingchars,
                 self::CHARSPERLINE + strlen(self::EOL),
                 $end
             ),
@@ -285,7 +285,7 @@ 
             -strlen($end) // exclude last EOL and TAB chars
         );
 
-        return $firstchars . $remainingchars;
+        return $firstchars.$remainingchars;
     }
 
     /**
@@ -312,14 +312,14 @@ 
     /**
      * this function takes an iCal array and converts it to iCal string while following RFC rules
      */
-    public static function create_ical_string_from_array($ical_array,$no_folding=false)
+    public static function create_ical_string_from_array($ical_array, $no_folding = false)
     {
         $str = "";
         foreach ($ical_array as $ical) {
-            if($no_folding){
-                $str .= $ical[0].":".self::escape_ical_chars($ical[1]) . self::EOL;
+            if ($no_folding) {
+                $str .= $ical[0].":".self::escape_ical_chars($ical[1]).self::EOL;
             } else {
-                $str .= self::fold_ical_lines($ical[0], self::escape_ical_chars($ical[1])) . self::EOL;
+                $str .= self::fold_ical_lines($ical[0], self::escape_ical_chars($ical[1])).self::EOL;
             }
         }
         return $str;
@@ -352,7 +352,7 @@ 
 	/**
 	 * get ics file content for meeting invite email
 	 */
-	public static function get_ical_event(SugarBean $bean, User $user){
+	public static function get_ical_event(SugarBean $bean, User $user) {
         global $timedate;
         $ical_array = array();
 
@@ -361,7 +361,7 @@ 
         $ical_array[] = array("PRODID", "-//SugarCRM//SugarCRM Calendar//EN");
         $ical_array[] = array("BEGIN", "VEVENT");
         $ical_array[] = array("UID", $bean->id);
-        $ical_array[] = array("ORGANIZED;CN=" . $user->full_name, $user->email1);
+        $ical_array[] = array("ORGANIZED;CN=".$user->full_name, $user->email1);
         $ical_array[] = array("DTSTART", $timedate->fromDb($bean->date_start)->format(self::UTC_FORMAT));
         $ical_array[] = array("DTEND", $timedate->fromDb($bean->date_end)->format(self::UTC_FORMAT));
 
@@ -372,8 +372,8 @@ 
         $ical_array[] = array("SUMMARY", $bean->name);
         $ical_array[] = array("LOCATION", $bean->location);
 
-        $descPrepend = empty($bean->join_url) ? "" : $bean->join_url . self::EOL . self::EOL;
-        $ical_array[] = array("DESCRIPTION", $descPrepend . $bean->description);
+        $descPrepend = empty($bean->join_url) ? "" : $bean->join_url.self::EOL.self::EOL;
+        $ical_array[] = array("DESCRIPTION", $descPrepend.$bean->description);
 
         $ical_array[] = array("END", "VEVENT");
         $ical_array[] = array("END", "VCALENDAR");

Braces +4 added lines, -3 removed lines

@@ -43,7 +43,9 @@ 
  * Date: 06/03/15
  * Comments
  */
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 
 class CasesController extends SugarController {
 
@@ -90,8 +92,7 @@ 
                 $count++;
             }
             echo '</table>';
-        }
-        else {
+        } else {
             echo $mod_strings['LBL_NO_SUGGESTIONS'];
         }
         die();

modules/ACL/ACLJSController.php

Indentation +84 added lines, -84 removed lines

@@ -42,12 +42,12 @@ 
 
 class ACLJSController{
 
-	public function __construct($module,$form='', $is_owner=false){
+    public function __construct($module,$form='', $is_owner=false){
 
-		$this->module = $module;
-		$this->is_owner = $is_owner;
-		$this->form = $form;
-	}
+        $this->module = $module;
+        $this->is_owner = $is_owner;
+        $this->form = $form;
+    }
 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
@@ -64,16 +64,16 @@ 
     }
 
 
-	function getJavascript(){
-		global $action;
-		if(!ACLController::moduleSupportsACL($this->module)){
-			return '';
-		}
-		$script = "<SCRIPT>\n//BEGIN ACL JAVASCRIPT\n";
+    function getJavascript(){
+        global $action;
+        if(!ACLController::moduleSupportsACL($this->module)){
+            return '';
+        }
+        $script = "<SCRIPT>\n//BEGIN ACL JAVASCRIPT\n";
 
-		if($action == 'DetailView'){
-			if(!ACLController::checkAccess($this->module,'edit', $this->is_owner)){
-			$script .= <<<EOQ
+        if($action == 'DetailView'){
+            if(!ACLController::checkAccess($this->module,'edit', $this->is_owner)){
+            $script .= <<<EOQ
 						if(typeof(document.DetailView) != 'undefined'){
 							if(typeof(document.DetailView.elements['Edit']) != 'undefined'){
 								document.DetailView.elements['Edit'].disabled = 'disabled';
@@ -84,8 +84,8 @@ 
 						}
 EOQ;
 }
-			if(!ACLController::checkAccess($this->module,'delete', $this->is_owner)){
-			$script .= <<<EOQ
+            if(!ACLController::checkAccess($this->module,'delete', $this->is_owner)){
+            $script .= <<<EOQ
 						if(typeof(document.DetailView) != 'undefined'){
 							if(typeof(document.DetailView.elements['Delete']) != 'undefined'){
 								document.DetailView.elements['Delete'].disabled = 'disabled';
@@ -93,94 +93,94 @@ 
 						}
 EOQ;
 }
-		}
-		if(file_exists('modules/'. $this->module . '/metadata/acldefs.php')){
-			include('modules/'. $this->module . '/metadata/acldefs.php');
-
-			foreach($acldefs[$this->module]['forms'] as $form_name=>$form){
-
-				foreach($form as $field_name=>$field){
-
-					if($field['app_action'] == $action){
-						switch($form_name){
-							case 'by_id':
-								$script .= $this->getFieldByIdScript($field_name, $field);
-								break;
-							case 'by_name':
-								$script .= $this->getFieldByNameScript($field_name, $field);
-								break;
-							default:
-								$script .= $this->getFieldByFormScript($form_name, $field_name, $field);
-								break;
-						}
-					}
-
-				}
-			}
-		}
-		$script .=  '</SCRIPT>';
+        }
+        if(file_exists('modules/'. $this->module . '/metadata/acldefs.php')){
+            include('modules/'. $this->module . '/metadata/acldefs.php');
+
+            foreach($acldefs[$this->module]['forms'] as $form_name=>$form){
+
+                foreach($form as $field_name=>$field){
+
+                    if($field['app_action'] == $action){
+                        switch($form_name){
+                            case 'by_id':
+                                $script .= $this->getFieldByIdScript($field_name, $field);
+                                break;
+                            case 'by_name':
+                                $script .= $this->getFieldByNameScript($field_name, $field);
+                                break;
+                            default:
+                                $script .= $this->getFieldByFormScript($form_name, $field_name, $field);
+                                break;
+                        }
+                    }
+
+                }
+            }
+        }
+        $script .=  '</SCRIPT>';
 
-		return $script;
+        return $script;
 
 
-	}
+    }
 
-	function getHTMLValues($def){
-		$return_array = array();
-		switch($def['display_option']){
-			case 'clear_link':
-				$return_array['href']= "#";
-				$return_array['className']= "nolink";
-				break;
-			default;
-				$return_array[$def['display_option']] = $def['display_option'];
-				break;
+    function getHTMLValues($def){
+        $return_array = array();
+        switch($def['display_option']){
+            case 'clear_link':
+                $return_array['href']= "#";
+                $return_array['className']= "nolink";
+                break;
+            default;
+                $return_array[$def['display_option']] = $def['display_option'];
+                break;
 
-		}
-		return $return_array;
+        }
+        return $return_array;
 
-	}
+    }
 
-	function getFieldByIdScript($name, $def){
-		$script = '';
-		if(!ACLController::checkAccess($def['module'], $def['action_option'], true)){
-		foreach($this->getHTMLValues($def) as $key=>$value){
-			$script .=  "\nif(document.getElementById('$name'))document.getElementById('$name')." . $key . '="' .$value. '";'. "\n";
-		}
-		}
-		return $script;
+    function getFieldByIdScript($name, $def){
+        $script = '';
+        if(!ACLController::checkAccess($def['module'], $def['action_option'], true)){
+        foreach($this->getHTMLValues($def) as $key=>$value){
+            $script .=  "\nif(document.getElementById('$name'))document.getElementById('$name')." . $key . '="' .$value. '";'. "\n";
+        }
+        }
+        return $script;
 
-	}
+    }
 
-	function getFieldByNameScript($name, $def){
-		$script = '';
-		if(!ACLController::checkAccess($def['module'], $def['action_option'], true)){
+    function getFieldByNameScript($name, $def){
+        $script = '';
+        if(!ACLController::checkAccess($def['module'], $def['action_option'], true)){
 
-		foreach($this->getHTMLValues($def) as $key=>$value){
-			$script .=  <<<EOQ
+        foreach($this->getHTMLValues($def) as $key=>$value){
+            $script .=  <<<EOQ
 			var aclfields = document.getElementsByName('$name');
 			for(var i in aclfields){
 				aclfields[i].$key = '$value';
 			}
 EOQ;
-		}
-		}
-		return $script;
+        }
+        }
+        return $script;
 
-	}
+    }
 
-	function getFieldByFormScript($form, $name, $def){
-		$script = '';
+    function getFieldByFormScript($form, $name, $def){
+        $script = '';
 
 
-		if(!ACLController::checkAccess($def['module'], $def['action_option'], true)){
-			foreach($this->getHTMLValues($def) as $key=>$value){
-				$script .= "\nif(typeof(document.$form.$name.$key) != 'undefined')\n document.$form.$name.".$key . '="' .$value. '";';
-			}
-		}
-		return $script;
+        if(!ACLController::checkAccess($def['module'], $def['action_option'], true)){
+            foreach($this->getHTMLValues($def) as $key=>$value){
+                $script .= "\nif(typeof(document.$form.$name.$key) != 'undefined')\n document.$form.$name.".$key . '="' .$value. '";';
+            }
+        }
+        return $script;
 
-	}
+    }
 
 
 

Spacing +33 added lines, -33 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -40,9 +40,9 @@ 
 
 
 
-class ACLJSController{
+class ACLJSController {
 
-	public function __construct($module,$form='', $is_owner=false){
+	public function __construct($module, $form = '', $is_owner = false) {
 
 		$this->module = $module;
 		$this->is_owner = $is_owner;
@@ -52,9 +52,9 @@ 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    public function ACLJSController($module,$form='', $is_owner=false){
+    public function ACLJSController($module, $form = '', $is_owner = false) {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {
@@ -64,15 +64,15 @@ 
     }
 
 
-	function getJavascript(){
+	function getJavascript() {
 		global $action;
-		if(!ACLController::moduleSupportsACL($this->module)){
+		if (!ACLController::moduleSupportsACL($this->module)) {
 			return '';
 		}
 		$script = "<SCRIPT>\n//BEGIN ACL JAVASCRIPT\n";
 
-		if($action == 'DetailView'){
-			if(!ACLController::checkAccess($this->module,'edit', $this->is_owner)){
+		if ($action == 'DetailView') {
+			if (!ACLController::checkAccess($this->module, 'edit', $this->is_owner)) {
 			$script .= <<<EOQ
 						if(typeof(document.DetailView) != 'undefined'){
 							if(typeof(document.DetailView.elements['Edit']) != 'undefined'){
@@ -84,7 +84,7 @@ 
 						}
 EOQ;
 }
-			if(!ACLController::checkAccess($this->module,'delete', $this->is_owner)){
+			if (!ACLController::checkAccess($this->module, 'delete', $this->is_owner)) {
 			$script .= <<<EOQ
 						if(typeof(document.DetailView) != 'undefined'){
 							if(typeof(document.DetailView.elements['Delete']) != 'undefined'){
@@ -94,15 +94,15 @@ 
 EOQ;
 }
 		}
-		if(file_exists('modules/'. $this->module . '/metadata/acldefs.php')){
-			include('modules/'. $this->module . '/metadata/acldefs.php');
+		if (file_exists('modules/'.$this->module.'/metadata/acldefs.php')) {
+			include('modules/'.$this->module.'/metadata/acldefs.php');
 
-			foreach($acldefs[$this->module]['forms'] as $form_name=>$form){
+			foreach ($acldefs[$this->module]['forms'] as $form_name=>$form) {
 
-				foreach($form as $field_name=>$field){
+				foreach ($form as $field_name=>$field) {
 
-					if($field['app_action'] == $action){
-						switch($form_name){
+					if ($field['app_action'] == $action) {
+						switch ($form_name) {
 							case 'by_id':
 								$script .= $this->getFieldByIdScript($field_name, $field);
 								break;
@@ -118,19 +118,19 @@ 
 				}
 			}
 		}
-		$script .=  '</SCRIPT>';
+		$script .= '</SCRIPT>';
 
 		return $script;
 
 
 	}
 
-	function getHTMLValues($def){
+	function getHTMLValues($def) {
 		$return_array = array();
-		switch($def['display_option']){
+		switch ($def['display_option']) {
 			case 'clear_link':
-				$return_array['href']= "#";
-				$return_array['className']= "nolink";
+				$return_array['href'] = "#";
+				$return_array['className'] = "nolink";
 				break;
 			default;
 				$return_array[$def['display_option']] = $def['display_option'];
@@ -141,23 +141,23 @@ 
 
 	}
 
-	function getFieldByIdScript($name, $def){
+	function getFieldByIdScript($name, $def) {
 		$script = '';
-		if(!ACLController::checkAccess($def['module'], $def['action_option'], true)){
-		foreach($this->getHTMLValues($def) as $key=>$value){
-			$script .=  "\nif(document.getElementById('$name'))document.getElementById('$name')." . $key . '="' .$value. '";'. "\n";
+		if (!ACLController::checkAccess($def['module'], $def['action_option'], true)) {
+		foreach ($this->getHTMLValues($def) as $key=>$value) {
+			$script .= "\nif(document.getElementById('$name'))document.getElementById('$name').".$key.'="'.$value.'";'."\n";
 		}
 		}
 		return $script;
 
 	}
 
-	function getFieldByNameScript($name, $def){
+	function getFieldByNameScript($name, $def) {
 		$script = '';
-		if(!ACLController::checkAccess($def['module'], $def['action_option'], true)){
+		if (!ACLController::checkAccess($def['module'], $def['action_option'], true)) {
 
-		foreach($this->getHTMLValues($def) as $key=>$value){
-			$script .=  <<<EOQ
+		foreach ($this->getHTMLValues($def) as $key=>$value) {
+			$script .= <<<EOQ
 			var aclfields = document.getElementsByName('$name');
 			for(var i in aclfields){
 				aclfields[i].$key = '$value';
@@ -169,13 +169,13 @@ 
 
 	}
 
-	function getFieldByFormScript($form, $name, $def){
+	function getFieldByFormScript($form, $name, $def) {
 		$script = '';
 
 
-		if(!ACLController::checkAccess($def['module'], $def['action_option'], true)){
-			foreach($this->getHTMLValues($def) as $key=>$value){
-				$script .= "\nif(typeof(document.$form.$name.$key) != 'undefined')\n document.$form.$name.".$key . '="' .$value. '";';
+		if (!ACLController::checkAccess($def['module'], $def['action_option'], true)) {
+			foreach ($this->getHTMLValues($def) as $key=>$value) {
+				$script .= "\nif(typeof(document.$form.$name.$key) != 'undefined')\n document.$form.$name.".$key.'="'.$value.'";';
 			}
 		}
 		return $script;

Braces +4 added lines, -3 removed lines

@@ -43,7 +43,9 @@ 
  * Date: 06/03/15
  * Comments
  */
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 
 class CasesController extends SugarController {
 
@@ -90,8 +92,7 @@ 
                 $count++;
             }
             echo '</table>';
-        }
-        else {
+        } else {
             echo $mod_strings['LBL_NO_SUGGESTIONS'];
         }
         die();

modules/AOS_Products/views/view.edit.php

Spacing +10 added lines, -10 removed lines

@@ -1,19 +1,19 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 
 require_once('include/MVC/View/views/view.edit.php');
 
 class AOS_ProductsViewEdit extends ViewEdit {
-	function __construct(){
+	function __construct() {
  		parent::__construct();
  	}
 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    function AOS_ProductsViewEdit(){
+    function AOS_ProductsViewEdit() {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {
@@ -23,22 +23,22 @@ 
     }
 
 
-    function display(){
+    function display() {
 
-        global $app_strings,$sugar_config;
+        global $app_strings, $sugar_config;
 
         isset($this->bean->product_image) ? $image = $this->bean->product_image : $image = '';
 
 
-        $temp = str_replace($sugar_config['site_url'].'/'.$sugar_config['upload_dir'],"", $image);
+        $temp = str_replace($sugar_config['site_url'].'/'.$sugar_config['upload_dir'], "", $image);
         $html = '<span id=\'new_attachment\' style=\'display:';
-        if(!empty($this->bean->product_image)){
+        if (!empty($this->bean->product_image)) {
             $html .= 'none';
         }
         $html .= '\'><input name="uploadimage" tabindex="3" type="file" size="60"/>
         	</span>
 		<span id=\'old_attachment\' style=\'display:';
-        if (empty($image)){
+        if (empty($image)) {
             $html .= 'none';
         }
         $html .= '\'><input type=\'hidden\' id=\'deleteAttachment\' name=\'deleteAttachment\' value=\'0\'>
@@ -46,7 +46,7 @@ 
 		<input type=\'button\' class=\'button\' value=\''.$app_strings['LBL_REMOVE'].'\' onclick=\'deleteProductImage();\' >
 		</span>';
 
-        $this->ss->assign('PRODUCT_IMAGE',$html);
+        $this->ss->assign('PRODUCT_IMAGE', $html);
         parent::display();
     }
 }

Braces +4 added lines, -3 removed lines

@@ -43,7 +43,9 @@ 
  * Date: 06/03/15
  * Comments
  */
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 
 class CasesController extends SugarController {
 
@@ -90,8 +92,7 @@ 
                 $count++;
             }
             echo '</table>';
-        }
-        else {
+        } else {
             echo $mod_strings['LBL_NO_SUGGESTIONS'];
         }
         die();