YetiForceCompany / YetiForceCRM

modules/Calendar/Appointment.php

Doc Comments +4 added lines, -1 removed lines

@@ -56,7 +56,7 @@ 
 	 * @param $userid -- The user Id:: Type integer
 	 * @param $from_datetime -- The start date Obj :: Type Array
 	 * @param $to_datetime -- The end date Obj :: Type Array
-	 * @param $view -- The calendar view :: Type String
+	 * @param string $view -- The calendar view :: Type String
 	 * @returns $list :: Type Array
 	 */
 	public function readAppointment($userid, &$from_datetime, &$to_datetime, $view)
@@ -286,6 +286,9 @@ 
 	return ($a->start_time->ts < $b->start_time->ts) ? -1 : 1;
 }
 
+/**
+ * @param string $fldname
+ */
 function getRoleBasesdPickList($fldname, $exist_val)
 {
 	$adb = PearDatabase::getInstance();

Spacing +1 added lines, -1 removed lines

@@ -169,7 +169,7 @@
 		//Get Recurring events
 		$q = "SELECT vtiger_activity.*, vtiger_crmentity.*, case when (vtiger_users.user_name not like '') then $userNameSql else vtiger_groups.groupname end as user_name , vtiger_recurringevents.recurringid, vtiger_recurringevents.recurringdate as date_start ,vtiger_recurringevents.recurringtype,vtiger_groups.groupname from vtiger_activity inner join vtiger_crmentity on vtiger_activity.activityid = vtiger_crmentity.crmid inner join vtiger_recurringevents on vtiger_activity.activityid=vtiger_recurringevents.activityid left join vtiger_groups on vtiger_groups.groupid = vtiger_crmentity.smownerid LEFT JOIN vtiger_users ON vtiger_users.id = vtiger_crmentity.smownerid";
 		$q .= getNonAdminAccessControlQuery('Calendar', $current_user);
-		$q.=" where vtiger_crmentity.deleted = 0 and vtiger_activity.activitytype not in ('Emails','Task') && (cast(concat(recurringdate, ' ', time_start) as datetime) between ? and ?) ";
+		$q .= " where vtiger_crmentity.deleted = 0 and vtiger_activity.activitytype not in ('Emails','Task') && (cast(concat(recurringdate, ' ', time_start) as datetime) between ? and ?) ";
 
 		// User Select Customization
 		$q .= $query_filter_prefix;

Braces +16 added lines, -11 removed lines

@@ -221,13 +221,15 @@ 
 				$que = "select * from vtiger_sharedcalendar where sharedid=? and userid=?";
 				$row = $adb->pquery($que, array($current_user->id, $act_array["smownerid"]));
 				$no = $adb->getRowCount($row);
-				if ($no > 0)
-					$this->shared = true;
+				if ($no > 0) {
+									$this->shared = true;
+				}
 			}
 		}
 		$this->image_name = $act_array["activitytype"] . ".gif";
-		if (!empty($act_array["recurringid"]) && !empty($act_array["recurringtype"]))
-			$this->recurring = "Recurring.gif";
+		if (!empty($act_array["recurringid"]) && !empty($act_array["recurringtype"])) {
+					$this->recurring = "Recurring.gif";
+		}
 
 		$this->record = $act_array["activityid"];
 		$date = new DateTimeField($act_array["date_start"] . ' ' . $act_array['time_start']);
@@ -295,8 +297,9 @@ 
 		$roleid = $current_user->roleid;
 		$roleids = Array();
 		$subrole = getRoleSubordinates($roleid);
-		if (count($subrole) > 0)
-			$roleids = $subrole;
+		if (count($subrole) > 0) {
+					$roleids = $subrole;
+		}
 		array_push($roleids, $roleid);
 
 		//here we are checking wheather the table contains the sortorder column .If  sortorder is present in the main picklist table, then the role2picklist will be applicable for this table...
@@ -310,12 +313,14 @@ 
 			$res_val = $adb->pquery($pick_query, array($roleids));
 			$num_val = $adb->num_rows($res_val);
 		}
-		if ($num_val > 0)
+		if ($num_val > 0) {
+					$pick_val = $exist_val;
+		} else {
+					$pick_val = \includes\Language::translate('LBL_NOT_ACCESSIBLE');
+		}
+	} else {
 			$pick_val = $exist_val;
-		else
-			$pick_val = \includes\Language::translate('LBL_NOT_ACCESSIBLE');
-	} else
-		$pick_val = $exist_val;
+	}
 
 	return $pick_val;
 }

modules/Calendar/Date.php

Doc Comments +1 added lines, -5 removed lines

@@ -384,7 +384,7 @@ 
 
 	/**
 	 *
-	 * @return Date
+	 * @return string
 	 */
 	public function get_DB_formatted_date()
 	{
@@ -529,10 +529,6 @@ 
 	 * This should be used whereever possible
 	 *
 	 * @param integer       $index - number between 0 to 42
-	 * @param string        $day   - date
-	 * @param string        $month - month
-	 * @param string        $year  - year
-	 * return vt_DateTime obj  $datetimevalue
 	 */
 	public function getThisMonthsDayByIndex($index)
 	{

Braces +37 added lines, -26 removed lines

@@ -87,12 +87,15 @@ 
 	 */
 	public function getTodayDatetimebyIndex($index, $day = '', $month = '', $year = '')
 	{
-		if ($day === '')
-			$day = $this->day;
-		if ($month === '')
-			$month = $this->month;
-		if ($year === '')
-			$year = $this->year;
+		if ($day === '') {
+					$day = $this->day;
+		}
+		if ($month === '') {
+					$month = $this->month;
+		}
+		if ($year === '') {
+					$year = $this->year;
+		}
 		$day_array = array();
 
 		if ($index < 0 || $index > 23) {
@@ -140,12 +143,15 @@ 
 	 */
 	public function getThismonthDaysbyIndex($index, $day = '', $month = '', $year = '')
 	{
-		if ($day == '')
-			$day = $index + 1;
-		if ($month == '')
-			$month = $this->month;
-		if ($year == '')
-			$year = $this->year;
+		if ($day == '') {
+					$day = $index + 1;
+		}
+		if ($month == '') {
+					$month = $this->month;
+		}
+		if ($year == '') {
+					$year = $this->year;
+		}
 		$month_array = array();
 		$month_array['day'] = $day;
 		$month_array['month'] = $month;
@@ -356,8 +362,9 @@ 
 		} else {
 			die("year was not set");
 		}
-		if (empty($hour) && $hour !== 0)
-			$hour = 0;
+		if (empty($hour) && $hour !== 0) {
+					$hour = 0;
+		}
 		$this->ts = mktime($hour, $minute, $second, $month, $day, $year);
 		$this->setDateTime($this->ts);
 	}
@@ -399,10 +406,12 @@ 
 	{
 		$hour = $this->z_hour;
 		$min = $this->minute;
-		if (empty($hour))
-			$hour = '00';
-		if (empty($min))
-			$min = '00';
+		if (empty($hour)) {
+					$hour = '00';
+		}
+		if (empty($min)) {
+					$min = '00';
+		}
 		return $hour . ':' . $min;
 	}
 
@@ -413,10 +422,11 @@ 
 	 */
 	public function get_changed_day($mode)
 	{
-		if ($mode == 'increment')
-			$day = $this->day + 1;
-		else
-			$day = $this->day - 1;
+		if ($mode == 'increment') {
+					$day = $this->day + 1;
+		} else {
+					$day = $this->day - 1;
+		}
 		$date_data = array('day' => $day,
 			'month' => $this->month,
 			'year' => $this->year
@@ -432,10 +442,11 @@ 
 	public function get_first_day_of_changed_week($mode)
 	{
 		$first_day = $this->getThisweekDaysbyIndex(1);
-		if ($mode == 'increment')
-			$day = $first_day->day + 7;
-		else
-			$day = $first_day->day - 7;
+		if ($mode == 'increment') {
+					$day = $first_day->day + 7;
+		} else {
+					$day = $first_day->day - 7;
+		}
 		$date_data = array('day' => $day,
 			'month' => $first_day->month,
 			'year' => $first_day->year

modules/com_vtiger_workflow/VTJsonCondition.inc

Doc Comments +4 added lines

@@ -11,6 +11,10 @@
 class VTJsonCondition
 {
 
+	/**
+	 * @param VTEntityCache $entityCache
+	 * @param string $id
+	 */
 	function evaluate($condition, $entityCache, $id)
 	{
 		$expr = \includes\utils\Json::decode($condition);

Braces +9 added lines, -6 removed lines

@@ -24,8 +24,9 @@ 
 			$i = 0;
 			foreach ($expr as $cond) {
 				$conditionGroup = $cond['groupid'];
-				if (empty($conditionGroup))
-					$conditionGroup = 0;
+				if (empty($conditionGroup)) {
+									$conditionGroup = 0;
+				}
 				preg_match('/(\w+) : \((\w+)\) (\w+)/', $cond['fieldname'], $matches);
 				if (count($matches) == 0) {
 					$expressionResults[$conditionGroup][$i]['result'] = $this->checkCondition($entityData, $cond);
@@ -117,8 +118,9 @@ 
 		$data = $entityData->getData();
 
 		$condition = $cond['operation'];
-		if (empty($condition))
-			return false;
+		if (empty($condition)) {
+					return false;
+		}
 		if ($cond['fieldname'] == 'date_start' || $cond['fieldname'] == 'due_date') {
 			$fieldName = $cond['fieldname'];
 			$dateTimePair = array('date_start' => 'time_start', 'due_date' => 'time_end');
@@ -238,8 +240,9 @@ 
 				}
 				return strpos($fieldValue, $value) !== FALSE;
 			case 'does not contain':
-				if (empty($value))
-					unset($value);
+				if (empty($value)) {
+									unset($value);
+				}
 				if (is_array($value)) {
 					return !in_array($fieldValue, $value);
 				}

modules/com_vtiger_workflow/VTTaskManager.inc

Doc Comments +6 added lines

@@ -152,6 +152,9 @@ 
 		}
 	}
 
+	/**
+	 * @param VTTaskType $taskTypeInstance
+	 */
 	public function retrieveTemplatePath($moduleName, $taskTypeInstance)
 	{
 		$taskTemplatePath = $taskTypeInstance->get('templatepath');
@@ -226,6 +229,9 @@ 
 
 	var $data;
 
+	/**
+	 * @param string $key
+	 */
 	public function get($key)
 	{
 		return $this->data[$key];

modules/com_vtiger_workflow/VTWorkflowApplication.inc

Doc Comments +6 added lines

@@ -11,6 +11,9 @@ 
 class VTWorkflowApplication
 {
 
+	/**
+	 * @param string $action
+	 */
 	function __construct($action)
 	{
 		$this->request;
@@ -36,6 +39,9 @@ 
 		return $_SERVER["REQUEST_URI"];
 	}
 
+	/**
+	 * @return string
+	 */
 	function returnUrl()
 	{
 		return $this->returnUrl;

modules/com_vtiger_workflow/VTWorkflowManager.inc

Doc Comments +3 added lines, -3 removed lines

@@ -480,7 +480,7 @@ 
 	/**
 	 * Function gets the next trigger for the workflows
 	 * @global <String> $default_timezone
-	 * @return type
+	 * @return string|null
 	 */
 	function getNextTriggerTime()
 	{
@@ -525,8 +525,8 @@ 
 
 	/**
 	 * get next trigger time for daily
-	 * @param type $schTime
-	 * @return time
+	 * @param type $scheduledTime
+	 * @return string
 	 */
 	function getNextTriggerTimeForDaily($scheduledTime)
 	{

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
 								module_name=?, summary=?, test=?, execution_condition=?, defaultworkflow=?, filtersavedinnew=?,
 								schtypeid=?, schtime=?, schdayofmonth=?, schdayofweek=?, schannualdates=?, nexttrigger_time=? where workflow_id=?", array($wf->moduleName, $wf->description, $wf->test, $wf->executionCondition, $wf->defaultworkflow, $wf->filtersavedinnew,
 				$wf->schtypeid, $wf->schtime, $wf->schdayofmonth, $wf->schdayofweek, $wf->schannualdates, $wf->nexttrigger_time, $wf->id));
-		}else {
+		} else {
 			$workflowId = $adb->getUniqueID("com_vtiger_workflows");
 			$workflow->id = $workflowId;
 			$wf = $workflow;

Braces +10 added lines, -7 removed lines

@@ -35,18 +35,20 @@ 
 		$adb = $this->adb;
 		if (isset($workflow->id)) {
 			$wf = $workflow;
-			if ($wf->filtersavedinnew == null)
-				$wf->filtersavedinnew = 5;
+			if ($wf->filtersavedinnew == null) {
+							$wf->filtersavedinnew = 5;
+			}
 			$adb->pquery("update com_vtiger_workflows set
 								module_name=?, summary=?, test=?, execution_condition=?, defaultworkflow=?, filtersavedinnew=?,
 								schtypeid=?, schtime=?, schdayofmonth=?, schdayofweek=?, schannualdates=?, nexttrigger_time=? where workflow_id=?", array($wf->moduleName, $wf->description, $wf->test, $wf->executionCondition, $wf->defaultworkflow, $wf->filtersavedinnew,
 				$wf->schtypeid, $wf->schtime, $wf->schdayofmonth, $wf->schdayofweek, $wf->schannualdates, $wf->nexttrigger_time, $wf->id));
-		}else {
+		} else {
 			$workflowId = $adb->getUniqueID("com_vtiger_workflows");
 			$workflow->id = $workflowId;
 			$wf = $workflow;
-			if ($wf->filtersavedinnew == null)
-				$wf->filtersavedinnew = 5;
+			if ($wf->filtersavedinnew == null) {
+							$wf->filtersavedinnew = 5;
+			}
 
 			$result = $adb->getColumnNames("com_vtiger_workflows");
 			if (in_array("type", $result)) {
@@ -155,8 +157,9 @@ 
 			$workflow = $this->getWorkflowInstance($row->type);
 			$workflow->setup($row->data);
 
-			if (!is_a($workflow, 'Workflow'))
-				continue;
+			if (!is_a($workflow, 'Workflow')) {
+							continue;
+			}
 
 			$workflows[$i++] = $workflow;
 		}

modules/com_vtiger_workflow/VTWorkflowTemplateManager.inc

Doc Comments +3 added lines, -3 removed lines

@@ -41,7 +41,7 @@ 
 	 * Retrieve a template given it's id
 	 *
 	 * @param $templateId The id of the template
-	 * @return The template object
+	 * @return VTWorkflowTemplate template object
 	 */
 	public function retrieveTemplate($templateId)
 	{
@@ -62,7 +62,7 @@ 
 	 *
 	 * The new workflow will also be added to the database.
 	 *
-	 * @param $template The template to use
+	 * @param VTWorkflowTemplate $template The template to use
 	 * @return A workflow object.
 	 */
 	public function createWorkflow($template)
@@ -145,7 +145,7 @@ 
 	 * This can be used for exporting templates from one 
 	 * machine to another
 	 *
-	 * @return The string dump of the templates.
+	 * @return string string dump of the templates.
 	 */
 	public function dumpAllTemplates()
 	{

Spacing +1 added lines, -2 removed lines

@@ -113,8 +113,7 @@
 		$adb = $this->adb;
 		if (is_numeric($template->id)) {//How do I check whether a member exists in php?
 			$templateId = $template->id;
-			$adb->pquery("update com_vtiger_workflowtemplates set title=?," +
-				" module_name=?, template=? where template_id=?", array($template->title, $template->moduleName,
+			$adb->pquery("update com_vtiger_workflowtemplates set title=?," +" module_name=?, template=? where template_id=?", array($template->title, $template->moduleName,
 				$template->template, $templateId));
 			return $templateId;
 		} else {

modules/com_vtiger_workflow/VTWorkflowUtils.php

Doc Comments +4 added lines

@@ -108,6 +108,7 @@ 
 
 	/**
 	 * Insert redirection script
+	 * @param string $to
 	 */
 	public function redirectTo($to, $message)
 	{
@@ -132,6 +133,9 @@ 
 	 * @params :: $modulename - name of the module
 	 */
 
+	/**
+	 * @param boolean $modulename
+	 */
 	public static function checkModuleWorkflow($modulename)
 	{
 		$adb = PearDatabase::getInstance();

modules/com_vtiger_workflow/WorkFlowScheduler.php

Doc Comments +4 added lines, -1 removed lines

@@ -126,6 +126,9 @@ 
 		$scheduledWorkflows = null;
 	}
 
+	/**
+	 * @param QueryGenerator $queryGenerator
+	 */
 	public function addWorkflowConditionsToQueryGenerator($queryGenerator, $conditions)
 	{
 		$conditionMapping = array(
@@ -232,7 +235,7 @@ 
 	/**
 	 * Function parse the value based on the condition
 	 * @param <Array> $condition
-	 * @return <String>
+	 * @return string
 	 */
 	public function _parseValueForDate($condition)
 	{

Braces +3 added lines, -2 removed lines

@@ -175,8 +175,9 @@
 				$operation = $condition['operation'];
 
 				//Cannot handle this condition for scheduled workflows
-				if ($operation == 'has changed')
-					continue;
+				if ($operation == 'has changed') {
+									continue;
+				}
 
 				$value = $condition['value'];
 				if (in_array($operation, $this->_specialDateTimeOperator())) {