Completed
Push — developer ( dcd43f...1946c6 )
by Błażej
48:56 queued 21:47
created
modules/PaymentsOut/helpers/mt940.php 2 patches
Doc Comments   +15 added lines patch added patch discarded remove patch
@@ -50,6 +50,9 @@  discard block
 block discarded – undo
50 50
 		return $xml;
51 51
 	}
52 52
 
53
+	/**
54
+	 * @param integer $level
55
+	 */
53 56
 	protected function createXML($key, $value, $level)
54 57
 	{
55 58
 		$indent = '';
@@ -69,6 +72,9 @@  discard block
 block discarded – undo
69 72
 		return $xml;
70 73
 	}
71 74
 
75
+	/**
76
+	 * @param string $line
77
+	 */
72 78
 	protected function parseLine($line)
73 79
 	{
74 80
 		$tag = substr($line, 1, strpos($line, ':', 1) - 1);
@@ -114,6 +120,9 @@  discard block
 block discarded – undo
114 120
 		$this->_lastTag = $tag;
115 121
 	}
116 122
 
123
+	/**
124
+	 * @param string $value
125
+	 */
117 126
 	protected function parseOperation($value)
118 127
 	{
119 128
 		$this->operations[] = array(
@@ -124,6 +133,9 @@  discard block
 block discarded – undo
124 133
 		);
125 134
 	}
126 135
 
136
+	/**
137
+	 * @param string $value
138
+	 */
127 139
 	protected function parseBalance($value)
128 140
 	{
129 141
 		return array(
@@ -134,6 +146,9 @@  discard block
 block discarded – undo
134 146
 		);
135 147
 	}
136 148
 
149
+	/**
150
+	 * @param string $value
151
+	 */
137 152
 	protected function parseTransaction($value)
138 153
 	{
139 154
 		$transaction = array(
Please login to merge, or discard this patch.
Braces   +19 added lines, -14 removed lines patch added patch discarded remove patch
@@ -34,8 +34,9 @@  discard block
 block discarded – undo
34 34
 	public function parse()
35 35
 	{
36 36
 		$tab = $this->prepareFile();
37
-		foreach ($tab as $line)
38
-			$this->parseLine($line);
37
+		foreach ($tab as $line) {
38
+					$this->parseLine($line);
39
+		}
39 40
 	}
40 41
 
41 42
 	public function getXML()
@@ -53,13 +54,15 @@  discard block
 block discarded – undo
53 54
 	protected function createXML($key, $value, $level)
54 55
 	{
55 56
 		$indent = '';
56
-		for ($i = 0; $i <= $level; $i++)
57
-			$indent .= "\t";
57
+		for ($i = 0; $i <= $level; $i++) {
58
+					$indent .= "\t";
59
+		}
58 60
 		if (is_array($value)) {
59 61
 			$xml = "$indent<$key>\n";
60 62
 			foreach ($value as $subKey => $subVal) {
61
-				if (is_numeric($subKey))
62
-					$subKey = substr($key, 0, -1);
63
+				if (is_numeric($subKey)) {
64
+									$subKey = substr($key, 0, -1);
65
+				}
63 66
 				$xml .= $this->createXML($subKey, $subVal, $level + 1);
64 67
 			}
65 68
 			$xml .= "$indent</$key>\n";
@@ -85,10 +88,11 @@  discard block
 block discarded – undo
85 88
 				break;
86 89
 			case 'NS':
87 90
 				$code = substr($value, 0, 2);
88
-				if ($code == '22')
89
-					$this->ownerName = substr($value, 2);
90
-				else if ($code == '23')
91
-					$this->accountName = substr($value, 2);
91
+				if ($code == '22') {
92
+									$this->ownerName = substr($value, 2);
93
+				} else if ($code == '23') {
94
+									$this->accountName = substr($value, 2);
95
+				}
92 96
 				break;
93 97
 			case '60F':
94 98
 				$this->openBalance = $this->parseBalance($value);
@@ -103,10 +107,11 @@  discard block
 block discarded – undo
103 107
 				self::parseOperation($value);
104 108
 				break;
105 109
 			case '86':
106
-				if ($this->_lastTag == '61')
107
-					$this->parseTransaction($value);
108
-				else
109
-					$this->info .= $value;
110
+				if ($this->_lastTag == '61') {
111
+									$this->parseTransaction($value);
112
+				} else {
113
+									$this->info .= $value;
114
+				}
110 115
 				break;
111 116
 			default:
112 117
 				break;
Please login to merge, or discard this patch.
modules/PaymentsOut/helpers/subclass/mt940_Milenium.php 2 patches
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -20,6 +20,9 @@  discard block
 block discarded – undo
20 20
 			$this->parseLine($line);
21 21
 	}
22 22
 
23
+	/**
24
+	 * @param string $line
25
+	 */
23 26
 	protected function parseLine($line)
24 27
 	{
25 28
 		$tag = substr($line, 1, strpos($line, ':', 1) - 1);
@@ -65,6 +68,9 @@  discard block
 block discarded – undo
65 68
 		$this->_lastTag = $tag;
66 69
 	}
67 70
 
71
+	/**
72
+	 * @param string $value
73
+	 */
68 74
 	protected function parseOperation($value)
69 75
 	{
70 76
 		$this->operations[] = array(
Please login to merge, or discard this patch.
Braces   +13 added lines, -10 removed lines patch added patch discarded remove patch
@@ -16,8 +16,9 @@  discard block
 block discarded – undo
16 16
 	public function parse()
17 17
 	{
18 18
 		$tab = $this->prepareFile();
19
-		foreach ($tab as $line)
20
-			$this->parseLine($line);
19
+		foreach ($tab as $line) {
20
+					$this->parseLine($line);
21
+		}
21 22
 	}
22 23
 
23 24
 	protected function parseLine($line)
@@ -36,10 +37,11 @@  discard block
 block discarded – undo
36 37
 				break;
37 38
 			case 'NS':
38 39
 				$code = substr($value, 0, 2);
39
-				if ($code == '22')
40
-					$this->ownerName = substr($value, 2);
41
-				else if ($code == '23')
42
-					$this->accountName = substr($value, 2);
40
+				if ($code == '22') {
41
+									$this->ownerName = substr($value, 2);
42
+				} else if ($code == '23') {
43
+									$this->accountName = substr($value, 2);
44
+				}
43 45
 				break;
44 46
 			case '60F':
45 47
 				$this->openBalance = $this->parseBalance($value);
@@ -54,10 +56,11 @@  discard block
 block discarded – undo
54 56
 				self::parseOperation($value);
55 57
 				break;
56 58
 			case '86':
57
-				if ($this->_lastTag == '61')
58
-					$this->parseTransaction($value);
59
-				else
60
-					$this->info .= $value;
59
+				if ($this->_lastTag == '61') {
60
+									$this->parseTransaction($value);
61
+				} else {
62
+									$this->info .= $value;
63
+				}
61 64
 				break;
62 65
 			default:
63 66
 				break;
Please login to merge, or discard this patch.
modules/Products/models/ListView.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -332,7 +332,6 @@
 block discarded – undo
332 332
 
333 333
 	/**
334 334
 	 * Function to get the list view entries
335
-	 * @param Vtiger_Paging_Model $pagingModel
336 335
 	 * @return <Array> - Associative array of record id mapped to Vtiger_Record_Model instance.
337 336
 	 */
338 337
 	public function getListViewCount()
Please login to merge, or discard this patch.
modules/RecycleBin/models/Module.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -49,7 +49,6 @@  discard block
 block discarded – undo
49 49
 
50 50
 	/**
51 51
 	 * Function to get the list of Mass actions for the module
52
-	 * @param <Array> $linkParams
53 52
 	 * @return <Array> - Associative array of Link type to List of  Vtiger_Link_Model instances for Mass Actions
54 53
 	 */
55 54
 	public function getListViewMassActions()
@@ -143,7 +142,7 @@  discard block
 block discarded – undo
143 142
 
144 143
 	/**
145 144
 	 * Function to deleted the records perminently in CRM
146
-	 * @param type $reocrdIds
145
+	 * @param type $recordIds
147 146
 	 */
148 147
 	public function deleteRecords($recordIds)
149 148
 	{
Please login to merge, or discard this patch.
modules/Reports/models/ListView.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,6 +16,7 @@  discard block
 block discarded – undo
16 16
 
17 17
 	/**
18 18
 	 * Function to get the list of listview links for the module
19
+	 * @param boolean $linkParams
19 20
 	 * @return <Array> - Associate array of Link Type to List of Vtiger_Link_Model instances
20 21
 	 */
21 22
 	public function getListViewLinks($linkParams)
@@ -70,7 +71,7 @@  discard block
 block discarded – undo
70 71
 
71 72
 	/**
72 73
 	 * Function to get the list of Mass actions for the module
73
-	 * @param <Array> $linkParams
74
+	 * @param boolean $linkParams
74 75
 	 * @return <Array> - Associative array of Link type to List of  Vtiger_Link_Model instances for Mass Actions
75 76
 	 */
76 77
 	public function getListViewMassActions($linkParams)
Please login to merge, or discard this patch.
modules/Settings/GlobalPermission/models/Record.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -42,6 +42,9 @@
 block discarded – undo
42 42
 		return $globalPermissions;
43 43
 	}
44 44
 
45
+	/**
46
+	 * @param integer $checked
47
+	 */
45 48
 	public static function save($profileID, $globalactionid, $checked)
46 49
 	{
47 50
 		if ($globalactionid == 1) {
Please login to merge, or discard this patch.
modules/Settings/LayoutEditor/models/Block.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@
 block discarded – undo
99 99
 
100 100
 	/**
101 101
 	 * Function to retrieve block instances for a module
102
-	 * @param <type> $moduleModel - module instance
102
+	 * @param Settings_LayoutEditor_Module_Model $moduleModel - module instance
103 103
 	 * @return <array> - list of Vtiger_Block_Model
104 104
 	 */
105 105
 	public static function getAllForModule($moduleModel)
Please login to merge, or discard this patch.
modules/Settings/MappedFields/models/Module.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -178,7 +178,7 @@
 block discarded – undo
178 178
 
179 179
 	/**
180 180
 	 * Function to set mapping details
181
-	 * @return instance
181
+	 * @return Settings_MappedFields_Module_Model
182 182
 	 */
183 183
 	public function setMapping($mapp = [])
184 184
 	{
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
 	];
30 30
 	public static $step1Fields = ['status', 'tabid', 'reltabid'];
31 31
 	public static $step2Fields = ['source', 'target', 'default', 'type'];
32
-	public static $step3Fields = ['conditions',];
32
+	public static $step3Fields = ['conditions', ];
33 33
 	public static $step4Fields = ['permissions'];
34 34
 	public $name = 'MappedFields';
35 35
 	public $parent = 'Settings';
Please login to merge, or discard this patch.
modules/Settings/PBXManager/models/Module.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
 
14 14
 	/**
15 15
 	 * Function to get the module model
16
-	 * @return string
16
+	 * @return Settings_PBXManager_Module_Model
17 17
 	 */
18 18
 	public static function getCleanInstance()
19 19
 	{
Please login to merge, or discard this patch.