Inspection of "Add "required" for prepend files" - XaBerr/JATE - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a12ace...998a95 )

by Federico

created 2016-04-27 13:27 UTC

Status

Braces +6 added lines, -3 removed lines patch added patch discarded remove patch

@@ -22,8 +22,9 @@  discard block
 block discarded – undo
 					$percent;
 					foreach (getGitLog() as $i) {
 						$cont++;
-						if($cont % $nPerCol == 1)
-							echo '<div class="row">';
+						if($cont % $nPerCol == 1) {
+													echo '<div class="row">';
+						}
 						if(isset($i["tag"])) {
 							$percent = explode(".",$i["tag"]);
 							$percent = 100 * intval($percent[0]) + 10 * intval($percent[1]) + intval($percent[2]);
@@ -32,7 +33,8 @@  discard block
 block discarded – undo
 						<div class="col-lg-<?=$dim?>">
 							<div class="well well-sm miniblock">
 								<div class="autor"><b>Autor:</b> <?=$i["author"]?><br></div>
-								<div class="tag"><b>Tag:</b> <?php if(isset($i["tag"])) echo $i["tag"]?><br></div>
+								<div class="tag"><b>Tag:</b> <?php if(isset($i["tag"])) {
+	echo $i["tag"]?><br></div>
 								<div class="date"><b>Date:</b> <?=$i["date"]?><br></div>
 								<div class="message"><b>Message:</b> <?=$i["message"]?><br></div>
 								<div class="progress">
@@ -46,6 +48,7 @@  discard block
 block discarded – undo
 					<?php
 					if($cont % $nPerCol == 0)
 						echo '</div>';
+}
 					} ?>
 				</div>
 			</div>

Please login to merge, or discard this patch.

dist/jate.php 1 patch

Braces +6 added lines, -4 removed lines patch added patch discarded remove patch

@@ -1,14 +1,16 @@
 block discarded – undo
 <?php
-	if(isset($GLOBALS["JATEPath"]))
-		$GLOBALS["JATEPath"] = [];
+	if(isset($GLOBALS["JATEPath"])) {
+			$GLOBALS["JATEPath"] = [];
+	}
 	$commonLocations = array(
 		"bower_components/JATE/dist/",
 		"vendor/xaberr/jate/dist/",
 		"../../dist/"
 	);
-	foreach ($commonLocations as $i)
-		if(file_exists($i."jate/coreEngine.php")) {
+	foreach ($commonLocations as $i) {
+			if(file_exists($i."jate/coreEngine.php")) {
 			array_push($GLOBALS["JATEPath"], $i);
+	}
 			require_once($i."jate/coreEngine.php");
 			break;
 		}

Please login to merge, or discard this patch.

examples/01essential/jate.php 1 patch

Braces +6 added lines, -4 removed lines patch added patch discarded remove patch

@@ -1,14 +1,16 @@
 block discarded – undo
 <?php
-	if(!isset($GLOBALS["JATEPath"]))
-		$GLOBALS["JATEPath"] = [];
+	if(!isset($GLOBALS["JATEPath"])) {
+			$GLOBALS["JATEPath"] = [];
+	}
 	$commonLocations = array(
 		"bower_components/JATE/dist/",
 		"vendor/xaberr/jate/dist/",
 		"../../dist/"
 	);
-	foreach ($commonLocations as $i)
-		if(file_exists($i."jate/coreEngine.php")) {
+	foreach ($commonLocations as $i) {
+			if(file_exists($i."jate/coreEngine.php")) {
 			array_push($GLOBALS["JATEPath"], $i);
+	}
 			require_once($i."jate/coreEngine.php");
 			break;
 		}

Please login to merge, or discard this patch.

examples/01essential/status.php 1 patch

Braces +6 added lines, -3 removed lines patch added patch discarded remove patch

@@ -22,8 +22,9 @@  discard block
 block discarded – undo
 					$percent;
 					foreach (getGitLog() as $i) {
 						$cont++;
-						if($cont % $nPerCol == 1)
-							echo '<div class="row">';
+						if($cont % $nPerCol == 1) {
+													echo '<div class="row">';
+						}
 						if(isset($i["tag"])) {
 							$percent = explode(".",$i["tag"]);
 							$percent = 100 * intval($percent[0]) + 10 * intval($percent[1]) + intval($percent[2]);
@@ -32,7 +33,8 @@  discard block
 block discarded – undo
 						<div class="col-lg-<?=$dim?>">
 							<div class="well well-sm miniblock">
 								<div class="autor"><b>Autor:</b> <?=$i["author"]?><br></div>
-								<div class="tag"><b>Tag:</b> <?php if(isset($i["tag"])) echo $i["tag"]?><br></div>
+								<div class="tag"><b>Tag:</b> <?php if(isset($i["tag"])) {
+	echo $i["tag"]?><br></div>
 								<div class="date"><b>Date:</b> <?=$i["date"]?><br></div>
 								<div class="message"><b>Message:</b> <?=$i["message"]?><br></div>
 								<div class="progress">
@@ -46,6 +48,7 @@  discard block
 block discarded – undo
 					<?php
 					if($cont % $nPerCol == 0)
 						echo '</div>';
+}
 					} ?>
 				</div>
 			</div>

Please login to merge, or discard this patch.

examples/01essential/index.php 1 patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,6 +1,8 @@
 block discarded – undo
 <?php
 	require_once("main.php");
-	if(!isset($_GET["page"])) $_GET["page"] = "home";
+	if(!isset($_GET["page"])) {
+		$_GET["page"] = "home";
+	}
 	$webApp->fetchPage($_GET["page"]);
 	$webApp->draw();
 ?>

Please login to merge, or discard this patch.

examples/05database/status.php 1 patch

Braces +6 added lines, -3 removed lines patch added patch discarded remove patch

@@ -22,8 +22,9 @@  discard block
 block discarded – undo
 					$percent;
 					foreach (getGitLog() as $i) {
 						$cont++;
-						if($cont % $nPerCol == 1)
-							echo '<div class="row">';
+						if($cont % $nPerCol == 1) {
+													echo '<div class="row">';
+						}
 						if(isset($i["tag"])) {
 							$percent = explode(".",$i["tag"]);
 							$percent = 100 * intval($percent[0]) + 10 * intval($percent[1]) + intval($percent[2]);
@@ -32,7 +33,8 @@  discard block
 block discarded – undo
 						<div class="col-lg-<?=$dim?>">
 							<div class="well well-sm miniblock">
 								<div class="autor"><b>Autor:</b> <?=$i["author"]?><br></div>
-								<div class="tag"><b>Tag:</b> <?php if(isset($i["tag"])) echo $i["tag"]?><br></div>
+								<div class="tag"><b>Tag:</b> <?php if(isset($i["tag"])) {
+	echo $i["tag"]?><br></div>
 								<div class="date"><b>Date:</b> <?=$i["date"]?><br></div>
 								<div class="message"><b>Message:</b> <?=$i["message"]?><br></div>
 								<div class="progress">
@@ -46,6 +48,7 @@  discard block
 block discarded – undo
 					<?php
 					if($cont % $nPerCol == 0)
 						echo '</div>';
+}
 					} ?>
 				</div>
 			</div>

Please login to merge, or discard this patch.

examples/05database/pages/Template.php 1 patch

Braces +3 added lines, -2 removed lines patch added patch discarded remove patch

@@ -19,13 +19,14 @@
 block discarded – undo
 		public function makeConnection() {
 			global $jConfig;
 			$connection = null;
-			if($jConfig->connection["enable"])
-				$connection = new Connection(
+			if($jConfig->connection["enable"]) {
+							$connection = new Connection(
 						$jConfig->connection["server"]
 					, $jConfig->connection["database"]
 					, $jConfig->connection["user"]
 					, $jConfig->connection["password"]
 				);
+			}
 			$this->addConnection("base",$connection);
 		}
 	}

Please login to merge, or discard this patch.

dist/jate/modules/Module/Module.php 1 patch

Braces +27 added lines, -18 removed lines patch added patch discarded remove patch

@@ -23,33 +23,39 @@  discard block
 block discarded – undo
 		}
 		public function getJsVariables() {
 			$temp = [];
-			foreach ($this->required as $i)
-				if (is_array($i))
+			foreach ($this->required as $i) {
+							if (is_array($i))
 					array_push($temp,$i);
-			foreach ($this->modules as $i)
-				$temp = array_merge( $temp, $i->getJsVariables() );
-			foreach ($this->files as $i)
-				if (is_array($i))
+			}
+			foreach ($this->modules as $i) {
+							$temp = array_merge( $temp, $i->getJsVariables() );
+			}
+			foreach ($this->files as $i) {
+							if (is_array($i))
 					array_push($temp,$i);
+			}
 			return $temp;
 		}
 		public function addModules( $_mods ) {
-			foreach ($_mods as $value)
-				$this->addModule($value);
+			foreach ($_mods as $value) {
+							$this->addModule($value);
+			}
 		}
 		public function addModule( $_mod ) {
 			$this->modules[$_mod->name] = $_mod;
 		}
 		public function addFiles( $_files ) {
-			foreach ($_files as $value)
-				$this->addFile($value);
+			foreach ($_files as $value) {
+							$this->addFile($value);
+			}
 		}
 		public function addFile( $_file ) {
 			array_push($this->files, $_file);
 		}
 		public function addFilesRequired( $_files ) {
-			foreach ($_files as $value)
-				$this->addFileRequired($value);
+			foreach ($_files as $value) {
+							$this->addFileRequired($value);
+			}
 		}
 		public function addFileRequired( $_file ) {
 			array_push($this->required, $_file);
@@ -61,14 +67,17 @@  discard block
 block discarded – undo
 		}
 		protected function getRequire( $_function, $_extenction) {
 			$temp = [];
-			foreach ($this->required as $i)
-				if (!is_array($i) && strpos($i, $_extenction) !== FALSE)
+			foreach ($this->required as $i) {
+							if (!is_array($i) && strpos($i, $_extenction) !== FALSE)
 					array_push($temp,$i);
-			foreach ($this->modules as $i)
-				$temp = array_merge( $temp, $i->$_function() );
-			foreach ($this->files as $i)
-				if (!is_array($i) && strpos($i, $_extenction) !== FALSE)
+			}
+			foreach ($this->modules as $i) {
+							$temp = array_merge( $temp, $i->$_function() );
+			}
+			foreach ($this->files as $i) {
+							if (!is_array($i) && strpos($i, $_extenction) !== FALSE)
 					array_push($temp,$i);
+			}
 			return $temp;
 		}
 	}

Please login to merge, or discard this patch.

examples/01essential/pages/Template.php 1 patch

Braces +3 added lines, -2 removed lines patch added patch discarded remove patch

@@ -19,13 +19,14 @@
 block discarded – undo
 		public function makeConnection() {
 			global $jConfig;
 			$connection = null;
-			if($jConfig->connection["enable"])
-				$connection = new Connection(
+			if($jConfig->connection["enable"]) {
+							$connection = new Connection(
 						$jConfig->connection["server"]
 					, $jConfig->connection["database"]
 					, $jConfig->connection["user"]
 					, $jConfig->connection["password"]
 				);
+			}
 			$this->addConnection("base",$connection);
 		}
 	}

Please login to merge, or discard this patch.

		@@ -22,8 +22,9 @@ discard block
		block discarded – undo
22	22	$percent;
23	23	foreach (getGitLog() as $i) {
24	24	$cont++;
25		- if($cont % $nPerCol == 1)
26		- echo '<div class="row">';
	25	+ if($cont % $nPerCol == 1) {
	26	+ echo '<div class="row">';
	27	+ }
27	28	if(isset($i["tag"])) {
28	29	$percent = explode(".",$i["tag"]);
29	30	$percent = 100 * intval($percent[0]) + 10 * intval($percent[1]) + intval($percent[2]);
		@@ -32,7 +33,8 @@ discard block
		block discarded – undo
32	33	<div class="col-lg-<?=$dim?>">
33	34	<div class="well well-sm miniblock">
34	35	<div class="autor"><b>Autor:</b> <?=$i["author"]?><br></div>
35		- <div class="tag"><b>Tag:</b> <?php if(isset($i["tag"])) echo $i["tag"]?><br></div>
	36	+ <div class="tag"><b>Tag:</b> <?php if(isset($i["tag"])) {
	37	+ echo $i["tag"]?><br></div>
36	38	<div class="date"><b>Date:</b> <?=$i["date"]?><br></div>
37	39	<div class="message"><b>Message:</b> <?=$i["message"]?><br></div>
38	40	<div class="progress">
		@@ -46,6 +48,7 @@ discard block
		block discarded – undo
46	48	<?php
47	49	if($cont % $nPerCol == 0)
48	50	echo '</div>';
	51	+}
49	52	} ?>
50	53	</div>
51	54	</div>

		@@ -1,14 +1,16 @@
		block discarded – undo
1	1	<?php
2		- if(isset($GLOBALS["JATEPath"]))
3		- $GLOBALS["JATEPath"] = [];
	2	+ if(isset($GLOBALS["JATEPath"])) {
	3	+ $GLOBALS["JATEPath"] = [];
	4	+ }
4	5	$commonLocations = array(
5	6	"bower_components/JATE/dist/",
6	7	"vendor/xaberr/jate/dist/",
7	8	"../../dist/"
8	9	);
9		- foreach ($commonLocations as $i)
10		- if(file_exists($i."jate/coreEngine.php")) {
	10	+ foreach ($commonLocations as $i) {
	11	+ if(file_exists($i."jate/coreEngine.php")) {
11	12	array_push($GLOBALS["JATEPath"], $i);
	13	+ }
12	14	require_once($i."jate/coreEngine.php");
13	15	break;
14	16	}

		@@ -1,6 +1,8 @@
		block discarded – undo
1	1	<?php
2	2	require_once("main.php");
3		- if(!isset($_GET["page"])) $_GET["page"] = "home";
	3	+ if(!isset($_GET["page"])) {
	4	+ $_GET["page"] = "home";
	5	+ }
4	6	$webApp->fetchPage($_GET["page"]);
5	7	$webApp->draw();
6	8	?>

		@@ -19,13 +19,14 @@
		block discarded – undo
19	19	public function makeConnection() {
20	20	global $jConfig;
21	21	$connection = null;
22		- if($jConfig->connection["enable"])
23		- $connection = new Connection(
	22	+ if($jConfig->connection["enable"]) {
	23	+ $connection = new Connection(
24	24	$jConfig->connection["server"]
25	25	, $jConfig->connection["database"]
26	26	, $jConfig->connection["user"]
27	27	, $jConfig->connection["password"]
28	28	);
	29	+ }
29	30	$this->addConnection("base",$connection);
30	31	}
31	32	}

		@@ -23,33 +23,39 @@ discard block
		block discarded – undo
23	23	}
24	24	public function getJsVariables() {
25	25	$temp = [];
26		- foreach ($this->required as $i)
27		- if (is_array($i))
	26	+ foreach ($this->required as $i) {
	27	+ if (is_array($i))
28	28	array_push($temp,$i);
29		- foreach ($this->modules as $i)
30		- $temp = array_merge( $temp, $i->getJsVariables() );
31		- foreach ($this->files as $i)
32		- if (is_array($i))
	29	+ }
	30	+ foreach ($this->modules as $i) {
	31	+ $temp = array_merge( $temp, $i->getJsVariables() );
	32	+ }
	33	+ foreach ($this->files as $i) {
	34	+ if (is_array($i))
33	35	array_push($temp,$i);
	36	+ }
34	37	return $temp;
35	38	}
36	39	public function addModules( $_mods ) {
37		- foreach ($_mods as $value)
38		- $this->addModule($value);
	40	+ foreach ($_mods as $value) {
	41	+ $this->addModule($value);
	42	+ }
39	43	}
40	44	public function addModule( $_mod ) {
41	45	$this->modules[$_mod->name] = $_mod;
42	46	}
43	47	public function addFiles( $_files ) {
44		- foreach ($_files as $value)
45		- $this->addFile($value);
	48	+ foreach ($_files as $value) {
	49	+ $this->addFile($value);
	50	+ }
46	51	}
47	52	public function addFile( $_file ) {
48	53	array_push($this->files, $_file);
49	54	}
50	55	public function addFilesRequired( $_files ) {
51		- foreach ($_files as $value)
52		- $this->addFileRequired($value);
	56	+ foreach ($_files as $value) {
	57	+ $this->addFileRequired($value);
	58	+ }
53	59	}
54	60	public function addFileRequired( $_file ) {
55	61	array_push($this->required, $_file);
		@@ -61,14 +67,17 @@ discard block
		block discarded – undo
61	67	}
62	68	protected function getRequire( $_function, $_extenction) {
63	69	$temp = [];
64		- foreach ($this->required as $i)
65		- if (!is_array($i) && strpos($i, $_extenction) !== FALSE)
	70	+ foreach ($this->required as $i) {
	71	+ if (!is_array($i) && strpos($i, $_extenction) !== FALSE)
66	72	array_push($temp,$i);
67		- foreach ($this->modules as $i)
68		- $temp = array_merge( $temp, $i->$_function() );
69		- foreach ($this->files as $i)
70		- if (!is_array($i) && strpos($i, $_extenction) !== FALSE)
	73	+ }
	74	+ foreach ($this->modules as $i) {
	75	+ $temp = array_merge( $temp, $i->$_function() );
	76	+ }
	77	+ foreach ($this->files as $i) {
	78	+ if (!is_array($i) && strpos($i, $_extenction) !== FALSE)
71	79	array_push($temp,$i);
	80	+ }
72	81	return $temp;
73	82	}
74	83	}

XaBerr / JATE

Push — master ( a12ace...998a95 )

Status

Category

Braces +6 added lines, -3 removed lines patch added patch discarded remove patch

Braces +6 added lines, -4 removed lines patch added patch discarded remove patch

Braces +6 added lines, -4 removed lines patch added patch discarded remove patch

Braces +6 added lines, -3 removed lines patch added patch discarded remove patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

Braces +6 added lines, -3 removed lines patch added patch discarded remove patch

Braces +3 added lines, -2 removed lines patch added patch discarded remove patch

Braces +27 added lines, -18 removed lines patch added patch discarded remove patch

Braces +3 added lines, -2 removed lines patch added patch discarded remove patch