Conditions | 18 |
Paths | 888 |
Total Lines | 100 |
Code Lines | 67 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
40 | public function header() |
||
41 | { |
||
42 | global $xoops, $xoopsConfig, $xoopsModule, $xoopsUser, $xoopsOption, $xoTheme, $xoopsTpl; |
||
43 | ob_start(); |
||
44 | |||
45 | xoops_loadLanguage('admin', 'system'); |
||
46 | xoops_loadLanguage('cpanel', 'system'); |
||
47 | xoops_loadLanguage('modinfo', 'system'); |
||
48 | |||
49 | $xoopsLogger = XoopsLogger::getInstance(); |
||
50 | $xoopsLogger->stopTime('Module init'); |
||
51 | $xoopsLogger->startTime('XOOPS output init'); |
||
52 | |||
53 | if (!headers_sent()) { |
||
54 | header('Content-Type:text/html; charset=' . _CHARSET); |
||
55 | header('Expires: Mon, 26 Jul 1997 05:00:00 GMT'); |
||
56 | header('Last-Modified: ' . gmdate('D, d M Y H:i:s') . ' GMT'); |
||
57 | header('Cache-Control: no-store, no-cache, must-revalidate'); |
||
58 | header('Cache-Control: post-check=0, pre-check=0', false); |
||
59 | header('Pragma: no-cache'); |
||
60 | } |
||
61 | |||
62 | require_once XOOPS_ROOT_PATH . '/class/template.php'; |
||
63 | require_once XOOPS_ROOT_PATH . '/class/theme.php'; |
||
64 | |||
65 | if (isset($GLOBALS['xoopsOption']['template_main'])) { |
||
66 | if (false === strpos($GLOBALS['xoopsOption']['template_main'], ':')) { |
||
67 | $GLOBALS['xoopsOption']['template_main'] = 'db:' . $GLOBALS['xoopsOption']['template_main']; |
||
68 | } |
||
69 | } |
||
70 | |||
71 | $adminThemeFactory = new xos_opal_AdminThemeFactory(); |
||
72 | $this->xoTheme =& $adminThemeFactory->createInstance(array( |
||
73 | 'folderName' => $this->foldername, |
||
74 | 'themesPath' => 'modules/system/themes', |
||
75 | 'contentTemplate' => isset($GLOBALS['xoopsOption']['template_main'])? $GLOBALS['xoopsOption']['template_main'] :'')); |
||
76 | $this->xoTheme->loadLocalization('admin'); |
||
77 | $this->template =& $this->xoTheme->template; |
||
78 | |||
79 | $GLOBALS['xoTheme'] =& $this->xoTheme; |
||
80 | $GLOBALS['adminTpl'] =& $this->xoTheme->template; |
||
81 | |||
82 | $xoopsLogger->stopTime('XOOPS output init'); |
||
83 | $xoopsLogger->startTime('Module display'); |
||
84 | |||
85 | $xoopsPreload = XoopsPreload::getInstance(); |
||
86 | $xoopsPreload->triggerEvent('system.class.gui.header'); |
||
87 | |||
88 | if (isset($xoopsModule) && $xoopsModule->getVar('dirname') === 'system') { |
||
89 | $xoopsModule->loadAdminMenu(); |
||
90 | |||
91 | foreach (array_keys($xoopsModule->adminmenu) as $item) { |
||
92 | $sys_menu[$item]['link'] = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/' . $xoopsModule->adminmenu[$item]['link']; |
||
93 | $GLOBALS['xoopsTpl']->appendByRef('sys_menu', $sys_menu); |
||
|
|||
94 | unset($sys_menu); |
||
95 | } |
||
96 | } |
||
97 | // Module adminmenu |
||
98 | if (isset($xoopsModule) && $xoopsModule->getVar('dirname') !== 'system') { |
||
99 | if ($xoopsModule->getInfo('system_menu')) { |
||
100 | $GLOBALS['xoTheme']->addStylesheet(XOOPS_URL . '/modules/system/css/menu.css'); |
||
101 | |||
102 | $xoopsModule->loadAdminMenu(); |
||
103 | // Get menu tab handler |
||
104 | /** @var SystemMenuHandler $menu_handler */ |
||
105 | $menu_handler = xoops_getModuleHandler('menu', 'system'); |
||
106 | // Define top navigation |
||
107 | $menu_handler->addMenuTop(XOOPS_URL . '/modules/system/admin.php?fct=preferences&op=showmod&mod=' . $xoopsModule->getVar('mid', 'e'), _AM_SYSTEM_PREF); |
||
108 | $menu_handler->addMenuTop(XOOPS_URL . '/modules/system/admin.php?fct=modulesadmin&op=update&module=' . $xoopsModule->getVar('dirname', 'e'), _AM_SYSTEM_UPDATE); |
||
109 | $blocksTest = $xoopsModule->getInfo('blocks'); |
||
110 | if (!empty($blocksTest)) { |
||
111 | $menu_handler->addMenuTop(XOOPS_URL . '/modules/system/admin.php?fct=blocksadmin&op=list&filter=1&selgen=' . $xoopsModule->getVar('mid', 'e') . '&selmod=-2&selgrp=-1&selvis=-1', _AM_SYSTEM_BLOCKS); |
||
112 | } |
||
113 | $menu_handler->addMenuTop(XOOPS_URL . '/modules/system/admin.php?fct=tplsets&op=listtpl&tplset=default&moddir=' . $xoopsModule->getVar('dirname', 'e'), _AM_SYSTEM_TPLSETS); |
||
114 | if ($xoopsModule->getInfo('hasComments') == 1){ |
||
115 | $menu_handler->addMenuTop(XOOPS_URL . '/modules/system/admin.php?module=' . $xoopsModule->getVar('mid', 'e') . '&status=0&limit=10&fct=comments', _AM_SYSTEM_COMMENTS); |
||
116 | } |
||
117 | $menu_handler->addMenuTop(XOOPS_URL . '/modules/system/admin.php?fct=modulesadmin&op=uninstall&module=' . $xoopsModule->getVar('dirname', 'e'), _AM_SYSTEM_UNINSTALL); |
||
118 | if ($xoopsModule->getInfo('hasMain') == 1){ |
||
119 | $menu_handler->addMenuTop(XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname', 'e') . '/', _AM_SYSTEM_GOTOMODULE); |
||
120 | } |
||
121 | // Define main tab navigation |
||
122 | $i = 0; |
||
123 | $current = $i; |
||
124 | foreach ($xoopsModule->adminmenu as $menu) { |
||
125 | if (stripos($_SERVER['REQUEST_URI'], $menu['link']) !== false) { |
||
126 | $current = $i; |
||
127 | } |
||
128 | $menu_handler->addMenuTabs($menu['link'], $menu['title']); |
||
129 | ++$i; |
||
130 | } |
||
131 | if ($xoopsModule->getInfo('help')) { |
||
132 | if (stripos($_SERVER['REQUEST_URI'], 'admin/' . $xoopsModule->getInfo('help')) !== false) { |
||
133 | $current = $i; |
||
134 | } |
||
135 | $menu_handler->addMenuTabs('../system/help.php?mid=' . $xoopsModule->getVar('mid', 's') . '&' . $xoopsModule->getInfo('help'), _AM_SYSTEM_HELP); |
||
136 | } |
||
137 | |||
138 | // Display navigation tabs |
||
139 | $GLOBALS['xoopsTpl']->assign('xo_system_menu', $menu_handler->render($current, false)); |
||
140 | } |
||
196 |