MetadataHelper   A
last analyzed

Complexity

Total Complexity 7

Size/Duplication

Total Lines 45
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 3

Importance

Changes 0
Metric Value
wmc 7
lcom 1
cbo 3
dl 0
loc 45
rs 10
c 0
b 0
f 0

4 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 4 1
A setMetadata() 0 4 1
A setFallbackMetadata() 0 4 1
A getMetadata() 0 12 4
1
<?php
2
3
namespace WellCommerce\Bundle\AppBundle\Service\Metadata\Helper;
4
5
use WellCommerce\Bundle\AppBundle\Entity\Meta;
6
use WellCommerce\Bundle\AppBundle\Service\Shop\Storage\ShopStorageInterface;
7
8
/**
9
 * Class MetadataHelper
10
 *
11
 * @author  Adam Piotrowski <[email protected]>
12
 */
13
final class MetadataHelper implements MetadataHelperInterface
14
{
15
    /**
16
     * @var Meta
17
     */
18
    private $meta;
19
    
20
    /**
21
     * @var Meta
22
     */
23
    private $fallbackMeta;
24
    
25
    /**
26
     * @var ShopStorageInterface
27
     */
28
    private $shopStorage;
29
    
30
    public function __construct(ShopStorageInterface $shopStorage)
31
    {
32
        $this->shopStorage = $shopStorage;
33
    }
34
    
35
    public function setMetadata(Meta $meta)
36
    {
37
        $this->meta = $meta;
38
    }
39
    
40
    public function setFallbackMetadata(Meta $meta)
41
    {
42
        $this->fallbackMeta = $meta;
43
    }
44
    
45
    public function getMetadata(): Meta
46
    {
47
        if ($this->meta instanceof Meta && false === $this->meta->isEmpty()) {
48
            return $this->meta;
49
        }
50
        
51
        if ($this->fallbackMeta instanceof Meta) {
52
            return $this->fallbackMeta;
53
        }
54
        
55
        return $this->shopStorage->getCurrentShop()->translate()->getMeta();
0 ignored issues
show
Bug introduced by Adam Piotrowski
It seems like getMeta() must be provided by classes using this trait. How about adding it as abstract method to this trait?

This check looks for methods that are used by a trait but not required by it.

To illustrate, let’s look at the following code example

trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

The trait Idable provides a method equalsId that in turn relies on the method getId(). If this method does not exist on a class mixing in this trait, the method will fail.

Adding the getId() as an abstract method to the trait will make sure it is available.

Loading history...
56
    }
57
}
58