Inspection of "Changelog for PR #1032" - Symplify/PHP7_CodeSniffer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (d87ed9)

by Tomáš

created 2016-06-24 23:04 UTC

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -239,7 +239,7 @@  discard block
 block discarded – undo
      * @return array
      * @throws ChannelException If the project is invalid.
      */
-    public static function getTestInfo($projectid=NULL)
+    public static function getTestInfo($projectid = NULL)
     {
         try {
             DAL::beginTransaction();
@@ -264,7 +264,7 @@  discard block
 block discarded – undo
     {
         parent::setUp();
 
-        if ( !strlen($this->folderName) ) {
+        if (!strlen($this->folderName)) {
             throw new \RuntimeException('The $this->folderName must be specified before proceeding.');
         }
     }

Please login to merge, or discard this patch.

Standards/Squiz/Tests/Commenting/PostStatementCommentUnitTest.php 3 patches

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -50,14 +50,14 @@
 block discarded – undo
                     6  => 1,
                     10 => 1,
                     18 => 1,
-                   );
+                    );
             break;
         case 'PostStatementCommentUnitTest.js':
             return array(
                     1 => 1,
                     4 => 1,
                     9 => 1,
-                   );
+                    );
             break;
         default:
             return array();

Please login to merge, or discard this patch.

Switch Indentation +17 added lines, -17 removed lines patch added patch discarded remove patch

@@ -45,23 +45,23 @@
 block discarded – undo
     public function getErrorList($testFile='PostStatementCommentUnitTest.inc')
     {
         switch ($testFile) {
-        case 'PostStatementCommentUnitTest.inc':
-            return array(
-                    6  => 1,
-                    10 => 1,
-                    18 => 1,
-                   );
-            break;
-        case 'PostStatementCommentUnitTest.js':
-            return array(
-                    1 => 1,
-                    4 => 1,
-                    9 => 1,
-                   );
-            break;
-        default:
-            return array();
-            break;
+            case 'PostStatementCommentUnitTest.inc':
+                return array(
+                        6  => 1,
+                        10 => 1,
+                        18 => 1,
+                       );
+                break;
+            case 'PostStatementCommentUnitTest.js':
+                return array(
+                        1 => 1,
+                        4 => 1,
+                        9 => 1,
+                       );
+                break;
+            default:
+                return array();
+                break;
         }//end switch
 
     }//end getErrorList()

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -42,7 +42,7 @@
 block discarded – undo
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='PostStatementCommentUnitTest.inc')
+    public function getErrorList($testFile = 'PostStatementCommentUnitTest.inc')
     {
         switch ($testFile) {
         case 'PostStatementCommentUnitTest.inc':

Please login to merge, or discard this patch.

Standards/Squiz/Tests/Commenting/DocCommentAlignmentUnitTest.php 1 patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

		@@ -56,7 +56,7 @@
		block discarded – undo
56	56	33 => 1,
57	57	38 => 1,
58	58	39 => 1,
59		- );
	59	+ );
60	60
61	61	}//end getErrorList()
62	62

Please login to merge, or discard this patch.

Standards/Squiz/Tests/Operators/ComparisonOperatorUsageUnitTest.php 3 patches

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -71,7 +71,7 @@  discard block
 block discarded – undo
                     100 => 1,
                     106 => 1,
                     112 => 1,
-                   );
+                    );
             break;
         case 'ComparisonOperatorUsageUnitTest.js':
             return array(
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
                     40 => 1,
                     47 => 1,
                     52 => 1,
-                   );
+                    );
             break;
         default:
             return array();

Please login to merge, or discard this patch.

Switch Indentation +43 added lines, -43 removed lines patch added patch discarded remove patch

		@@ -45,49 +45,49 @@
		block discarded – undo
45	45	public function getErrorList($testFile='ComparisonOperatorUsageUnitTest.inc')
46	46	{
47	47	switch ($testFile) {
48		- case 'ComparisonOperatorUsageUnitTest.inc':
49		- return array(
50		- 6 => 1,
51		- 7 => 1,
52		- 10 => 1,
53		- 11 => 1,
54		- 18 => 1,
55		- 19 => 1,
56		- 22 => 1,
57		- 23 => 1,
58		- 29 => 2,
59		- 32 => 2,
60		- 38 => 4,
61		- 47 => 2,
62		- 69 => 1,
63		- 72 => 1,
64		- 75 => 1,
65		- 78 => 1,
66		- 80 => 1,
67		- 82 => 1,
68		- 83 => 1,
69		- 89 => 1,
70		- 92 => 1,
71		- 100 => 1,
72		- 106 => 1,
73		- 112 => 1,
74		- );
75		- break;
76		- case 'ComparisonOperatorUsageUnitTest.js':
77		- return array(
78		- 5 => 1,
79		- 6 => 1,
80		- 17 => 1,
81		- 18 => 1,
82		- 28 => 2,
83		- 40 => 1,
84		- 47 => 1,
85		- 52 => 1,
86		- );
87		- break;
88		- default:
89		- return array();
90		- break;
	48	+ case 'ComparisonOperatorUsageUnitTest.inc':
	49	+ return array(
	50	+ 6 => 1,
	51	+ 7 => 1,
	52	+ 10 => 1,
	53	+ 11 => 1,
	54	+ 18 => 1,
	55	+ 19 => 1,
	56	+ 22 => 1,
	57	+ 23 => 1,
	58	+ 29 => 2,
	59	+ 32 => 2,
	60	+ 38 => 4,
	61	+ 47 => 2,
	62	+ 69 => 1,
	63	+ 72 => 1,
	64	+ 75 => 1,
	65	+ 78 => 1,
	66	+ 80 => 1,
	67	+ 82 => 1,
	68	+ 83 => 1,
	69	+ 89 => 1,
	70	+ 92 => 1,
	71	+ 100 => 1,
	72	+ 106 => 1,
	73	+ 112 => 1,
	74	+ );
	75	+ break;
	76	+ case 'ComparisonOperatorUsageUnitTest.js':
	77	+ return array(
	78	+ 5 => 1,
	79	+ 6 => 1,
	80	+ 17 => 1,
	81	+ 18 => 1,
	82	+ 28 => 2,
	83	+ 40 => 1,
	84	+ 47 => 1,
	85	+ 52 => 1,
	86	+ );
	87	+ break;
	88	+ default:
	89	+ return array();
	90	+ break;
91	91	}//end switch
92	92
93	93	}//end getErrorList()

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -42,7 +42,7 @@
 block discarded – undo
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='ComparisonOperatorUsageUnitTest.inc')
+    public function getErrorList($testFile = 'ComparisonOperatorUsageUnitTest.inc')
     {
         switch ($testFile) {
         case 'ComparisonOperatorUsageUnitTest.inc':

Please login to merge, or discard this patch.

Standards/Squiz/Tests/Operators/IncrementDecrementUsageUnitTest.php 1 patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

		@@ -52,7 +52,7 @@
		block discarded – undo
52	52	27 => 1,
53	53	29 => 1,
54	54	31 => 1,
55		- );
	55	+ );
56	56
57	57	}//end getErrorList()
58	58

Please login to merge, or discard this patch.

Standards/Squiz/Tests/Operators/ValidLogicalOperatorsUnitTest.php 1 patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

		@@ -46,7 +46,7 @@
		block discarded – undo
46	46	5 => 1,
47	47	11 => 1,
48	48	17 => 2,
49		- );
	49	+ );
50	50
51	51	}//end getErrorList()
52	52

Please login to merge, or discard this patch.

Standards/Squiz/Tests/Operators/IncrementDecrementUsageUnitTest.inc 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

		@@ -22,7 +22,7 @@
		block discarded – undo
22	22	$var -= $var - 1;
23	23	$var += $var - 1;
24	24
25		-$id = $id.'_'.($i-- - $x--).'_'.$x;
	25	+$id = $id.'_'.($i-- -$x--).'_'.$x;
26	26	$id = $id.'_'.(++$i - $x--).'_'.$x;
27	27	$id = $id.'_'.(--$i - $x++).'_'.$x;
28	28

Please login to merge, or discard this patch.

CodeSniffer/Standards/Squiz/Tests/PHP/HeredocUnitTest.php 1 patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -45,7 +45,7 @@
 block discarded – undo
         return array(
                 2 => 1,
                 8 => 1,
-               );
+                );
 
     }//end getErrorList()
 

Please login to merge, or discard this patch.

CodeSniffer/Standards/Squiz/Tests/PHP/DisallowInlineIfUnitTest.php 3 patches

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -46,12 +46,12 @@
 block discarded – undo
         case 'DisallowInlineIfUnitTest.inc':
             return array(
                     8 => 1,
-                   );
+                    );
             break;
         case 'DisallowInlineIfUnitTest.js':
             return array(
                     1 => 1,
-                   );
+                    );
             break;
         default:
             return array();

Please login to merge, or discard this patch.

Switch Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -43,19 +43,19 @@
 block discarded – undo
     public function getErrorList($testFile='DisallowInlineIfUnitTest.inc')
     {
         switch ($testFile) {
-        case 'DisallowInlineIfUnitTest.inc':
-            return array(
-                    8 => 1,
-                   );
-            break;
-        case 'DisallowInlineIfUnitTest.js':
-            return array(
-                    1 => 1,
-                   );
-            break;
-        default:
-            return array();
-            break;
+            case 'DisallowInlineIfUnitTest.inc':
+                return array(
+                        8 => 1,
+                       );
+                break;
+            case 'DisallowInlineIfUnitTest.js':
+                return array(
+                        1 => 1,
+                       );
+                break;
+            default:
+                return array();
+                break;
         }//end switch
 
     }//end getErrorList()

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -40,7 +40,7 @@
 block discarded – undo
      *
      * @return array<int, int>
      */
-    public function getErrorList($testFile='DisallowInlineIfUnitTest.inc')
+    public function getErrorList($testFile = 'DisallowInlineIfUnitTest.inc')
     {
         switch ($testFile) {
         case 'DisallowInlineIfUnitTest.inc':

Please login to merge, or discard this patch.

		@@ -239,7 +239,7 @@ discard block
		block discarded – undo
239	239	* @return array
240	240	* @throws ChannelException If the project is invalid.
241	241	*/
242		- public static function getTestInfo($projectid=NULL)
	242	+ public static function getTestInfo($projectid = NULL)
243	243	{
244	244	try {
245	245	DAL::beginTransaction();
		@@ -264,7 +264,7 @@ discard block
		block discarded – undo
264	264	{
265	265	parent::setUp();
266	266
267		- if ( !strlen($this->folderName) ) {
	267	+ if (!strlen($this->folderName)) {
268	268	throw new \RuntimeException('The $this->folderName must be specified before proceeding.');
269	269	}
270	270	}

		@@ -50,14 +50,14 @@
		block discarded – undo
50	50	6 => 1,
51	51	10 => 1,
52	52	18 => 1,
53		- );
	53	+ );
54	54	break;
55	55	case 'PostStatementCommentUnitTest.js':
56	56	return array(
57	57	1 => 1,
58	58	4 => 1,
59	59	9 => 1,
60		- );
	60	+ );
61	61	break;
62	62	default:
63	63	return array();

		@@ -45,23 +45,23 @@
		block discarded – undo
45	45	public function getErrorList($testFile='PostStatementCommentUnitTest.inc')
46	46	{
47	47	switch ($testFile) {
48		- case 'PostStatementCommentUnitTest.inc':
49		- return array(
50		- 6 => 1,
51		- 10 => 1,
52		- 18 => 1,
53		- );
54		- break;
55		- case 'PostStatementCommentUnitTest.js':
56		- return array(
57		- 1 => 1,
58		- 4 => 1,
59		- 9 => 1,
60		- );
61		- break;
62		- default:
63		- return array();
64		- break;
	48	+ case 'PostStatementCommentUnitTest.inc':
	49	+ return array(
	50	+ 6 => 1,
	51	+ 10 => 1,
	52	+ 18 => 1,
	53	+ );
	54	+ break;
	55	+ case 'PostStatementCommentUnitTest.js':
	56	+ return array(
	57	+ 1 => 1,
	58	+ 4 => 1,
	59	+ 9 => 1,
	60	+ );
	61	+ break;
	62	+ default:
	63	+ return array();
	64	+ break;
65	65	}//end switch
66	66
67	67	}//end getErrorList()

		@@ -42,7 +42,7 @@
		block discarded – undo
42	42	*
43	43	* @return array<int, int>
44	44	*/
45		- public function getErrorList($testFile='PostStatementCommentUnitTest.inc')
	45	+ public function getErrorList($testFile = 'PostStatementCommentUnitTest.inc')
46	46	{
47	47	switch ($testFile) {
48	48	case 'PostStatementCommentUnitTest.inc':

		@@ -71,7 +71,7 @@ discard block
		block discarded – undo
71	71	100 => 1,
72	72	106 => 1,
73	73	112 => 1,
74		- );
	74	+ );
75	75	break;
76	76	case 'ComparisonOperatorUsageUnitTest.js':
77	77	return array(
		@@ -83,7 +83,7 @@ discard block
		block discarded – undo
83	83	40 => 1,
84	84	47 => 1,
85	85	52 => 1,
86		- );
	86	+ );
87	87	break;
88	88	default:
89	89	return array();

		@@ -45,7 +45,7 @@
		block discarded – undo
45	45	return array(
46	46	2 => 1,
47	47	8 => 1,
48		- );
	48	+ );
49	49
50	50	}//end getErrorList()
51	51

		@@ -46,12 +46,12 @@
		block discarded – undo
46	46	case 'DisallowInlineIfUnitTest.inc':
47	47	return array(
48	48	8 => 1,
49		- );
	49	+ );
50	50	break;
51	51	case 'DisallowInlineIfUnitTest.js':
52	52	return array(
53	53	1 => 1,
54		- );
	54	+ );
55	55	break;
56	56	default:
57	57	return array();

		@@ -43,19 +43,19 @@
		block discarded – undo
43	43	public function getErrorList($testFile='DisallowInlineIfUnitTest.inc')
44	44	{
45	45	switch ($testFile) {
46		- case 'DisallowInlineIfUnitTest.inc':
47		- return array(
48		- 8 => 1,
49		- );
50		- break;
51		- case 'DisallowInlineIfUnitTest.js':
52		- return array(
53		- 1 => 1,
54		- );
55		- break;
56		- default:
57		- return array();
58		- break;
	46	+ case 'DisallowInlineIfUnitTest.inc':
	47	+ return array(
	48	+ 8 => 1,
	49	+ );
	50	+ break;
	51	+ case 'DisallowInlineIfUnitTest.js':
	52	+ return array(
	53	+ 1 => 1,
	54	+ );
	55	+ break;
	56	+ default:
	57	+ return array();
	58	+ break;
59	59	}//end switch
60	60
61	61	}//end getErrorList()

		@@ -40,7 +40,7 @@
		block discarded – undo
40	40	*
41	41	* @return array<int, int>
42	42	*/
43		- public function getErrorList($testFile='DisallowInlineIfUnitTest.inc')
	43	+ public function getErrorList($testFile = 'DisallowInlineIfUnitTest.inc')
44	44	{
45	45	switch ($testFile) {
46	46	case 'DisallowInlineIfUnitTest.inc':

Symplify / PHP7_CodeSniffer

Branch — master (d87ed9)

Category

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Switch Indentation +17 added lines, -17 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Switch Indentation +43 added lines, -43 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Switch Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch