Completed
Pull Request — master (#2603)
by
unknown
49s
created
classes/controllers/FrmWelcomeTourController.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
 		$active_step = 0;
119 119
 
120 120
 		foreach ( $step_keys as $index => $step_key ) {
121
-			$completed_step = isset( self::$checklist['completed_steps'][ $step_key ] );
121
+			$completed_step = isset( self::$checklist['completed_steps'][$step_key] );
122 122
 
123 123
 			if ( false === $completed_step ) {
124 124
 				switch ( $step_key ) {
@@ -132,15 +132,15 @@  discard block
 block discarded – undo
132 132
 			}
133 133
 
134 134
 			if ( $completed_step ) {
135
-				self::$checklist['completed_steps'][ $step_key ] = true;
135
+				self::$checklist['completed_steps'][$step_key] = true;
136 136
 			}
137 137
 
138 138
 			// Count completed steps from start until gap found.
139 139
 			if ( $completed_step && $index === $active_step ) {
140
-				$active_step++;
140
+				$active_step ++;
141 141
 			}
142 142
 
143
-			self::$steps['steps'][ $index ]['completed'] = $completed_step;
143
+			self::$steps['steps'][$index]['completed'] = $completed_step;
144 144
 		}//end foreach
145 145
 
146 146
 		self::$checklist['active_step'] = $active_step;
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 			self::$checklist['done']            = true;
150 150
 			self::$checklist['active_step_key'] = 'completed';
151 151
 		} else {
152
-			self::$checklist['active_step_key'] = $step_keys[ $active_step ];
152
+			self::$checklist['active_step_key'] = $step_keys[$active_step];
153 153
 		}
154 154
 
155 155
 		self::save_checklist();
@@ -199,8 +199,8 @@  discard block
 block discarded – undo
199 199
 	 */
200 200
 	private static function fill_step_completed_data( $steps, $steps_keys ) {
201 201
 		return array_map(
202
-			function ( $step, $step_key ) {
203
-				$step['completed'] = isset( self::$checklist['completed_steps'][ $step_key ] );
202
+			function( $step, $step_key ) {
203
+				$step['completed'] = isset( self::$checklist['completed_steps'][$step_key] );
204 204
 				return $step;
205 205
 			},
206 206
 			$steps,
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
234 234
 					'target'        => '#frm_style_sidebar .frm-style-card > div',
235 235
 					'left-position' => 'end',
236 236
 					'offset'        => array(
237
-						'top'  => -22,
237
+						'top'  => - 22,
238 238
 						'left' => 16,
239 239
 					),
240 240
 				);
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
250 250
 				break;
251 251
 		}//end switch
252 252
 
253
-		return array_merge( self::$steps['steps'][ self::$checklist['active_step'] ], $spotlight_data );
253
+		return array_merge( self::$steps['steps'][self::$checklist['active_step']], $spotlight_data );
254 254
 	}
255 255
 
256 256
 	/**
@@ -377,7 +377,7 @@  discard block
 block discarded – undo
377 377
 		}
378 378
 
379 379
 		self::$checklist                                 = self::get_checklist();
380
-		self::$checklist['completed_steps'][ $step_key ] = true;
380
+		self::$checklist['completed_steps'][$step_key] = true;
381 381
 		self::save_checklist();
382 382
 
383 383
 		wp_send_json_success();
@@ -591,7 +591,7 @@  discard block
 block discarded – undo
591 591
 		$steps      = self::get_steps();
592 592
 
593 593
 		foreach ( $steps as $key => $step ) {
594
-			$usage_data[ 'completed_step_' . $key ] = empty( $option['completed_steps'][ $key ] ) ? 0 : 1;
594
+			$usage_data['completed_step_' . $key] = empty( $option['completed_steps'][$key] ) ? 0 : 1;
595 595
 		}
596 596
 
597 597
 		$usage_data['done'] = empty( $option['done'] ) ? 0 : 1;
Please login to merge, or discard this patch.
classes/models/FrmField.php 1 patch
Spacing   +36 added lines, -36 removed lines patch added patch discarded remove patch
@@ -267,11 +267,11 @@  discard block
 block discarded – undo
267 267
 			'ranking' => '2024-03-12',
268 268
 		);
269 269
 
270
-		if ( ! isset( $release_dates[ $type ] ) ) {
270
+		if ( ! isset( $release_dates[$type] ) ) {
271 271
 			return false;
272 272
 		}
273 273
 
274
-		$release_date = $release_dates[ $type ];
274
+		$release_date = $release_dates[$type];
275 275
 
276 276
 		$three_months_after_release = gmdate( 'Y-m-d', strtotime( $release_date . ' + 90 days' ) );
277 277
 		return gmdate( 'Y-m-d' ) < $three_months_after_release;
@@ -304,8 +304,8 @@  discard block
 block discarded – undo
304 304
 		$values = FrmAppHelper::maybe_filter_array( $values, array( 'name', 'description' ) );
305 305
 
306 306
 		foreach ( array( 'name', 'description', 'type', 'default_value' ) as $col ) {
307
-			if ( isset( $values[ $col ] ) ) {
308
-				$new_values[ $col ] = $values[ $col ];
307
+			if ( isset( $values[$col] ) ) {
308
+				$new_values[$col] = $values[$col];
309 309
 			}
310 310
 		}
311 311
 
@@ -317,7 +317,7 @@  discard block
 block discarded – undo
317 317
 		$new_values['created_at']    = current_time( 'mysql', 1 );
318 318
 
319 319
 		if ( isset( $values['id'] ) ) {
320
-			$frm_duplicate_ids[ $values['field_key'] ] = $new_values['field_key'];
320
+			$frm_duplicate_ids[$values['field_key']] = $new_values['field_key'];
321 321
 			$new_values                                = apply_filters( 'frm_duplicated_field', $new_values );
322 322
 		}
323 323
 
@@ -326,9 +326,9 @@  discard block
 block discarded – undo
326 326
 		foreach ( $new_values as $k => $v ) {
327 327
 			if ( is_array( $v ) ) {
328 328
 				if ( $k === 'default_value' ) {
329
-					$new_values[ $k ] = FrmAppHelper::maybe_json_encode( $v );
329
+					$new_values[$k] = FrmAppHelper::maybe_json_encode( $v );
330 330
 				} else {
331
-					$new_values[ $k ] = serialize( $v );
331
+					$new_values[$k] = serialize( $v );
332 332
 				}
333 333
 			}
334 334
 			unset( $k, $v );
@@ -348,7 +348,7 @@  discard block
 block discarded – undo
348 348
 		}
349 349
 
350 350
 		if ( isset( $values['id'] ) ) {
351
-			$frm_duplicate_ids[ $values['id'] ] = $new_id;
351
+			$frm_duplicate_ids[$values['id']] = $new_id;
352 352
 		}
353 353
 
354 354
 		return $new_id;
@@ -399,7 +399,7 @@  discard block
 block discarded – undo
399 399
 			 * @param array $match Shortcode data.
400 400
 			 * @return string
401 401
 			 */
402
-			function ( $match ) {
402
+			function( $match ) {
403 403
 				$attr = shortcode_parse_atts( $match[3] );
404 404
 
405 405
 				if ( ! is_array( $attr ) ) {
@@ -424,7 +424,7 @@  discard block
 block discarded – undo
424 424
 					}
425 425
 
426 426
 					if ( FrmAppHelper::input_key_is_safe( $key, 'update' ) ) {
427
-						$safe_atts[ $key ] = $value;
427
+						$safe_atts[$key] = $value;
428 428
 					}
429 429
 				}
430 430
 
@@ -482,7 +482,7 @@  discard block
 block discarded – undo
482 482
 	public static function duplicate( $old_form_id, $form_id, $copy_keys = false, $blog_id = false ) {
483 483
 		global $frm_duplicate_ids;
484 484
 
485
-		$where  = array(
485
+		$where = array(
486 486
 			array(
487 487
 				'or'                => 1,
488 488
 				'fi.form_id'        => $old_form_id,
@@ -528,8 +528,8 @@  discard block
 block discarded – undo
528 528
 
529 529
 			$values                                 = apply_filters( 'frm_duplicated_field', $values );
530 530
 			$new_id                                 = self::create( $values );
531
-			$frm_duplicate_ids[ $field->id ]        = $new_id;
532
-			$frm_duplicate_ids[ $field->field_key ] = $new_id;
531
+			$frm_duplicate_ids[$field->id]        = $new_id;
532
+			$frm_duplicate_ids[$field->field_key] = $new_id;
533 533
 			unset( $field );
534 534
 		}//end foreach
535 535
 	}
@@ -578,11 +578,11 @@  discard block
 block discarded – undo
578 578
 
579 579
 		// serialize array values
580 580
 		foreach ( array( 'field_options', 'options' ) as $opt ) {
581
-			if ( isset( $values[ $opt ] ) && is_array( $values[ $opt ] ) ) {
581
+			if ( isset( $values[$opt] ) && is_array( $values[$opt] ) ) {
582 582
 				if ( 'field_options' === $opt ) {
583
-					$values[ $opt ] = self::maybe_filter_options( $values[ $opt ] );
583
+					$values[$opt] = self::maybe_filter_options( $values[$opt] );
584 584
 				}
585
-				$values[ $opt ] = serialize( $values[ $opt ] );
585
+				$values[$opt] = serialize( $values[$opt] );
586 586
 			}
587 587
 		}
588 588
 		if ( isset( $values['default_value'] ) && is_array( $values['default_value'] ) ) {
@@ -769,8 +769,8 @@  discard block
 block discarded – undo
769 769
 					continue;
770 770
 				}
771 771
 
772
-				$fields[ $result->id ] = $result;
773
-				++$count;
772
+				$fields[$result->id] = $result;
773
+				++ $count;
774 774
 				if ( $limit == 1 ) {
775 775
 					$fields = $result;
776 776
 					break;
@@ -821,8 +821,8 @@  discard block
 block discarded – undo
821 821
 			$fields = array();
822 822
 			$count  = 0;
823 823
 			foreach ( $results as $result ) {
824
-				++$count;
825
-				$fields[ $result->id ] = $result;
824
+				++ $count;
825
+				$fields[$result->id] = $result;
826 826
 				if ( ! empty( $limit ) && $count >= $limit ) {
827 827
 					break;
828 828
 				}
@@ -936,7 +936,7 @@  discard block
 block discarded – undo
936 936
 		$query_type = $limit === ' LIMIT 1' || $limit == 1 ? 'row' : 'results';
937 937
 
938 938
 		if ( is_array( $where ) ) {
939
-			$args    = array(
939
+			$args = array(
940 940
 				'order_by' => $order_by,
941 941
 				'limit'    => $limit,
942 942
 			);
@@ -969,9 +969,9 @@  discard block
 block discarded – undo
969 969
 				FrmDb::set_cache( $result->field_key, $result, 'frm_field' );
970 970
 
971 971
 				self::prepare_options( $result );
972
-				$results[ $r_key ]->field_options = $result->field_options;
973
-				$results[ $r_key ]->options       = $result->options;
974
-				$results[ $r_key ]->default_value = $result->default_value;
972
+				$results[$r_key]->field_options = $result->field_options;
973
+				$results[$r_key]->options       = $result->options;
974
+				$results[$r_key]->default_value = $result->default_value;
975 975
 
976 976
 				unset( $r_key, $result );
977 977
 			}
@@ -1050,7 +1050,7 @@  discard block
 block discarded – undo
1050 1050
 
1051 1051
 			if ( count( $next_fields ) >= self::$transient_size ) {
1052 1052
 				// if this transient is full, check for another
1053
-				++$next;
1053
+				++ $next;
1054 1054
 				self::get_next_transient( $fields, $base_name, $next );
1055 1055
 			}
1056 1056
 		}
@@ -1078,7 +1078,7 @@  discard block
 block discarded – undo
1078 1078
 				return;
1079 1079
 			}
1080 1080
 
1081
-			++$next;
1081
+			++ $next;
1082 1082
 		}
1083 1083
 	}
1084 1084
 
@@ -1226,7 +1226,7 @@  discard block
 block discarded – undo
1226 1226
 	 * @return bool
1227 1227
 	 */
1228 1228
 	public static function is_option_true_in_array( $field, $option ) {
1229
-		return ! empty( $field[ $option ] );
1229
+		return ! empty( $field[$option] );
1230 1230
 	}
1231 1231
 
1232 1232
 	/**
@@ -1235,7 +1235,7 @@  discard block
 block discarded – undo
1235 1235
 	 * @return bool
1236 1236
 	 */
1237 1237
 	public static function is_option_true_in_object( $field, $option ) {
1238
-		return isset( $field->field_options[ $option ] ) && $field->field_options[ $option ];
1238
+		return isset( $field->field_options[$option] ) && $field->field_options[$option];
1239 1239
 	}
1240 1240
 
1241 1241
 	/**
@@ -1244,7 +1244,7 @@  discard block
 block discarded – undo
1244 1244
 	 * @return bool
1245 1245
 	 */
1246 1246
 	public static function is_option_empty_in_array( $field, $option ) {
1247
-		return empty( $field[ $option ] );
1247
+		return empty( $field[$option] );
1248 1248
 	}
1249 1249
 
1250 1250
 	/**
@@ -1253,7 +1253,7 @@  discard block
 block discarded – undo
1253 1253
 	 * @return bool
1254 1254
 	 */
1255 1255
 	public static function is_option_empty_in_object( $field, $option ) {
1256
-		return empty( $field->field_options[ $option ] );
1256
+		return empty( $field->field_options[$option] );
1257 1257
 	}
1258 1258
 
1259 1259
 	/**
@@ -1262,7 +1262,7 @@  discard block
 block discarded – undo
1262 1262
 	 * @return bool
1263 1263
 	 */
1264 1264
 	public static function is_option_value_in_object( $field, $option ) {
1265
-		return isset( $field->field_options[ $option ] ) && $field->field_options[ $option ] != '';
1265
+		return isset( $field->field_options[$option] ) && $field->field_options[$option] != '';
1266 1266
 	}
1267 1267
 
1268 1268
 	/**
@@ -1288,10 +1288,10 @@  discard block
 block discarded – undo
1288 1288
 	 * @return mixed
1289 1289
 	 */
1290 1290
 	public static function get_option_in_array( $field, $option ) {
1291
-		if ( isset( $field[ $option ] ) ) {
1292
-			$this_option = $field[ $option ];
1293
-		} elseif ( isset( $field['field_options'] ) && is_array( $field['field_options'] ) && isset( $field['field_options'][ $option ] ) ) {
1294
-			$this_option = $field['field_options'][ $option ];
1291
+		if ( isset( $field[$option] ) ) {
1292
+			$this_option = $field[$option];
1293
+		} elseif ( isset( $field['field_options'] ) && is_array( $field['field_options'] ) && isset( $field['field_options'][$option] ) ) {
1294
+			$this_option = $field['field_options'][$option];
1295 1295
 		} else {
1296 1296
 			$this_option = '';
1297 1297
 		}
@@ -1305,7 +1305,7 @@  discard block
 block discarded – undo
1305 1305
 	 * @return mixed
1306 1306
 	 */
1307 1307
 	public static function get_option_in_object( $field, $option ) {
1308
-		return $field->field_options[ $option ] ?? '';
1308
+		return $field->field_options[$option] ?? '';
1309 1309
 	}
1310 1310
 
1311 1311
 	/**
Please login to merge, or discard this patch.
classes/models/FrmEntryMeta.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 
59 59
 		global $wpdb;
60 60
 
61
-		$values               = array(
61
+		$values = array(
62 62
 			'item_id'  => $entry_id,
63 63
 			'field_id' => $field_id,
64 64
 		);
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
 				}
139 139
 			}
140 140
 
141
-			$values_indexed_by_field_id[ $field_id ] = $meta_value;
141
+			$values_indexed_by_field_id[$field_id] = $meta_value;
142 142
 
143 143
 			self::get_value_to_save( compact( 'field', 'field_id', 'entry_id' ), $meta_value );
144 144
 
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
 
147 147
 				if ( ( is_array( $meta_value ) && empty( $meta_value ) ) || ( ! is_array( $meta_value ) && trim( $meta_value ) === '' ) ) {
148 148
 					// Remove blank fields.
149
-					unset( $values_indexed_by_field_id[ $field_id ] );
149
+					unset( $values_indexed_by_field_id[$field_id] );
150 150
 				} else {
151 151
 					// if value exists, then update it
152 152
 					self::update_entry_meta( $entry_id, $field_id, '', $meta_value );
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
 	 */
225 225
 	public static function get_meta_value( $entry, $field_id ) {
226 226
 		if ( isset( $entry->metas ) ) {
227
-			return $entry->metas[ $field_id ] ?? false;
227
+			return $entry->metas[$field_id] ?? false;
228 228
 		}
229 229
 		return self::get_entry_meta_by_field( $entry->id, $field_id );
230 230
 	}
@@ -246,8 +246,8 @@  discard block
 block discarded – undo
246 246
 			$cached   = FrmDb::check_cache( $entry_id, 'frm_entry' );
247 247
 		}
248 248
 
249
-		if ( $cached && isset( $cached->metas ) && isset( $cached->metas[ $field_id ] ) ) {
250
-			$result = $cached->metas[ $field_id ];
249
+		if ( $cached && isset( $cached->metas ) && isset( $cached->metas[$field_id] ) ) {
250
+			$result = $cached->metas[$field_id];
251 251
 
252 252
 			return wp_unslash( $result );
253 253
 		}
@@ -280,7 +280,7 @@  discard block
 block discarded – undo
280 280
 			'stripslashes' => true,
281 281
 			'is_draft'     => false,
282 282
 		);
283
-		$args     = wp_parse_args( $args, $defaults );
283
+		$args = wp_parse_args( $args, $defaults );
284 284
 
285 285
 		$query = array();
286 286
 		self::meta_field_query( $field_id, $order, $limit, $args, $query );
@@ -295,7 +295,7 @@  discard block
 block discarded – undo
295 295
 
296 296
 		foreach ( $values as $k => $v ) {
297 297
 			FrmAppHelper::unserialize_or_decode( $v );
298
-			$values[ $k ] = $v;
298
+			$values[$k] = $v;
299 299
 			unset( $k, $v );
300 300
 		}
301 301
 
@@ -362,7 +362,7 @@  discard block
 block discarded – undo
362 362
 
363 363
 		foreach ( $results as $k => $result ) {
364 364
 			FrmAppHelper::unserialize_or_decode( $result->meta_value );
365
-			$results[ $k ]->meta_value = wp_unslash( $result->meta_value );
365
+			$results[$k]->meta_value = wp_unslash( $result->meta_value );
366 366
 			unset( $k, $result );
367 367
 		}
368 368
 
@@ -375,7 +375,7 @@  discard block
 block discarded – undo
375 375
 			'user_id'  => '',
376 376
 			'group_by' => '',
377 377
 		);
378
-		$args     = wp_parse_args( $args, $defaults );
378
+		$args = wp_parse_args( $args, $defaults );
379 379
 
380 380
 		$query = array();
381 381
 		self::get_ids_query( $where, $order_by, $limit, $unique, $args, $query );
@@ -478,7 +478,7 @@  discard block
 block discarded – undo
478 478
 			} elseif ( false !== strpos( $args['is_draft'], ',' ) ) {
479 479
 				$is_draft = array_reduce(
480 480
 					explode( ',', $args['is_draft'] ),
481
-					function ( $total, $current ) {
481
+					function( $total, $current ) {
482 482
 						if ( is_numeric( $current ) ) {
483 483
 							$total[] = absint( $current );
484 484
 						}
Please login to merge, or discard this patch.
classes/helpers/FrmListHelper.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -224,8 +224,8 @@  discard block
 block discarded – undo
224 224
 			return $this->get_pagenum();
225 225
 		}
226 226
 
227
-		if ( isset( $this->_pagination_args[ $key ] ) ) {
228
-			return $this->_pagination_args[ $key ];
227
+		if ( isset( $this->_pagination_args[$key] ) ) {
228
+			return $this->_pagination_args[$key];
229 229
 		}
230 230
 	}
231 231
 
@@ -270,8 +270,8 @@  discard block
 block discarded – undo
270 270
 	}
271 271
 
272 272
 	private function hidden_search_inputs( $param_name ) {
273
-		if ( ! empty( $_REQUEST[ $param_name ] ) ) {
274
-			$value = sanitize_text_field( wp_unslash( $_REQUEST[ $param_name ] ) );
273
+		if ( ! empty( $_REQUEST[$param_name] ) ) {
274
+			$value = sanitize_text_field( wp_unslash( $_REQUEST[$param_name] ) );
275 275
 			echo '<input type="hidden" name="' . esc_attr( $param_name ) . '" value="' . esc_attr( $value ) . '" />';
276 276
 		}
277 277
 	}
@@ -313,7 +313,7 @@  discard block
 block discarded – undo
313 313
 
314 314
 		echo "<ul class='subsubsub'>\n";
315 315
 		foreach ( $views as $class => $view ) {
316
-			$views[ $class ] = "\t" . '<li class="' . esc_attr( $class ) . '">' . $view;
316
+			$views[$class] = "\t" . '<li class="' . esc_attr( $class ) . '">' . $view;
317 317
 		}
318 318
 		echo implode( " |</li>\n", $views ) . "</li>\n"; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
319 319
 		echo '</ul>';
@@ -474,7 +474,7 @@  discard block
 block discarded – undo
474 474
 
475 475
 		$out = '<div class="' . ( $always_visible ? 'row-actions visible' : 'row-actions' ) . '">';
476 476
 		foreach ( $actions as $action => $link ) {
477
-			++$i;
477
+			++ $i;
478 478
 			$sep  = $i === $action_count ? '' : ' | ';
479 479
 			$out .= "<span class='$action'>$link$sep</span>";
480 480
 		}
@@ -697,7 +697,7 @@  discard block
 block discarded – undo
697 697
 			'next'  => __( 'Next page', 'formidable' ),
698 698
 		);
699 699
 
700
-		return $labels[ $link ];
700
+		return $labels[$link];
701 701
 	}
702 702
 
703 703
 	private function current_url() {
@@ -787,7 +787,7 @@  discard block
 block discarded – undo
787 787
 
788 788
 		// If the primary column doesn't exist fall back to the
789 789
 		// first non-checkbox column.
790
-		if ( ! isset( $columns[ $default ] ) ) {
790
+		if ( ! isset( $columns[$default] ) ) {
791 791
 			$default = self::get_default_primary_column_name();
792 792
 		}
793 793
 
@@ -801,7 +801,7 @@  discard block
 block discarded – undo
801 801
 		 */
802 802
 		$column = apply_filters( 'list_table_primary_column', $default, $this->screen->id );
803 803
 
804
-		if ( empty( $column ) || ! isset( $columns[ $column ] ) ) {
804
+		if ( empty( $column ) || ! isset( $columns[$column] ) ) {
805 805
 			$column = $default;
806 806
 		}
807 807
 
@@ -822,7 +822,7 @@  discard block
 block discarded – undo
822 822
 			// In 4.3, we added a fourth argument for primary column.
823 823
 			$column_headers = array( array(), array(), array(), $this->get_primary_column_name() );
824 824
 			foreach ( $this->_column_headers as $key => $value ) {
825
-				$column_headers[ $key ] = $value;
825
+				$column_headers[$key] = $value;
826 826
 			}
827 827
 
828 828
 			return $column_headers;
@@ -855,7 +855,7 @@  discard block
 block discarded – undo
855 855
 				$data[1] = false;
856 856
 			}
857 857
 
858
-			$sortable[ $id ] = $data;
858
+			$sortable[$id] = $data;
859 859
 		}
860 860
 
861 861
 		$primary = $this->get_primary_column_name();
@@ -913,7 +913,7 @@  discard block
 block discarded – undo
913 913
 			static $cb_counter = 1;
914 914
 			$columns['cb']     = '<label class="screen-reader-text" for="cb-select-all-' . $cb_counter . '">' . __( 'Select All', 'formidable' ) . '</label>';
915 915
 			$columns['cb']    .= '<input id="cb-select-all-' . esc_attr( $cb_counter ) . '" type="checkbox" />';
916
-			++$cb_counter;
916
+			++ $cb_counter;
917 917
 		}
918 918
 
919 919
 		foreach ( $columns as $column_key => $column_display_name ) {
@@ -935,8 +935,8 @@  discard block
 block discarded – undo
935 935
 				$class[] = 'column-primary';
936 936
 			}
937 937
 
938
-			if ( isset( $sortable[ $column_key ] ) ) {
939
-				list( $orderby, $desc_first ) = $sortable[ $column_key ];
938
+			if ( isset( $sortable[$column_key] ) ) {
939
+				list( $orderby, $desc_first ) = $sortable[$column_key];
940 940
 
941 941
 				if ( $current_orderby == $orderby ) {
942 942
 					// The sorted column. The `aria-sort` attribute must be set only on the sorted column.
@@ -1053,7 +1053,7 @@  discard block
 block discarded – undo
1053 1053
 	 * @return bool Returns true if the setting is not set or if it is not false; otherwise, returns false.
1054 1054
 	 */
1055 1055
 	protected function should_display( $args, $settings ) {
1056
-		return ! isset( $args[ $settings ] ) || false !== $args[ $settings ];
1056
+		return ! isset( $args[$settings] ) || false !== $args[$settings];
1057 1057
 	}
1058 1058
 
1059 1059
 	/**
Please login to merge, or discard this patch.