Linter::validate() - Code Metrics - Inspection of "Sort packages linter" - Soullivaneuh/composer-lint - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2)

by Sullivan

created 2016-05-29 08:42 UTC

Linter::validate() B

↳ Parent: Linter

Complexity

Conditions	6
Paths	2

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	14
rs	8.8571
cc	6
eloc	7
nc	2
nop	1

<?php

namespace SLLH\ComposerLint;

/**
 * @author Sullivan Senechal <[email protected]>
 */
final class Linter
{
    /**
     * @param array $manifest composer.json file manifest
     *
     * @return string[]
     */
    public function validate($manifest)
    {
        $errors = array();

        if (isset($manifest['config']['sort-packages']) && $manifest['config']['sort-packages']) {
            foreach (array('require', 'require-dev', 'conflict', 'replace', 'provide', 'suggest') as $linksSection) {
                if (array_key_exists($linksSection, $manifest) && !$this->packagesAreSorted($manifest[$linksSection])) {
                    array_push($errors, 'Links under '.$linksSection.' section are not sorted.');
                }
            }
        }

        return $errors;
    }

    private function packagesAreSorted(array $packages)
    {
        $names = array_keys($packages);

        $hasPHP = in_array('php', $names);
        $extNames = array_filter($names, function ($name) {
            return 'ext-' === substr($name, 0, 4) && !strstr($name, '/');
        });
        sort($extNames);
        $vendorName = array_filter($names, function ($name) {
            return 'ext-' !== substr($name, 0, 4) && 'php' !== $name;
        });
        sort($vendorName);

        $sortedNames = array_merge(
            $hasPHP ? array('php') : array(),
            $extNames,
            $vendorName
        );

        return $sortedNames === $names;
    }
}


1			<?php
2
3			namespace SLLH\ComposerLint;
4
5			/**
6			* @author Sullivan Senechal <[email protected]>
7			*/
8			final class Linter
9			{
10			/**
11			* @param array $manifest composer.json file manifest
12			*
13			* @return string[]
14			*/
15			public function validate($manifest)
16			{
17			$errors = array();
18
19			if (isset($manifest['config']['sort-packages']) && $manifest['config']['sort-packages']) {
20			foreach (array('require', 'require-dev', 'conflict', 'replace', 'provide', 'suggest') as $linksSection) {
21			if (array_key_exists($linksSection, $manifest) && !$this->packagesAreSorted($manifest[$linksSection])) {
22			array_push($errors, 'Links under '.$linksSection.' section are not sorted.');
23			}
24			}
25			}
26
27			return $errors;
28			}
29
30			private function packagesAreSorted(array $packages)
31			{
32			$names = array_keys($packages);
33
34			$hasPHP = in_array('php', $names);
35			$extNames = array_filter($names, function ($name) {
36			return 'ext-' === substr($name, 0, 4) && !strstr($name, '/');
37			});
38			sort($extNames);
39			$vendorName = array_filter($names, function ($name) {
40			return 'ext-' !== substr($name, 0, 4) && 'php' !== $name;
41			});
42			sort($vendorName);
43
44			$sortedNames = array_merge(
45			$hasPHP ? array('php') : array(),
46			$extNames,
47			$vendorName
48			);
49
50			return $sortedNames === $names;
51			}
52			}
53

Soullivaneuh / composer-lint

Pull Request — master (#2)

Linter::validate() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like