@@ -15,8 +15,9 @@ discard block |
||
| 15 | 15 | * @version 2.1 Beta 3 |
| 16 | 16 | */ |
| 17 | 17 | |
| 18 | -if (!defined('SMF')) |
|
| 18 | +if (!defined('SMF')) { |
|
| 19 | 19 | die('No direct access...'); |
| 20 | +} |
|
| 20 | 21 | |
| 21 | 22 | /** |
| 22 | 23 | * Takes a message and parses it, returning nothing. |
@@ -46,17 +47,19 @@ discard block |
||
| 46 | 47 | $message = preg_replace('~\.{100,}~', '...', $message); |
| 47 | 48 | |
| 48 | 49 | // Trim off trailing quotes - these often happen by accident. |
| 49 | - while (substr($message, -7) == '[quote]') |
|
| 50 | - $message = substr($message, 0, -7); |
|
| 51 | - while (substr($message, 0, 8) == '[/quote]') |
|
| 52 | - $message = substr($message, 8); |
|
| 50 | + while (substr($message, -7) == '[quote]') { |
|
| 51 | + $message = substr($message, 0, -7); |
|
| 52 | + } |
|
| 53 | + while (substr($message, 0, 8) == '[/quote]') { |
|
| 54 | + $message = substr($message, 8); |
|
| 55 | + } |
|
| 53 | 56 | |
| 54 | 57 | // Find all code blocks, work out whether we'd be parsing them, then ensure they are all closed. |
| 55 | 58 | $in_tag = false; |
| 56 | 59 | $had_tag = false; |
| 57 | 60 | $codeopen = 0; |
| 58 | - if (preg_match_all('~(\[(/)*code(?:=[^\]]+)?\])~is', $message, $matches)) |
|
| 59 | - foreach ($matches[0] as $index => $dummy) |
|
| 61 | + if (preg_match_all('~(\[(/)*code(?:=[^\]]+)?\])~is', $message, $matches)) { |
|
| 62 | + foreach ($matches[0] as $index => $dummy) |
|
| 60 | 63 | { |
| 61 | 64 | // Closing? |
| 62 | 65 | if (!empty($matches[2][$index])) |
@@ -64,6 +67,7 @@ discard block |
||
| 64 | 67 | // If it's closing and we're not in a tag we need to open it... |
| 65 | 68 | if (!$in_tag) |
| 66 | 69 | $codeopen = true; |
| 70 | + } |
|
| 67 | 71 | // Either way we ain't in one any more. |
| 68 | 72 | $in_tag = false; |
| 69 | 73 | } |
@@ -72,17 +76,20 @@ discard block |
||
| 72 | 76 | { |
| 73 | 77 | $had_tag = true; |
| 74 | 78 | // If we're in a tag don't do nought! |
| 75 | - if (!$in_tag) |
|
| 76 | - $in_tag = true; |
|
| 79 | + if (!$in_tag) { |
|
| 80 | + $in_tag = true; |
|
| 81 | + } |
|
| 77 | 82 | } |
| 78 | 83 | } |
| 79 | 84 | |
| 80 | 85 | // If we have an open tag, close it. |
| 81 | - if ($in_tag) |
|
| 82 | - $message .= '[/code]'; |
|
| 86 | + if ($in_tag) { |
|
| 87 | + $message .= '[/code]'; |
|
| 88 | + } |
|
| 83 | 89 | // Open any ones that need to be open, only if we've never had a tag. |
| 84 | - if ($codeopen && !$had_tag) |
|
| 85 | - $message = '[code]' . $message; |
|
| 90 | + if ($codeopen && !$had_tag) { |
|
| 91 | + $message = '[code]' . $message; |
|
| 92 | + } |
|
| 86 | 93 | |
| 87 | 94 | // Now that we've fixed all the code tags, let's fix the img and url tags... |
| 88 | 95 | $parts = preg_split('~(\[/code\]|\[code(?:=[^\]]+)?\])~i', $message, -1, PREG_SPLIT_DELIM_CAPTURE); |
@@ -108,23 +115,26 @@ discard block |
||
| 108 | 115 | fixTags($message); |
| 109 | 116 | |
| 110 | 117 | // Replace /me.+?\n with [me=name]dsf[/me]\n. |
| 111 | - if (strpos($user_info['name'], '[') !== false || strpos($user_info['name'], ']') !== false || strpos($user_info['name'], '\'') !== false || strpos($user_info['name'], '"') !== false) |
|
| 112 | - $message = preg_replace('~(\A|\n)/me(?: | )([^\n]*)(?:\z)?~i', '$1[me="' . $user_info['name'] . '"]$2[/me]', $message); |
|
| 113 | - else |
|
| 114 | - $message = preg_replace('~(\A|\n)/me(?: | )([^\n]*)(?:\z)?~i', '$1[me=' . $user_info['name'] . ']$2[/me]', $message); |
|
| 118 | + if (strpos($user_info['name'], '[') !== false || strpos($user_info['name'], ']') !== false || strpos($user_info['name'], '\'') !== false || strpos($user_info['name'], '"') !== false) { |
|
| 119 | + $message = preg_replace('~(\A|\n)/me(?: | )([^\n]*)(?:\z)?~i', '$1[me="' . $user_info['name'] . '"]$2[/me]', $message); |
|
| 120 | + } else { |
|
| 121 | + $message = preg_replace('~(\A|\n)/me(?: | )([^\n]*)(?:\z)?~i', '$1[me=' . $user_info['name'] . ']$2[/me]', $message); |
|
| 122 | + } |
|
| 115 | 123 | |
| 116 | 124 | if (!$previewing && strpos($message, '[html]') !== false) |
| 117 | 125 | { |
| 118 | - if (allowedTo('admin_forum')) |
|
| 119 | - $message = preg_replace_callback('~\[html\](.+?)\[/html\]~is', function($m) { |
|
| 126 | + if (allowedTo('admin_forum')) { |
|
| 127 | + $message = preg_replace_callback('~\[html\](.+?)\[/html\]~is', function($m) { |
|
| 120 | 128 | return '[html]' . strtr(un_htmlspecialchars($m[1]), array("\n" => ' ', ' ' => '  ', '[' => '[', ']' => ']')) . '[/html]'; |
| 129 | + } |
|
| 121 | 130 | }, $message); |
| 122 | 131 | |
| 123 | 132 | // We should edit them out, or else if an admin edits the message they will get shown... |
| 124 | 133 | else |
| 125 | 134 | { |
| 126 | - while (strpos($message, '[html]') !== false) |
|
| 127 | - $message = preg_replace('~\[[/]?html\]~i', '', $message); |
|
| 135 | + while (strpos($message, '[html]') !== false) { |
|
| 136 | + $message = preg_replace('~\[[/]?html\]~i', '', $message); |
|
| 137 | + } |
|
| 128 | 138 | } |
| 129 | 139 | } |
| 130 | 140 | |
@@ -146,10 +156,12 @@ discard block |
||
| 146 | 156 | |
| 147 | 157 | $list_open = substr_count($message, '[list]') + substr_count($message, '[list '); |
| 148 | 158 | $list_close = substr_count($message, '[/list]'); |
| 149 | - if ($list_close - $list_open > 0) |
|
| 150 | - $message = str_repeat('[list]', $list_close - $list_open) . $message; |
|
| 151 | - if ($list_open - $list_close > 0) |
|
| 152 | - $message = $message . str_repeat('[/list]', $list_open - $list_close); |
|
| 159 | + if ($list_close - $list_open > 0) { |
|
| 160 | + $message = str_repeat('[list]', $list_close - $list_open) . $message; |
|
| 161 | + } |
|
| 162 | + if ($list_open - $list_close > 0) { |
|
| 163 | + $message = $message . str_repeat('[/list]', $list_open - $list_close); |
|
| 164 | + } |
|
| 153 | 165 | |
| 154 | 166 | $mistake_fixes = array( |
| 155 | 167 | // Find [table]s not followed by [tr]. |
@@ -198,8 +210,9 @@ discard block |
||
| 198 | 210 | ); |
| 199 | 211 | |
| 200 | 212 | // Fix up some use of tables without [tr]s, etc. (it has to be done more than once to catch it all.) |
| 201 | - for ($j = 0; $j < 3; $j++) |
|
| 202 | - $message = preg_replace(array_keys($mistake_fixes), $mistake_fixes, $message); |
|
| 213 | + for ($j = 0; $j < 3; $j++) { |
|
| 214 | + $message = preg_replace(array_keys($mistake_fixes), $mistake_fixes, $message); |
|
| 215 | + } |
|
| 203 | 216 | |
| 204 | 217 | // Remove empty bbc from the sections outside the code tags |
| 205 | 218 | $allowedEmpty = array( |
@@ -209,24 +222,28 @@ discard block |
||
| 209 | 222 | |
| 210 | 223 | require_once($sourcedir . '/Subs.php'); |
| 211 | 224 | |
| 212 | - foreach (($codes = parse_bbc(false)) as $code) |
|
| 213 | - if (!in_array($code['tag'], $allowedEmpty)) |
|
| 225 | + foreach (($codes = parse_bbc(false)) as $code) { |
|
| 226 | + if (!in_array($code['tag'], $allowedEmpty)) |
|
| 214 | 227 | $alltags[] = $code['tag']; |
| 228 | + } |
|
| 215 | 229 | |
| 216 | 230 | $alltags_regex = '\b' . implode("\b|\b", array_unique($alltags)) . '\b'; |
| 217 | 231 | |
| 218 | - while (preg_match('~\[(' . $alltags_regex . ')[^\]]*\]\s*\[/\1\]\s?~i', $message)) |
|
| 219 | - $message = preg_replace('~\[(' . $alltags_regex . ')[^\]]*\]\s*\[/\1\]\s?~i', '', $message); |
|
| 232 | + while (preg_match('~\[(' . $alltags_regex . ')[^\]]*\]\s*\[/\1\]\s?~i', $message)) { |
|
| 233 | + $message = preg_replace('~\[(' . $alltags_regex . ')[^\]]*\]\s*\[/\1\]\s?~i', '', $message); |
|
| 234 | + } |
|
| 220 | 235 | |
| 221 | 236 | // Restore code blocks |
| 222 | - if (!empty($code_tags)) |
|
| 223 | - $message = str_replace(array_keys($code_tags), array_values($code_tags), $message); |
|
| 237 | + if (!empty($code_tags)) { |
|
| 238 | + $message = str_replace(array_keys($code_tags), array_values($code_tags), $message); |
|
| 239 | + } |
|
| 224 | 240 | |
| 225 | 241 | // Restore white space entities |
| 226 | - if (!$previewing) |
|
| 227 | - $message = strtr($message, array(' ' => ' ', "\n" => '<br>', $context['utf8'] ? "\xC2\xA0" : "\xA0" => ' ')); |
|
| 228 | - else |
|
| 229 | - $message = strtr($message, array(' ' => ' ', $context['utf8'] ? "\xC2\xA0" : "\xA0" => ' ')); |
|
| 242 | + if (!$previewing) { |
|
| 243 | + $message = strtr($message, array(' ' => ' ', "\n" => '<br>', $context['utf8'] ? "\xC2\xA0" : "\xA0" => ' ')); |
|
| 244 | + } else { |
|
| 245 | + $message = strtr($message, array(' ' => ' ', $context['utf8'] ? "\xC2\xA0" : "\xA0" => ' ')); |
|
| 246 | + } |
|
| 230 | 247 | |
| 231 | 248 | // Now let's quickly clean up things that will slow our parser (which are common in posted code.) |
| 232 | 249 | $message = strtr($message, array('[]' => '[]', '['' => '['')); |
@@ -269,8 +286,9 @@ discard block |
||
| 269 | 286 | return "[time]" . timeformat("$m[1]", false) . "[/time]"; |
| 270 | 287 | }, $message); |
| 271 | 288 | |
| 272 | - if (!empty($code_tags)) |
|
| 273 | - $message = str_replace(array_keys($code_tags), array_values($code_tags), $message); |
|
| 289 | + if (!empty($code_tags)) { |
|
| 290 | + $message = str_replace(array_keys($code_tags), array_values($code_tags), $message); |
|
| 291 | + } |
|
| 274 | 292 | |
| 275 | 293 | // Change breaks back to \n's and &nsbp; back to spaces. |
| 276 | 294 | return preg_replace('~<br( /)?' . '>~', "\n", str_replace(' ', ' ', $message)); |
@@ -351,8 +369,9 @@ discard block |
||
| 351 | 369 | ); |
| 352 | 370 | |
| 353 | 371 | // Fix each type of tag. |
| 354 | - foreach ($fixArray as $param) |
|
| 355 | - fixTag($message, $param['tag'], $param['protocols'], $param['embeddedUrl'], $param['hasEqualSign'], !empty($param['hasExtra'])); |
|
| 372 | + foreach ($fixArray as $param) { |
|
| 373 | + fixTag($message, $param['tag'], $param['protocols'], $param['embeddedUrl'], $param['hasEqualSign'], !empty($param['hasExtra'])); |
|
| 374 | + } |
|
| 356 | 375 | |
| 357 | 376 | // Now fix possible security problems with images loading links automatically... |
| 358 | 377 | $message = preg_replace_callback('~(\[img.*?\])(.+?)\[/img\]~is', function($m) |
@@ -388,16 +407,19 @@ discard block |
||
| 388 | 407 | $desired_height = $height; |
| 389 | 408 | } |
| 390 | 409 | // Scale it to the width... |
| 391 | - elseif (empty($desired_width) && !empty($height)) |
|
| 392 | - $desired_width = (int) (($desired_height * $width) / $height); |
|
| 410 | + elseif (empty($desired_width) && !empty($height)) { |
|
| 411 | + $desired_width = (int) (($desired_height * $width) / $height); |
|
| 412 | + } |
|
| 393 | 413 | // Scale if to the height. |
| 394 | - elseif (!empty($width)) |
|
| 395 | - $desired_height = (int) (($desired_width * $height) / $width); |
|
| 414 | + elseif (!empty($width)) { |
|
| 415 | + $desired_height = (int) (($desired_width * $height) / $width); |
|
| 416 | + } |
|
| 396 | 417 | } |
| 397 | 418 | |
| 398 | 419 | // If the width and height are fine, just continue along... |
| 399 | - if ($desired_width <= $modSettings['max_image_width'] && $desired_height <= $modSettings['max_image_height']) |
|
| 400 | - continue; |
|
| 420 | + if ($desired_width <= $modSettings['max_image_width'] && $desired_height <= $modSettings['max_image_height']) { |
|
| 421 | + continue; |
|
| 422 | + } |
|
| 401 | 423 | |
| 402 | 424 | // Too bad, it's too wide. Make it as wide as the maximum. |
| 403 | 425 | if ($desired_width > $modSettings['max_image_width'] && !empty($modSettings['max_image_width'])) |
@@ -417,8 +439,9 @@ discard block |
||
| 417 | 439 | } |
| 418 | 440 | |
| 419 | 441 | // If any img tags were actually changed... |
| 420 | - if (!empty($replaces)) |
|
| 421 | - $message = strtr($message, $replaces); |
|
| 442 | + if (!empty($replaces)) { |
|
| 443 | + $message = strtr($message, $replaces); |
|
| 444 | + } |
|
| 422 | 445 | } |
| 423 | 446 | } |
| 424 | 447 | |
@@ -437,10 +460,11 @@ discard block |
||
| 437 | 460 | { |
| 438 | 461 | global $boardurl, $scripturl; |
| 439 | 462 | |
| 440 | - if (preg_match('~^([^:]+://[^/]+)~', $boardurl, $match) != 0) |
|
| 441 | - $domain_url = $match[1]; |
|
| 442 | - else |
|
| 443 | - $domain_url = $boardurl . '/'; |
|
| 463 | + if (preg_match('~^([^:]+://[^/]+)~', $boardurl, $match) != 0) { |
|
| 464 | + $domain_url = $match[1]; |
|
| 465 | + } else { |
|
| 466 | + $domain_url = $boardurl . '/'; |
|
| 467 | + } |
|
| 444 | 468 | |
| 445 | 469 | $replaces = array(); |
| 446 | 470 | |
@@ -448,11 +472,11 @@ discard block |
||
| 448 | 472 | { |
| 449 | 473 | $quoted = preg_match('~\[(' . $myTag . ')="~', $message); |
| 450 | 474 | preg_match_all('~\[(' . $myTag . ')=' . ($quoted ? '"(.*?)"' : '([^\]]*?)') . '\](?:(.+?)\[/(' . $myTag . ')\])?~is', $message, $matches); |
| 475 | + } elseif ($hasEqualSign) { |
|
| 476 | + preg_match_all('~\[(' . $myTag . ')=([^\]]*?)\](?:(.+?)\[/(' . $myTag . ')\])?~is', $message, $matches); |
|
| 477 | + } else { |
|
| 478 | + preg_match_all('~\[(' . $myTag . ($hasExtra ? '(?:[^\]]*?)' : '') . ')\](.+?)\[/(' . $myTag . ')\]~is', $message, $matches); |
|
| 451 | 479 | } |
| 452 | - elseif ($hasEqualSign) |
|
| 453 | - preg_match_all('~\[(' . $myTag . ')=([^\]]*?)\](?:(.+?)\[/(' . $myTag . ')\])?~is', $message, $matches); |
|
| 454 | - else |
|
| 455 | - preg_match_all('~\[(' . $myTag . ($hasExtra ? '(?:[^\]]*?)' : '') . ')\](.+?)\[/(' . $myTag . ')\]~is', $message, $matches); |
|
| 456 | 480 | |
| 457 | 481 | foreach ($matches[0] as $k => $dummy) |
| 458 | 482 | { |
@@ -465,49 +489,53 @@ discard block |
||
| 465 | 489 | foreach ($protocols as $protocol) |
| 466 | 490 | { |
| 467 | 491 | $found = strncasecmp($replace, $protocol . '://', strlen($protocol) + 3) === 0; |
| 468 | - if ($found) |
|
| 469 | - break; |
|
| 492 | + if ($found) { |
|
| 493 | + break; |
|
| 494 | + } |
|
| 470 | 495 | } |
| 471 | 496 | |
| 472 | 497 | if (!$found && $protocols[0] == 'http') |
| 473 | 498 | { |
| 474 | - if (substr($replace, 0, 1) == '/' && substr($replace, 0, 2) != '//') |
|
| 475 | - $replace = $domain_url . $replace; |
|
| 476 | - elseif (substr($replace, 0, 1) == '?') |
|
| 477 | - $replace = $scripturl . $replace; |
|
| 478 | - elseif (substr($replace, 0, 1) == '#' && $embeddedUrl) |
|
| 499 | + if (substr($replace, 0, 1) == '/' && substr($replace, 0, 2) != '//') { |
|
| 500 | + $replace = $domain_url . $replace; |
|
| 501 | + } elseif (substr($replace, 0, 1) == '?') { |
|
| 502 | + $replace = $scripturl . $replace; |
|
| 503 | + } elseif (substr($replace, 0, 1) == '#' && $embeddedUrl) |
|
| 479 | 504 | { |
| 480 | 505 | $replace = '#' . preg_replace('~[^A-Za-z0-9_\-#]~', '', substr($replace, 1)); |
| 481 | 506 | $this_tag = 'iurl'; |
| 482 | 507 | $this_close = 'iurl'; |
| 508 | + } elseif (substr($replace, 0, 2) != '//') { |
|
| 509 | + $replace = $protocols[0] . '://' . $replace; |
|
| 483 | 510 | } |
| 484 | - elseif (substr($replace, 0, 2) != '//') |
|
| 485 | - $replace = $protocols[0] . '://' . $replace; |
|
| 486 | - } |
|
| 487 | - elseif (!$found && $protocols[0] == 'ftp') |
|
| 488 | - $replace = $protocols[0] . '://' . preg_replace('~^(?!ftps?)[^:]+://~', '', $replace); |
|
| 489 | - elseif (!$found) |
|
| 490 | - $replace = $protocols[0] . '://' . $replace; |
|
| 491 | - |
|
| 492 | - if ($hasEqualSign && $embeddedUrl) |
|
| 493 | - $replaces[$matches[0][$k]] = '[' . $this_tag . '="' . $replace . '"]' . (empty($matches[4][$k]) ? '' : $matches[3][$k] . '[/' . $this_close . ']'); |
|
| 494 | - elseif ($hasEqualSign) |
|
| 495 | - $replaces['[' . $matches[1][$k] . '=' . $matches[2][$k] . ']'] = '[' . $this_tag . '=' . $replace . ']'; |
|
| 496 | - elseif ($embeddedUrl) |
|
| 497 | - $replaces['[' . $matches[1][$k] . ']' . $matches[2][$k] . '[/' . $matches[3][$k] . ']'] = '[' . $this_tag . '=' . $replace . ']' . $matches[2][$k] . '[/' . $this_close . ']'; |
|
| 498 | - else |
|
| 499 | - $replaces['[' . $matches[1][$k] . ']' . $matches[2][$k] . '[/' . $matches[3][$k] . ']'] = '[' . $this_tag . ']' . $replace . '[/' . $this_close . ']'; |
|
| 511 | + } elseif (!$found && $protocols[0] == 'ftp') { |
|
| 512 | + $replace = $protocols[0] . '://' . preg_replace('~^(?!ftps?)[^:]+://~', '', $replace); |
|
| 513 | + } elseif (!$found) { |
|
| 514 | + $replace = $protocols[0] . '://' . $replace; |
|
| 515 | + } |
|
| 516 | + |
|
| 517 | + if ($hasEqualSign && $embeddedUrl) { |
|
| 518 | + $replaces[$matches[0][$k]] = '[' . $this_tag . '="' . $replace . '"]' . (empty($matches[4][$k]) ? '' : $matches[3][$k] . '[/' . $this_close . ']'); |
|
| 519 | + } elseif ($hasEqualSign) { |
|
| 520 | + $replaces['[' . $matches[1][$k] . '=' . $matches[2][$k] . ']'] = '[' . $this_tag . '=' . $replace . ']'; |
|
| 521 | + } elseif ($embeddedUrl) { |
|
| 522 | + $replaces['[' . $matches[1][$k] . ']' . $matches[2][$k] . '[/' . $matches[3][$k] . ']'] = '[' . $this_tag . '=' . $replace . ']' . $matches[2][$k] . '[/' . $this_close . ']'; |
|
| 523 | + } else { |
|
| 524 | + $replaces['[' . $matches[1][$k] . ']' . $matches[2][$k] . '[/' . $matches[3][$k] . ']'] = '[' . $this_tag . ']' . $replace . '[/' . $this_close . ']'; |
|
| 525 | + } |
|
| 500 | 526 | } |
| 501 | 527 | |
| 502 | 528 | foreach ($replaces as $k => $v) |
| 503 | 529 | { |
| 504 | - if ($k == $v) |
|
| 505 | - unset($replaces[$k]); |
|
| 530 | + if ($k == $v) { |
|
| 531 | + unset($replaces[$k]); |
|
| 532 | + } |
|
| 506 | 533 | } |
| 507 | 534 | |
| 508 | - if (!empty($replaces)) |
|
| 509 | - $message = strtr($message, $replaces); |
|
| 510 | -} |
|
| 535 | + if (!empty($replaces)) { |
|
| 536 | + $message = strtr($message, $replaces); |
|
| 537 | + } |
|
| 538 | + } |
|
| 511 | 539 | |
| 512 | 540 | /** |
| 513 | 541 | * This function sends an email to the specified recipient(s). |
@@ -551,8 +579,9 @@ discard block |
||
| 551 | 579 | } |
| 552 | 580 | |
| 553 | 581 | // Nothing left? Nothing else to do |
| 554 | - if (empty($to_array)) |
|
| 555 | - return true; |
|
| 582 | + if (empty($to_array)) { |
|
| 583 | + return true; |
|
| 584 | + } |
|
| 556 | 585 | |
| 557 | 586 | // Once upon a time, Hotmail could not interpret non-ASCII mails. |
| 558 | 587 | // In honour of those days, it's still called the 'hotmail fix'. |
@@ -569,15 +598,17 @@ discard block |
||
| 569 | 598 | } |
| 570 | 599 | |
| 571 | 600 | // Call this function recursively for the hotmail addresses. |
| 572 | - if (!empty($hotmail_to)) |
|
| 573 | - $mail_result = sendmail($hotmail_to, $subject, $message, $from, $message_id, $send_html, $priority, true, $is_private); |
|
| 601 | + if (!empty($hotmail_to)) { |
|
| 602 | + $mail_result = sendmail($hotmail_to, $subject, $message, $from, $message_id, $send_html, $priority, true, $is_private); |
|
| 603 | + } |
|
| 574 | 604 | |
| 575 | 605 | // The remaining addresses no longer need the fix. |
| 576 | 606 | $hotmail_fix = false; |
| 577 | 607 | |
| 578 | 608 | // No other addresses left? Return instantly. |
| 579 | - if (empty($to_array)) |
|
| 580 | - return $mail_result; |
|
| 609 | + if (empty($to_array)) { |
|
| 610 | + return $mail_result; |
|
| 611 | + } |
|
| 581 | 612 | } |
| 582 | 613 | |
| 583 | 614 | // Get rid of entities. |
@@ -602,13 +633,15 @@ discard block |
||
| 602 | 633 | $headers .= 'Return-Path: ' . (empty($modSettings['mail_from']) ? $webmaster_email : $modSettings['mail_from']) . $line_break; |
| 603 | 634 | $headers .= 'Date: ' . gmdate('D, d M Y H:i:s') . ' -0000' . $line_break; |
| 604 | 635 | |
| 605 | - if ($message_id !== null && empty($modSettings['mail_no_message_id'])) |
|
| 606 | - $headers .= 'Message-ID: <' . md5($scripturl . microtime()) . '-' . $message_id . strstr(empty($modSettings['mail_from']) ? $webmaster_email : $modSettings['mail_from'], '@') . '>' . $line_break; |
|
| 636 | + if ($message_id !== null && empty($modSettings['mail_no_message_id'])) { |
|
| 637 | + $headers .= 'Message-ID: <' . md5($scripturl . microtime()) . '-' . $message_id . strstr(empty($modSettings['mail_from']) ? $webmaster_email : $modSettings['mail_from'], '@') . '>' . $line_break; |
|
| 638 | + } |
|
| 607 | 639 | $headers .= 'X-Mailer: SMF' . $line_break; |
| 608 | 640 | |
| 609 | 641 | // Pass this to the integration before we start modifying the output -- it'll make it easier later. |
| 610 | - if (in_array(false, call_integration_hook('integrate_outgoing_email', array(&$subject, &$message, &$headers, &$to_array)), true)) |
|
| 611 | - return false; |
|
| 642 | + if (in_array(false, call_integration_hook('integrate_outgoing_email', array(&$subject, &$message, &$headers, &$to_array)), true)) { |
|
| 643 | + return false; |
|
| 644 | + } |
|
| 612 | 645 | |
| 613 | 646 | // Save the original message... |
| 614 | 647 | $orig_message = $message; |
@@ -657,17 +690,19 @@ discard block |
||
| 657 | 690 | } |
| 658 | 691 | |
| 659 | 692 | // Are we using the mail queue, if so this is where we butt in... |
| 660 | - if ($priority != 0) |
|
| 661 | - return AddMailQueue(false, $to_array, $subject, $message, $headers, $send_html, $priority, $is_private); |
|
| 693 | + if ($priority != 0) { |
|
| 694 | + return AddMailQueue(false, $to_array, $subject, $message, $headers, $send_html, $priority, $is_private); |
|
| 695 | + } |
|
| 662 | 696 | |
| 663 | 697 | // If it's a priority mail, send it now - note though that this should NOT be used for sending many at once. |
| 664 | 698 | elseif (!empty($modSettings['mail_limit'])) |
| 665 | 699 | { |
| 666 | 700 | list ($last_mail_time, $mails_this_minute) = @explode('|', $modSettings['mail_recent']); |
| 667 | - if (empty($mails_this_minute) || time() > $last_mail_time + 60) |
|
| 668 | - $new_queue_stat = time() . '|' . 1; |
|
| 669 | - else |
|
| 670 | - $new_queue_stat = $last_mail_time . '|' . ((int) $mails_this_minute + 1); |
|
| 701 | + if (empty($mails_this_minute) || time() > $last_mail_time + 60) { |
|
| 702 | + $new_queue_stat = time() . '|' . 1; |
|
| 703 | + } else { |
|
| 704 | + $new_queue_stat = $last_mail_time . '|' . ((int) $mails_this_minute + 1); |
|
| 705 | + } |
|
| 671 | 706 | |
| 672 | 707 | updateSettings(array('mail_recent' => $new_queue_stat)); |
| 673 | 708 | } |
@@ -692,12 +727,13 @@ discard block |
||
| 692 | 727 | |
| 693 | 728 | // Wait, wait, I'm still sending here! |
| 694 | 729 | @set_time_limit(300); |
| 695 | - if (function_exists('apache_reset_timeout')) |
|
| 696 | - @apache_reset_timeout(); |
|
| 730 | + if (function_exists('apache_reset_timeout')) { |
|
| 731 | + @apache_reset_timeout(); |
|
| 732 | + } |
|
| 697 | 733 | } |
| 734 | + } else { |
|
| 735 | + $mail_result = $mail_result && smtp_mail($to_array, $subject, $message, $headers); |
|
| 698 | 736 | } |
| 699 | - else |
|
| 700 | - $mail_result = $mail_result && smtp_mail($to_array, $subject, $message, $headers); |
|
| 701 | 737 | |
| 702 | 738 | // Everything go smoothly? |
| 703 | 739 | return $mail_result; |
@@ -723,8 +759,9 @@ discard block |
||
| 723 | 759 | static $cur_insert = array(); |
| 724 | 760 | static $cur_insert_len = 0; |
| 725 | 761 | |
| 726 | - if ($cur_insert_len == 0) |
|
| 727 | - $cur_insert = array(); |
|
| 762 | + if ($cur_insert_len == 0) { |
|
| 763 | + $cur_insert = array(); |
|
| 764 | + } |
|
| 728 | 765 | |
| 729 | 766 | // If we're flushing, make the final inserts - also if we're near the MySQL length limit! |
| 730 | 767 | if (($flush || $cur_insert_len > 800000) && !empty($cur_insert)) |
@@ -799,8 +836,9 @@ discard block |
||
| 799 | 836 | } |
| 800 | 837 | |
| 801 | 838 | // If they are using SSI there is a good chance obExit will never be called. So lets be nice and flush it for them. |
| 802 | - if (SMF === 'SSI' || SMF === 'BACKGROUND') |
|
| 803 | - return AddMailQueue(true); |
|
| 839 | + if (SMF === 'SSI' || SMF === 'BACKGROUND') { |
|
| 840 | + return AddMailQueue(true); |
|
| 841 | + } |
|
| 804 | 842 | |
| 805 | 843 | return true; |
| 806 | 844 | } |
@@ -831,23 +869,26 @@ discard block |
||
| 831 | 869 | 'sent' => array() |
| 832 | 870 | ); |
| 833 | 871 | |
| 834 | - if ($from === null) |
|
| 835 | - $from = array( |
|
| 872 | + if ($from === null) { |
|
| 873 | + $from = array( |
|
| 836 | 874 | 'id' => $user_info['id'], |
| 837 | 875 | 'name' => $user_info['name'], |
| 838 | 876 | 'username' => $user_info['username'] |
| 839 | 877 | ); |
| 878 | + } |
|
| 840 | 879 | |
| 841 | 880 | // This is the one that will go in their inbox. |
| 842 | 881 | $htmlmessage = $smcFunc['htmlspecialchars']($message, ENT_QUOTES); |
| 843 | 882 | preparsecode($htmlmessage); |
| 844 | 883 | $htmlsubject = strtr($smcFunc['htmlspecialchars']($subject), array("\r" => '', "\n" => '', "\t" => '')); |
| 845 | - if ($smcFunc['strlen']($htmlsubject) > 100) |
|
| 846 | - $htmlsubject = $smcFunc['substr']($htmlsubject, 0, 100); |
|
| 884 | + if ($smcFunc['strlen']($htmlsubject) > 100) { |
|
| 885 | + $htmlsubject = $smcFunc['substr']($htmlsubject, 0, 100); |
|
| 886 | + } |
|
| 847 | 887 | |
| 848 | 888 | // Make sure is an array |
| 849 | - if (!is_array($recipients)) |
|
| 850 | - $recipients = array($recipients); |
|
| 889 | + if (!is_array($recipients)) { |
|
| 890 | + $recipients = array($recipients); |
|
| 891 | + } |
|
| 851 | 892 | |
| 852 | 893 | // Integrated PMs |
| 853 | 894 | call_integration_hook('integrate_personal_message', array(&$recipients, &$from, &$subject, &$message)); |
@@ -875,21 +916,23 @@ discard block |
||
| 875 | 916 | 'usernames' => array_keys($usernames), |
| 876 | 917 | ) |
| 877 | 918 | ); |
| 878 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 879 | - if (isset($usernames[$smcFunc['strtolower']($row['member_name'])])) |
|
| 919 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 920 | + if (isset($usernames[$smcFunc['strtolower']($row['member_name'])])) |
|
| 880 | 921 | $usernames[$smcFunc['strtolower']($row['member_name'])] = $row['id_member']; |
| 922 | + } |
|
| 881 | 923 | $smcFunc['db_free_result']($request); |
| 882 | 924 | |
| 883 | 925 | // Replace the usernames with IDs. Drop usernames that couldn't be found. |
| 884 | - foreach ($recipients as $rec_type => $rec) |
|
| 885 | - foreach ($rec as $id => $member) |
|
| 926 | + foreach ($recipients as $rec_type => $rec) { |
|
| 927 | + foreach ($rec as $id => $member) |
|
| 886 | 928 | { |
| 887 | 929 | if (is_numeric($recipients[$rec_type][$id])) |
| 888 | 930 | continue; |
| 931 | + } |
|
| 889 | 932 | |
| 890 | - if (!empty($usernames[$member])) |
|
| 891 | - $recipients[$rec_type][$id] = $usernames[$member]; |
|
| 892 | - else |
|
| 933 | + if (!empty($usernames[$member])) { |
|
| 934 | + $recipients[$rec_type][$id] = $usernames[$member]; |
|
| 935 | + } else |
|
| 893 | 936 | { |
| 894 | 937 | $log['failed'][$id] = sprintf($txt['pm_error_user_not_found'], $recipients[$rec_type][$id]); |
| 895 | 938 | unset($recipients[$rec_type][$id]); |
@@ -927,8 +970,9 @@ discard block |
||
| 927 | 970 | $delete = false; |
| 928 | 971 | foreach ($criteria as $criterium) |
| 929 | 972 | { |
| 930 | - if (($criterium['t'] == 'mid' && $criterium['v'] == $from['id']) || ($criterium['t'] == 'gid' && in_array($criterium['v'], $user_info['groups'])) || ($criterium['t'] == 'sub' && strpos($subject, $criterium['v']) !== false) || ($criterium['t'] == 'msg' && strpos($message, $criterium['v']) !== false)) |
|
| 931 | - $delete = true; |
|
| 973 | + if (($criterium['t'] == 'mid' && $criterium['v'] == $from['id']) || ($criterium['t'] == 'gid' && in_array($criterium['v'], $user_info['groups'])) || ($criterium['t'] == 'sub' && strpos($subject, $criterium['v']) !== false) || ($criterium['t'] == 'msg' && strpos($message, $criterium['v']) !== false)) { |
|
| 974 | + $delete = true; |
|
| 975 | + } |
|
| 932 | 976 | // If we're adding and one criteria don't match then we stop! |
| 933 | 977 | elseif (!$row['is_or']) |
| 934 | 978 | { |
@@ -936,8 +980,9 @@ discard block |
||
| 936 | 980 | break; |
| 937 | 981 | } |
| 938 | 982 | } |
| 939 | - if ($delete) |
|
| 940 | - $deletes[$row['id_member']] = 1; |
|
| 983 | + if ($delete) { |
|
| 984 | + $deletes[$row['id_member']] = 1; |
|
| 985 | + } |
|
| 941 | 986 | } |
| 942 | 987 | $smcFunc['db_free_result']($request); |
| 943 | 988 | |
@@ -952,8 +997,9 @@ discard block |
||
| 952 | 997 | array( |
| 953 | 998 | ) |
| 954 | 999 | ); |
| 955 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 956 | - $message_limit_cache[$row['id_group']] = $row['max_messages']; |
|
| 1000 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 1001 | + $message_limit_cache[$row['id_group']] = $row['max_messages']; |
|
| 1002 | + } |
|
| 957 | 1003 | $smcFunc['db_free_result']($request); |
| 958 | 1004 | } |
| 959 | 1005 | |
@@ -961,8 +1007,9 @@ discard block |
||
| 961 | 1007 | require_once($sourcedir . '/Subs-Members.php'); |
| 962 | 1008 | $pmReadGroups = groupsAllowedTo('pm_read'); |
| 963 | 1009 | |
| 964 | - if (empty($modSettings['permission_enable_deny'])) |
|
| 965 | - $pmReadGroups['denied'] = array(); |
|
| 1010 | + if (empty($modSettings['permission_enable_deny'])) { |
|
| 1011 | + $pmReadGroups['denied'] = array(); |
|
| 1012 | + } |
|
| 966 | 1013 | |
| 967 | 1014 | // Load their alert preferences |
| 968 | 1015 | require_once($sourcedir . '/Subs-Notify.php'); |
@@ -994,8 +1041,9 @@ discard block |
||
| 994 | 1041 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
| 995 | 1042 | { |
| 996 | 1043 | // Don't do anything for members to be deleted! |
| 997 | - if (isset($deletes[$row['id_member']])) |
|
| 998 | - continue; |
|
| 1044 | + if (isset($deletes[$row['id_member']])) { |
|
| 1045 | + continue; |
|
| 1046 | + } |
|
| 999 | 1047 | |
| 1000 | 1048 | // Load the preferences for this member (if any) |
| 1001 | 1049 | $prefs = !empty($notifyPrefs[$row['id_member']]) ? $notifyPrefs[$row['id_member']] : array(); |
@@ -1016,8 +1064,9 @@ discard block |
||
| 1016 | 1064 | { |
| 1017 | 1065 | foreach ($groups as $id) |
| 1018 | 1066 | { |
| 1019 | - if (isset($message_limit_cache[$id]) && $message_limit != 0 && $message_limit < $message_limit_cache[$id]) |
|
| 1020 | - $message_limit = $message_limit_cache[$id]; |
|
| 1067 | + if (isset($message_limit_cache[$id]) && $message_limit != 0 && $message_limit < $message_limit_cache[$id]) { |
|
| 1068 | + $message_limit = $message_limit_cache[$id]; |
|
| 1069 | + } |
|
| 1021 | 1070 | } |
| 1022 | 1071 | |
| 1023 | 1072 | if ($message_limit > 0 && $message_limit <= $row['instant_messages']) |
@@ -1065,8 +1114,9 @@ discard block |
||
| 1065 | 1114 | $smcFunc['db_free_result']($request); |
| 1066 | 1115 | |
| 1067 | 1116 | // Only 'send' the message if there are any recipients left. |
| 1068 | - if (empty($all_to)) |
|
| 1069 | - return $log; |
|
| 1117 | + if (empty($all_to)) { |
|
| 1118 | + return $log; |
|
| 1119 | + } |
|
| 1070 | 1120 | |
| 1071 | 1121 | // Insert the message itself and then grab the last insert id. |
| 1072 | 1122 | $id_pm = $smcFunc['db_insert']('', |
@@ -1087,8 +1137,8 @@ discard block |
||
| 1087 | 1137 | if (!empty($id_pm)) |
| 1088 | 1138 | { |
| 1089 | 1139 | // If this is new we need to set it part of it's own conversation. |
| 1090 | - if (empty($pm_head)) |
|
| 1091 | - $smcFunc['db_query']('', ' |
|
| 1140 | + if (empty($pm_head)) { |
|
| 1141 | + $smcFunc['db_query']('', ' |
|
| 1092 | 1142 | UPDATE {db_prefix}personal_messages |
| 1093 | 1143 | SET id_pm_head = {int:id_pm_head} |
| 1094 | 1144 | WHERE id_pm = {int:id_pm_head}', |
@@ -1096,6 +1146,7 @@ discard block |
||
| 1096 | 1146 | 'id_pm_head' => $id_pm, |
| 1097 | 1147 | ) |
| 1098 | 1148 | ); |
| 1149 | + } |
|
| 1099 | 1150 | |
| 1100 | 1151 | // Some people think manually deleting personal_messages is fun... it's not. We protect against it though :) |
| 1101 | 1152 | $smcFunc['db_query']('', ' |
@@ -1111,8 +1162,9 @@ discard block |
||
| 1111 | 1162 | foreach ($all_to as $to) |
| 1112 | 1163 | { |
| 1113 | 1164 | $insertRows[] = array($id_pm, $to, in_array($to, $recipients['bcc']) ? 1 : 0, isset($deletes[$to]) ? 1 : 0, 1); |
| 1114 | - if (!in_array($to, $recipients['bcc'])) |
|
| 1115 | - $to_list[] = $to; |
|
| 1165 | + if (!in_array($to, $recipients['bcc'])) { |
|
| 1166 | + $to_list[] = $to; |
|
| 1167 | + } |
|
| 1116 | 1168 | } |
| 1117 | 1169 | |
| 1118 | 1170 | $smcFunc['db_insert']('insert', |
@@ -1130,9 +1182,9 @@ discard block |
||
| 1130 | 1182 | { |
| 1131 | 1183 | censorText($message); |
| 1132 | 1184 | $message = trim(un_htmlspecialchars(strip_tags(strtr(parse_bbc($smcFunc['htmlspecialchars']($message), false), array('<br>' => "\n", '</div>' => "\n", '</li>' => "\n", '[' => '[', ']' => ']'))))); |
| 1185 | + } else { |
|
| 1186 | + $message = ''; |
|
| 1133 | 1187 | } |
| 1134 | - else |
|
| 1135 | - $message = ''; |
|
| 1136 | 1188 | |
| 1137 | 1189 | $to_names = array(); |
| 1138 | 1190 | if (count($to_list) > 1) |
@@ -1145,8 +1197,9 @@ discard block |
||
| 1145 | 1197 | 'to_members' => $to_list, |
| 1146 | 1198 | ) |
| 1147 | 1199 | ); |
| 1148 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 1149 | - $to_names[] = un_htmlspecialchars($row['real_name']); |
|
| 1200 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 1201 | + $to_names[] = un_htmlspecialchars($row['real_name']); |
|
| 1202 | + } |
|
| 1150 | 1203 | $smcFunc['db_free_result']($request); |
| 1151 | 1204 | } |
| 1152 | 1205 | $replacements = array( |
@@ -1174,11 +1227,13 @@ discard block |
||
| 1174 | 1227 | loadLanguage('index+PersonalMessage'); |
| 1175 | 1228 | |
| 1176 | 1229 | // Add one to their unread and read message counts. |
| 1177 | - foreach ($all_to as $k => $id) |
|
| 1178 | - if (isset($deletes[$id])) |
|
| 1230 | + foreach ($all_to as $k => $id) { |
|
| 1231 | + if (isset($deletes[$id])) |
|
| 1179 | 1232 | unset($all_to[$k]); |
| 1180 | - if (!empty($all_to)) |
|
| 1181 | - updateMemberData($all_to, array('instant_messages' => '+', 'unread_messages' => '+', 'new_pm' => 1)); |
|
| 1233 | + } |
|
| 1234 | + if (!empty($all_to)) { |
|
| 1235 | + updateMemberData($all_to, array('instant_messages' => '+', 'unread_messages' => '+', 'new_pm' => 1)); |
|
| 1236 | + } |
|
| 1182 | 1237 | |
| 1183 | 1238 | return $log; |
| 1184 | 1239 | } |
@@ -1208,15 +1263,17 @@ discard block |
||
| 1208 | 1263 | // Let's, for now, assume there are only 'ish characters. |
| 1209 | 1264 | $simple = true; |
| 1210 | 1265 | |
| 1211 | - foreach ($matches[1] as $entity) |
|
| 1212 | - if ($entity > 128) |
|
| 1266 | + foreach ($matches[1] as $entity) { |
|
| 1267 | + if ($entity > 128) |
|
| 1213 | 1268 | $simple = false; |
| 1269 | + } |
|
| 1214 | 1270 | unset($matches); |
| 1215 | 1271 | |
| 1216 | - if ($simple) |
|
| 1217 | - $string = preg_replace_callback('~&#(\d{3,8});~', function($m) |
|
| 1272 | + if ($simple) { |
|
| 1273 | + $string = preg_replace_callback('~&#(\d{3,8});~', function($m) |
|
| 1218 | 1274 | { |
| 1219 | 1275 | return chr("$m[1]"); |
| 1276 | + } |
|
| 1220 | 1277 | }, $string); |
| 1221 | 1278 | else |
| 1222 | 1279 | { |
@@ -1224,8 +1281,9 @@ discard block |
||
| 1224 | 1281 | if (!$context['utf8'] && function_exists('iconv')) |
| 1225 | 1282 | { |
| 1226 | 1283 | $newstring = @iconv($context['character_set'], 'UTF-8', $string); |
| 1227 | - if ($newstring) |
|
| 1228 | - $string = $newstring; |
|
| 1284 | + if ($newstring) { |
|
| 1285 | + $string = $newstring; |
|
| 1286 | + } |
|
| 1229 | 1287 | } |
| 1230 | 1288 | |
| 1231 | 1289 | $string = preg_replace_callback('~&#(\d{3,8});~', 'fixchar__callback', $string); |
@@ -1241,23 +1299,25 @@ discard block |
||
| 1241 | 1299 | if (!$context['utf8'] && function_exists('iconv')) |
| 1242 | 1300 | { |
| 1243 | 1301 | $newstring = @iconv($context['character_set'], 'UTF-8', $string); |
| 1244 | - if ($newstring) |
|
| 1245 | - $string = $newstring; |
|
| 1302 | + if ($newstring) { |
|
| 1303 | + $string = $newstring; |
|
| 1304 | + } |
|
| 1246 | 1305 | } |
| 1247 | 1306 | |
| 1248 | 1307 | $entityConvert = function($m) |
| 1249 | 1308 | { |
| 1250 | 1309 | $c = $m[1]; |
| 1251 | - if (strlen($c) === 1 && ord($c[0]) <= 0x7F) |
|
| 1252 | - return $c; |
|
| 1253 | - elseif (strlen($c) === 2 && ord($c[0]) >= 0xC0 && ord($c[0]) <= 0xDF) |
|
| 1254 | - return "&#" . (((ord($c[0]) ^ 0xC0) << 6) + (ord($c[1]) ^ 0x80)) . ";"; |
|
| 1255 | - elseif (strlen($c) === 3 && ord($c[0]) >= 0xE0 && ord($c[0]) <= 0xEF) |
|
| 1256 | - return "&#" . (((ord($c[0]) ^ 0xE0) << 12) + ((ord($c[1]) ^ 0x80) << 6) + (ord($c[2]) ^ 0x80)) . ";"; |
|
| 1257 | - elseif (strlen($c) === 4 && ord($c[0]) >= 0xF0 && ord($c[0]) <= 0xF7) |
|
| 1258 | - return "&#" . (((ord($c[0]) ^ 0xF0) << 18) + ((ord($c[1]) ^ 0x80) << 12) + ((ord($c[2]) ^ 0x80) << 6) + (ord($c[3]) ^ 0x80)) . ";"; |
|
| 1259 | - else |
|
| 1260 | - return ""; |
|
| 1310 | + if (strlen($c) === 1 && ord($c[0]) <= 0x7F) { |
|
| 1311 | + return $c; |
|
| 1312 | + } elseif (strlen($c) === 2 && ord($c[0]) >= 0xC0 && ord($c[0]) <= 0xDF) { |
|
| 1313 | + return "&#" . (((ord($c[0]) ^ 0xC0) << 6) + (ord($c[1]) ^ 0x80)) . ";"; |
|
| 1314 | + } elseif (strlen($c) === 3 && ord($c[0]) >= 0xE0 && ord($c[0]) <= 0xEF) { |
|
| 1315 | + return "&#" . (((ord($c[0]) ^ 0xE0) << 12) + ((ord($c[1]) ^ 0x80) << 6) + (ord($c[2]) ^ 0x80)) . ";"; |
|
| 1316 | + } elseif (strlen($c) === 4 && ord($c[0]) >= 0xF0 && ord($c[0]) <= 0xF7) { |
|
| 1317 | + return "&#" . (((ord($c[0]) ^ 0xF0) << 18) + ((ord($c[1]) ^ 0x80) << 12) + ((ord($c[2]) ^ 0x80) << 6) + (ord($c[3]) ^ 0x80)) . ";"; |
|
| 1318 | + } else { |
|
| 1319 | + return ""; |
|
| 1320 | + } |
|
| 1261 | 1321 | }; |
| 1262 | 1322 | |
| 1263 | 1323 | // Convert all 'special' characters to HTML entities. |
@@ -1271,19 +1331,20 @@ discard block |
||
| 1271 | 1331 | $string = base64_encode($string); |
| 1272 | 1332 | |
| 1273 | 1333 | // Show the characterset and the transfer-encoding for header strings. |
| 1274 | - if ($with_charset) |
|
| 1275 | - $string = '=?' . $charset . '?B?' . $string . '?='; |
|
| 1334 | + if ($with_charset) { |
|
| 1335 | + $string = '=?' . $charset . '?B?' . $string . '?='; |
|
| 1336 | + } |
|
| 1276 | 1337 | |
| 1277 | 1338 | // Break it up in lines (mail body). |
| 1278 | - else |
|
| 1279 | - $string = chunk_split($string, 76, $line_break); |
|
| 1339 | + else { |
|
| 1340 | + $string = chunk_split($string, 76, $line_break); |
|
| 1341 | + } |
|
| 1280 | 1342 | |
| 1281 | 1343 | return array($charset, $string, 'base64'); |
| 1344 | + } else { |
|
| 1345 | + return array($charset, $string, '7bit'); |
|
| 1346 | + } |
|
| 1282 | 1347 | } |
| 1283 | - |
|
| 1284 | - else |
|
| 1285 | - return array($charset, $string, '7bit'); |
|
| 1286 | -} |
|
| 1287 | 1348 | |
| 1288 | 1349 | /** |
| 1289 | 1350 | * Sends mail, like mail() but over SMTP. |
@@ -1307,8 +1368,9 @@ discard block |
||
| 1307 | 1368 | if ($modSettings['mail_type'] == 3 && $modSettings['smtp_username'] != '' && $modSettings['smtp_password'] != '') |
| 1308 | 1369 | { |
| 1309 | 1370 | $socket = fsockopen($modSettings['smtp_host'], 110, $errno, $errstr, 2); |
| 1310 | - if (!$socket && (substr($modSettings['smtp_host'], 0, 5) == 'smtp.' || substr($modSettings['smtp_host'], 0, 11) == 'ssl://smtp.')) |
|
| 1311 | - $socket = fsockopen(strtr($modSettings['smtp_host'], array('smtp.' => 'pop.')), 110, $errno, $errstr, 2); |
|
| 1371 | + if (!$socket && (substr($modSettings['smtp_host'], 0, 5) == 'smtp.' || substr($modSettings['smtp_host'], 0, 11) == 'ssl://smtp.')) { |
|
| 1372 | + $socket = fsockopen(strtr($modSettings['smtp_host'], array('smtp.' => 'pop.')), 110, $errno, $errstr, 2); |
|
| 1373 | + } |
|
| 1312 | 1374 | |
| 1313 | 1375 | if ($socket) |
| 1314 | 1376 | { |
@@ -1329,8 +1391,9 @@ discard block |
||
| 1329 | 1391 | // Maybe we can still save this? The port might be wrong. |
| 1330 | 1392 | if (substr($modSettings['smtp_host'], 0, 4) == 'ssl:' && (empty($modSettings['smtp_port']) || $modSettings['smtp_port'] == 25)) |
| 1331 | 1393 | { |
| 1332 | - if ($socket = fsockopen($modSettings['smtp_host'], 465, $errno, $errstr, 3)) |
|
| 1333 | - log_error($txt['smtp_port_ssl']); |
|
| 1394 | + if ($socket = fsockopen($modSettings['smtp_host'], 465, $errno, $errstr, 3)) { |
|
| 1395 | + log_error($txt['smtp_port_ssl']); |
|
| 1396 | + } |
|
| 1334 | 1397 | } |
| 1335 | 1398 | |
| 1336 | 1399 | // Unable to connect! Don't show any error message, but just log one and try to continue anyway. |
@@ -1342,20 +1405,23 @@ discard block |
||
| 1342 | 1405 | } |
| 1343 | 1406 | |
| 1344 | 1407 | // Wait for a response of 220, without "-" continuer. |
| 1345 | - if (!server_parse(null, $socket, '220')) |
|
| 1346 | - return false; |
|
| 1408 | + if (!server_parse(null, $socket, '220')) { |
|
| 1409 | + return false; |
|
| 1410 | + } |
|
| 1347 | 1411 | |
| 1348 | 1412 | // Try and determine the servers name, fall back to the mail servers if not found |
| 1349 | 1413 | $helo = false; |
| 1350 | - if (function_exists('gethostname') && gethostname() !== false) |
|
| 1351 | - $helo = gethostname(); |
|
| 1352 | - elseif (function_exists('php_uname')) |
|
| 1353 | - $helo = php_uname('n'); |
|
| 1354 | - elseif (array_key_exists('SERVER_NAME', $_SERVER) && !empty($_SERVER['SERVER_NAME'])) |
|
| 1355 | - $helo = $_SERVER['SERVER_NAME']; |
|
| 1414 | + if (function_exists('gethostname') && gethostname() !== false) { |
|
| 1415 | + $helo = gethostname(); |
|
| 1416 | + } elseif (function_exists('php_uname')) { |
|
| 1417 | + $helo = php_uname('n'); |
|
| 1418 | + } elseif (array_key_exists('SERVER_NAME', $_SERVER) && !empty($_SERVER['SERVER_NAME'])) { |
|
| 1419 | + $helo = $_SERVER['SERVER_NAME']; |
|
| 1420 | + } |
|
| 1356 | 1421 | |
| 1357 | - if (empty($helo)) |
|
| 1358 | - $helo = $modSettings['smtp_host']; |
|
| 1422 | + if (empty($helo)) { |
|
| 1423 | + $helo = $modSettings['smtp_host']; |
|
| 1424 | + } |
|
| 1359 | 1425 | |
| 1360 | 1426 | // SMTP = 1, SMTP - STARTTLS = 2 |
| 1361 | 1427 | if (in_array($modSettings['mail_type'], array(1, 2)) && $modSettings['smtp_username'] != '' && $modSettings['smtp_password'] != '') |
@@ -1367,33 +1433,39 @@ discard block |
||
| 1367 | 1433 | if ($modSettings['mail_type'] == 2 && preg_match("~250( |-)STARTTLS~mi", $response)) |
| 1368 | 1434 | { |
| 1369 | 1435 | // Send STARTTLS to enable encryption |
| 1370 | - if (!server_parse('STARTTLS', $socket, '220')) |
|
| 1371 | - return false; |
|
| 1436 | + if (!server_parse('STARTTLS', $socket, '220')) { |
|
| 1437 | + return false; |
|
| 1438 | + } |
|
| 1372 | 1439 | // Enable the encryption |
| 1373 | - if (!@stream_socket_enable_crypto($socket, true, STREAM_CRYPTO_METHOD_TLS_CLIENT)) |
|
| 1374 | - return false; |
|
| 1440 | + if (!@stream_socket_enable_crypto($socket, true, STREAM_CRYPTO_METHOD_TLS_CLIENT)) { |
|
| 1441 | + return false; |
|
| 1442 | + } |
|
| 1375 | 1443 | // Send the EHLO command again |
| 1376 | - if (!server_parse('EHLO ' . $helo, $socket, null) == '250') |
|
| 1377 | - return false; |
|
| 1444 | + if (!server_parse('EHLO ' . $helo, $socket, null) == '250') { |
|
| 1445 | + return false; |
|
| 1446 | + } |
|
| 1378 | 1447 | } |
| 1379 | 1448 | |
| 1380 | - if (!server_parse('AUTH LOGIN', $socket, '334')) |
|
| 1381 | - return false; |
|
| 1449 | + if (!server_parse('AUTH LOGIN', $socket, '334')) { |
|
| 1450 | + return false; |
|
| 1451 | + } |
|
| 1382 | 1452 | // Send the username and password, encoded. |
| 1383 | - if (!server_parse(base64_encode($modSettings['smtp_username']), $socket, '334')) |
|
| 1384 | - return false; |
|
| 1453 | + if (!server_parse(base64_encode($modSettings['smtp_username']), $socket, '334')) { |
|
| 1454 | + return false; |
|
| 1455 | + } |
|
| 1385 | 1456 | // The password is already encoded ;) |
| 1386 | - if (!server_parse($modSettings['smtp_password'], $socket, '235')) |
|
| 1387 | - return false; |
|
| 1457 | + if (!server_parse($modSettings['smtp_password'], $socket, '235')) { |
|
| 1458 | + return false; |
|
| 1459 | + } |
|
| 1460 | + } elseif (!server_parse('HELO ' . $helo, $socket, '250')) { |
|
| 1461 | + return false; |
|
| 1388 | 1462 | } |
| 1389 | - elseif (!server_parse('HELO ' . $helo, $socket, '250')) |
|
| 1390 | - return false; |
|
| 1391 | - } |
|
| 1392 | - else |
|
| 1463 | + } else |
|
| 1393 | 1464 | { |
| 1394 | 1465 | // Just say "helo". |
| 1395 | - if (!server_parse('HELO ' . $helo, $socket, '250')) |
|
| 1396 | - return false; |
|
| 1466 | + if (!server_parse('HELO ' . $helo, $socket, '250')) { |
|
| 1467 | + return false; |
|
| 1468 | + } |
|
| 1397 | 1469 | } |
| 1398 | 1470 | |
| 1399 | 1471 | // Fix the message for any lines beginning with a period! (the first is ignored, you see.) |
@@ -1406,31 +1478,38 @@ discard block |
||
| 1406 | 1478 | // Reset the connection to send another email. |
| 1407 | 1479 | if ($i != 0) |
| 1408 | 1480 | { |
| 1409 | - if (!server_parse('RSET', $socket, '250')) |
|
| 1410 | - return false; |
|
| 1481 | + if (!server_parse('RSET', $socket, '250')) { |
|
| 1482 | + return false; |
|
| 1483 | + } |
|
| 1411 | 1484 | } |
| 1412 | 1485 | |
| 1413 | 1486 | // From, to, and then start the data... |
| 1414 | - if (!server_parse('MAIL FROM: <' . (empty($modSettings['mail_from']) ? $webmaster_email : $modSettings['mail_from']) . '>', $socket, '250')) |
|
| 1415 | - return false; |
|
| 1416 | - if (!server_parse('RCPT TO: <' . $mail_to . '>', $socket, '250')) |
|
| 1417 | - return false; |
|
| 1418 | - if (!server_parse('DATA', $socket, '354')) |
|
| 1419 | - return false; |
|
| 1487 | + if (!server_parse('MAIL FROM: <' . (empty($modSettings['mail_from']) ? $webmaster_email : $modSettings['mail_from']) . '>', $socket, '250')) { |
|
| 1488 | + return false; |
|
| 1489 | + } |
|
| 1490 | + if (!server_parse('RCPT TO: <' . $mail_to . '>', $socket, '250')) { |
|
| 1491 | + return false; |
|
| 1492 | + } |
|
| 1493 | + if (!server_parse('DATA', $socket, '354')) { |
|
| 1494 | + return false; |
|
| 1495 | + } |
|
| 1420 | 1496 | fputs($socket, 'Subject: ' . $subject . "\r\n"); |
| 1421 | - if (strlen($mail_to) > 0) |
|
| 1422 | - fputs($socket, 'To: <' . $mail_to . '>' . "\r\n"); |
|
| 1497 | + if (strlen($mail_to) > 0) { |
|
| 1498 | + fputs($socket, 'To: <' . $mail_to . '>' . "\r\n"); |
|
| 1499 | + } |
|
| 1423 | 1500 | fputs($socket, $headers . "\r\n\r\n"); |
| 1424 | 1501 | fputs($socket, $message . "\r\n"); |
| 1425 | 1502 | |
| 1426 | 1503 | // Send a ., or in other words "end of data". |
| 1427 | - if (!server_parse('.', $socket, '250')) |
|
| 1428 | - return false; |
|
| 1504 | + if (!server_parse('.', $socket, '250')) { |
|
| 1505 | + return false; |
|
| 1506 | + } |
|
| 1429 | 1507 | |
| 1430 | 1508 | // Almost done, almost done... don't stop me just yet! |
| 1431 | 1509 | @set_time_limit(300); |
| 1432 | - if (function_exists('apache_reset_timeout')) |
|
| 1433 | - @apache_reset_timeout(); |
|
| 1510 | + if (function_exists('apache_reset_timeout')) { |
|
| 1511 | + @apache_reset_timeout(); |
|
| 1512 | + } |
|
| 1434 | 1513 | } |
| 1435 | 1514 | fputs($socket, 'QUIT' . "\r\n"); |
| 1436 | 1515 | fclose($socket); |
@@ -1454,8 +1533,9 @@ discard block |
||
| 1454 | 1533 | { |
| 1455 | 1534 | global $txt; |
| 1456 | 1535 | |
| 1457 | - if ($message !== null) |
|
| 1458 | - fputs($socket, $message . "\r\n"); |
|
| 1536 | + if ($message !== null) { |
|
| 1537 | + fputs($socket, $message . "\r\n"); |
|
| 1538 | + } |
|
| 1459 | 1539 | |
| 1460 | 1540 | // No response yet. |
| 1461 | 1541 | $server_response = ''; |
@@ -1471,8 +1551,9 @@ discard block |
||
| 1471 | 1551 | $response .= $server_response; |
| 1472 | 1552 | } |
| 1473 | 1553 | |
| 1474 | - if ($code === null) |
|
| 1475 | - return substr($server_response, 0, 3); |
|
| 1554 | + if ($code === null) { |
|
| 1555 | + return substr($server_response, 0, 3); |
|
| 1556 | + } |
|
| 1476 | 1557 | |
| 1477 | 1558 | if (substr($server_response, 0, 3) != $code) |
| 1478 | 1559 | { |
@@ -1502,8 +1583,9 @@ discard block |
||
| 1502 | 1583 | // Create a pspell or enchant dictionary resource |
| 1503 | 1584 | $dict = spell_init(); |
| 1504 | 1585 | |
| 1505 | - if (!isset($_POST['spellstring']) || !$dict) |
|
| 1506 | - die; |
|
| 1586 | + if (!isset($_POST['spellstring']) || !$dict) { |
|
| 1587 | + die; |
|
| 1588 | + } |
|
| 1507 | 1589 | |
| 1508 | 1590 | // Construct a bit of Javascript code. |
| 1509 | 1591 | $context['spell_js'] = ' |
@@ -1521,8 +1603,9 @@ discard block |
||
| 1521 | 1603 | $check_word = explode('|', $alphas[$i]); |
| 1522 | 1604 | |
| 1523 | 1605 | // If the word is a known word, or spelled right... |
| 1524 | - if (in_array($smcFunc['strtolower']($check_word[0]), $known_words) || spell_check($dict, $check_word[0]) || !isset($check_word[2])) |
|
| 1525 | - continue; |
|
| 1606 | + if (in_array($smcFunc['strtolower']($check_word[0]), $known_words) || spell_check($dict, $check_word[0]) || !isset($check_word[2])) { |
|
| 1607 | + continue; |
|
| 1608 | + } |
|
| 1526 | 1609 | |
| 1527 | 1610 | // Find the word, and move up the "last occurrence" to here. |
| 1528 | 1611 | $found_words = true; |
@@ -1536,20 +1619,23 @@ discard block |
||
| 1536 | 1619 | if (!empty($suggestions)) |
| 1537 | 1620 | { |
| 1538 | 1621 | // But first check they aren't going to be censored - no naughty words! |
| 1539 | - foreach ($suggestions as $k => $word) |
|
| 1540 | - if ($suggestions[$k] != censorText($word)) |
|
| 1622 | + foreach ($suggestions as $k => $word) { |
|
| 1623 | + if ($suggestions[$k] != censorText($word)) |
|
| 1541 | 1624 | unset($suggestions[$k]); |
| 1625 | + } |
|
| 1542 | 1626 | |
| 1543 | - if (!empty($suggestions)) |
|
| 1544 | - $context['spell_js'] .= '"' . implode('", "', $suggestions) . '"'; |
|
| 1627 | + if (!empty($suggestions)) { |
|
| 1628 | + $context['spell_js'] .= '"' . implode('", "', $suggestions) . '"'; |
|
| 1629 | + } |
|
| 1545 | 1630 | } |
| 1546 | 1631 | |
| 1547 | 1632 | $context['spell_js'] .= ']),'; |
| 1548 | 1633 | } |
| 1549 | 1634 | |
| 1550 | 1635 | // If words were found, take off the last comma. |
| 1551 | - if ($found_words) |
|
| 1552 | - $context['spell_js'] = substr($context['spell_js'], 0, -1); |
|
| 1636 | + if ($found_words) { |
|
| 1637 | + $context['spell_js'] = substr($context['spell_js'], 0, -1); |
|
| 1638 | + } |
|
| 1553 | 1639 | |
| 1554 | 1640 | $context['spell_js'] .= ' |
| 1555 | 1641 | );'; |
@@ -1584,11 +1670,13 @@ discard block |
||
| 1584 | 1670 | global $user_info, $smcFunc; |
| 1585 | 1671 | |
| 1586 | 1672 | // Can't do it if there's no topics. |
| 1587 | - if (empty($topics)) |
|
| 1588 | - return; |
|
| 1673 | + if (empty($topics)) { |
|
| 1674 | + return; |
|
| 1675 | + } |
|
| 1589 | 1676 | // It must be an array - it must! |
| 1590 | - if (!is_array($topics)) |
|
| 1591 | - $topics = array($topics); |
|
| 1677 | + if (!is_array($topics)) { |
|
| 1678 | + $topics = array($topics); |
|
| 1679 | + } |
|
| 1592 | 1680 | |
| 1593 | 1681 | // Get the subject and body... |
| 1594 | 1682 | $result = $smcFunc['db_query']('', ' |
@@ -1636,14 +1724,15 @@ discard block |
||
| 1636 | 1724 | } |
| 1637 | 1725 | $smcFunc['db_free_result']($result); |
| 1638 | 1726 | |
| 1639 | - if (!empty($task_rows)) |
|
| 1640 | - $smcFunc['db_insert']('', |
|
| 1727 | + if (!empty($task_rows)) { |
|
| 1728 | + $smcFunc['db_insert']('', |
|
| 1641 | 1729 | '{db_prefix}background_tasks', |
| 1642 | 1730 | array('task_file' => 'string', 'task_class' => 'string', 'task_data' => 'string', 'claimed_time' => 'int'), |
| 1643 | 1731 | $task_rows, |
| 1644 | 1732 | array('id_task') |
| 1645 | 1733 | ); |
| 1646 | -} |
|
| 1734 | + } |
|
| 1735 | + } |
|
| 1647 | 1736 | |
| 1648 | 1737 | /** |
| 1649 | 1738 | * Create a post, either as new topic (id_topic = 0) or in an existing one. |
@@ -1681,9 +1770,9 @@ discard block |
||
| 1681 | 1770 | $msgOptions['send_notifications'] = isset($msgOptions['send_notifications']) ? (bool) $msgOptions['send_notifications'] : true; |
| 1682 | 1771 | |
| 1683 | 1772 | // We need to know if the topic is approved. If we're told that's great - if not find out. |
| 1684 | - if (!$modSettings['postmod_active']) |
|
| 1685 | - $topicOptions['is_approved'] = true; |
|
| 1686 | - elseif (!empty($topicOptions['id']) && !isset($topicOptions['is_approved'])) |
|
| 1773 | + if (!$modSettings['postmod_active']) { |
|
| 1774 | + $topicOptions['is_approved'] = true; |
|
| 1775 | + } elseif (!empty($topicOptions['id']) && !isset($topicOptions['is_approved'])) |
|
| 1687 | 1776 | { |
| 1688 | 1777 | $request = $smcFunc['db_query']('', ' |
| 1689 | 1778 | SELECT approved |
@@ -1706,8 +1795,7 @@ discard block |
||
| 1706 | 1795 | $posterOptions['id'] = 0; |
| 1707 | 1796 | $posterOptions['name'] = $txt['guest_title']; |
| 1708 | 1797 | $posterOptions['email'] = ''; |
| 1709 | - } |
|
| 1710 | - elseif ($posterOptions['id'] != $user_info['id']) |
|
| 1798 | + } elseif ($posterOptions['id'] != $user_info['id']) |
|
| 1711 | 1799 | { |
| 1712 | 1800 | $request = $smcFunc['db_query']('', ' |
| 1713 | 1801 | SELECT member_name, email_address |
@@ -1725,12 +1813,11 @@ discard block |
||
| 1725 | 1813 | $posterOptions['id'] = 0; |
| 1726 | 1814 | $posterOptions['name'] = $txt['guest_title']; |
| 1727 | 1815 | $posterOptions['email'] = ''; |
| 1816 | + } else { |
|
| 1817 | + list ($posterOptions['name'], $posterOptions['email']) = $smcFunc['db_fetch_row']($request); |
|
| 1728 | 1818 | } |
| 1729 | - else |
|
| 1730 | - list ($posterOptions['name'], $posterOptions['email']) = $smcFunc['db_fetch_row']($request); |
|
| 1731 | 1819 | $smcFunc['db_free_result']($request); |
| 1732 | - } |
|
| 1733 | - else |
|
| 1820 | + } else |
|
| 1734 | 1821 | { |
| 1735 | 1822 | $posterOptions['name'] = $user_info['name']; |
| 1736 | 1823 | $posterOptions['email'] = $user_info['email']; |
@@ -1740,8 +1827,9 @@ discard block |
||
| 1740 | 1827 | if (!empty($modSettings['enable_mentions'])) |
| 1741 | 1828 | { |
| 1742 | 1829 | $msgOptions['mentioned_members'] = Mentions::getMentionedMembers($msgOptions['body']); |
| 1743 | - if (!empty($msgOptions['mentioned_members'])) |
|
| 1744 | - $msgOptions['body'] = Mentions::getBody($msgOptions['body'], $msgOptions['mentioned_members']); |
|
| 1830 | + if (!empty($msgOptions['mentioned_members'])) { |
|
| 1831 | + $msgOptions['body'] = Mentions::getBody($msgOptions['body'], $msgOptions['mentioned_members']); |
|
| 1832 | + } |
|
| 1745 | 1833 | } |
| 1746 | 1834 | |
| 1747 | 1835 | // It's do or die time: forget any user aborts! |
@@ -1774,12 +1862,13 @@ discard block |
||
| 1774 | 1862 | ); |
| 1775 | 1863 | |
| 1776 | 1864 | // Something went wrong creating the message... |
| 1777 | - if (empty($msgOptions['id'])) |
|
| 1778 | - return false; |
|
| 1865 | + if (empty($msgOptions['id'])) { |
|
| 1866 | + return false; |
|
| 1867 | + } |
|
| 1779 | 1868 | |
| 1780 | 1869 | // Fix the attachments. |
| 1781 | - if (!empty($msgOptions['attachments'])) |
|
| 1782 | - $smcFunc['db_query']('', ' |
|
| 1870 | + if (!empty($msgOptions['attachments'])) { |
|
| 1871 | + $smcFunc['db_query']('', ' |
|
| 1783 | 1872 | UPDATE {db_prefix}attachments |
| 1784 | 1873 | SET id_msg = {int:id_msg} |
| 1785 | 1874 | WHERE id_attach IN ({array_int:attachment_list})', |
@@ -1788,6 +1877,7 @@ discard block |
||
| 1788 | 1877 | 'id_msg' => $msgOptions['id'], |
| 1789 | 1878 | ) |
| 1790 | 1879 | ); |
| 1880 | + } |
|
| 1791 | 1881 | |
| 1792 | 1882 | // What if we want to export new posts out to a CMS? |
| 1793 | 1883 | call_integration_hook('integrate_after_create_post', array($msgOptions, $topicOptions, $posterOptions, $message_columns, $message_parameters)); |
@@ -1864,20 +1954,23 @@ discard block |
||
| 1864 | 1954 | 'id_topic' => $topicOptions['id'], |
| 1865 | 1955 | 'counter_increment' => 1, |
| 1866 | 1956 | ); |
| 1867 | - if ($msgOptions['approved']) |
|
| 1868 | - $topics_columns = array( |
|
| 1957 | + if ($msgOptions['approved']) { |
|
| 1958 | + $topics_columns = array( |
|
| 1869 | 1959 | 'id_member_updated = {int:poster_id}', |
| 1870 | 1960 | 'id_last_msg = {int:id_msg}', |
| 1871 | 1961 | 'num_replies = num_replies + {int:counter_increment}', |
| 1872 | 1962 | ); |
| 1873 | - else |
|
| 1874 | - $topics_columns = array( |
|
| 1963 | + } else { |
|
| 1964 | + $topics_columns = array( |
|
| 1875 | 1965 | 'unapproved_posts = unapproved_posts + {int:counter_increment}', |
| 1876 | 1966 | ); |
| 1877 | - if ($topicOptions['lock_mode'] !== null) |
|
| 1878 | - $topics_columns[] = 'locked = {int:locked}'; |
|
| 1879 | - if ($topicOptions['sticky_mode'] !== null) |
|
| 1880 | - $topics_columns[] = 'is_sticky = {int:is_sticky}'; |
|
| 1967 | + } |
|
| 1968 | + if ($topicOptions['lock_mode'] !== null) { |
|
| 1969 | + $topics_columns[] = 'locked = {int:locked}'; |
|
| 1970 | + } |
|
| 1971 | + if ($topicOptions['sticky_mode'] !== null) { |
|
| 1972 | + $topics_columns[] = 'is_sticky = {int:is_sticky}'; |
|
| 1973 | + } |
|
| 1881 | 1974 | |
| 1882 | 1975 | call_integration_hook('integrate_modify_topic', array(&$topics_columns, &$update_parameters, &$msgOptions, &$topicOptions, &$posterOptions)); |
| 1883 | 1976 | |
@@ -1906,8 +1999,8 @@ discard block |
||
| 1906 | 1999 | ); |
| 1907 | 2000 | |
| 1908 | 2001 | // Increase the number of posts and topics on the board. |
| 1909 | - if ($msgOptions['approved']) |
|
| 1910 | - $smcFunc['db_query']('', ' |
|
| 2002 | + if ($msgOptions['approved']) { |
|
| 2003 | + $smcFunc['db_query']('', ' |
|
| 1911 | 2004 | UPDATE {db_prefix}boards |
| 1912 | 2005 | SET num_posts = num_posts + 1' . ($new_topic ? ', num_topics = num_topics + 1' : '') . ' |
| 1913 | 2006 | WHERE id_board = {int:id_board}', |
@@ -1915,7 +2008,7 @@ discard block |
||
| 1915 | 2008 | 'id_board' => $topicOptions['board'], |
| 1916 | 2009 | ) |
| 1917 | 2010 | ); |
| 1918 | - else |
|
| 2011 | + } else |
|
| 1919 | 2012 | { |
| 1920 | 2013 | $smcFunc['db_query']('', ' |
| 1921 | 2014 | UPDATE {db_prefix}boards |
@@ -1985,8 +2078,8 @@ discard block |
||
| 1985 | 2078 | } |
| 1986 | 2079 | } |
| 1987 | 2080 | |
| 1988 | - if ($msgOptions['approved'] && empty($topicOptions['is_approved'])) |
|
| 1989 | - $smcFunc['db_insert']('', |
|
| 2081 | + if ($msgOptions['approved'] && empty($topicOptions['is_approved'])) { |
|
| 2082 | + $smcFunc['db_insert']('', |
|
| 1990 | 2083 | '{db_prefix}background_tasks', |
| 1991 | 2084 | array('task_file' => 'string', 'task_class' => 'string', 'task_data' => 'string', 'claimed_time' => 'int'), |
| 1992 | 2085 | array( |
@@ -1998,19 +2091,22 @@ discard block |
||
| 1998 | 2091 | ), |
| 1999 | 2092 | array('id_task') |
| 2000 | 2093 | ); |
| 2094 | + } |
|
| 2001 | 2095 | |
| 2002 | 2096 | // If there's a custom search index, it may need updating... |
| 2003 | 2097 | require_once($sourcedir . '/Search.php'); |
| 2004 | 2098 | $searchAPI = findSearchAPI(); |
| 2005 | - if (is_callable(array($searchAPI, 'postCreated'))) |
|
| 2006 | - $searchAPI->postCreated($msgOptions, $topicOptions, $posterOptions); |
|
| 2099 | + if (is_callable(array($searchAPI, 'postCreated'))) { |
|
| 2100 | + $searchAPI->postCreated($msgOptions, $topicOptions, $posterOptions); |
|
| 2101 | + } |
|
| 2007 | 2102 | |
| 2008 | 2103 | // Increase the post counter for the user that created the post. |
| 2009 | 2104 | if (!empty($posterOptions['update_post_count']) && !empty($posterOptions['id']) && $msgOptions['approved']) |
| 2010 | 2105 | { |
| 2011 | 2106 | // Are you the one that happened to create this post? |
| 2012 | - if ($user_info['id'] == $posterOptions['id']) |
|
| 2013 | - $user_info['posts']++; |
|
| 2107 | + if ($user_info['id'] == $posterOptions['id']) { |
|
| 2108 | + $user_info['posts']++; |
|
| 2109 | + } |
|
| 2014 | 2110 | updateMemberData($posterOptions['id'], array('posts' => '+')); |
| 2015 | 2111 | } |
| 2016 | 2112 | |
@@ -2018,19 +2114,21 @@ discard block |
||
| 2018 | 2114 | $_SESSION['last_read_topic'] = 0; |
| 2019 | 2115 | |
| 2020 | 2116 | // Better safe than sorry. |
| 2021 | - if (isset($_SESSION['topicseen_cache'][$topicOptions['board']])) |
|
| 2022 | - $_SESSION['topicseen_cache'][$topicOptions['board']]--; |
|
| 2117 | + if (isset($_SESSION['topicseen_cache'][$topicOptions['board']])) { |
|
| 2118 | + $_SESSION['topicseen_cache'][$topicOptions['board']]--; |
|
| 2119 | + } |
|
| 2023 | 2120 | |
| 2024 | 2121 | // Update all the stats so everyone knows about this new topic and message. |
| 2025 | 2122 | updateStats('message', true, $msgOptions['id']); |
| 2026 | 2123 | |
| 2027 | 2124 | // Update the last message on the board assuming it's approved AND the topic is. |
| 2028 | - if ($msgOptions['approved']) |
|
| 2029 | - updateLastMessages($topicOptions['board'], $new_topic || !empty($topicOptions['is_approved']) ? $msgOptions['id'] : 0); |
|
| 2125 | + if ($msgOptions['approved']) { |
|
| 2126 | + updateLastMessages($topicOptions['board'], $new_topic || !empty($topicOptions['is_approved']) ? $msgOptions['id'] : 0); |
|
| 2127 | + } |
|
| 2030 | 2128 | |
| 2031 | 2129 | // Queue createPost background notification |
| 2032 | - if ($msgOptions['send_notifications'] && $msgOptions['approved']) |
|
| 2033 | - $smcFunc['db_insert']('', |
|
| 2130 | + if ($msgOptions['send_notifications'] && $msgOptions['approved']) { |
|
| 2131 | + $smcFunc['db_insert']('', |
|
| 2034 | 2132 | '{db_prefix}background_tasks', |
| 2035 | 2133 | array('task_file' => 'string', 'task_class' => 'string', 'task_data' => 'string', 'claimed_time' => 'int'), |
| 2036 | 2134 | array('$sourcedir/tasks/CreatePost-Notify.php', 'CreatePost_Notify_Background', json_encode(array( |
@@ -2041,6 +2139,7 @@ discard block |
||
| 2041 | 2139 | )), 0), |
| 2042 | 2140 | array('id_task') |
| 2043 | 2141 | ); |
| 2142 | + } |
|
| 2044 | 2143 | |
| 2045 | 2144 | // Alright, done now... we can abort now, I guess... at least this much is done. |
| 2046 | 2145 | ignore_user_abort($previous_ignore_user_abort); |
@@ -2067,14 +2166,18 @@ discard block |
||
| 2067 | 2166 | |
| 2068 | 2167 | // This is longer than it has to be, but makes it so we only set/change what we have to. |
| 2069 | 2168 | $messages_columns = array(); |
| 2070 | - if (isset($posterOptions['name'])) |
|
| 2071 | - $messages_columns['poster_name'] = $posterOptions['name']; |
|
| 2072 | - if (isset($posterOptions['email'])) |
|
| 2073 | - $messages_columns['poster_email'] = $posterOptions['email']; |
|
| 2074 | - if (isset($msgOptions['icon'])) |
|
| 2075 | - $messages_columns['icon'] = $msgOptions['icon']; |
|
| 2076 | - if (isset($msgOptions['subject'])) |
|
| 2077 | - $messages_columns['subject'] = $msgOptions['subject']; |
|
| 2169 | + if (isset($posterOptions['name'])) { |
|
| 2170 | + $messages_columns['poster_name'] = $posterOptions['name']; |
|
| 2171 | + } |
|
| 2172 | + if (isset($posterOptions['email'])) { |
|
| 2173 | + $messages_columns['poster_email'] = $posterOptions['email']; |
|
| 2174 | + } |
|
| 2175 | + if (isset($msgOptions['icon'])) { |
|
| 2176 | + $messages_columns['icon'] = $msgOptions['icon']; |
|
| 2177 | + } |
|
| 2178 | + if (isset($msgOptions['subject'])) { |
|
| 2179 | + $messages_columns['subject'] = $msgOptions['subject']; |
|
| 2180 | + } |
|
| 2078 | 2181 | if (isset($msgOptions['body'])) |
| 2079 | 2182 | { |
| 2080 | 2183 | $messages_columns['body'] = $msgOptions['body']; |
@@ -2101,8 +2204,9 @@ discard block |
||
| 2101 | 2204 | $messages_columns['modified_reason'] = $msgOptions['modify_reason']; |
| 2102 | 2205 | $messages_columns['id_msg_modified'] = $modSettings['maxMsgID']; |
| 2103 | 2206 | } |
| 2104 | - if (isset($msgOptions['smileys_enabled'])) |
|
| 2105 | - $messages_columns['smileys_enabled'] = empty($msgOptions['smileys_enabled']) ? 0 : 1; |
|
| 2207 | + if (isset($msgOptions['smileys_enabled'])) { |
|
| 2208 | + $messages_columns['smileys_enabled'] = empty($msgOptions['smileys_enabled']) ? 0 : 1; |
|
| 2209 | + } |
|
| 2106 | 2210 | |
| 2107 | 2211 | // Which columns need to be ints? |
| 2108 | 2212 | $messageInts = array('modified_time', 'id_msg_modified', 'smileys_enabled'); |
@@ -2120,23 +2224,27 @@ discard block |
||
| 2120 | 2224 | { |
| 2121 | 2225 | preg_match_all('/\[member\=([0-9]+)\]([^\[]*)\[\/member\]/U', $msgOptions['old_body'], $match); |
| 2122 | 2226 | |
| 2123 | - if (isset($match[1]) && isset($match[2]) && is_array($match[1]) && is_array($match[2])) |
|
| 2124 | - foreach ($match[1] as $i => $oldID) |
|
| 2227 | + if (isset($match[1]) && isset($match[2]) && is_array($match[1]) && is_array($match[2])) { |
|
| 2228 | + foreach ($match[1] as $i => $oldID) |
|
| 2125 | 2229 | $oldmentions[$oldID] = array('id' => $oldID, 'real_name' => $match[2][$i]); |
| 2230 | + } |
|
| 2126 | 2231 | |
| 2127 | - if (empty($modSettings['search_custom_index_config'])) |
|
| 2128 | - unset($msgOptions['old_body']); |
|
| 2232 | + if (empty($modSettings['search_custom_index_config'])) { |
|
| 2233 | + unset($msgOptions['old_body']); |
|
| 2234 | + } |
|
| 2129 | 2235 | } |
| 2130 | 2236 | |
| 2131 | 2237 | $mentions = Mentions::getMentionedMembers($msgOptions['body']); |
| 2132 | 2238 | $messages_columns['body'] = $msgOptions['body'] = Mentions::getBody($msgOptions['body'], $mentions); |
| 2133 | 2239 | |
| 2134 | 2240 | // Remove the poster. |
| 2135 | - if (isset($mentions[$user_info['id']])) |
|
| 2136 | - unset($mentions[$user_info['id']]); |
|
| 2241 | + if (isset($mentions[$user_info['id']])) { |
|
| 2242 | + unset($mentions[$user_info['id']]); |
|
| 2243 | + } |
|
| 2137 | 2244 | |
| 2138 | - if (isset($oldmentions[$user_info['id']])) |
|
| 2139 | - unset($oldmentions[$user_info['id']]); |
|
| 2245 | + if (isset($oldmentions[$user_info['id']])) { |
|
| 2246 | + unset($oldmentions[$user_info['id']]); |
|
| 2247 | + } |
|
| 2140 | 2248 | |
| 2141 | 2249 | if (is_array($mentions) && is_array($oldmentions) && count(array_diff_key($mentions, $oldmentions)) > 0 && count($mentions) > count($oldmentions)) |
| 2142 | 2250 | { |
@@ -2166,8 +2274,9 @@ discard block |
||
| 2166 | 2274 | } |
| 2167 | 2275 | |
| 2168 | 2276 | // Nothing to do? |
| 2169 | - if (empty($messages_columns)) |
|
| 2170 | - return true; |
|
| 2277 | + if (empty($messages_columns)) { |
|
| 2278 | + return true; |
|
| 2279 | + } |
|
| 2171 | 2280 | |
| 2172 | 2281 | // Change the post. |
| 2173 | 2282 | $smcFunc['db_query']('', ' |
@@ -2228,8 +2337,9 @@ discard block |
||
| 2228 | 2337 | // If there's a custom search index, it needs to be modified... |
| 2229 | 2338 | require_once($sourcedir . '/Search.php'); |
| 2230 | 2339 | $searchAPI = findSearchAPI(); |
| 2231 | - if (is_callable(array($searchAPI, 'postModified'))) |
|
| 2232 | - $searchAPI->postModified($msgOptions, $topicOptions, $posterOptions); |
|
| 2340 | + if (is_callable(array($searchAPI, 'postModified'))) { |
|
| 2341 | + $searchAPI->postModified($msgOptions, $topicOptions, $posterOptions); |
|
| 2342 | + } |
|
| 2233 | 2343 | |
| 2234 | 2344 | if (isset($msgOptions['subject'])) |
| 2235 | 2345 | { |
@@ -2243,14 +2353,16 @@ discard block |
||
| 2243 | 2353 | 'id_first_msg' => $msgOptions['id'], |
| 2244 | 2354 | ) |
| 2245 | 2355 | ); |
| 2246 | - if ($smcFunc['db_num_rows']($request) == 1) |
|
| 2247 | - updateStats('subject', $topicOptions['id'], $msgOptions['subject']); |
|
| 2356 | + if ($smcFunc['db_num_rows']($request) == 1) { |
|
| 2357 | + updateStats('subject', $topicOptions['id'], $msgOptions['subject']); |
|
| 2358 | + } |
|
| 2248 | 2359 | $smcFunc['db_free_result']($request); |
| 2249 | 2360 | } |
| 2250 | 2361 | |
| 2251 | 2362 | // Finally, if we are setting the approved state we need to do much more work :( |
| 2252 | - if ($modSettings['postmod_active'] && isset($msgOptions['approved'])) |
|
| 2253 | - approvePosts($msgOptions['id'], $msgOptions['approved']); |
|
| 2363 | + if ($modSettings['postmod_active'] && isset($msgOptions['approved'])) { |
|
| 2364 | + approvePosts($msgOptions['id'], $msgOptions['approved']); |
|
| 2365 | + } |
|
| 2254 | 2366 | |
| 2255 | 2367 | return true; |
| 2256 | 2368 | } |
@@ -2267,11 +2379,13 @@ discard block |
||
| 2267 | 2379 | { |
| 2268 | 2380 | global $smcFunc; |
| 2269 | 2381 | |
| 2270 | - if (!is_array($msgs)) |
|
| 2271 | - $msgs = array($msgs); |
|
| 2382 | + if (!is_array($msgs)) { |
|
| 2383 | + $msgs = array($msgs); |
|
| 2384 | + } |
|
| 2272 | 2385 | |
| 2273 | - if (empty($msgs)) |
|
| 2274 | - return false; |
|
| 2386 | + if (empty($msgs)) { |
|
| 2387 | + return false; |
|
| 2388 | + } |
|
| 2275 | 2389 | |
| 2276 | 2390 | // May as well start at the beginning, working out *what* we need to change. |
| 2277 | 2391 | $request = $smcFunc['db_query']('', ' |
@@ -2303,20 +2417,22 @@ discard block |
||
| 2303 | 2417 | $topics[] = $row['id_topic']; |
| 2304 | 2418 | |
| 2305 | 2419 | // Ensure our change array exists already. |
| 2306 | - if (!isset($topic_changes[$row['id_topic']])) |
|
| 2307 | - $topic_changes[$row['id_topic']] = array( |
|
| 2420 | + if (!isset($topic_changes[$row['id_topic']])) { |
|
| 2421 | + $topic_changes[$row['id_topic']] = array( |
|
| 2308 | 2422 | 'id_last_msg' => $row['id_last_msg'], |
| 2309 | 2423 | 'approved' => $row['topic_approved'], |
| 2310 | 2424 | 'replies' => 0, |
| 2311 | 2425 | 'unapproved_posts' => 0, |
| 2312 | 2426 | ); |
| 2313 | - if (!isset($board_changes[$row['id_board']])) |
|
| 2314 | - $board_changes[$row['id_board']] = array( |
|
| 2427 | + } |
|
| 2428 | + if (!isset($board_changes[$row['id_board']])) { |
|
| 2429 | + $board_changes[$row['id_board']] = array( |
|
| 2315 | 2430 | 'posts' => 0, |
| 2316 | 2431 | 'topics' => 0, |
| 2317 | 2432 | 'unapproved_posts' => 0, |
| 2318 | 2433 | 'unapproved_topics' => 0, |
| 2319 | 2434 | ); |
| 2435 | + } |
|
| 2320 | 2436 | |
| 2321 | 2437 | // If it's the first message then the topic state changes! |
| 2322 | 2438 | if ($row['id_msg'] == $row['id_first_msg']) |
@@ -2337,14 +2453,13 @@ discard block |
||
| 2337 | 2453 | 'poster' => $row['id_member'], |
| 2338 | 2454 | 'new_topic' => true, |
| 2339 | 2455 | ); |
| 2340 | - } |
|
| 2341 | - else |
|
| 2456 | + } else |
|
| 2342 | 2457 | { |
| 2343 | 2458 | $topic_changes[$row['id_topic']]['replies'] += $approve ? 1 : -1; |
| 2344 | 2459 | |
| 2345 | 2460 | // This will be a post... but don't notify unless it's not followed by approved ones. |
| 2346 | - if ($row['id_msg'] > $row['id_last_msg']) |
|
| 2347 | - $notification_posts[$row['id_topic']] = array( |
|
| 2461 | + if ($row['id_msg'] > $row['id_last_msg']) { |
|
| 2462 | + $notification_posts[$row['id_topic']] = array( |
|
| 2348 | 2463 | 'id' => $row['id_msg'], |
| 2349 | 2464 | 'body' => $row['body'], |
| 2350 | 2465 | 'subject' => $row['subject'], |
@@ -2355,28 +2470,33 @@ discard block |
||
| 2355 | 2470 | 'new_topic' => false, |
| 2356 | 2471 | 'msg' => $row['id_msg'], |
| 2357 | 2472 | ); |
| 2473 | + } |
|
| 2358 | 2474 | } |
| 2359 | 2475 | |
| 2360 | 2476 | // If this is being approved and id_msg is higher than the current id_last_msg then it changes. |
| 2361 | - if ($approve && $row['id_msg'] > $topic_changes[$row['id_topic']]['id_last_msg']) |
|
| 2362 | - $topic_changes[$row['id_topic']]['id_last_msg'] = $row['id_msg']; |
|
| 2477 | + if ($approve && $row['id_msg'] > $topic_changes[$row['id_topic']]['id_last_msg']) { |
|
| 2478 | + $topic_changes[$row['id_topic']]['id_last_msg'] = $row['id_msg']; |
|
| 2479 | + } |
|
| 2363 | 2480 | // If this is being unapproved, and it's equal to the id_last_msg we need to find a new one! |
| 2364 | - elseif (!$approve) |
|
| 2365 | - // Default to the first message and then we'll override in a bit ;) |
|
| 2481 | + elseif (!$approve) { |
|
| 2482 | + // Default to the first message and then we'll override in a bit ;) |
|
| 2366 | 2483 | $topic_changes[$row['id_topic']]['id_last_msg'] = $row['id_first_msg']; |
| 2484 | + } |
|
| 2367 | 2485 | |
| 2368 | 2486 | $topic_changes[$row['id_topic']]['unapproved_posts'] += $approve ? -1 : 1; |
| 2369 | 2487 | $board_changes[$row['id_board']]['unapproved_posts'] += $approve ? -1 : 1; |
| 2370 | 2488 | $board_changes[$row['id_board']]['posts'] += $approve ? 1 : -1; |
| 2371 | 2489 | |
| 2372 | 2490 | // Post count for the user? |
| 2373 | - if ($row['id_member'] && empty($row['count_posts'])) |
|
| 2374 | - $member_post_changes[$row['id_member']] = isset($member_post_changes[$row['id_member']]) ? $member_post_changes[$row['id_member']] + 1 : 1; |
|
| 2491 | + if ($row['id_member'] && empty($row['count_posts'])) { |
|
| 2492 | + $member_post_changes[$row['id_member']] = isset($member_post_changes[$row['id_member']]) ? $member_post_changes[$row['id_member']] + 1 : 1; |
|
| 2493 | + } |
|
| 2375 | 2494 | } |
| 2376 | 2495 | $smcFunc['db_free_result']($request); |
| 2377 | 2496 | |
| 2378 | - if (empty($msgs)) |
|
| 2379 | - return; |
|
| 2497 | + if (empty($msgs)) { |
|
| 2498 | + return; |
|
| 2499 | + } |
|
| 2380 | 2500 | |
| 2381 | 2501 | // Now we have the differences make the changes, first the easy one. |
| 2382 | 2502 | $smcFunc['db_query']('', ' |
@@ -2403,14 +2523,15 @@ discard block |
||
| 2403 | 2523 | 'approved' => 1, |
| 2404 | 2524 | ) |
| 2405 | 2525 | ); |
| 2406 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 2407 | - $topic_changes[$row['id_topic']]['id_last_msg'] = $row['id_last_msg']; |
|
| 2526 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 2527 | + $topic_changes[$row['id_topic']]['id_last_msg'] = $row['id_last_msg']; |
|
| 2528 | + } |
|
| 2408 | 2529 | $smcFunc['db_free_result']($request); |
| 2409 | 2530 | } |
| 2410 | 2531 | |
| 2411 | 2532 | // ... next the topics... |
| 2412 | - foreach ($topic_changes as $id => $changes) |
|
| 2413 | - $smcFunc['db_query']('', ' |
|
| 2533 | + foreach ($topic_changes as $id => $changes) { |
|
| 2534 | + $smcFunc['db_query']('', ' |
|
| 2414 | 2535 | UPDATE {db_prefix}topics |
| 2415 | 2536 | SET approved = {int:approved}, unapproved_posts = unapproved_posts + {int:unapproved_posts}, |
| 2416 | 2537 | num_replies = num_replies + {int:num_replies}, id_last_msg = {int:id_last_msg} |
@@ -2423,10 +2544,11 @@ discard block |
||
| 2423 | 2544 | 'id_topic' => $id, |
| 2424 | 2545 | ) |
| 2425 | 2546 | ); |
| 2547 | + } |
|
| 2426 | 2548 | |
| 2427 | 2549 | // ... finally the boards... |
| 2428 | - foreach ($board_changes as $id => $changes) |
|
| 2429 | - $smcFunc['db_query']('', ' |
|
| 2550 | + foreach ($board_changes as $id => $changes) { |
|
| 2551 | + $smcFunc['db_query']('', ' |
|
| 2430 | 2552 | UPDATE {db_prefix}boards |
| 2431 | 2553 | SET num_posts = num_posts + {int:num_posts}, unapproved_posts = unapproved_posts + {int:unapproved_posts}, |
| 2432 | 2554 | num_topics = num_topics + {int:num_topics}, unapproved_topics = unapproved_topics + {int:unapproved_topics} |
@@ -2439,13 +2561,14 @@ discard block |
||
| 2439 | 2561 | 'id_board' => $id, |
| 2440 | 2562 | ) |
| 2441 | 2563 | ); |
| 2564 | + } |
|
| 2442 | 2565 | |
| 2443 | 2566 | // Finally, least importantly, notifications! |
| 2444 | 2567 | if ($approve) |
| 2445 | 2568 | { |
| 2446 | 2569 | $task_rows = array(); |
| 2447 | - foreach (array_merge($notification_topics, $notification_posts) as $topic) |
|
| 2448 | - $task_rows[] = array( |
|
| 2570 | + foreach (array_merge($notification_topics, $notification_posts) as $topic) { |
|
| 2571 | + $task_rows[] = array( |
|
| 2449 | 2572 | '$sourcedir/tasks/CreatePost-Notify.php', 'CreatePost_Notify_Background', json_encode(array( |
| 2450 | 2573 | 'msgOptions' => array( |
| 2451 | 2574 | 'id' => $topic['msg'], |
@@ -2463,14 +2586,16 @@ discard block |
||
| 2463 | 2586 | 'type' => $topic['new_topic'] ? 'topic' : 'reply', |
| 2464 | 2587 | )), 0 |
| 2465 | 2588 | ); |
| 2589 | + } |
|
| 2466 | 2590 | |
| 2467 | - if ($notify) |
|
| 2468 | - $smcFunc['db_insert']('', |
|
| 2591 | + if ($notify) { |
|
| 2592 | + $smcFunc['db_insert']('', |
|
| 2469 | 2593 | '{db_prefix}background_tasks', |
| 2470 | 2594 | array('task_file' => 'string', 'task_class' => 'string', 'task_data' => 'string', 'claimed_time' => 'int'), |
| 2471 | 2595 | $task_rows, |
| 2472 | 2596 | array('id_task') |
| 2473 | 2597 | ); |
| 2598 | + } |
|
| 2474 | 2599 | |
| 2475 | 2600 | $smcFunc['db_query']('', ' |
| 2476 | 2601 | DELETE FROM {db_prefix}approval_queue |
@@ -2486,8 +2611,9 @@ discard block |
||
| 2486 | 2611 | else |
| 2487 | 2612 | { |
| 2488 | 2613 | $msgInserts = array(); |
| 2489 | - foreach ($msgs as $msg) |
|
| 2490 | - $msgInserts[] = array($msg); |
|
| 2614 | + foreach ($msgs as $msg) { |
|
| 2615 | + $msgInserts[] = array($msg); |
|
| 2616 | + } |
|
| 2491 | 2617 | |
| 2492 | 2618 | $smcFunc['db_insert']('ignore', |
| 2493 | 2619 | '{db_prefix}approval_queue', |
@@ -2501,9 +2627,10 @@ discard block |
||
| 2501 | 2627 | updateLastMessages(array_keys($board_changes)); |
| 2502 | 2628 | |
| 2503 | 2629 | // Post count for the members? |
| 2504 | - if (!empty($member_post_changes)) |
|
| 2505 | - foreach ($member_post_changes as $id_member => $count_change) |
|
| 2630 | + if (!empty($member_post_changes)) { |
|
| 2631 | + foreach ($member_post_changes as $id_member => $count_change) |
|
| 2506 | 2632 | updateMemberData($id_member, array('posts' => 'posts ' . ($approve ? '+' : '-') . ' ' . $count_change)); |
| 2633 | + } |
|
| 2507 | 2634 | |
| 2508 | 2635 | return true; |
| 2509 | 2636 | } |
@@ -2520,11 +2647,13 @@ discard block |
||
| 2520 | 2647 | { |
| 2521 | 2648 | global $smcFunc; |
| 2522 | 2649 | |
| 2523 | - if (!is_array($topics)) |
|
| 2524 | - $topics = array($topics); |
|
| 2650 | + if (!is_array($topics)) { |
|
| 2651 | + $topics = array($topics); |
|
| 2652 | + } |
|
| 2525 | 2653 | |
| 2526 | - if (empty($topics)) |
|
| 2527 | - return false; |
|
| 2654 | + if (empty($topics)) { |
|
| 2655 | + return false; |
|
| 2656 | + } |
|
| 2528 | 2657 | |
| 2529 | 2658 | $approve_type = $approve ? 0 : 1; |
| 2530 | 2659 | |
@@ -2540,8 +2669,9 @@ discard block |
||
| 2540 | 2669 | ) |
| 2541 | 2670 | ); |
| 2542 | 2671 | $msgs = array(); |
| 2543 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 2544 | - $msgs[] = $row['id_msg']; |
|
| 2672 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 2673 | + $msgs[] = $row['id_msg']; |
|
| 2674 | + } |
|
| 2545 | 2675 | $smcFunc['db_free_result']($request); |
| 2546 | 2676 | |
| 2547 | 2677 | return approvePosts($msgs, $approve); |
@@ -2564,11 +2694,13 @@ discard block |
||
| 2564 | 2694 | global $board_info, $board, $smcFunc; |
| 2565 | 2695 | |
| 2566 | 2696 | // Please - let's be sane. |
| 2567 | - if (empty($setboards)) |
|
| 2568 | - return false; |
|
| 2697 | + if (empty($setboards)) { |
|
| 2698 | + return false; |
|
| 2699 | + } |
|
| 2569 | 2700 | |
| 2570 | - if (!is_array($setboards)) |
|
| 2571 | - $setboards = array($setboards); |
|
| 2701 | + if (!is_array($setboards)) { |
|
| 2702 | + $setboards = array($setboards); |
|
| 2703 | + } |
|
| 2572 | 2704 | |
| 2573 | 2705 | // If we don't know the id_msg we need to find it. |
| 2574 | 2706 | if (!$id_msg) |
@@ -2586,15 +2718,16 @@ discard block |
||
| 2586 | 2718 | ) |
| 2587 | 2719 | ); |
| 2588 | 2720 | $lastMsg = array(); |
| 2589 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 2590 | - $lastMsg[$row['id_board']] = $row['id_msg']; |
|
| 2721 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 2722 | + $lastMsg[$row['id_board']] = $row['id_msg']; |
|
| 2723 | + } |
|
| 2591 | 2724 | $smcFunc['db_free_result']($request); |
| 2592 | - } |
|
| 2593 | - else |
|
| 2725 | + } else |
|
| 2594 | 2726 | { |
| 2595 | 2727 | // Just to note - there should only be one board passed if we are doing this. |
| 2596 | - foreach ($setboards as $id_board) |
|
| 2597 | - $lastMsg[$id_board] = $id_msg; |
|
| 2728 | + foreach ($setboards as $id_board) { |
|
| 2729 | + $lastMsg[$id_board] = $id_msg; |
|
| 2730 | + } |
|
| 2598 | 2731 | } |
| 2599 | 2732 | |
| 2600 | 2733 | $parent_boards = array(); |
@@ -2609,10 +2742,11 @@ discard block |
||
| 2609 | 2742 | $lastModified[$id_board] = 0; |
| 2610 | 2743 | } |
| 2611 | 2744 | |
| 2612 | - if (!empty($board) && $id_board == $board) |
|
| 2613 | - $parents = $board_info['parent_boards']; |
|
| 2614 | - else |
|
| 2615 | - $parents = getBoardParents($id_board); |
|
| 2745 | + if (!empty($board) && $id_board == $board) { |
|
| 2746 | + $parents = $board_info['parent_boards']; |
|
| 2747 | + } else { |
|
| 2748 | + $parents = getBoardParents($id_board); |
|
| 2749 | + } |
|
| 2616 | 2750 | |
| 2617 | 2751 | // Ignore any parents on the top child level. |
| 2618 | 2752 | // @todo Why? |
@@ -2621,10 +2755,11 @@ discard block |
||
| 2621 | 2755 | if ($parent['level'] != 0) |
| 2622 | 2756 | { |
| 2623 | 2757 | // If we're already doing this one as a board, is this a higher last modified? |
| 2624 | - if (isset($lastModified[$id]) && $lastModified[$id_board] > $lastModified[$id]) |
|
| 2625 | - $lastModified[$id] = $lastModified[$id_board]; |
|
| 2626 | - elseif (!isset($lastModified[$id]) && (!isset($parent_boards[$id]) || $parent_boards[$id] < $lastModified[$id_board])) |
|
| 2627 | - $parent_boards[$id] = $lastModified[$id_board]; |
|
| 2758 | + if (isset($lastModified[$id]) && $lastModified[$id_board] > $lastModified[$id]) { |
|
| 2759 | + $lastModified[$id] = $lastModified[$id_board]; |
|
| 2760 | + } elseif (!isset($lastModified[$id]) && (!isset($parent_boards[$id]) || $parent_boards[$id] < $lastModified[$id_board])) { |
|
| 2761 | + $parent_boards[$id] = $lastModified[$id_board]; |
|
| 2762 | + } |
|
| 2628 | 2763 | } |
| 2629 | 2764 | } |
| 2630 | 2765 | } |
@@ -2637,23 +2772,24 @@ discard block |
||
| 2637 | 2772 | // Finally, to save on queries make the changes... |
| 2638 | 2773 | foreach ($parent_boards as $id => $msg) |
| 2639 | 2774 | { |
| 2640 | - if (!isset($parent_updates[$msg])) |
|
| 2641 | - $parent_updates[$msg] = array($id); |
|
| 2642 | - else |
|
| 2643 | - $parent_updates[$msg][] = $id; |
|
| 2775 | + if (!isset($parent_updates[$msg])) { |
|
| 2776 | + $parent_updates[$msg] = array($id); |
|
| 2777 | + } else { |
|
| 2778 | + $parent_updates[$msg][] = $id; |
|
| 2779 | + } |
|
| 2644 | 2780 | } |
| 2645 | 2781 | |
| 2646 | 2782 | foreach ($lastMsg as $id => $msg) |
| 2647 | 2783 | { |
| 2648 | - if (!isset($board_updates[$msg . '-' . $lastModified[$id]])) |
|
| 2649 | - $board_updates[$msg . '-' . $lastModified[$id]] = array( |
|
| 2784 | + if (!isset($board_updates[$msg . '-' . $lastModified[$id]])) { |
|
| 2785 | + $board_updates[$msg . '-' . $lastModified[$id]] = array( |
|
| 2650 | 2786 | 'id' => $msg, |
| 2651 | 2787 | 'updated' => $lastModified[$id], |
| 2652 | 2788 | 'boards' => array($id) |
| 2653 | 2789 | ); |
| 2654 | - |
|
| 2655 | - else |
|
| 2656 | - $board_updates[$msg . '-' . $lastModified[$id]]['boards'][] = $id; |
|
| 2790 | + } else { |
|
| 2791 | + $board_updates[$msg . '-' . $lastModified[$id]]['boards'][] = $id; |
|
| 2792 | + } |
|
| 2657 | 2793 | } |
| 2658 | 2794 | |
| 2659 | 2795 | // Now commit the changes! |
@@ -2745,11 +2881,13 @@ discard block |
||
| 2745 | 2881 | global $txt, $mbname, $scripturl, $settings; |
| 2746 | 2882 | |
| 2747 | 2883 | // First things first, load up the email templates language file, if we need to. |
| 2748 | - if ($loadLang) |
|
| 2749 | - loadLanguage('EmailTemplates', $lang); |
|
| 2884 | + if ($loadLang) { |
|
| 2885 | + loadLanguage('EmailTemplates', $lang); |
|
| 2886 | + } |
|
| 2750 | 2887 | |
| 2751 | - if (!isset($txt[$template . '_subject']) || !isset($txt[$template . '_body'])) |
|
| 2752 | - fatal_lang_error('email_no_template', 'template', array($template)); |
|
| 2888 | + if (!isset($txt[$template . '_subject']) || !isset($txt[$template . '_body'])) { |
|
| 2889 | + fatal_lang_error('email_no_template', 'template', array($template)); |
|
| 2890 | + } |
|
| 2753 | 2891 | |
| 2754 | 2892 | $ret = array( |
| 2755 | 2893 | 'subject' => $txt[$template . '_subject'], |
@@ -2799,17 +2937,18 @@ discard block |
||
| 2799 | 2937 | function user_info_callback($matches) |
| 2800 | 2938 | { |
| 2801 | 2939 | global $user_info; |
| 2802 | - if (empty($matches[1])) |
|
| 2803 | - return ''; |
|
| 2940 | + if (empty($matches[1])) { |
|
| 2941 | + return ''; |
|
| 2942 | + } |
|
| 2804 | 2943 | |
| 2805 | 2944 | $use_ref = true; |
| 2806 | 2945 | $ref = &$user_info; |
| 2807 | 2946 | |
| 2808 | 2947 | foreach (explode('.', $matches[1]) as $index) |
| 2809 | 2948 | { |
| 2810 | - if ($use_ref && isset($ref[$index])) |
|
| 2811 | - $ref = &$ref[$index]; |
|
| 2812 | - else |
|
| 2949 | + if ($use_ref && isset($ref[$index])) { |
|
| 2950 | + $ref = &$ref[$index]; |
|
| 2951 | + } else |
|
| 2813 | 2952 | { |
| 2814 | 2953 | $use_ref = false; |
| 2815 | 2954 | break; |
@@ -2846,8 +2985,7 @@ discard block |
||
| 2846 | 2985 | if (!empty($lang_locale) && enchant_broker_dict_exists($context['enchant_broker'], $lang_locale)) |
| 2847 | 2986 | { |
| 2848 | 2987 | $enchant_link = enchant_broker_request_dict($context['enchant_broker'], $lang_locale); |
| 2849 | - } |
|
| 2850 | - elseif (enchant_broker_dict_exists($context['enchant_broker'], $txt['lang_dictionary'])) |
|
| 2988 | + } elseif (enchant_broker_dict_exists($context['enchant_broker'], $txt['lang_dictionary'])) |
|
| 2851 | 2989 | { |
| 2852 | 2990 | $enchant_link = enchant_broker_request_dict($context['enchant_broker'], $txt['lang_dictionary']); |
| 2853 | 2991 | } |
@@ -2857,8 +2995,7 @@ discard block |
||
| 2857 | 2995 | { |
| 2858 | 2996 | $context['provider'] = 'enchant'; |
| 2859 | 2997 | return $enchant_link; |
| 2860 | - } |
|
| 2861 | - else |
|
| 2998 | + } else |
|
| 2862 | 2999 | { |
| 2863 | 3000 | // Free up any resources used... |
| 2864 | 3001 | @enchant_broker_free($context['enchant_broker']); |
@@ -2879,8 +3016,9 @@ discard block |
||
| 2879 | 3016 | $pspell_link = pspell_new($txt['lang_dictionary'], $txt['lang_spelling'], '', strtr($context['character_set'], array('iso-' => 'iso', 'ISO-' => 'iso')), PSPELL_FAST | PSPELL_RUN_TOGETHER); |
| 2880 | 3017 | |
| 2881 | 3018 | // Most people don't have anything but English installed... So we use English as a last resort. |
| 2882 | - if (!$pspell_link) |
|
| 2883 | - $pspell_link = pspell_new('en', '', '', '', PSPELL_FAST | PSPELL_RUN_TOGETHER); |
|
| 3019 | + if (!$pspell_link) { |
|
| 3020 | + $pspell_link = pspell_new('en', '', '', '', PSPELL_FAST | PSPELL_RUN_TOGETHER); |
|
| 3021 | + } |
|
| 2884 | 3022 | |
| 2885 | 3023 | error_reporting($old); |
| 2886 | 3024 | ob_end_clean(); |
@@ -2920,8 +3058,7 @@ discard block |
||
| 2920 | 3058 | $word = iconv($txt['lang_character_set'], 'UTF-8', $word); |
| 2921 | 3059 | } |
| 2922 | 3060 | return enchant_dict_check($dict, $word); |
| 2923 | - } |
|
| 2924 | - elseif ($context['provider'] == 'pspell') |
|
| 3061 | + } elseif ($context['provider'] == 'pspell') |
|
| 2925 | 3062 | { |
| 2926 | 3063 | return pspell_check($dict, $word); |
| 2927 | 3064 | } |
@@ -2957,13 +3094,11 @@ discard block |
||
| 2957 | 3094 | } |
| 2958 | 3095 | |
| 2959 | 3096 | return $suggestions; |
| 2960 | - } |
|
| 2961 | - else |
|
| 3097 | + } else |
|
| 2962 | 3098 | { |
| 2963 | 3099 | return enchant_dict_suggest($dict, $word); |
| 2964 | 3100 | } |
| 2965 | - } |
|
| 2966 | - elseif ($context['provider'] == 'pspell') |
|
| 3101 | + } elseif ($context['provider'] == 'pspell') |
|
| 2967 | 3102 | { |
| 2968 | 3103 | return pspell_suggest($dict, $word); |
| 2969 | 3104 | } |
@@ -1,9 +1,10 @@ |
||
| 1 | 1 | <?php |
| 2 | 2 | |
| 3 | 3 | // Try to handle it with the upper level index.php. (it should know what to do.) |
| 4 | -if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) |
|
| 4 | +if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) { |
|
| 5 | 5 | include (dirname(dirname(__FILE__)) . '/index.php'); |
| 6 | -else |
|
| 6 | +} else { |
|
| 7 | 7 | exit; |
| 8 | +} |
|
| 8 | 9 | |
| 9 | 10 | ?> |
| 10 | 11 | \ No newline at end of file |
@@ -1,9 +1,10 @@ |
||
| 1 | 1 | <?php |
| 2 | 2 | |
| 3 | 3 | // Try to handle it with the upper level index.php. (it should know what to do.) |
| 4 | -if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) |
|
| 4 | +if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) { |
|
| 5 | 5 | include (dirname(dirname(__FILE__)) . '/index.php'); |
| 6 | -else |
|
| 6 | +} else { |
|
| 7 | 7 | exit; |
| 8 | +} |
|
| 8 | 9 | |
| 9 | 10 | ?> |
| 10 | 11 | \ No newline at end of file |
@@ -1,9 +1,10 @@ |
||
| 1 | 1 | <?php |
| 2 | 2 | |
| 3 | 3 | // Try to handle it with the upper level index.php. (it should know what to do.) |
| 4 | -if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) |
|
| 4 | +if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) { |
|
| 5 | 5 | include (dirname(dirname(__FILE__)) . '/index.php'); |
| 6 | -else |
|
| 6 | +} else { |
|
| 7 | 7 | exit; |
| 8 | +} |
|
| 8 | 9 | |
| 9 | 10 | ?> |
| 10 | 11 | \ No newline at end of file |
@@ -1,9 +1,10 @@ |
||
| 1 | 1 | <?php |
| 2 | 2 | |
| 3 | 3 | // Try to handle it with the upper level index.php. (it should know what to do.) |
| 4 | -if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) |
|
| 4 | +if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) { |
|
| 5 | 5 | include (dirname(dirname(__FILE__)) . '/index.php'); |
| 6 | -else |
|
| 6 | +} else { |
|
| 7 | 7 | exit; |
| 8 | +} |
|
| 8 | 9 | |
| 9 | 10 | ?> |
| 10 | 11 | \ No newline at end of file |
@@ -1,9 +1,10 @@ |
||
| 1 | 1 | <?php |
| 2 | 2 | |
| 3 | 3 | // Try to handle it with the upper level index.php. (it should know what to do.) |
| 4 | -if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) |
|
| 4 | +if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) { |
|
| 5 | 5 | include (dirname(dirname(__FILE__)) . '/index.php'); |
| 6 | -else |
|
| 6 | +} else { |
|
| 7 | 7 | exit; |
| 8 | +} |
|
| 8 | 9 | |
| 9 | 10 | ?> |
| 10 | 11 | \ No newline at end of file |
@@ -1,9 +1,10 @@ |
||
| 1 | 1 | <?php |
| 2 | 2 | |
| 3 | 3 | // Try to handle it with the upper level index.php. (it should know what to do.) |
| 4 | -if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) |
|
| 4 | +if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) { |
|
| 5 | 5 | include (dirname(dirname(__FILE__)) . '/index.php'); |
| 6 | -else |
|
| 6 | +} else { |
|
| 7 | 7 | exit; |
| 8 | +} |
|
| 8 | 9 | |
| 9 | 10 | ?> |
| 10 | 11 | \ No newline at end of file |
@@ -1,9 +1,10 @@ |
||
| 1 | 1 | <?php |
| 2 | 2 | |
| 3 | 3 | // Try to handle it with the upper level index.php. (it should know what to do.) |
| 4 | -if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) |
|
| 4 | +if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) { |
|
| 5 | 5 | include (dirname(dirname(__FILE__)) . '/index.php'); |
| 6 | -else |
|
| 6 | +} else { |
|
| 7 | 7 | exit; |
| 8 | +} |
|
| 8 | 9 | |
| 9 | 10 | ?> |
| 10 | 11 | \ No newline at end of file |
@@ -14,8 +14,9 @@ discard block |
||
| 14 | 14 | * @version 2.1 Beta 3 |
| 15 | 15 | */ |
| 16 | 16 | |
| 17 | -if (!defined('SMF')) |
|
| 17 | +if (!defined('SMF')) { |
|
| 18 | 18 | die('No direct access...'); |
| 19 | +} |
|
| 19 | 20 | |
| 20 | 21 | /** |
| 21 | 22 | * Shows a listing of registered members. |
@@ -110,8 +111,9 @@ discard block |
||
| 110 | 111 | |
| 111 | 112 | $context['custom_profile_fields'] = getCustFieldsMList(); |
| 112 | 113 | |
| 113 | - if (!empty($context['custom_profile_fields']['columns'])) |
|
| 114 | - $context['columns'] += $context['custom_profile_fields']['columns']; |
|
| 114 | + if (!empty($context['custom_profile_fields']['columns'])) { |
|
| 115 | + $context['columns'] += $context['custom_profile_fields']['columns']; |
|
| 116 | + } |
|
| 115 | 117 | |
| 116 | 118 | $context['colspan'] = 0; |
| 117 | 119 | $context['disabled_fields'] = isset($modSettings['disabled_profile_fields']) ? array_flip(explode(',', $modSettings['disabled_profile_fields'])) : array(); |
@@ -147,12 +149,12 @@ discard block |
||
| 147 | 149 | call_integration_hook('integrate_memberlist_buttons'); |
| 148 | 150 | |
| 149 | 151 | // Jump to the sub action. |
| 150 | - if (isset($subActions[$context['listing_by']])) |
|
| 151 | - call_helper($subActions[$context['listing_by']][1]); |
|
| 152 | - |
|
| 153 | - else |
|
| 154 | - call_helper($subActions['all'][1]); |
|
| 155 | -} |
|
| 152 | + if (isset($subActions[$context['listing_by']])) { |
|
| 153 | + call_helper($subActions[$context['listing_by']][1]); |
|
| 154 | + } else { |
|
| 155 | + call_helper($subActions['all'][1]); |
|
| 156 | + } |
|
| 157 | + } |
|
| 156 | 158 | |
| 157 | 159 | /** |
| 158 | 160 | * List all members, page by page, with sorting. |
@@ -177,8 +179,9 @@ discard block |
||
| 177 | 179 | if ($use_cache) |
| 178 | 180 | { |
| 179 | 181 | // Maybe there's something cached already. |
| 180 | - if (!empty($modSettings['memberlist_cache'])) |
|
| 181 | - $memberlist_cache = smf_json_decode($modSettings['memberlist_cache'], true); |
|
| 182 | + if (!empty($modSettings['memberlist_cache'])) { |
|
| 183 | + $memberlist_cache = smf_json_decode($modSettings['memberlist_cache'], true); |
|
| 184 | + } |
|
| 182 | 185 | |
| 183 | 186 | // The chunk size for the cached index. |
| 184 | 187 | $cache_step_size = 500; |
@@ -234,13 +237,15 @@ discard block |
||
| 234 | 237 | } |
| 235 | 238 | |
| 236 | 239 | // Set defaults for sort (real_name) and start. (0) |
| 237 | - if (!isset($_REQUEST['sort']) || !isset($context['columns'][$_REQUEST['sort']])) |
|
| 238 | - $_REQUEST['sort'] = 'real_name'; |
|
| 240 | + if (!isset($_REQUEST['sort']) || !isset($context['columns'][$_REQUEST['sort']])) { |
|
| 241 | + $_REQUEST['sort'] = 'real_name'; |
|
| 242 | + } |
|
| 239 | 243 | |
| 240 | 244 | if (!is_numeric($_REQUEST['start'])) |
| 241 | 245 | { |
| 242 | - if (preg_match('~^[^\'\\\\/]~' . ($context['utf8'] ? 'u' : ''), $smcFunc['strtolower']($_REQUEST['start']), $match) === 0) |
|
| 243 | - fatal_error('Hacker?', false); |
|
| 246 | + if (preg_match('~^[^\'\\\\/]~' . ($context['utf8'] ? 'u' : ''), $smcFunc['strtolower']($_REQUEST['start']), $match) === 0) { |
|
| 247 | + fatal_error('Hacker?', false); |
|
| 248 | + } |
|
| 244 | 249 | |
| 245 | 250 | $_REQUEST['start'] = $match[0]; |
| 246 | 251 | |
@@ -259,16 +264,18 @@ discard block |
||
| 259 | 264 | } |
| 260 | 265 | |
| 261 | 266 | $context['letter_links'] = ''; |
| 262 | - for ($i = 97; $i < 123; $i++) |
|
| 263 | - $context['letter_links'] .= '<a href="' . $scripturl . '?action=mlist;sa=all;start=' . chr($i) . '#letter' . chr($i) . '">' . strtoupper(chr($i)) . '</a> '; |
|
| 267 | + for ($i = 97; $i < 123; $i++) { |
|
| 268 | + $context['letter_links'] .= '<a href="' . $scripturl . '?action=mlist;sa=all;start=' . chr($i) . '#letter' . chr($i) . '">' . strtoupper(chr($i)) . '</a> '; |
|
| 269 | + } |
|
| 264 | 270 | |
| 265 | 271 | // Sort out the column information. |
| 266 | 272 | foreach ($context['columns'] as $col => $column_details) |
| 267 | 273 | { |
| 268 | 274 | $context['columns'][$col]['href'] = $scripturl . '?action=mlist;sort=' . $col . ';start=0'; |
| 269 | 275 | |
| 270 | - if ((!isset($_REQUEST['desc']) && $col == $_REQUEST['sort']) || ($col != $_REQUEST['sort'] && !empty($column_details['default_sort_rev']))) |
|
| 271 | - $context['columns'][$col]['href'] .= ';desc'; |
|
| 276 | + if ((!isset($_REQUEST['desc']) && $col == $_REQUEST['sort']) || ($col != $_REQUEST['sort'] && !empty($column_details['default_sort_rev']))) { |
|
| 277 | + $context['columns'][$col]['href'] .= ';desc'; |
|
| 278 | + } |
|
| 272 | 279 | |
| 273 | 280 | $context['columns'][$col]['link'] = '<a href="' . $context['columns'][$col]['href'] . '" rel="nofollow">' . $context['columns'][$col]['label'] . '</a>'; |
| 274 | 281 | $context['columns'][$col]['selected'] = $_REQUEST['sort'] == $col; |
@@ -317,8 +324,9 @@ discard block |
||
| 317 | 324 | elseif ($use_cache && $_REQUEST['sort'] === 'real_name') |
| 318 | 325 | { |
| 319 | 326 | $first_offset = floor(($memberlist_cache['num_members'] - $modSettings['defaultMaxMembers'] - $_REQUEST['start']) / $cache_step_size) * $cache_step_size; |
| 320 | - if ($first_offset < 0) |
|
| 321 | - $first_offset = 0; |
|
| 327 | + if ($first_offset < 0) { |
|
| 328 | + $first_offset = 0; |
|
| 329 | + } |
|
| 322 | 330 | $second_offset = ceil(($memberlist_cache['num_members'] - $_REQUEST['start']) / $cache_step_size) * $cache_step_size; |
| 323 | 331 | |
| 324 | 332 | $where = 'mem.real_name BETWEEN {string:real_name_low} AND {string:real_name_high}'; |
@@ -395,12 +403,13 @@ discard block |
||
| 395 | 403 | ) |
| 396 | 404 | ); |
| 397 | 405 | $context['custom_search_fields'] = array(); |
| 398 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 399 | - $context['custom_search_fields'][$row['col_name']] = array( |
|
| 406 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 407 | + $context['custom_search_fields'][$row['col_name']] = array( |
|
| 400 | 408 | 'colname' => $row['col_name'], |
| 401 | 409 | 'name' => $row['field_name'], |
| 402 | 410 | 'desc' => $row['field_desc'], |
| 403 | 411 | ); |
| 412 | + } |
|
| 404 | 413 | $smcFunc['db_free_result']($request); |
| 405 | 414 | |
| 406 | 415 | // They're searching.. |
@@ -413,23 +422,27 @@ discard block |
||
| 413 | 422 | $context['old_search_value'] = urlencode($_REQUEST['search']); |
| 414 | 423 | |
| 415 | 424 | // No fields? Use default... |
| 416 | - if (empty($_POST['fields'])) |
|
| 417 | - $_POST['fields'] = array('name'); |
|
| 425 | + if (empty($_POST['fields'])) { |
|
| 426 | + $_POST['fields'] = array('name'); |
|
| 427 | + } |
|
| 418 | 428 | |
| 419 | 429 | // Set defaults for how the results are sorted |
| 420 | - if (!isset($_REQUEST['sort']) || !isset($context['columns'][$_REQUEST['sort']])) |
|
| 421 | - $_REQUEST['sort'] = 'real_name'; |
|
| 430 | + if (!isset($_REQUEST['sort']) || !isset($context['columns'][$_REQUEST['sort']])) { |
|
| 431 | + $_REQUEST['sort'] = 'real_name'; |
|
| 432 | + } |
|
| 422 | 433 | |
| 423 | 434 | // Build the column link / sort information. |
| 424 | 435 | foreach ($context['columns'] as $col => $column_details) |
| 425 | 436 | { |
| 426 | 437 | $context['columns'][$col]['href'] = $scripturl . '?action=mlist;sa=search;start=0;sort=' . $col; |
| 427 | 438 | |
| 428 | - if ((!isset($_REQUEST['desc']) && $col == $_REQUEST['sort']) || ($col != $_REQUEST['sort'] && !empty($column_details['default_sort_rev']))) |
|
| 429 | - $context['columns'][$col]['href'] .= ';desc'; |
|
| 439 | + if ((!isset($_REQUEST['desc']) && $col == $_REQUEST['sort']) || ($col != $_REQUEST['sort'] && !empty($column_details['default_sort_rev']))) { |
|
| 440 | + $context['columns'][$col]['href'] .= ';desc'; |
|
| 441 | + } |
|
| 430 | 442 | |
| 431 | - if (isset($_POST['search']) && isset($_POST['fields'])) |
|
| 432 | - $context['columns'][$col]['href'] .= ';search=' . $_POST['search'] . ';fields=' . implode(',', $_POST['fields']); |
|
| 443 | + if (isset($_POST['search']) && isset($_POST['fields'])) { |
|
| 444 | + $context['columns'][$col]['href'] .= ';search=' . $_POST['search'] . ';fields=' . implode(',', $_POST['fields']); |
|
| 445 | + } |
|
| 433 | 446 | |
| 434 | 447 | $context['columns'][$col]['link'] = '<a href="' . $context['columns'][$col]['href'] . '" rel="nofollow">' . $context['columns'][$col]['label'] . '</a>'; |
| 435 | 448 | $context['columns'][$col]['selected'] = $_REQUEST['sort'] == $col; |
@@ -452,8 +465,7 @@ discard block |
||
| 452 | 465 | { |
| 453 | 466 | $fields = allowedTo('moderate_forum') ? array('member_name', 'real_name') : array('real_name'); |
| 454 | 467 | $search_fields[] = 'name'; |
| 455 | - } |
|
| 456 | - else |
|
| 468 | + } else |
|
| 457 | 469 | { |
| 458 | 470 | $fields = array(); |
| 459 | 471 | $search_fields = array(); |
@@ -478,9 +490,10 @@ discard block |
||
| 478 | 490 | $search_fields[] = 'email'; |
| 479 | 491 | } |
| 480 | 492 | |
| 481 | - if ($smcFunc['db_case_sensitive']) |
|
| 482 | - foreach ($fields as $key => $field) |
|
| 493 | + if ($smcFunc['db_case_sensitive']) { |
|
| 494 | + foreach ($fields as $key => $field) |
|
| 483 | 495 | $fields[$key] = 'LOWER(' . $field . ')'; |
| 496 | + } |
|
| 484 | 497 | |
| 485 | 498 | $customJoin = array(); |
| 486 | 499 | $customCount = 10; |
@@ -499,8 +512,9 @@ discard block |
||
| 499 | 512 | } |
| 500 | 513 | |
| 501 | 514 | // No search fields? That means you're trying to hack things |
| 502 | - if (empty($search_fields)) |
|
| 503 | - fatal_lang_error('invalid_search_string', false); |
|
| 515 | + if (empty($search_fields)) { |
|
| 516 | + fatal_lang_error('invalid_search_string', false); |
|
| 517 | + } |
|
| 504 | 518 | |
| 505 | 519 | $query = $_POST['search'] == '' ? '= {string:blank_string}' : ($smcFunc['db_case_sensitive'] ? 'LIKE LOWER({string:search})' : 'LIKE {string:search}'); |
| 506 | 520 | |
@@ -538,8 +552,7 @@ discard block |
||
| 538 | 552 | ); |
| 539 | 553 | printMemberListRows($request); |
| 540 | 554 | $smcFunc['db_free_result']($request); |
| 541 | - } |
|
| 542 | - else |
|
| 555 | + } else |
|
| 543 | 556 | { |
| 544 | 557 | // These are all the possible fields. |
| 545 | 558 | $context['search_fields'] = array( |
@@ -554,14 +567,14 @@ discard block |
||
| 554 | 567 | { |
| 555 | 568 | unset($context['search_fields']['email']); |
| 556 | 569 | $context['search_defaults'] = array('name'); |
| 557 | - } |
|
| 558 | - else |
|
| 570 | + } else |
|
| 559 | 571 | { |
| 560 | 572 | $context['search_defaults'] = array('name', 'email'); |
| 561 | 573 | } |
| 562 | 574 | |
| 563 | - foreach ($context['custom_search_fields'] as $field) |
|
| 564 | - $context['search_fields']['cust_' . $field['colname']] = sprintf($txt['mlist_search_by'], $field['name']); |
|
| 575 | + foreach ($context['custom_search_fields'] as $field) { |
|
| 576 | + $context['search_fields']['cust_' . $field['colname']] = sprintf($txt['mlist_search_by'], $field['name']); |
|
| 577 | + } |
|
| 565 | 578 | |
| 566 | 579 | $context['sub_template'] = 'search'; |
| 567 | 580 | $context['old_search'] = isset($_GET['search']) ? $_GET['search'] : (isset($_POST['search']) ? $smcFunc['htmlspecialchars']($_POST['search']) : ''); |
@@ -603,12 +616,14 @@ discard block |
||
| 603 | 616 | $smcFunc['db_free_result']($result); |
| 604 | 617 | |
| 605 | 618 | // Avoid division by zero... |
| 606 | - if ($most_posts == 0) |
|
| 607 | - $most_posts = 1; |
|
| 619 | + if ($most_posts == 0) { |
|
| 620 | + $most_posts = 1; |
|
| 621 | + } |
|
| 608 | 622 | |
| 609 | 623 | $members = array(); |
| 610 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 611 | - $members[] = $row['id_member']; |
|
| 624 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 625 | + $members[] = $row['id_member']; |
|
| 626 | + } |
|
| 612 | 627 | |
| 613 | 628 | // Load all the members for display. |
| 614 | 629 | loadMemberData($members); |
@@ -616,8 +631,9 @@ discard block |
||
| 616 | 631 | $context['members'] = array(); |
| 617 | 632 | foreach ($members as $member) |
| 618 | 633 | { |
| 619 | - if (!loadMemberContext($member)) |
|
| 620 | - continue; |
|
| 634 | + if (!loadMemberContext($member)) { |
|
| 635 | + continue; |
|
| 636 | + } |
|
| 621 | 637 | |
| 622 | 638 | $context['members'][$member] = $memberContext[$member]; |
| 623 | 639 | $context['members'][$member]['post_percent'] = round(($context['members'][$member]['real_posts'] * 100) / $most_posts); |
@@ -634,20 +650,21 @@ discard block |
||
| 634 | 650 | continue; |
| 635 | 651 | } |
| 636 | 652 | |
| 637 | - if ($column['bbc'] && !empty($context['members'][$member]['options'][$key])) |
|
| 638 | - $context['members'][$member]['options'][$key] = strip_tags(parse_bbc($context['members'][$member]['options'][$key])); |
|
| 639 | - |
|
| 640 | - elseif ($column['type'] == 'check') |
|
| 641 | - $context['members'][$member]['options'][$key] = $context['members'][$member]['options'][$key] == 0 ? $txt['no'] : $txt['yes']; |
|
| 653 | + if ($column['bbc'] && !empty($context['members'][$member]['options'][$key])) { |
|
| 654 | + $context['members'][$member]['options'][$key] = strip_tags(parse_bbc($context['members'][$member]['options'][$key])); |
|
| 655 | + } elseif ($column['type'] == 'check') { |
|
| 656 | + $context['members'][$member]['options'][$key] = $context['members'][$member]['options'][$key] == 0 ? $txt['no'] : $txt['yes']; |
|
| 657 | + } |
|
| 642 | 658 | |
| 643 | 659 | // Enclosing the user input within some other text? |
| 644 | - if (!empty($column['enclose'])) |
|
| 645 | - $context['members'][$member]['options'][$key] = strtr($column['enclose'], array( |
|
| 660 | + if (!empty($column['enclose'])) { |
|
| 661 | + $context['members'][$member]['options'][$key] = strtr($column['enclose'], array( |
|
| 646 | 662 | '{SCRIPTURL}' => $scripturl, |
| 647 | 663 | '{IMAGES_URL}' => $settings['images_url'], |
| 648 | 664 | '{DEFAULT_IMAGES_URL}' => $settings['default_images_url'], |
| 649 | 665 | '{INPUT}' => $context['members'][$member]['options'][$key], |
| 650 | 666 | )); |
| 667 | + } |
|
| 651 | 668 | } |
| 652 | 669 | } |
| 653 | 670 | } |
@@ -688,17 +705,17 @@ discard block |
||
| 688 | 705 | ); |
| 689 | 706 | |
| 690 | 707 | // Get the right sort method depending on the cust field type. |
| 691 | - if ($row['field_type'] != 'check') |
|
| 692 | - $cpf['columns'][$row['col_name']]['sort'] = array( |
|
| 708 | + if ($row['field_type'] != 'check') { |
|
| 709 | + $cpf['columns'][$row['col_name']]['sort'] = array( |
|
| 693 | 710 | 'down' => 'LENGTH(t' . $row['col_name'] . '.value) > 0 ASC, COALESCE(t' . $row['col_name'] . '.value, "") DESC', |
| 694 | 711 | 'up' => 'LENGTH(t' . $row['col_name'] . '.value) > 0 DESC, COALESCE(t' . $row['col_name'] . '.value, "") ASC' |
| 695 | 712 | ); |
| 696 | - |
|
| 697 | - else |
|
| 698 | - $cpf['columns'][$row['col_name']]['sort'] = array( |
|
| 713 | + } else { |
|
| 714 | + $cpf['columns'][$row['col_name']]['sort'] = array( |
|
| 699 | 715 | 'down' => 't' . $row['col_name'] . '.value DESC', |
| 700 | 716 | 'up' => 't' . $row['col_name'] . '.value ASC' |
| 701 | 717 | ); |
| 718 | + } |
|
| 702 | 719 | |
| 703 | 720 | $cpf['join'][$row['col_name']] = 'LEFT JOIN {db_prefix}themes AS t' . $row['col_name'] . ' ON (t' . $row['col_name'] . '.variable = {literal:' . $row['col_name'] . '} AND t' . $row['col_name'] . '.id_theme = 1 AND t' . $row['col_name'] . '.id_member = mem.id_member)'; |
| 704 | 721 | } |