SherifElfadaly / Laravel-Api-Skeleton

src/Modules/Acl/AclGroup.php

Spacing +3 added lines, -3 removed lines

@@ -3,7 +3,7 @@ 
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Database\Eloquent\SoftDeletes;
 
-class AclGroup extends Model{
+class AclGroup extends Model {
 
     use SoftDeletes;
     protected $table    = 'groups';
@@ -29,12 +29,12 @@ 
 
     public function users()
     {
-        return $this->belongsToMany('\App\Modules\Acl\AclUser','users_groups','group_id','user_id')->whereNull('users_groups.deleted_at')->withTimestamps();
+        return $this->belongsToMany('\App\Modules\Acl\AclUser', 'users_groups', 'group_id', 'user_id')->whereNull('users_groups.deleted_at')->withTimestamps();
     }
 
     public function permissions()
     {
-        return $this->belongsToMany('\App\Modules\Acl\AclPermission','groups_permissions','group_id','permission_id')->whereNull('groups_permissions.deleted_at')->withTimestamps();
+        return $this->belongsToMany('\App\Modules\Acl\AclPermission', 'groups_permissions', 'group_id', 'permission_id')->whereNull('groups_permissions.deleted_at')->withTimestamps();
     }
 
     public static function boot()

src/Modules/Acl/Http/Controllers/GroupsController.php

Spacing +2 added lines, -2 removed lines

@@ -13,14 +13,14 @@
      * to preform actions like (add, edit ... etc).
      * @var string
      */
-    protected $model               = 'groups';
+    protected $model = 'groups';
 
     /**
      * The validations rules used by the base api controller
      * to check before add.
      * @var array
      */
-    protected $validationRules  = [
+    protected $validationRules = [
     'name' => 'required|string|max:100|unique:groups,name,{id}'
     ];
 

src/Modules/Acl/Database/Migrations/2016_01_05_130506_permissions.php

Spacing +4 added lines, -4 removed lines

@@ -12,15 +12,15 @@
 	 */
 	public function up()
 	{
-        Schema::create('permissions', function (Blueprint $table) {
+        Schema::create('permissions', function(Blueprint $table) {
             $table->increments('id');
-            $table->string('name',100);
-            $table->string('model',100);
+            $table->string('name', 100);
+            $table->string('model', 100);
             $table->softDeletes();
             $table->timestamps();
             $table->unique(array('name', 'model'));
         });
-        Schema::create('groups_permissions', function (Blueprint $table) {
+        Schema::create('groups_permissions', function(Blueprint $table) {
             $table->increments('id');
             $table->integer('group_id');
             $table->integer('permission_id');

src/Modules/Acl/Database/Migrations/2015_12_22_145819_groups.php

Spacing +3 added lines, -3 removed lines

@@ -12,14 +12,14 @@
 	 */
 	public function up()
 	{
-		Schema::create('groups', function (Blueprint $table) {
+		Schema::create('groups', function(Blueprint $table) {
             $table->increments('id');
-            $table->string('name',100)->unique();
+            $table->string('name', 100)->unique();
             $table->softDeletes();
             $table->timestamps();
         });
         
-        Schema::create('users_groups', function (Blueprint $table) {
+        Schema::create('users_groups', function(Blueprint $table) {
             $table->increments('id');
             $table->integer('user_id');
             $table->integer('group_id');

src/Modules/Acl/AclPermission.php

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
     
     public function groups()
     {
-        return $this->belongsToMany('\App\Modules\Acl\AclGroup','groups_permissions','permission_id','group_id')->whereNull('groups_permissions.deleted_at')->withTimestamps();
+        return $this->belongsToMany('\App\Modules\Acl\AclGroup', 'groups_permissions', 'permission_id', 'group_id')->whereNull('groups_permissions.deleted_at')->withTimestamps();
     }
 
     public static function boot()

src/Modules/Reporting/Database/Migrations/2016_01_19_112350_reports.php

Spacing +3 added lines, -3 removed lines

@@ -12,10 +12,10 @@
 	 */
 	public function up()
 	{
-		Schema::create('reports', function (Blueprint $table) {
+		Schema::create('reports', function(Blueprint $table) {
 			$table->increments('id');
-			$table->string('report_name',100);
-			$table->string('view_name',100);
+			$table->string('report_name', 100);
+			$table->string('view_name', 100);
 			$table->softDeletes();
 			$table->timestamps();
         });

src/Modules/Core/Console/Commands/GenerateDoc.php

Doc Comments +2 added lines, -1 removed lines

@@ -123,6 +123,7 @@ 
      * 
      * @param  array  &$route
      * @param  object $reflectionMethod]
+     * @param \ReflectionMethod $reflectionMethod
      * @return void
      */
     protected function processDocBlock(&$route, $reflectionMethod)
@@ -145,7 +146,7 @@ 
      * Generate post body for the given route.
      * 
      * @param  array  &$route
-     * @param  object $reflectionMethod
+     * @param  \ReflectionMethod $reflectionMethod
      * @param  array  $validationRules
      * @return void
      */

Spacing +9 added lines, -9 removed lines

@@ -45,7 +45,7 @@ 
             if ($route) 
             {
                 $actoinArray = explode('@', $route['action']);
-                if(array_get($actoinArray, 1, false))
+                if (array_get($actoinArray, 1, false))
                 {
                     $controller       = $actoinArray[0];
                     $method           = $actoinArray[1];
@@ -64,7 +64,7 @@ 
                     $route['response'] = $this->getResponseObject($classProperties['model'], $route['name'], $route['returnDocBlock']);
 
                     preg_match('/api\/([^#]+)\//iU', $route['uri'], $module);
-                    $docData['modules'][$module[1]][substr($route['prefix'], strlen('/api/' . $module[1] . '/') - 1)][] = $route;
+                    $docData['modules'][$module[1]][substr($route['prefix'], strlen('/api/'.$module[1].'/') - 1)][] = $route;
 
                     $this->getModels($classProperties['model'], $docData);   
                 }
@@ -82,7 +82,7 @@ 
      */
     protected function getRoutes()
     {
-        return collect(\Route::getRoutes())->map(function ($route) {
+        return collect(\Route::getRoutes())->map(function($route) {
             if (strpos($route->uri(), 'api') !== false) 
             {
                 return [
@@ -114,7 +114,7 @@ 
         ];
 
 
-        if (! $skipLoginCheck || ! in_array($method, $skipLoginCheck)) 
+        if ( ! $skipLoginCheck || ! in_array($method, $skipLoginCheck)) 
         {
             $route['headers']['Authorization'] = 'Bearer {token}';
         }
@@ -168,16 +168,16 @@ 
                 }
                 else
                 {
-                    $route['body'] = eval('return ' . str_replace(',\'.$request->get(\'id\')', ',{id}\'', $match[1]) . ';');
+                    $route['body'] = eval('return '.str_replace(',\'.$request->get(\'id\')', ',{id}\'', $match[1]).';');
                 }
 
                 foreach ($route['body'] as &$rule) 
                 {
-                    if(strpos($rule, 'unique'))
+                    if (strpos($rule, 'unique'))
                     {
                         $rule = substr($rule, 0, strpos($rule, 'unique') + 6);
                     }
-                    elseif(strpos($rule, 'exists'))
+                    elseif (strpos($rule, 'exists'))
                     {
                         $rule = substr($rule, 0, strpos($rule, 'exists') - 1);
                     }
@@ -250,10 +250,10 @@ 
             $model      = factory($modelClass)->make();
             $modelArr   = $model->toArray();
 
-            if ( $model->trans && ! $model->trans->count()) 
+            if ($model->trans && ! $model->trans->count()) 
             {
                 $modelArr['trans'] = [
-                    'en' => factory($modelClass . 'Translation')->make()->toArray()
+                    'en' => factory($modelClass.'Translation')->make()->toArray()
                 ];
             }
 

src/Modules/Notifications/Notifications/ResetPassword.php

Doc Comments +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
      * Get the notification's delivery channels.
      *
      * @param  mixed  $notifiable
-     * @return array
+     * @return string[]
      */
     public function via($notifiable)
     {

Spacing +1 added lines, -1 removed lines

@@ -47,6 +47,6 @@
             ->subject('Reset passowrd')
             ->line('Reset passowrd')
             ->line('To reset your password click on the button below')
-            ->action('Reset password', config('skeleton.reset_password_url') . '/' . $this->token);
+            ->action('Reset password', config('skeleton.reset_password_url').'/'.$this->token);
     }
 }
\ No newline at end of file

src/Modules/Notifications/Repositories/PushNotificationDeviceRepository.php

Doc Comments +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
      * Register the given device to the logged in user.
      *
      * @param  string $data
-     * @return void
+     * @return boolean
      */
     public function registerDevice($data)
     {

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
         $notificationBuilder = new PayloadNotificationBuilder($title);
         $dataBuilder         = new PayloadDataBuilder();
 
-        $optionBuilder->setTimeToLive(60*20);
+        $optionBuilder->setTimeToLive(60 * 20);
         $notificationBuilder->setBody($message);
         $dataBuilder->addData($data);