Issues in GanttTask.php - New Issues - Inspection of "Provide "gantt" format (#467)" - SemanticMediaWiki/SemanticResultFormats - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6dc7d8...407c40 )

by Karsten

created 2019-05-06 14:27 UTC

formats/Gantt/src/GanttTask.php (1 issue)

Labels

Bug 1

Severity

Major 1

sebastianschmid 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * File holding the GanttTask class
 *
 * Creates Tasks with params
 *
 * @author Sebastian Schmid
 * @file
 * @ingroup SemanticResultFormats
 */

namespace SRF\Gantt;


class GanttTask {

	private $mTitle;
	private $mID;
	private $mStatus = '';
	private $mPriority = '';
	private $mStartDate;
	private $mEndDate;


	public function setTitle( $title ) {
		$this->mTitle = $title;
	}

	public function getTitle() {
		return $this->mTitle;
	}

	public function setID( $id ) {
		$this->mID = $id;
	}

	public function getID() {
		return $this->mID;
	}

	public function setStatus($status){
		$this->mStatus = $this->mStatus . $status . ', ';
	}

	public function setPriority($priority){
		$this->mPriority = $this->mPriority . $priority . ', ';
	}

	/**
	 * Either set the status or priority of the task
	 *
	 * @param array $params
	 * @param string $paramMapping
	 * @param string $type
	 *
	 */
	public function setTaskParam( $params, $paramMapping, $type ) {

		// skip if $paramMapping is empty and
		// output errormessage if wrong mapping
		if ( !empty( $paramMapping ) ) {

			foreach ( $paramMapping as $pKey => $pVal ) {

				if ( in_array( $pKey, $params ) ) {
					if ( $type === 'status' ) {
						$this->setStatus( trim( $pVal ) );
					}
					if ( $type === 'priority' ) {
						$this->setPriority( trim( $pVal ) );
					}
				}
			}
		}
	}

	public function getStatus() {
		return $this->mStatus;
	}

	public function getPriority() {
		return $this->mPriority;
	}

	public function setStartDate( $startDate ) {
		$this->mStartDate = $startDate;
	}

	public function getStartDate() {
		return $this->mStartDate;
	}

	public function setEndDate( $endDate ) {
		$this->mEndDate = $endDate;
	}

	public function getEndDate() {
		return $this->mEndDate;
	}
}

1			<?php
2			/**
3			* File holding the GanttTask class
4			*
5			* Creates Tasks with params
6			*
7			* @author Sebastian Schmid
8			* @file
9			* @ingroup SemanticResultFormats
10			*/
11
12			namespace SRF\Gantt;
13
14
15			class GanttTask {
16
17			private $mTitle;
18			private $mID;
19			private $mStatus = '';
20			private $mPriority = '';
21			private $mStartDate;
22			private $mEndDate;
23
24
25			public function setTitle( $title ) {
26			$this->mTitle = $title;
27			}
28
29			public function getTitle() {
30			return $this->mTitle;
31			}
32
33			public function setID( $id ) {
34			$this->mID = $id;
35			}
36
37			public function getID() {
38			return $this->mID;
39			}
40
41			public function setStatus($status){
42			$this->mStatus = $this->mStatus . $status . ', ';
43			}
44
45			public function setPriority($priority){
46			$this->mPriority = $this->mPriority . $priority . ', ';
47			}
48
49			/**
50			* Either set the status or priority of the task
51			*
52			* @param array $params
53			* @param string $paramMapping
54			* @param string $type
55			*
56			*/
57			public function setTaskParam( $params, $paramMapping, $type ) {
58
59			// skip if $paramMapping is empty and
60			// output errormessage if wrong mapping
61			if ( !empty( $paramMapping ) ) {
62
63			foreach ( $paramMapping as $pKey => $pVal ) {
			0 ignored issues – show Bug introduced 2019-03-05 16:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$paramMapping` of type `string` is not traversable. Loading history...
64			if ( in_array( $pKey, $params ) ) {
65			if ( $type === 'status' ) {
66			$this->setStatus( trim( $pVal ) );
67			}
68			if ( $type === 'priority' ) {
69			$this->setPriority( trim( $pVal ) );
70			}
71			}
72			}
73			}
74			}
75
76			public function getStatus() {
77			return $this->mStatus;
78			}
79
80			public function getPriority() {
81			return $this->mPriority;
82			}
83
84			public function setStartDate( $startDate ) {
85			$this->mStartDate = $startDate;
86			}
87
88			public function getStartDate() {
89			return $this->mStartDate;
90			}
91
92			public function setEndDate( $endDate ) {
93			$this->mEndDate = $endDate;
94			}
95
96			public function getEndDate() {
97			return $this->mEndDate;
98			}
99			}

SemanticMediaWiki / SemanticResultFormats

Push — master ( 6dc7d8...407c40 )

formats/Gantt/src/GanttTask.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like