LocalizedFileWidgetTestCase - Code Metrics - Inspection of "Use template-based widget rendering in AdminLocali..." - SectorLabs/django-localized-fields - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#34)

by Swen

created 2017-07-18 06:34 UTC

LocalizedFileWidgetTestCase A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	18
Duplicated Lines	83.33 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	4
c	1
b	0
f	0
dl	15
loc	18
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
A	test_get_context()	15	15	4

How to fix Duplicated Code

from django.test import TestCase
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3

from localized_fields.value import LocalizedFileValue
from localized_fields.widgets import LocalizedFileWidget


class LocalizedFileWidgetTestCase(TestCase):

    """Tests the workings of the :see:LocalizedFiledWidget class."""

    @staticmethod

    def test_get_context():
        """Tests whether the :see:get_context correctly
        handles 'required' attribute, separately for each subwidget."""

        widget = LocalizedFileWidget()
        widget.widgets[0].is_required = True

        widget.widgets[1].is_required = True

        widget.widgets[2].is_required = False

        context = widget.get_context(name='test',
                                     value=LocalizedFileValue(dict(en='test')),
                                     attrs=dict(required=True))
        assert 'required' not in context['widget']['subwidgets'][0]['attrs']
        assert context['widget']['subwidgets'][1]['attrs']['required']
        assert 'required' not in context['widget']['subwidgets'][2]['attrs']


Pull Request — master (#34)

LocalizedFileWidgetTestCase A

Complexity

Size/Duplication

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

1. Missing Dependencies

2. Missing init.py files

1		from django.test import TestCase
		0 ignored issues – show Configuration introduced 2017-02-23 14:51 UTC by Report Bug Copy Issue Report The import `django.test` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
2
3		from localized_fields.value import LocalizedFileValue
4		from localized_fields.widgets import LocalizedFileWidget
5
6
7		class LocalizedFileWidgetTestCase(TestCase):
		0 ignored issues – show Coding Style introduced 2017-02-23 14:51 UTC by Report Bug Copy Issue Report This class has no `__init__` method. Loading history...
8		"""Tests the workings of the :see:LocalizedFiledWidget class."""
9
10	View Code Duplication	@staticmethod
		0 ignored issues – show Duplication introduced 2017-07-17 22:05 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
11		def test_get_context():
12		"""Tests whether the :see:get_context correctly
13		handles 'required' attribute, separately for each subwidget."""
14
15		widget = LocalizedFileWidget()
16		widget.widgets[0].is_required = True
		0 ignored issues – show Bug introduced 2017-07-17 22:05 UTC by Report Bug Copy Issue Report The Instance of `LocalizedFileWidget` does not seem to have a member named `widgets`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
17		widget.widgets[1].is_required = True
		0 ignored issues – show Bug introduced 2017-07-17 22:05 UTC by Report Bug Copy Issue Report The Instance of `LocalizedFileWidget` does not seem to have a member named `widgets`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
18		widget.widgets[2].is_required = False
		0 ignored issues – show Bug introduced 2017-07-17 22:05 UTC by Report Bug Copy Issue Report The Instance of `LocalizedFileWidget` does not seem to have a member named `widgets`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
19		context = widget.get_context(name='test',
20		value=LocalizedFileValue(dict(en='test')),
21		attrs=dict(required=True))
22		assert 'required' not in context['widget']['subwidgets'][0]['attrs']
23		assert context['widget']['subwidgets'][1]['attrs']['required']
24		assert 'required' not in context['widget']['subwidgets'][2]['attrs']
25

SectorLabs / django-localized-fields

Pull Request — master (#34)

LocalizedFileWidgetTestCase A

Complexity

Size/Duplication

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files