LocalizedFieldTestCase.test_required_all() - Code Metrics - Inspection of "Improved functionality of required parameter (#19)..." - SectorLabs/django-localized-fields - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#31)

by Swen

created 2017-07-16 09:23 UTC

LocalizedFieldTestCase.test_required_all() D

↳ Parent: LocalizedFieldTestCase

Complexity

Conditions

Size

Total Lines

Duplication

Lines	28
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	28
loc	28
rs	4
cc	8

import json

from django.conf import settings
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
from django.db.utils import IntegrityError
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
from django.test import TestCase
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3

from localized_fields.fields import LocalizedField
from localized_fields.forms import LocalizedFieldForm
from localized_fields.value import LocalizedValue

from .data import get_init_values
from .fake_model import get_fake_model


class LocalizedFieldTestCase(TestCase):

    """Tests the :see:LocalizedField class."""

    @staticmethod
    def test_from_db_value():
        """Tests whether the :see:from_db_value function
        produces the expected :see:LocalizedValue."""

        input_data = get_init_values()
        localized_value = LocalizedField().from_db_value(input_data)

        for lang_code, _ in settings.LANGUAGES:
            assert getattr(localized_value, lang_code) == input_data[lang_code]

    @staticmethod
    def test_from_db_value_none():
        """Tests whether the :see:from_db_value function
        correctly handles None values."""

        localized_value = LocalizedField().from_db_value(None)

        for lang_code, _ in settings.LANGUAGES:
            assert localized_value.get(lang_code) is None

    def test_from_db_value_none_return_none(self):
        """Tests whether the :see:from_db_value function
        correctly handles None values when LOCALIZED_FIELDS_EXPERIMENTAL
        is set to True."""

        with self.settings(LOCALIZED_FIELDS_EXPERIMENTAL=True):

            localized_value = LocalizedField.from_db_value(None)

        assert localized_value is None

    @staticmethod
    def test_to_python():
        """Tests whether the :see:to_python function
        produces the expected :see:LocalizedValue."""

        input_data = get_init_values()
        localized_value = LocalizedField().to_python(input_data)

        for language, value in input_data.items():
            assert localized_value.get(language) == value

    @staticmethod
    def test_to_python_non_json():
        """Tests whether the :see:to_python function
        properly handles a string that is not JSON."""

        localized_value = LocalizedField().to_python('my value')
        assert localized_value.get() == 'my value'

    @staticmethod
    def test_to_python_none():
        """Tests whether the :see:to_python function
        produces the expected :see:LocalizedValue
        instance when it is passes None."""

        localized_value = LocalizedField().to_python(None)
        assert localized_value

        for lang_code, _ in settings.LANGUAGES:
            assert localized_value.get(lang_code) is None

    @staticmethod
    def test_to_python_non_dict():
        """Tests whether the :see:to_python function produces
        the expected :see:LocalizedValue when it is
        passed a non-dictionary value."""

        localized_value = LocalizedField().to_python(list())
        assert localized_value

        for lang_code, _ in settings.LANGUAGES:
            assert localized_value.get(lang_code) is None

    @staticmethod
    def test_to_python_str():
        """Tests whether the :see:to_python function produces
        the expected :see:LocalizedValue when it is
        passed serialized string value."""

        serialized_str = json.dumps(get_init_values())
        localized_value = LocalizedField().to_python(serialized_str)
        assert isinstance(localized_value, LocalizedValue)

        for language, value in get_init_values().items():
            assert localized_value.get(language) == value
            assert getattr(localized_value, language) == value

    @staticmethod
    def test_get_prep_value():
        """"Tests whether the :see:get_prep_value function
        produces the expected dictionary."""

        input_data = get_init_values()
        localized_value = LocalizedValue(input_data)

        output_data = LocalizedField().get_prep_value(localized_value)

        for language, value in input_data.items():
            assert language in output_data
            assert output_data.get(language) == value

    @staticmethod
    def test_get_prep_value_none():
        """Tests whether the :see:get_prep_value function
        produces the expected output when it is passed None."""

        output_data = LocalizedField().get_prep_value(None)
        assert not output_data

    @staticmethod
    def test_get_prep_value_no_localized_value():
        """Tests whether the :see:get_prep_value function
        produces the expected output when it is passed a
        non-LocalizedValue value."""

        output_data = LocalizedField().get_prep_value(['huh'])
        assert not output_data

    def test_get_prep_value_clean(self):
        """Tests whether the :see:get_prep_value produces
        None as the output when it is passed an empty, but
        valid LocalizedValue value but, only when null=True."""

        localized_value = LocalizedValue()

        with self.assertRaises(IntegrityError):

            LocalizedField(null=False).get_prep_value(localized_value)

        assert not LocalizedField(null=True).get_prep_value(localized_value)
        assert not LocalizedField().clean(None)
        assert not LocalizedField().clean(['huh'])

    @staticmethod
    def test_formfield():
        """Tests whether the :see:formfield function
        correctly returns a valid form."""

        assert isinstance(
            LocalizedField().formfield(),
            LocalizedFieldForm
        )

    def test_required_all(self):

        """Tests whether passing required=True properly validates
        that all languages are filled in."""

        model = get_fake_model(dict(
            title=LocalizedField(required=True)
        ))

        with self.assertRaises(IntegrityError):

            model.objects.create(title=dict(ro='romanian', nl='dutch'))

        with self.assertRaises(IntegrityError):

            model.objects.create(title=dict(nl='dutch'))

        with self.assertRaises(IntegrityError):

            model.objects.create(title=dict(random='random'))

        with self.assertRaises(IntegrityError):

            model.objects.create(title=dict())

        with self.assertRaises(IntegrityError):

            model.objects.create(title=None)

        with self.assertRaises(IntegrityError):

            model.objects.create(title='')

        with self.assertRaises(IntegrityError):

            model.objects.create(title='         ')

    def test_required_some(self):

        """Tests whether passing an array to required,
        properly validates whether the specified languages
        are marked as required."""

        model = get_fake_model(dict(
            title=LocalizedField(required=['nl', 'ro'])
        ))

        with self.assertRaises(IntegrityError):

            model.objects.create(title=dict(ro='romanian', nl='dutch'))

        with self.assertRaises(IntegrityError):

            model.objects.create(title=dict(nl='dutch'))

        with self.assertRaises(IntegrityError):

            model.objects.create(title=dict(random='random'))

        with self.assertRaises(IntegrityError):

            model.objects.create(title=dict())

        with self.assertRaises(IntegrityError):

            model.objects.create(title=None)

        with self.assertRaises(IntegrityError):

            model.objects.create(title='')

        with self.assertRaises(IntegrityError):

            model.objects.create(title='         ')


Pull Request — master (#31)

LocalizedFieldTestCase.test_required_all() D

Complexity

Size

Duplication

Importance

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

1		import json
2
3		from django.conf import settings
		0 ignored issues – show Configuration introduced 2017-02-23 14:51 UTC by Report Bug Copy Issue Report The import `django.conf` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
4		from django.db.utils import IntegrityError
		0 ignored issues – show Configuration introduced 2017-02-23 14:51 UTC by Report Bug Copy Issue Report The import `django.db.utils` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
5		from django.test import TestCase
		0 ignored issues – show Configuration introduced 2017-05-31 08:21 UTC by Report Bug Copy Issue Report The import `django.test` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
6
7		from localized_fields.fields import LocalizedField
8		from localized_fields.forms import LocalizedFieldForm
9		from localized_fields.value import LocalizedValue
10
11		from .data import get_init_values
12		from .fake_model import get_fake_model
13
14
15		class LocalizedFieldTestCase(TestCase):
		0 ignored issues – show Coding Style introduced 2017-02-23 14:51 UTC by Report Bug Copy Issue Report This class has no `__init__` method. Loading history...
16		"""Tests the :see:LocalizedField class."""
17
18		@staticmethod
19		def test_from_db_value():
20		"""Tests whether the :see:from_db_value function
21		produces the expected :see:LocalizedValue."""
22
23		input_data = get_init_values()
24		localized_value = LocalizedField().from_db_value(input_data)
25
26		for lang_code, _ in settings.LANGUAGES:
27		assert getattr(localized_value, lang_code) == input_data[lang_code]
28
29		@staticmethod
30		def test_from_db_value_none():
31		"""Tests whether the :see:from_db_value function
32		correctly handles None values."""
33
34		localized_value = LocalizedField().from_db_value(None)
35
36		for lang_code, _ in settings.LANGUAGES:
37		assert localized_value.get(lang_code) is None
38
39		def test_from_db_value_none_return_none(self):
40		"""Tests whether the :see:from_db_value function
41		correctly handles None values when LOCALIZED_FIELDS_EXPERIMENTAL
42		is set to True."""
43
44		with self.settings(LOCALIZED_FIELDS_EXPERIMENTAL=True):
		0 ignored issues – show Bug introduced 2017-03-24 12:50 UTC by Report Bug Copy Issue Report The Instance of `LocalizedFieldTestCase` does not seem to have a member named `settings`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
45		localized_value = LocalizedField.from_db_value(None)
46
47		assert localized_value is None
48
49		@staticmethod
50		def test_to_python():
51		"""Tests whether the :see:to_python function
52		produces the expected :see:LocalizedValue."""
53
54		input_data = get_init_values()
55		localized_value = LocalizedField().to_python(input_data)
56
57		for language, value in input_data.items():
58		assert localized_value.get(language) == value
59
60		@staticmethod
61		def test_to_python_non_json():
62		"""Tests whether the :see:to_python function
63		properly handles a string that is not JSON."""
64
65		localized_value = LocalizedField().to_python('my value')
66		assert localized_value.get() == 'my value'
67
68		@staticmethod
69		def test_to_python_none():
70		"""Tests whether the :see:to_python function
71		produces the expected :see:LocalizedValue
72		instance when it is passes None."""
73
74		localized_value = LocalizedField().to_python(None)
75		assert localized_value
76
77		for lang_code, _ in settings.LANGUAGES:
78		assert localized_value.get(lang_code) is None
79
80		@staticmethod
81		def test_to_python_non_dict():
82		"""Tests whether the :see:to_python function produces
83		the expected :see:LocalizedValue when it is
84		passed a non-dictionary value."""
85
86		localized_value = LocalizedField().to_python(list())
87		assert localized_value
88
89		for lang_code, _ in settings.LANGUAGES:
90		assert localized_value.get(lang_code) is None
91
92		@staticmethod
93		def test_to_python_str():
94		"""Tests whether the :see:to_python function produces
95		the expected :see:LocalizedValue when it is
96		passed serialized string value."""
97
98		serialized_str = json.dumps(get_init_values())
99		localized_value = LocalizedField().to_python(serialized_str)
100		assert isinstance(localized_value, LocalizedValue)
101
102		for language, value in get_init_values().items():
103		assert localized_value.get(language) == value
104		assert getattr(localized_value, language) == value
105
106		@staticmethod
107		def test_get_prep_value():
108		""""Tests whether the :see:get_prep_value function
109		produces the expected dictionary."""
110
111		input_data = get_init_values()
112		localized_value = LocalizedValue(input_data)
113
114		output_data = LocalizedField().get_prep_value(localized_value)
115
116		for language, value in input_data.items():
117		assert language in output_data
118		assert output_data.get(language) == value
119
120		@staticmethod
121		def test_get_prep_value_none():
122		"""Tests whether the :see:get_prep_value function
123		produces the expected output when it is passed None."""
124
125		output_data = LocalizedField().get_prep_value(None)
126		assert not output_data
127
128		@staticmethod
129		def test_get_prep_value_no_localized_value():
130		"""Tests whether the :see:get_prep_value function
131		produces the expected output when it is passed a
132		non-LocalizedValue value."""
133
134		output_data = LocalizedField().get_prep_value(['huh'])
135		assert not output_data
136
137		def test_get_prep_value_clean(self):
138		"""Tests whether the :see:get_prep_value produces
139		None as the output when it is passed an empty, but
140		valid LocalizedValue value but, only when null=True."""
141
142		localized_value = LocalizedValue()
143
144		with self.assertRaises(IntegrityError):
		0 ignored issues – show Bug introduced 2017-02-23 14:51 UTC by Report Bug Copy Issue Report The Instance of `LocalizedFieldTestCase` does not seem to have a member named `assertRaises`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
145		LocalizedField(null=False).get_prep_value(localized_value)
146
147		assert not LocalizedField(null=True).get_prep_value(localized_value)
148		assert not LocalizedField().clean(None)
149		assert not LocalizedField().clean(['huh'])
150
151		@staticmethod
152		def test_formfield():
153		"""Tests whether the :see:formfield function
154		correctly returns a valid form."""
155
156		assert isinstance(
157		LocalizedField().formfield(),
158		LocalizedFieldForm
159		)
160
161	View Code Duplication	def test_required_all(self):
		0 ignored issues – show Duplication introduced 2017-07-16 09:24 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
162		"""Tests whether passing required=True properly validates
163		that all languages are filled in."""
164
165		model = get_fake_model(dict(
166		title=LocalizedField(required=True)
167		))
168
169		with self.assertRaises(IntegrityError):
		0 ignored issues – show Bug introduced 2017-07-16 09:24 UTC by Report Bug Copy Issue Report The Instance of `LocalizedFieldTestCase` does not seem to have a member named `assertRaises`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
170		model.objects.create(title=dict(ro='romanian', nl='dutch'))
171
172		with self.assertRaises(IntegrityError):
		0 ignored issues – show Bug introduced 2017-07-16 09:24 UTC by Report Bug Copy Issue Report The Instance of `LocalizedFieldTestCase` does not seem to have a member named `assertRaises`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
173		model.objects.create(title=dict(nl='dutch'))
174
175		with self.assertRaises(IntegrityError):
		0 ignored issues – show Bug introduced 2017-07-16 09:24 UTC by Report Bug Copy Issue Report The Instance of `LocalizedFieldTestCase` does not seem to have a member named `assertRaises`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
176		model.objects.create(title=dict(random='random'))
177
178		with self.assertRaises(IntegrityError):
		0 ignored issues – show Bug introduced 2017-07-16 09:24 UTC by Report Bug Copy Issue Report The Instance of `LocalizedFieldTestCase` does not seem to have a member named `assertRaises`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
179		model.objects.create(title=dict())
180
181		with self.assertRaises(IntegrityError):
		0 ignored issues – show Bug introduced 2017-07-16 09:24 UTC by Report Bug Copy Issue Report The Instance of `LocalizedFieldTestCase` does not seem to have a member named `assertRaises`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
182		model.objects.create(title=None)
183
184		with self.assertRaises(IntegrityError):
		0 ignored issues – show Bug introduced 2017-07-16 09:24 UTC by Report Bug Copy Issue Report The Instance of `LocalizedFieldTestCase` does not seem to have a member named `assertRaises`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
185		model.objects.create(title='')
186
187		with self.assertRaises(IntegrityError):
		0 ignored issues – show Bug introduced 2017-07-16 09:24 UTC by Report Bug Copy Issue Report The Instance of `LocalizedFieldTestCase` does not seem to have a member named `assertRaises`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
188		model.objects.create(title=' ')
189
190	View Code Duplication	def test_required_some(self):
		0 ignored issues – show Duplication introduced 2017-07-16 09:24 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
191		"""Tests whether passing an array to required,
192		properly validates whether the specified languages
193		are marked as required."""
194
195		model = get_fake_model(dict(
196		title=LocalizedField(required=['nl', 'ro'])
197		))
198
199		with self.assertRaises(IntegrityError):
		0 ignored issues – show Bug introduced 2017-07-16 09:24 UTC by Report Bug Copy Issue Report The Instance of `LocalizedFieldTestCase` does not seem to have a member named `assertRaises`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
200		model.objects.create(title=dict(ro='romanian', nl='dutch'))
201
202		with self.assertRaises(IntegrityError):
		0 ignored issues – show Bug introduced 2017-07-16 09:24 UTC by Report Bug Copy Issue Report The Instance of `LocalizedFieldTestCase` does not seem to have a member named `assertRaises`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
203		model.objects.create(title=dict(nl='dutch'))
204
205		with self.assertRaises(IntegrityError):
		0 ignored issues – show Bug introduced 2017-07-16 09:24 UTC by Report Bug Copy Issue Report The Instance of `LocalizedFieldTestCase` does not seem to have a member named `assertRaises`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
206		model.objects.create(title=dict(random='random'))
207
208		with self.assertRaises(IntegrityError):
		0 ignored issues – show Bug introduced 2017-07-16 09:24 UTC by Report Bug Copy Issue Report The Instance of `LocalizedFieldTestCase` does not seem to have a member named `assertRaises`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
209		model.objects.create(title=dict())
210
211		with self.assertRaises(IntegrityError):
		0 ignored issues – show Bug introduced 2017-07-16 09:24 UTC by Report Bug Copy Issue Report The Instance of `LocalizedFieldTestCase` does not seem to have a member named `assertRaises`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
212		model.objects.create(title=None)
213
214		with self.assertRaises(IntegrityError):
		0 ignored issues – show Bug introduced 2017-07-16 09:24 UTC by Report Bug Copy Issue Report The Instance of `LocalizedFieldTestCase` does not seem to have a member named `assertRaises`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
215		model.objects.create(title='')
216
217		with self.assertRaises(IntegrityError):
		0 ignored issues – show Bug introduced 2017-07-16 09:24 UTC by Report Bug Copy Issue Report The Instance of `LocalizedFieldTestCase` does not seem to have a member named `assertRaises`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
218		model.objects.create(title=' ')
219

SectorLabs / django-localized-fields

Pull Request — master (#31)

LocalizedFieldTestCase.test_required_all() D

Complexity

Size

Duplication

Importance

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files

2. Missing init.py files

2. Missing init.py files