Schlaefer / Saito

app/Controller/SearchesController.php

Doc Comments +3 added lines

@@ -180,6 +180,9 @@
 			return Sanitize::escape($string, $this->Entry->useDbConfig);
 		}
 
+		/**
+		 * @param string[] $params
+		 */
 		protected function _filterQuery($params) {
 			$this->request->query = array_intersect_key($this->request->query,
 					array_fill_keys($params, 1));

app/Lib/Saito/Test/AssertTrait.php

Doc Comments +3 added lines

@@ -18,6 +18,9 @@
 			return $this->assertEquals($count, $length, "Failed XPath. Expected '$path' to be found $count times instead of $length.");
 		}
 
+		/**
+		 * @param string $path
+		 */
 		public function assertNotXPath($html, $path) {
 			return !$this->assertXPath($html, $path, 0);
 		}

app/Lib/Saito/Test/ControllerTestCase.php

Doc Comments +9 added lines

@@ -48,6 +48,9 @@ 
 			unset($_ENV['HTTP_X_REQUESTED_WITH']);
 		}
 
+		/**
+		 * @param string $agent
+		 */
 		protected function _setUserAgent($agent) {
 			if (isset($this->_env['HTTP_USER_AGENT'])) {
 				$this->_env['HTTP_USER_AGENT'] = $_ENV['HTTP_USER_AGENT'];
@@ -63,6 +66,9 @@ 
 			}
 		}
 
+		/**
+		 * @param integer $id
+		 */
 		protected function _loginUser($id) {
 			// see: http://stackoverflow.com/a/10411128/1372085
 			$this->_logoutUser();
@@ -100,6 +106,9 @@ 
 			endif;
 		}
 
+		/**
+		 * @param string $name
+		 */
 		protected function _notImplementedOnDatasource($name) {
 			$mc = $this->controller->modelClass;
 			$Ds = $this->controller->{$mc}->getDataSource();

app/Lib/Saito/Test/SecurityMockTrait.php

Doc Comments +3 added lines

@@ -4,6 +4,9 @@
 
 	trait SecurityMockTrait {
 
+		/**
+		 * @param string $controller
+		 */
 		public function generate($controller, $mocks = []) {
 			$byPassSecurity = false;
 			if (!isset($mocks['components']['Security'])) {

app/Model/UserIgnore.php

Doc Comments +12 added lines, -2 removed lines

@@ -29,6 +29,10 @@ 
 		 */
 		public $duration = 8035200;
 
+		/**
+		 * @param integer $userId
+		 * @param integer $blockedUserId
+		 */
 		public function ignore($userId, $blockedUserId) {
 			$exists = $this->_get($userId, $blockedUserId);
 			if ($exists) {
@@ -62,6 +66,9 @@ 
 			]);
 		}
 
+		/**
+		 * @param integer $id
+		 */
 		public function ignoredBy($id) {
 			return $this->find(
 				'all',
@@ -72,6 +79,9 @@ 
 			);
 		}
 
+		/**
+		 * @param integer $userId
+		 */
 		public function deleteUser($userId) {
 			$success = $this->deleteAll(['user_id' => $userId], false);
 			$success = $success && $this->deleteAll(['blocked_user_id' => $userId], false);
@@ -81,8 +91,8 @@ 
 		/**
 		 * counts how many users ignore the user with ID $id
 		 *
-		 * @param $id
-		 * @return array
+		 * @param integer $id
+		 * @return integer
 		 */
 		public function countIgnored($id) {
 			return count($this->getIgnored($id));

app/Plugin/Embedly/Vendor/Embedly.php

Doc Comments +3 added lines, -3 removed lines

@@ -169,7 +169,7 @@ 
     /**
      *
      * @param string $version
-     * @param array $action
+     * @param string $action
      * @param array $params
      * @return object
      */
@@ -291,7 +291,7 @@ 
     /**
      *
      * @param resource $ch
-     * @param array $headers
+     * @param string[] $headers
      * @return void
      */
     protected function setCurlOptions(&$ch, $headers = array())
@@ -333,7 +333,7 @@ 
 
     /**
      *
-     * @param stdClass $o
+     * @param \stdClass $o
      * @return string
      */
     public static function reg_imploder(\stdClass $o)

Spacing +3 added lines, -3 removed lines

@@ -202,7 +202,7 @@ 
                 if (!$match) {
                     //print("rejecting $url");
                     unset($params['urls'][$i]);
-                    $rejects[$i] = (object)array(
+                    $rejects[$i] = (object) array(
                         'error_code' => '401',
                         'error_message' => 'This service requires an Embedly key',
                         'type' => 'error'
@@ -243,7 +243,7 @@ 
             array_push($merged_result, $obj);
         }
 
-        if($justone) {
+        if ($justone) {
             return array_shift($merged_result);
         }
 
@@ -365,7 +365,7 @@ 
      */
     public static function paramify($input)
     {
-        if(is_string($input)) {
+        if (is_string($input)) {
             return array('urls' => $input);
         }
 

app/Plugin/FileUpload/Vendor/uploader.php

Doc Comments +3 added lines, -2 removed lines

@@ -94,6 +94,7 @@ 
     * Preform requested target patch checks depending on the unique setting
     *
     * @var string chosen filename target_path
+    * @param string $target_path
     * @return string of resulting target_path
     * @access private
     */
@@ -217,7 +218,7 @@ 
   /**
     * Checks if there is a file uploaded
     *
-    * @return void
+    * @return boolean
     * @access public
     * @param file array of uploaded file (optional)
     */
@@ -293,7 +294,7 @@ 
   }
 
   /**
-    * @return boolean true if errors were detected.
+    * @return integer true if errors were detected.
     */
   function hasErrors(){
     return count($this->errors);

Spacing +50 added lines, -50 removed lines

@@ -55,7 +55,7 @@ 
     */
   var $finalFile = null;
 
-  function __construct($options = array()){
+  function __construct($options = array()) {
     $this->options = array_merge($this->options, $options);
   }
 
@@ -66,25 +66,25 @@ 
     * @return string of resulting filename
     * @access private
     */
-  function __handleFileNameCallback($fileName){
-    if($this->options['fileNameFunction']){
-      if($this->options['fileModel']){
+  function __handleFileNameCallback($fileName) {
+    if ($this->options['fileNameFunction']) {
+      if ($this->options['fileModel']) {
         $Model = ClassRegistry::init($this->options['fileModel']);
-        if(method_exists($Model, $this->options['fileNameFunction'])){
+        if (method_exists($Model, $this->options['fileNameFunction'])) {
           $fileName = $Model->{$this->options['fileNameFunction']}($fileName);
         }
-        elseif(function_exists($this->options['fileNameFunction'])){
+        elseif (function_exists($this->options['fileNameFunction'])) {
           $fileName = call_user_func($this->options['fileNameFunction'], $fileName);
         }
       }
       else {
-        if(function_exists($this->options['fileNameFunction'])){
+        if (function_exists($this->options['fileNameFunction'])) {
           $fileName = call_user_func($this->options['fileNameFunction'], $fileName);
         }
       }
 
-      if(!$fileName){
-        $this->_error('No filename resulting after parsing. Function: ' . $this->options['fileNameFunction']);
+      if (!$fileName) {
+        $this->_error('No filename resulting after parsing. Function: '.$this->options['fileNameFunction']);
       }
     }
     return $fileName;
@@ -97,12 +97,12 @@ 
     * @return string of resulting target_path
     * @access private
     */
-  function __handleUnique($target_path){
-    if($this->options['unique']){
+  function __handleUnique($target_path) {
+    if ($this->options['unique']) {
       $temp_path = substr($target_path, 0, strlen($target_path) - strlen($this->_ext())); //temp path without the ext
-      $i=1;
-      while(file_exists($target_path)){
-        $target_path = $temp_path . "-" . $i . $this->_ext();
+      $i = 1;
+      while (file_exists($target_path)) {
+        $target_path = $temp_path."-".$i.$this->_ext();
         $i++;
       }
 		}
@@ -118,11 +118,11 @@ 
     * @return String | false String of finalFile name saved to the file system or false if unable to save to file system.
     * @access public
     */
-  function processFile($file = null){
+  function processFile($file = null) {
     $this->setFile($file);
 
     //check if we have a file and if we allow the type, return false otherwise.
-    if(!$this->checkFile() || !$this->checkType() || !$this->checkSize()){
+    if (!$this->checkFile() || !$this->checkType() || !$this->checkSize()) {
       return false;
     }
 
@@ -130,18 +130,18 @@ 
     $up_dir = $this->options['uploadDir'];
     $fileName = $this->__handleFileNameCallback($this->file['name']);
     //if callback returns false hault the upload
-    if(!$fileName){
+    if (!$fileName) {
       return false;
     }
-    $target_path = $up_dir . DS . $fileName;
+    $target_path = $up_dir.DS.$fileName;
     $target_path = $this->__handleUnique($target_path);
 
     //now move the file.
-    if(move_uploaded_file($this->file['tmp_name'], $target_path)){
+    if (move_uploaded_file($this->file['tmp_name'], $target_path)) {
       $this->finalFile = basename($target_path);
       return $this->finalFile;
     }
-    else{
+    else {
       $this->_error('Unable to save temp file to file system.');
       return false;
     }
@@ -153,8 +153,8 @@ 
     * @param file array of uploaded file. (optional)
     * @return void
     */
-  function setFile($file = null){
-    if($file) $this->file = $file;
+  function setFile($file = null) {
+    if ($file) $this->file = $file;
   }
 
   /**
@@ -164,9 +164,9 @@ 
     * @param file array of uploaded file (optional)
     * @access protected
     */
-  function _ext($file = null){
+  function _ext($file = null) {
     $this->setFile($file);
-    return strrchr($this->file['name'],".");
+    return strrchr($this->file['name'], ".");
   }
 
   /**
@@ -176,7 +176,7 @@ 
   * @return void
   * @access protected
   */
-  function _error($text){
+  function _error($text) {
     $this->errors[] = __($text);
   }
 
@@ -187,20 +187,20 @@ 
   * @param file array of uploaded file (optional)
   * @access public
   */
-  function checkType($file = null){
+  function checkType($file = null) {
     $this->setFile($file);
-    foreach($this->options['allowedTypes'] as $ext => $types){
-      if(!is_string($ext)){
+    foreach ($this->options['allowedTypes'] as $ext => $types) {
+      if (!is_string($ext)) {
         $ext = $types;
       }
-      if($ext == '*'){
+      if ($ext == '*') {
         return true;
       }
 
-      $ext = strtolower('.' . str_replace('.','', $ext));
+      $ext = strtolower('.'.str_replace('.', '', $ext));
       $file_ext = strtolower($this->_ext());
-      if($file_ext == $ext){
-        if(is_array($types) && !in_array($this->file['type'], $types)){
+      if ($file_ext == $ext) {
+        if (is_array($types) && !in_array($this->file['type'], $types)) {
           $this->_error("{$this->file['type']} is not an allowed type.");
           return false;
         }
@@ -221,10 +221,10 @@ 
     * @access public
     * @param file array of uploaded file (optional)
     */
-  function checkFile($file = null){
+  function checkFile($file = null) {
     $this->setFile($file);
-    if($this->hasUpload() && $this->file){
-      if(isset($this->file['error']) && $this->file['error'] == UPLOAD_ERR_OK ) {
+    if ($this->hasUpload() && $this->file) {
+      if (isset($this->file['error']) && $this->file['error'] == UPLOAD_ERR_OK) {
         return true;
       }
       else {
@@ -241,13 +241,13 @@ 
     * @access public
     * @param file array of uploaded file (optional)
     */
-  function checkSize($file = null){
+  function checkSize($file = null) {
     $this->setFile($file);
-    if($this->hasUpload() && $this->file){
-      if(!$this->options['maxFileSize']){ //We don't want to test maxFileSize
+    if ($this->hasUpload() && $this->file) {
+      if (!$this->options['maxFileSize']) { //We don't want to test maxFileSize
         return true;
       }
-      elseif($this->options['maxFileSize'] && $this->file['size'] < $this->options['maxFileSize']){
+      elseif ($this->options['maxFileSize'] && $this->file['size'] < $this->options['maxFileSize']) {
         return true;
       }
       else {
@@ -265,16 +265,16 @@ 
     * @return boolean
     * @access public
     */
-  function removeFile($name = null){
-    if(!$name || strpos($name, '://')){
+  function removeFile($name = null) {
+    if (!$name || strpos($name, '://')) {
       return false;
     }
 
     $up_dir = $this->options['uploadDir'];
-    $target_path = $up_dir . DS . $name;
+    $target_path = $up_dir.DS.$name;
 
     //delete main image -- $name
-    if(@unlink($target_path)){
+    if (@unlink($target_path)) {
       return true;
     } else {
       return false;
@@ -287,7 +287,7 @@ 
     * @return boolean true | false depending if a file was actually uploaded.
     * @param file array of uploaded file (optional)
     */
-  function hasUpload($file = null){
+  function hasUpload($file = null) {
     $this->setFile($file);
     return ($this->_multiArrayKeyExists("tmp_name", $this->file));
   }
@@ -295,7 +295,7 @@ 
   /**
     * @return boolean true if errors were detected.
     */
-  function hasErrors(){
+  function hasErrors() {
     return count($this->errors);
   }
 
@@ -308,9 +308,9 @@ 
     * @return string
     * @access public
     */
-  function showErrors($sep = " "){
+  function showErrors($sep = " ") {
     $retval = "";
-    foreach($this->errors as $error){
+    foreach ($this->errors as $error) {
       $retval .= "$error $sep";
     }
     return $retval;
@@ -325,13 +325,13 @@ 
     * @access protected
     */
   function _multiArrayKeyExists($needle, $haystack) {
-    if(is_array($haystack)){
+    if (is_array($haystack)) {
       foreach ($haystack as $key=>$value) {
-        if ($needle===$key && $value) {
+        if ($needle === $key && $value) {
           return true;
         }
         if (is_array($value)) {
-          if($this->_multiArrayKeyExists($needle, $value)){
+          if ($this->_multiArrayKeyExists($needle, $value)) {
             return true;
           }
         }

app/Plugin/FileUpload/View/Helper/FileUploadHelper.php

Doc Comments +13 added lines, -13 removed lines

@@ -99,7 +99,7 @@ 
     * @param Array|Int $options takes an array of options passed to the image helper, or an integer representing the width of the image to display
     *         options: width = 100 (default), if width is set along with autoResize the uploaded image will be resized.
     * @access public
-    * @return mixed html tag, url string, or false if unable to find image.
+    * @return string|false html tag, url string, or false if unable to find image.
     */
   function image($name, $options = array()){
     $this->fileName = $name;
@@ -329,7 +329,7 @@ 
 		 * Constructor
 		 *
 		 * @param [String $imgFile] Image File Name
-		 * @return RESIZEIMAGE (Class Object)
+		 * @return false|null (Class Object)
 		 */
 		function __construct($imgFile=""){
 			if (!function_exists("imagecreate")){
@@ -356,7 +356,7 @@ 
 		 * Set image file name
 		 *
 		 * @param String $imgFile
-		 * @return void
+		 * @return boolean
 		 */
 		function setImage($imgFile){
 			$this->imgFile=$imgFile;
@@ -374,7 +374,7 @@ 
 		 * Resize a image to given width and height and keep it's current width and height ratio
 		 *
 		 * @param Number $imgwidth
-		 * @param Numnber $imgheight
+		 * @param integer $imgheight
 		 * @param String $newfile
 		 */
 		function resize_limitwh($imgwidth,$imgheight,$newfile=NULL){
@@ -394,9 +394,9 @@ 
     /**
 		 * Resize an image to given percentage.
 		 *
-		 * @param Number $percent
+		 * @param integer $percent
 		 * @param String $newfile
-		 * @return Boolean
+		 * @return false|null
 		 */
 		function resize_percentage($percent=100,$newfile=NULL)	{
 			$newWidth=($this->imgWidth*$percent)/100;
@@ -407,10 +407,10 @@ 
     /**
 		 * Resize an image to given X and Y percentage.
 		 *
-		 * @param Number $xpercent
-		 * @param Number $ypercent
+		 * @param integer $xpercent
+		 * @param integer $ypercent
 		 * @param String $newfile
-		 * @return Boolean
+		 * @return false|null
 		 */
 		function resize_xypercentage($xpercent=100,$ypercent=100,$newfile=NULL)		{
 			$newWidth=($this->imgWidth*$xpercent)/100;
@@ -421,10 +421,10 @@ 
 		/**
 		 * Resize an image to given width and height
 		 *
-		 * @param Number $width
-		 * @param Number $height
+		 * @param integer $width
+		 * @param integer $height
 		 * @param String $newfile
-		 * @return Boolean
+		 * @return false|null
 		 */
 		function resize($width,$height,$newfile=NULL){
 			if(empty($this->imgFile)){
@@ -483,7 +483,7 @@ 
 		 * @param Number $width
 		 * @param Number $height
 		 * @param String $newfile
-		 * @return Boolean
+		 * @return false|null
 		 */
 		function _resize($width,$height,$newfile=NULL){
 			if (!function_exists("imagecreate")){

Spacing +118 added lines, -118 removed lines

@@ -20,7 +20,7 @@ 
   *
   */
 App::import('Config', 'FileUpload.file_upload_settings');
-class FileUploadHelper extends AppHelper{
+class FileUploadHelper extends AppHelper {
   var $helpers = array('Html', 'Form');
 
   /**
@@ -64,7 +64,7 @@ 
     * Constructor, initiallizes the FileUpload Component
     * and sets the default options.
     */
-  function __construct(View $View, $settings = array()){
+  function __construct(View $View, $settings = array()) {
 		parent::__construct($View, $settings);
     $this->FileUploadSettings = new FileUploadSettings;
 
@@ -77,7 +77,7 @@ 
     * @access public
     * @return void
     */
-  function reset(){
+  function reset() {
     $this->fileName = null;
     $this->options = array(
       'width' => 0,
@@ -101,10 +101,10 @@ 
     * @access public
     * @return mixed html tag, url string, or false if unable to find image.
     */
-  function image($name, $options = array()){
+  function image($name, $options = array()) {
     $this->fileName = $name;
     //options takes in a width as well
-    if(is_int($options)){
+    if (is_int($options)) {
       $width = $options;
       $options = array();
       $options['width'] = $width;
@@ -113,14 +113,14 @@ 
     $this->settings = array_merge($this->settings, $options);
 
     $img = false;
-    if(is_string($name)){
+    if (is_string($name)) {
       $img = $this->_getImageByName();
     }
-    elseif(is_int($name)){
+    elseif (is_int($name)) {
       $img = $this->_getImageById();
     }
 
-    if($img){
+    if ($img) {
       return $img;
     }
 
@@ -135,13 +135,13 @@ 
     * @return String HTML form input element configured for the FileUploadComponent
     * @access public
     */
-  function input($options = array()){
+  function input($options = array()) {
     $options = array_merge(
-      array('var' => $this->settings['fileVar'],'model' => $this->settings['fileModel']),
+      array('var' => $this->settings['fileVar'], 'model' => $this->settings['fileModel']),
       $options
     );
     $configs = $options;
-    if($configs['model']){
+    if ($configs['model']) {
       unset($options['model'], $options['var']);
 
       return $this->Form->input("{$configs['model']}.".$this->inputCount++.".{$configs['var']}", array_merge(array('type'=>'file'), $options));
@@ -154,20 +154,20 @@ 
   /**
     * @access protected
     */
-  function _getImageById(){
+  function _getImageById() {
     App::import('Component', 'FileUpload.FileUpload');
     $this->FileUpload = new FileUploadComponent;
 
     $id = $this->fileName;
     $this->FileUpload->options['fileModel'] = $this->settings['fileModel'];
-    $Model =& $this->FileUpload->getModel();
+    $Model = & $this->FileUpload->getModel();
     $Model->recursive = -1;
     $upload = $Model->findById($id);
-    if(!empty($upload)){
+    if (!empty($upload)) {
       $this->fileName = $upload[$this->settings['fileModel']][$this->settings['fields']['name']];
       return $this->_getImageByName();
     }
-    else{
+    else {
       return false;
     }
   }
@@ -177,12 +177,12 @@ 
     * @access protected
     * @return String full path of the file name
     */
-  function _getFullPath(){
-    if($this->_isOutsideSource()){
+  function _getFullPath() {
+    if ($this->_isOutsideSource()) {
       return $this->fileName;
     }
     else {
-      return WWW_ROOT . $this->_getUploadPath();
+      return WWW_ROOT.$this->_getUploadPath();
     }
   }
 
@@ -191,12 +191,12 @@ 
     * @access protected
     * @return String full path of the file name
     */
-  function _getImagePath(){
-    if($this->_isOutsideSource()){
+  function _getImagePath() {
+    if ($this->_isOutsideSource()) {
       return $this->fileName;
     }
     else {
-      return '/' . $this->_getUploadPath();
+      return '/'.$this->_getUploadPath();
     }
   }
 
@@ -205,8 +205,8 @@ 
     * @access protected
     * @return String upload path of all files
     */
-  function _getUploadPath(){
-    return $this->settings['uploadDir'] . '/' . $this->fileName;
+  function _getUploadPath() {
+    return $this->settings['uploadDir'].'/'.$this->fileName;
   }
 
   /**
@@ -214,8 +214,8 @@ 
     * @access protected
     * @return String extension of filename
     */
-  function _getExt(){
-    return strrchr($this->fileName,".");
+  function _getExt() {
+    return strrchr($this->fileName, ".");
   }
 
   /**
@@ -225,12 +225,12 @@ 
     * if not, make it, save it, and return it.
     * @return String HTML of resized or full image.
     */
-  function _getImageByName(){
+  function _getImageByName() {
     //only proceed if we actually have the file in question
-    if(!$this->_isOutsideSource() && !file_exists($this->_getFullPath())) return false;
+    if (!$this->_isOutsideSource() && !file_exists($this->_getFullPath())) return false;
 
     //resize if we have resize on, a width, and if it doesn't already exist.
-    if($this->options['autoResize'] && $this->options['width'] > 0 && !file_exists($this->_getResizeNameOrPath($this->_getFullPath()))){
+    if ($this->options['autoResize'] && $this->options['width'] > 0 && !file_exists($this->_getResizeNameOrPath($this->_getFullPath()))) {
       $this->_resizeImage();
     }
     return $this->_htmlImage();
@@ -240,11 +240,11 @@ 
     * @return String of the resizedpath of a filename or path.
     * @access protected
     */
-  function _getResizeNameOrPath($file_name_or_path){
+  function _getResizeNameOrPath($file_name_or_path) {
     $file_name = basename($file_name_or_path);
     $path = substr($file_name_or_path, 0, strlen($file_name_or_path) - strlen($file_name));
-    $temp_path = substr($file_name,0,strlen($file_name) - strlen($this->_getExt())) . "x" . $this->options['width'] . $this->_getExt();
-    $full_path = (strlen($this->options['resizedDir']) > 0) ? $path . $this->options['resizedDir'] . '/' . $temp_path : $path . $temp_path;
+    $temp_path = substr($file_name, 0, strlen($file_name) - strlen($this->_getExt()))."x".$this->options['width'].$this->_getExt();
+    $full_path = (strlen($this->options['resizedDir']) > 0) ? $path.$this->options['resizedDir'].'/'.$temp_path : $path.$temp_path;
     return $full_path;
   }
 
@@ -253,9 +253,9 @@ 
     * @access protected
     * @return null
     */
-  function _resizeImage(){
+  function _resizeImage() {
     $this->newImage = new RResizeImage($this->_getFullPath());
-    if($this->newImage->imgWidth > $this->options['width']){
+    if ($this->newImage->imgWidth > $this->options['width']) {
       $this->newImage->resize_limitwh($this->options['width'], 0, $this->_getResizeNameOrPath($this->_getFullPath()));
     }
     else {
@@ -268,9 +268,9 @@ 
     * @access protected
     * @return String HTML image asked for
     */
-  function _htmlImage(){
-    if(!$this->_isOutsideSource() && $this->options['autoResize'] && $this->options['width'] > 0){
-      if(isset($this->newImage) && $this->newImage->imgWidth && $this->newImage->imgWidth <= $this->options['width']){
+  function _htmlImage() {
+    if (!$this->_isOutsideSource() && $this->options['autoResize'] && $this->options['width'] > 0) {
+      if (isset($this->newImage) && $this->newImage->imgWidth && $this->newImage->imgWidth <= $this->options['width']) {
         $image = $this->_getImagePath();
       }
       else {
@@ -285,10 +285,10 @@ 
     //unset the default options
     unset($options['resizedDir'], $options['uploadDir'], $options['imagePathOnly'], $options['autoResize'], $options['resizeThumbOnly']);
     //unset width only if we're not an outsourced image, we have resize turned on, or we don't have a width to begin with.
-    if(!$this->_isOutsideSource() && ($this->options['resizeThumbOnly'] || !$options['width'])) unset($options['width']);
+    if (!$this->_isOutsideSource() && ($this->options['resizeThumbOnly'] || !$options['width'])) unset($options['width']);
 
     //return the impage path or image html
-    if($this->options['imagePathOnly']){
+    if ($this->options['imagePathOnly']) {
       return $image;
     }
     else {
@@ -299,7 +299,7 @@ 
   /**
     * _isOutsideSource searches the fileName string for :// to determine if the image source is inside or outside our server
     */
-  function _isOutsideSource(){
+  function _isOutsideSource() {
     return !!strpos($this->fileName, '://');
   }
 }
@@ -315,15 +315,15 @@ 
 	 *
 	 */
 	//define("HAR_AUTO_NAME",1);
-	Class RResizeImage	{
-		var $imgFile="";
-		var $imgWidth=0;
-		var $imgHeight=0;
-		var $imgType="";
-		var $imgAttr="";
-		var $type=NULL;
-		var $_img=NULL;
-		var $_error="";
+	Class RResizeImage {
+		var $imgFile = "";
+		var $imgWidth = 0;
+		var $imgHeight = 0;
+		var $imgType = "";
+		var $imgAttr = "";
+		var $type = NULL;
+		var $_img = NULL;
+		var $_error = "";
 
 		/**
 		 * Constructor
@@ -331,14 +331,14 @@ 
 		 * @param [String $imgFile] Image File Name
 		 * @return RESIZEIMAGE (Class Object)
 		 */
-		function __construct($imgFile=""){
-			if (!function_exists("imagecreate")){
-				$this->_error="Error: GD Library is not available.";
+		function __construct($imgFile = "") {
+			if (!function_exists("imagecreate")) {
+				$this->_error = "Error: GD Library is not available.";
 				return false;
 			}
 
-			$this->type=Array(1 => 'GIF', 2 => 'JPG', 3 => 'PNG', 4 => 'SWF', 5 => 'PSD', 6 => 'BMP', 7 => 'TIFF', 8 => 'TIFF', 9 => 'JPC', 10 => 'JP2', 11 => 'JPX', 12 => 'JB2', 13 => 'SWC', 14 => 'IFF', 15 => 'WBMP', 16 => 'XBM');
-			if(!empty($imgFile)){
+			$this->type = Array(1 => 'GIF', 2 => 'JPG', 3 => 'PNG', 4 => 'SWF', 5 => 'PSD', 6 => 'BMP', 7 => 'TIFF', 8 => 'TIFF', 9 => 'JPC', 10 => 'JP2', 11 => 'JPX', 12 => 'JB2', 13 => 'SWC', 14 => 'IFF', 15 => 'WBMP', 16 => 'XBM');
+			if (!empty($imgFile)) {
 				$this->setImage($imgFile);
       }
 		}
@@ -348,7 +348,7 @@ 
 		 *
 		 * @return String
 		 */
-		function error(){
+		function error() {
 			return $this->_error;
 		}
 
@@ -358,15 +358,15 @@ 
 		 * @param String $imgFile
 		 * @return void
 		 */
-		function setImage($imgFile){
-			$this->imgFile=$imgFile;
+		function setImage($imgFile) {
+			$this->imgFile = $imgFile;
 			return $this->_createImage();
 		}
 
     /**
 		 * @return void
 		 */
-		function close(){
+		function close() {
 			return @imagedestroy($this->_img);
 		}
 
@@ -377,18 +377,18 @@ 
 		 * @param Numnber $imgheight
 		 * @param String $newfile
 		 */
-		function resize_limitwh($imgwidth,$imgheight,$newfile=NULL){
+		function resize_limitwh($imgwidth, $imgheight, $newfile = NULL) {
 			$image_per = 100;
 			list($width, $height, $type, $attr) = @getimagesize($this->imgFile);
-			if($width > $imgwidth && $imgwidth > 0){
-				$image_per = (double)(($imgwidth * 100) / $width);
+			if ($width > $imgwidth && $imgwidth > 0) {
+				$image_per = (double) (($imgwidth * 100) / $width);
       }
 
-			if(floor(($height * $image_per)/100)>$imgheight && $imgheight > 0){
-				$image_per = (double)(($imgheight * 100) / $height);
+			if (floor(($height * $image_per) / 100) > $imgheight && $imgheight > 0) {
+				$image_per = (double) (($imgheight * 100) / $height);
       }
 
-			$this->resize_percentage($image_per,$newfile);
+			$this->resize_percentage($image_per, $newfile);
 		}
 
     /**
@@ -398,10 +398,10 @@ 
 		 * @param String $newfile
 		 * @return Boolean
 		 */
-		function resize_percentage($percent=100,$newfile=NULL)	{
-			$newWidth=($this->imgWidth*$percent)/100;
-			$newHeight=($this->imgHeight*$percent)/100;
-			return $this->resize($newWidth,$newHeight,$newfile);
+		function resize_percentage($percent = 100, $newfile = NULL) {
+			$newWidth = ($this->imgWidth * $percent) / 100;
+			$newHeight = ($this->imgHeight * $percent) / 100;
+			return $this->resize($newWidth, $newHeight, $newfile);
 		}
 
     /**
@@ -412,10 +412,10 @@ 
 		 * @param String $newfile
 		 * @return Boolean
 		 */
-		function resize_xypercentage($xpercent=100,$ypercent=100,$newfile=NULL)		{
-			$newWidth=($this->imgWidth*$xpercent)/100;
-			$newHeight=($this->imgHeight*$ypercent)/100;
-			return $this->resize($newWidth,$newHeight,$newfile);
+		function resize_xypercentage($xpercent = 100, $ypercent = 100, $newfile = NULL) {
+			$newWidth = ($this->imgWidth * $xpercent) / 100;
+			$newHeight = ($this->imgHeight * $ypercent) / 100;
+			return $this->resize($newWidth, $newHeight, $newfile);
 		}
 
 		/**
@@ -426,19 +426,19 @@ 
 		 * @param String $newfile
 		 * @return Boolean
 		 */
-		function resize($width,$height,$newfile=NULL){
-			if(empty($this->imgFile)){
-				$this->_error="File name is not initialised.";
+		function resize($width, $height, $newfile = NULL) {
+			if (empty($this->imgFile)) {
+				$this->_error = "File name is not initialised.";
 				return false;
 			}
-			if($this->imgWidth<=0 || $this->imgHeight<=0){
-				$this->_error="Could not resize given image";
+			if ($this->imgWidth <= 0 || $this->imgHeight <= 0) {
+				$this->_error = "Could not resize given image";
 				return false;
 			}
-			if($width<=0)	$width=$this->imgWidth;
-			if($height<=0) $height=$this->imgHeight;
+			if ($width <= 0)	$width = $this->imgWidth;
+			if ($height <= 0) $height = $this->imgHeight;
 
-			return $this->_resize($width,$height,$newfile);
+			return $this->_resize($width, $height, $newfile);
 		}
 
 		/**
@@ -448,8 +448,8 @@ 
 		 */
 		function _getImageInfo()
 		{
-			@list($this->imgWidth,$this->imgHeight,$type,$this->imgAttr)=@getimagesize($this->imgFile);
-			$this->imgType=$this->type[$type];
+			@list($this->imgWidth, $this->imgHeight, $type, $this->imgAttr) = @getimagesize($this->imgFile);
+			$this->imgType = $this->type[$type];
 		}
 
 		/**
@@ -457,20 +457,20 @@ 
 		 * @access Private
 		 * @return Boolean
 		 */
-		function _createImage(){
+		function _createImage() {
 			$this->_getImageInfo();
-			if($this->imgType=='GIF'){
-				$this->_img=@imagecreatefromgif($this->imgFile);
+			if ($this->imgType == 'GIF') {
+				$this->_img = @imagecreatefromgif($this->imgFile);
 			}
-			elseif($this->imgType=='JPG'){
-				$this->_img=@imagecreatefromjpeg($this->imgFile);
+			elseif ($this->imgType == 'JPG') {
+				$this->_img = @imagecreatefromjpeg($this->imgFile);
 			}
-			elseif($this->imgType=='PNG'){
-				$this->_img=@imagecreatefrompng($this->imgFile);
+			elseif ($this->imgType == 'PNG') {
+				$this->_img = @imagecreatefrompng($this->imgFile);
 			}
 
-			if(!$this->_img || !@is_resource($this->_img)){
-				$this->_error="Error loading ".$this->imgFile;
+			if (!$this->_img || !@is_resource($this->_img)) {
+				$this->_error = "Error loading ".$this->imgFile;
 				return false;
 			}
 			return true;
@@ -485,64 +485,64 @@ 
 		 * @param String $newfile
 		 * @return Boolean
 		 */
-		function _resize($width,$height,$newfile=NULL){
-			if (!function_exists("imagecreate")){
-				$this->_error="Error: GD Library is not available.";
+		function _resize($width, $height, $newfile = NULL) {
+			if (!function_exists("imagecreate")) {
+				$this->_error = "Error: GD Library is not available.";
 				return false;
 			}
 
-			$newimg=@imagecreatetruecolor($width,$height);
+			$newimg = @imagecreatetruecolor($width, $height);
 			//imagecolortransparent( $newimg, imagecolorat( $newimg, 0, 0 ) );
 
-			if($this->imgType=='GIF' || $this->imgType=='PNG')	{
+			if ($this->imgType == 'GIF' || $this->imgType == 'PNG') {
 				/** Code to keep transparency of image **/
 				$colorcount = imagecolorstotal($this->_img);
 				if ($colorcount == 0) $colorcount = 256;
-				imagetruecolortopalette($newimg,true,$colorcount);
-				imagepalettecopy($newimg,$this->_img);
+				imagetruecolortopalette($newimg, true, $colorcount);
+				imagepalettecopy($newimg, $this->_img);
 				$transparentcolor = imagecolortransparent($this->_img);
-				imagefill($newimg,0,0,$transparentcolor);
-				imagecolortransparent($newimg,$transparentcolor);
+				imagefill($newimg, 0, 0, $transparentcolor);
+				imagecolortransparent($newimg, $transparentcolor);
 			}
 
-			@imagecopyresampled ( $newimg, $this->_img, 0,0,0,0, $width, $height, $this->imgWidth,$this->imgHeight);
+			@imagecopyresampled($newimg, $this->_img, 0, 0, 0, 0, $width, $height, $this->imgWidth, $this->imgHeight);
 
-			if($newfile===1)	{
-				if(@preg_match("/\..*+$/",@basename($this->imgFile),$matches)){
-			   		$newfile=@substr_replace($this->imgFile,"_har",-@strlen($matches[0]),0);
+			if ($newfile === 1) {
+				if (@preg_match("/\..*+$/", @basename($this->imgFile), $matches)) {
+			   		$newfile = @substr_replace($this->imgFile, "_har", -@strlen($matches[0]), 0);
         }
 			}
-			elseif(!empty($newfile)){
-				if(!@preg_match("/\..*+$/",@basename($newfile))){
-					if(@preg_match("/\..*+$/",@basename($this->imgFile),$matches)){
-					   $newfile=$newfile.$matches[0];
+			elseif (!empty($newfile)) {
+				if (!@preg_match("/\..*+$/", @basename($newfile))) {
+					if (@preg_match("/\..*+$/", @basename($this->imgFile), $matches)) {
+					   $newfile = $newfile.$matches[0];
           }
 				}
 			}
 
-			if($this->imgType=='GIF'){
-				if(!empty($newfile)){
-          @imagegif($newimg,$newfile);
+			if ($this->imgType == 'GIF') {
+				if (!empty($newfile)) {
+          @imagegif($newimg, $newfile);
         }
 				else {
 					@header("Content-type: image/gif");
 					@imagegif($newimg);
 				}
 			}
-			elseif($this->imgType=='JPG'){
-				if(!empty($newfile)){
-					@imagejpeg($newimg,$newfile);
+			elseif ($this->imgType == 'JPG') {
+				if (!empty($newfile)) {
+					@imagejpeg($newimg, $newfile);
         }
-				else	{
+				else {
 					@header("Content-type: image/jpeg");
 					@imagejpeg($newimg);
 				}
 			}
-			elseif($this->imgType=='PNG'){
-				if(!empty($newfile)){
-					@imagepng($newimg,$newfile);
+			elseif ($this->imgType == 'PNG') {
+				if (!empty($newfile)) {
+					@imagepng($newimg, $newfile);
         }
-				else{
+				else {
 					@header("Content-type: image/png");
 					@imagepng($newimg);
 				}

app/Plugin/Install/Controller/InstallController.php

Doc Comments +1 added lines, -1 removed lines

@@ -110,7 +110,7 @@
  * credentials or create the missing database
  * Create the database file and insert the submitted details
  *
- * @return void
+ * @return null|CakeResponse
  * @access public
  */
 	public function database() {

Spacing +11 added lines, -11 removed lines

@@ -83,7 +83,7 @@ 
  * @return void
  */
 	protected function _check() {
-		if (file_exists(APP . 'Config' . DS . 'installed.txt')) {
+		if (file_exists(APP.'Config'.DS.'installed.txt')) {
 //		if (Configure::read('Install.installed') && Configure::read('Install.secured')) {
 			$this->Session->setFlash('Already Installed');
 			$this->redirect('/');
@@ -142,16 +142,16 @@ 
 			return;
 		}
 
-		copy(APP . 'Config' . DS.'database.php.install', APP . 'Config' . DS.'database.php');
+		copy(APP.'Config'.DS.'database.php.install', APP.'Config'.DS.'database.php');
 		App::uses('File', 'Utility');
-		$file = new File(APP . 'Config' . DS.'database.php', true);
+		$file = new File(APP.'Config'.DS.'database.php', true);
 		$content = $file->read();
 
 		foreach ($config AS $configKey => $configValue) {
-			$content = str_replace('{default_' . $configKey . '}', $configValue, $content);
+			$content = str_replace('{default_'.$configKey.'}', $configValue, $content);
 		}
 
-		if($file->write($content) ) {
+		if ($file->write($content)) {
 			return $this->redirect(array('action' => 'data'));
 		} else {
 			$this->Session->setFlash(__('Could not write database.php file.'), 'default', array('class' => 'error'));
@@ -166,7 +166,7 @@ 
 		$nextValue = $model->find('first', array(
 			'fields' => sprintf('MAX(%s.%s) as max', $model->alias, $model->primaryKey),
 			));
-		$nextValue = empty($nextValue[0]['max']) ? 1 :  $nextValue[0]['max'] + 1;
+		$nextValue = empty($nextValue[0]['max']) ? 1 : $nextValue[0]['max'] + 1;
 		$sql = sprintf('alter sequence %s restart with %d', $db->getSequence($model), $nextValue);
 		$db->execute($sql);
 	}
@@ -187,12 +187,12 @@ 
 
 			$db = ConnectionManager::getDataSource('default');
 			$brokenSequence = $db instanceof Postgres;
-			if(!$db->isConnected()) {
+			if (!$db->isConnected()) {
 				$this->Session->setFlash(__('Could not connect to database.'), 'default', array('class' => 'error'));
 			} else {
 				$schema = new CakeSchema(array('name'=>'app'));
 				$schema = $schema->load();
-				foreach($schema->tables as $table => $fields) {
+				foreach ($schema->tables as $table => $fields) {
 					$create = $db->createSchema($schema, $table);
 					try {
 						$db->execute($create);
@@ -203,10 +203,10 @@ 
 					}
 				}
 
-				$path = CakePlugin::path('Install') .DS. 'Config' .DS. 'Data' .DS;
+				$path = CakePlugin::path('Install').DS.'Config'.DS.'Data'.DS;
 				$dataObjects = App::objects('class', $path);
 				foreach ($dataObjects as $data) {
-					include($path . $data . '.php');
+					include($path.$data.'.php');
 					$classVars = get_class_vars($data);
 					$modelAlias = substr($data, 0, -4);
 					$table = $classVars['table'];
@@ -219,7 +219,7 @@ 
 					));
 					if (is_array($records) && count($records) > 0) {
 						$i = 1;
-						foreach($records as $record) {
+						foreach ($records as $record) {
 							if (!isset($record['id'])) {
 								$record['id'] = $i++;
 							}