PiedWeb\CMSBundle\Service\VichUploadPropertyNamer

Complexity

Total Complexity

4

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getExtension()	0	14	3
A	name()	0	3	1

<?php

namespace PiedWeb\CMSBundle\Service;

use Symfony\Component\HttpFoundation\File\UploadedFile;
use Vich\UploaderBundle\Mapping\PropertyMapping;

class VichUploadPropertyNamer extends \Vich\UploaderBundle\Naming\PropertyNamer //implements NamerInterface, ConfigurableInterface
{
    /**
     * Guess the extension of the given file.
     *
     * @param UploadedFile $file
     *
     * @return string|null
     */
    private function getExtension(UploadedFile $file): ?string

The method getExtension() is not used, and could be removed.

The parameter $file is not used and could be removed.

    {
        var_dump('hello'); exit;

var_dump('hello') looks like debug code. Are you sure you do not want to remove it?

Using exit here is not recommended.

        $originalName = $file->getClientOriginalName();

$originalName = $file->getClientOriginalName() is not reachable.

        if ($extension = pathinfo($originalName, PATHINFO_EXTENSION)) {
            return strtolower($extension);
        }

        if ($extension = $file->guessExtension()) {
            return strtolower($extension);
        }

        return null;
    }

    public function name($object, PropertyMapping $mapping): string
    {
        return strtolower(parent::name($object, $mapping));
    }
}