SubjectIdentifier::setUpdatedAt() - Code Metrics - Inspection of "Merge pull request #748 from PROCERGS/preview-1.18..." - PROCERGS/login-cidadao - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Branch — master (116909)

by Guilherme

created 2018-01-16 11:00 UTC

SubjectIdentifier::setUpdatedAt() A

↳ Parent: SubjectIdentifier

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	1
dl	0
loc	9
ccs	5
cts	5
cp	1
crap	2
rs	9.6666
c	0
b	0
f	0

<?php
/**
 * This file is part of the login-cidadao project or it's bundles.
 *
 * (c) Guilherme Donato <guilhermednt on github>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace LoginCidadao\OpenIDBundle\Entity;

use Doctrine\ORM\Mapping as ORM;
use LoginCidadao\CoreBundle\Model\PersonInterface;
use LoginCidadao\OAuthBundle\Model\ClientInterface;
use Symfony\Bridge\Doctrine\Validator\Constraints\UniqueEntity;

/**
 * @ORM\Entity(repositoryClass="LoginCidadao\OpenIDBundle\Entity\SubjectIdentifierRepository")
 * @UniqueEntity({"client", "person"})
 * @ORM\HasLifecycleCallbacks
 * @ORM\Table(name="subject_identifier")
 */
class SubjectIdentifier
{
    /**
     * @ORM\Id
     * @ORM\Column(type="integer")
     * @ORM\GeneratedValue(strategy="AUTO")
     */
    protected $id;

    /**
     * @var PersonInterface
     * @ORM\ManyToOne(targetEntity="LoginCidadao\CoreBundle\Entity\Person")
     * @ORM\JoinColumn(name="person_id", referencedColumnName="id", nullable=false)
     */
    private $person;

    /**
     * @var ClientInterface
     * @ORM\ManyToOne(targetEntity="LoginCidadao\OAuthBundle\Entity\Client", inversedBy="authorizations")
     * @ORM\JoinColumn(name="client_id", referencedColumnName="id", nullable=false)
     */
    private $client;

    /**
     * @var mixed
     * @ORM\Column(name="subject_identifier", type="string", nullable=false)
     */
    private $subjectIdentifier;

    /**
     * @var \DateTime
     * @ORM\Column(name="created_at", type="datetime")
     */
    private $createdAt;

    /**
     * @var \DateTime
     * @ORM\Column(name="updated_at", type="datetime")
     */
    private $updatedAt;

    /**
     * @return mixed
     */
    public function getPerson()
    {
        return $this->person;
    }

    /**
     * @param mixed $person
     * @return SubjectIdentifier
     */
    public function setPerson(PersonInterface $person)
    {
        $this->person = $person;

        return $this;
    }

    /**
     * @return ClientInterface
     */
    public function getClient()
    {
        return $this->client;
    }

    /**
     * @param ClientInterface $client
     * @return SubjectIdentifier
     */
    public function setClient(ClientInterface $client)
    {
        $this->client = $client;

        return $this;
    }

    /**
     * @return mixed
     */
    public function getSubjectIdentifier()
    {
        return $this->subjectIdentifier;
    }

    /**
     * @param mixed $subjectIdentifier
     * @return SubjectIdentifier
     */
    public function setSubjectIdentifier($subjectIdentifier)
    {
        $this->subjectIdentifier = $subjectIdentifier;

        return $this;
    }

    /**
     * @return mixed
     */
    public function getCreatedAt()
    {
        return $this->createdAt;
    }

    /**
     * @ORM\PrePersist()
     * @param mixed $createdAt
     * @return SubjectIdentifier
     */
    public function setCreatedAt($createdAt = null)
    {
        if ($createdAt instanceof \DateTime) {
            $this->createdAt = $createdAt;
        } else {
            $this->createdAt = \DateTime::createFromFormat('U', time());
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        }

        return $this;
    }

    /**
     * @return \DateTime
     */
    public function getUpdatedAt()
    {
        return $this->updatedAt;
    }

    /**
     * @ORM\PrePersist()
     * @ORM\PreUpdate()
     * @param \DateTime $updatedAt
     * @return SubjectIdentifier
     */
    public function setUpdatedAt($updatedAt = null)
    {
        if ($updatedAt instanceof \DateTime) {
            $this->updatedAt = $updatedAt;
        } else {
            $this->updatedAt = \DateTime::createFromFormat('U', time());
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        }

        return $this;
    }
}


1		<?php
2		/**
3		* This file is part of the login-cidadao project or it's bundles.
4		*
5		* (c) Guilherme Donato <guilhermednt on github>
6		*
7		* For the full copyright and license information, please view the LICENSE
8		* file that was distributed with this source code.
9		*/
10
11		namespace LoginCidadao\OpenIDBundle\Entity;
12
13		use Doctrine\ORM\Mapping as ORM;
14		use LoginCidadao\CoreBundle\Model\PersonInterface;
15		use LoginCidadao\OAuthBundle\Model\ClientInterface;
16		use Symfony\Bridge\Doctrine\Validator\Constraints\UniqueEntity;
17
18		/**
19		* @ORM\Entity(repositoryClass="LoginCidadao\OpenIDBundle\Entity\SubjectIdentifierRepository")
20		* @UniqueEntity({"client", "person"})
21		* @ORM\HasLifecycleCallbacks
22		* @ORM\Table(name="subject_identifier")
23		*/
24		class SubjectIdentifier
25		{
26		/**
27		* @ORM\Id
28		* @ORM\Column(type="integer")
29		* @ORM\GeneratedValue(strategy="AUTO")
30		*/
31		protected $id;
32
33		/**
34		* @var PersonInterface
35		* @ORM\ManyToOne(targetEntity="LoginCidadao\CoreBundle\Entity\Person")
36		* @ORM\JoinColumn(name="person_id", referencedColumnName="id", nullable=false)
37		*/
38		private $person;
39
40		/**
41		* @var ClientInterface
42		* @ORM\ManyToOne(targetEntity="LoginCidadao\OAuthBundle\Entity\Client", inversedBy="authorizations")
43		* @ORM\JoinColumn(name="client_id", referencedColumnName="id", nullable=false)
44		*/
45		private $client;
46
47		/**
48		* @var mixed
49		* @ORM\Column(name="subject_identifier", type="string", nullable=false)
50		*/
51		private $subjectIdentifier;
52
53		/**
54		* @var \DateTime
55		* @ORM\Column(name="created_at", type="datetime")
56		*/
57		private $createdAt;
58
59		/**
60		* @var \DateTime
61		* @ORM\Column(name="updated_at", type="datetime")
62		*/
63		private $updatedAt;
64
65		/**
66		* @return mixed
67		*/
68	1	public function getPerson()
69		{
70	1	return $this->person;
71		}
72
73		/**
74		* @param mixed $person
75		* @return SubjectIdentifier
76		*/
77	3	public function setPerson(PersonInterface $person)
78		{
79	3	$this->person = $person;
80
81	3	return $this;
82		}
83
84		/**
85		* @return ClientInterface
86		*/
87	1	public function getClient()
88		{
89	1	return $this->client;
90		}
91
92		/**
93		* @param ClientInterface $client
94		* @return SubjectIdentifier
95		*/
96	3	public function setClient(ClientInterface $client)
97		{
98	3	$this->client = $client;
99
100	3	return $this;
101		}
102
103		/**
104		* @return mixed
105		*/
106	1	public function getSubjectIdentifier()
107		{
108	1	return $this->subjectIdentifier;
109		}
110
111		/**
112		* @param mixed $subjectIdentifier
113		* @return SubjectIdentifier
114		*/
115	3	public function setSubjectIdentifier($subjectIdentifier)
116		{
117	3	$this->subjectIdentifier = $subjectIdentifier;
118
119	3	return $this;
120		}
121
122		/**
123		* @return mixed
124		*/
125	2	public function getCreatedAt()
126		{
127	2	return $this->createdAt;
128		}
129
130		/**
131		* @ORM\PrePersist()
132		* @param mixed $createdAt
133		* @return SubjectIdentifier
134		*/
135	2	public function setCreatedAt($createdAt = null)
136		{
137	2	if ($createdAt instanceof \DateTime) {
138	1	$this->createdAt = $createdAt;
139		} else {
140	1	$this->createdAt = \DateTime::createFromFormat('U', time());
		0 ignored issues – show Documentation Bug introduced 2018-01-15 19:42 UTC by Report Bug Copy Issue Report It seems like `DateTime::createFromFormat('U', time())` can also be of type `false`. However, the property `$createdAt` is declared as type `DateTime`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
141		}
142
143	2	return $this;
144		}
145
146		/**
147		* @return \DateTime
148		*/
149	2	public function getUpdatedAt()
150		{
151	2	return $this->updatedAt;
152		}
153
154		/**
155		* @ORM\PrePersist()
156		* @ORM\PreUpdate()
157		* @param \DateTime $updatedAt
158		* @return SubjectIdentifier
159		*/
160	2	public function setUpdatedAt($updatedAt = null)
161		{
162	2	if ($updatedAt instanceof \DateTime) {
163	1	$this->updatedAt = $updatedAt;
164		} else {
165	1	$this->updatedAt = \DateTime::createFromFormat('U', time());
		0 ignored issues – show Documentation Bug introduced 2018-01-15 19:42 UTC by Report Bug Copy Issue Report It seems like `DateTime::createFromFormat('U', time())` can also be of type `false`. However, the property `$updatedAt` is declared as type `DateTime`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
166		}
167
168	2	return $this;
169		}
170		}
171

PROCERGS / login-cidadao

Branch — master (116909)

SubjectIdentifier::setUpdatedAt() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like