Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 36 | class Customer extends \Payone\Core\Helper\Base |
||
| 37 | { |
||
| 38 | /** |
||
| 39 | * Checkout session |
||
| 40 | * |
||
| 41 | * @var \Magento\Checkout\Model\Session |
||
| 42 | */ |
||
| 43 | protected $checkoutSession; |
||
| 44 | |||
| 45 | /** |
||
| 46 | * Region factory |
||
| 47 | * |
||
| 48 | * @var \Magento\Directory\Model\RegionFactory |
||
| 49 | */ |
||
| 50 | protected $regionFactory; |
||
| 51 | |||
| 52 | /** |
||
| 53 | * Constructor |
||
| 54 | * |
||
| 55 | * @param \Magento\Framework\App\Helper\Context $context |
||
| 56 | * @param \Magento\Store\Model\StoreManagerInterface $storeManager |
||
| 57 | * @param \Payone\Core\Helper\Shop $shopHelper |
||
| 58 | * @param \Magento\Checkout\Model\Session $checkoutSession |
||
| 59 | * @param \Magento\Directory\Model\RegionFactory $regionFactory |
||
| 60 | */ |
||
| 61 | public function __construct( |
||
| 62 | \Magento\Framework\App\Helper\Context $context, |
||
| 63 | \Magento\Store\Model\StoreManagerInterface $storeManager, |
||
| 64 | \Payone\Core\Helper\Shop $shopHelper, |
||
| 65 | \Magento\Checkout\Model\Session $checkoutSession, |
||
| 66 | \Magento\Directory\Model\RegionFactory $regionFactory |
||
| 67 | ) { |
||
| 68 | parent::__construct($context, $storeManager, $shopHelper); |
||
| 69 | $this->checkoutSession = $checkoutSession; |
||
| 70 | $this->regionFactory = $regionFactory; |
||
| 71 | } |
||
| 72 | |||
| 73 | /** |
||
| 74 | * Determine if the customer entered his gender |
||
| 75 | * |
||
| 76 | * @return bool |
||
| 77 | */ |
||
| 78 | View Code Duplication | public function customerHasGivenGender() |
|
|
|
|||
| 79 | { |
||
| 80 | $oCustomer = $this->checkoutSession->getQuote()->getCustomer(); |
||
| 81 | if ($oCustomer && $oCustomer->getGender()) { |
||
| 82 | return true; |
||
| 83 | } |
||
| 84 | return false; |
||
| 85 | } |
||
| 86 | |||
| 87 | /** |
||
| 88 | * Determine if the customer entered his birthday |
||
| 89 | * |
||
| 90 | * @return string|bool |
||
| 91 | */ |
||
| 92 | View Code Duplication | public function getCustomerBirthday() |
|
| 93 | { |
||
| 94 | $oCustomer = $this->checkoutSession->getQuote()->getCustomer(); |
||
| 95 | if ($oCustomer && $oCustomer->getDob()) { |
||
| 96 | return $oCustomer->getDob(); |
||
| 97 | } |
||
| 98 | return false; |
||
| 99 | } |
||
| 100 | |||
| 101 | /** |
||
| 102 | * Get the region object for the state and country given by PayPal |
||
| 103 | * |
||
| 104 | * @param string $sCountry |
||
| 105 | * @param string $sState |
||
| 106 | * @return Region|bool |
||
| 107 | */ |
||
| 108 | public function getRegion($sCountry, $sState) |
||
| 123 | |||
| 124 | /** |
||
| 125 | * Get region code by address |
||
| 126 | * |
||
| 127 | * @param QuoteAddress|OrderAddress $oAddress |
||
| 128 | * @return string |
||
| 129 | */ |
||
| 130 | public function getRegionCode($oAddress) |
||
| 142 | |||
| 143 | /** |
||
| 144 | * Map magento gender to PAYONE gender parameter |
||
| 145 | * |
||
| 146 | * @param int $iGender |
||
| 147 | * @return string |
||
| 148 | */ |
||
| 149 | public function getGenderParameter($iGender) |
||
| 159 | |||
| 160 | /** |
||
| 161 | * Map magento gender to PAYONE salutation parameter |
||
| 162 | * |
||
| 163 | * @param int $iGender |
||
| 164 | * @return string |
||
| 165 | */ |
||
| 166 | public function getSalutationParameter($iGender) |
||
| 176 | } |
||
| 177 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.