OpenROV / openrov-cockpit

src/system-plugins/rov-beacon/index.js

'use strict';

Use the function form of "use strict".

const beaconRate = 5000;

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

const ignorePressureChangeThreshold = 100000;

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

const RESIN_APP_RELEASE = process.env.RESIN_APP_RELEASE;

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

process does not seem to be defined.

class RovBeacon{

'class' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

    constructor(name,deps){
     this.state={
         name: require('os').hostname(),

require does not seem to be defined.

         //model:'trident',  //TODO: Add model detection
         battery:.7,

A leading decimal point can be confused with a dot: '.7'.

         imageVersion:RESIN_APP_RELEASE
     };
     this.beacon = null;
     this.bus = deps.globalEventLoop;

     this._lastIntPressureReading = {time:0,p:0,t:0};
    }

    start() {
     this.beacon = require('./beacon.js')({beaconRate});

'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

require does not seem to be defined.

     this.beacon.broadcast(this._genBeaconMessage.bind(this));
     this._listenForStateChanges();
    }

    stop(){
     this.beacon.stop();
     this._stopListenForStateChanges()

There should be a semicolon.

    }

    _genBeaconMessage(){
        this.state.exp=beaconRate*2; //Set the expeiration for this to 2X the broadcast rate.
        return this.state;
    }

    _listenForStateChanges(){
      this.bus.on('mcu.status',this._processMCUStatus.bind(this))

There should be a semicolon.

    }

    _stopListenForStateChanges(){
      this.bus.off('mcu.status',this._processMCUStatus.bind(this))

There should be a semicolon.

    }

    _computerPressureTrend(currentpressure,currenttemp){
        //TODO: Do we need to enhance for temperature compensation?
        if (this._lastIntPressureReading.p> (currentpressure+ignorePressureChangeThreshold)) {
            return this._lastIntPressureReading.p-currentpressure;
        }
        if (this._lastIntPressureReading.p< ( currentpressure-ignorePressureChangeThreshold)){
            return this._lastIntPressureReading.p-currentpressure;
        }
        return 0

There should be a semicolon.

    }

    _processMCUStatus(status){
        for (var data in status) {
            switch (data) {
                case 'baro_p' : 
                    //TODO: Confirm the value units of baro_p
                    //https://gitlab.com/openrov/RIOT/blob/openrov/apps/trident/CMPL3115A2.cpp#L98
                    this.state.intPressure_mb=status["baro_p"];

['baro_p'] could be written in dot notation.

                    //TODO: Does this need to be smoothed over time?
                    this.state.intPressureRate=this._computerPressureTrend(this.state.intPressure_mb,status['baro_t']);

['baro_t'] could be written in dot notation.

                    this._lastIntPressureReading = {time: Date.now(), p:this.state.intPressure_mb, t:status['baro_t']};

['baro_t'] could be written in dot notation.

                break;
                case 'vout' :
                  this.state.battery = status['vout'];

['vout'] could be written in dot notation.

                break;
                case 'batt_v': //Ma
                 this.state.battery = status['batt_v'] / 1000.0;

['batt_v'] could be written in dot notation.

                break;                
            }
        }
    }

}

module.exports = function (name, deps) {

module does not seem to be defined.

  return new RovBeacon(name, deps);
};