OpenROV / openrov-cockpit

src/system-plugins/rov-beacon/beacon.js

"use strict";

Use the function form of "use strict".

const dgram = require('dgram');

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

require does not seem to be defined.

const EventEmitter = require('events');

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

require does not seem to be defined.

const os = require('os');

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

require does not seem to be defined.

var ifaces = os.networkInterfaces();
function getBroadcastAddress(addressString) {
    var address = addressString.split('.');
    address[3] = '255';
    return address.join('.');
}

class Beacon extends EventEmitter{

'class' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

    constructor (options){
        if(!options){
            options = {}

There should be a semicolon.

        }
        super();
        this.port = options.port || 8088;
        this.broadcastAddress = options.broadcastAddress || '192.168.1.255';//;'230.185.192.108';
        this.beaconRate = options.beaconRate || 3000;
       
    }

    broadcast(messageFn) {
        var self = this;
        this.server = dgram.createSocket('udp4');
        let server = this.server;

'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

        server.on('listening', () => {

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

        var address = server.address();
            server.setBroadcast(true)

There should be a semicolon.

       //     server.setMulticastTTL(128);
       //     server.addMembership( self.broadcastAddress);   
        });

        this.beaconInterval = setInterval(broadcastNew, this.beaconRate);

setInterval does not seem to be defined.

        function broadcastNew() {
            ifaces = os.networkInterfaces(); //In case interfaces change;
            //Updated to iterate over all ipv4 interfaces
            var message = new Buffer(JSON.stringify(messageFn()));

Buffer does not seem to be defined.

            Object.keys(ifaces).forEach(function(iface) {
                ifaces[iface].forEach(function(idetail) {
                    if('IPv4' !== idetail.family || idetail.internal !== false) {
                        //Skip over internal (i.e. 127.0.0.1) and non ipv4
                        return;
                    }
                    idetail.broadcastAddress = getBroadcastAddress(idetail.address);
                    server.send(message, 0, message.length, self.port, idetail.broadcastAddress);
                });
            });
        }
        server.bind();
    }

    listen () {
        var self=this;
        this.client = dgram.createSocket('udp4');
        let client = this.client;

'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

        
        client.on('listening', function () {
            var address = client.address();
            console.log('UDP Client listening on ' + address.address + ":" + address.port);

console does not seem to be defined.

            client.setBroadcast(true)

There should be a semicolon.

      //      client.setMulticastTTL(128); 
      //      client.addMembership( self.broadcastAddress);
        });

        client.on('message', function (message, remote) {   
            self.emit("deviceAnnouncement",{remoteAddress:remote.address,remotePort:remote.port,data:message})

There should be a semicolon.

        });

        client.bind(this.port);

    }

    stop () {
        clearInterval(this.beaconInterval);

clearInterval does not seem to be defined.

        if (this.server){
            this.server.close();
        }
        if (this.client){
            this.client.close();
        }
    }
}

module.exports = function(options){

module does not seem to be defined.

    return new Beacon(options)

There should be a semicolon.

};