UserActivityObserver::deleted() - Code Metrics - Inspection of "Update activity tracking" - NNTmux/newznab-tmux - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( e2afa6...f12f55 )

by Darko

created 2025-10-28 10:20 UTC

UserActivityObserver::deleted() A

↳ Parent: UserActivityObserver

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	9
dl	0
loc	12
rs	9.9666
c	1
b	0
f	0
cc	2
nc	2
nop	1

<?php

namespace App\Observers;

use App\Models\User;
use App\Models\UserActivity;

class UserActivityObserver
{
    /**
     * Handle the User "created" event.
     */
    public function created(User $user): void
    {
        UserActivity::create([
            'user_id' => $user->id,
            'username' => $user->username,
            'activity_type' => 'registered',
            'description' => "New user registered: {$user->username}",
            'metadata' => [
                'email' => $user->email,
                'ip_address' => request()->ip(),
            ],
        ]);
    }

    /**
     * Handle the User "updated" event.
     */
    public function updated(User $user): void
    {
        // Check if the role was changed
        if ($user->isDirty('roles_id')) {
            $oldRoleId = $user->getOriginal('roles_id');
            $newRoleId = $user->roles_id;

            // Get role names
            $oldRoleName = $this->getRoleName($oldRoleId);
            $newRoleName = $this->getRoleName($newRoleId);

            UserActivity::create([
                'user_id' => $user->id,
                'username' => $user->username,
                'activity_type' => 'role_updated',
                'description' => "User role updated: {$user->username} → {$newRoleName}",
                'metadata' => [
                    'old_role_id' => $oldRoleId,
                    'new_role_id' => $newRoleId,
                    'old_role_name' => $oldRoleName,
                    'new_role_name' => $newRoleName,
                    'updated_by' => auth()->user()?->username ?? 'System',
                ],
            ]);
        }
    }

    /**
     * Handle the User "deleted" event (soft delete).
     */
    public function deleted(User $user): void
    {
        // Only log if it's a soft delete (not force delete)
        if ($user->trashed()) {
            UserActivity::create([
                'user_id' => $user->id,
                'username' => $user->username,
                'activity_type' => 'deleted',
                'description' => "User deleted: {$user->username}",
                'metadata' => [
                    'email' => $user->email,
                    'deleted_by' => auth()->user()?->username ?? 'System',
                ],
            ]);
        }
    }

    /**
     * Handle the User "restored" event.
     */
    public function restored(User $user): void
    {
        UserActivity::create([
            'user_id' => $user->id,
            'username' => $user->username,
            'activity_type' => 'registered',
            'description' => "User restored: {$user->username}",
            'metadata' => [
                'restored_by' => auth()->user()?->username ?? 'System',
            ],
        ]);
    }

    /**
     * Handle the User "force deleted" event.
     */
    public function forceDeleted(User $user): void
    {
        // Log permanent deletion
        UserActivity::create([
            'user_id' => null, // User no longer exists
            'username' => $user->username,
            'activity_type' => 'deleted',
            'description' => "User permanently deleted: {$user->username}",
            'metadata' => [
                'email' => $user->email,
                'deleted_by' => auth()->user()?->username ?? 'System',
                'permanent' => true,
            ],
        ]);
    }

    /**
     * Get role name by ID
     */
    private function getRoleName(?int $roleId): string
    {
        if (! $roleId) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            return 'None';
        }

        try {
            $role = \Spatie\Permission\Models\Role::find($roleId);

            return $role ? $role->name : "Role #{$roleId}";
        } catch (\Exception $e) {
            return "Role #{$roleId}";
        }
    }
}


1			<?php
2
3			namespace App\Observers;
4
5			use App\Models\User;
6			use App\Models\UserActivity;
7
8			class UserActivityObserver
9			{
10			/**
11			* Handle the User "created" event.
12			*/
13			public function created(User $user): void
14			{
15			UserActivity::create([
16			'user_id' => $user->id,
17			'username' => $user->username,
18			'activity_type' => 'registered',
19			'description' => "New user registered: {$user->username}",
20			'metadata' => [
21			'email' => $user->email,
22			'ip_address' => request()->ip(),
23			],
24			]);
25			}
26
27			/**
28			* Handle the User "updated" event.
29			*/
30			public function updated(User $user): void
31			{
32			// Check if the role was changed
33			if ($user->isDirty('roles_id')) {
34			$oldRoleId = $user->getOriginal('roles_id');
35			$newRoleId = $user->roles_id;
36
37			// Get role names
38			$oldRoleName = $this->getRoleName($oldRoleId);
39			$newRoleName = $this->getRoleName($newRoleId);
40
41			UserActivity::create([
42			'user_id' => $user->id,
43			'username' => $user->username,
44			'activity_type' => 'role_updated',
45			'description' => "User role updated: {$user->username} → {$newRoleName}",
46			'metadata' => [
47			'old_role_id' => $oldRoleId,
48			'new_role_id' => $newRoleId,
49			'old_role_name' => $oldRoleName,
50			'new_role_name' => $newRoleName,
51			'updated_by' => auth()->user()?->username ?? 'System',
52			],
53			]);
54			}
55			}
56
57			/**
58			* Handle the User "deleted" event (soft delete).
59			*/
60			public function deleted(User $user): void
61			{
62			// Only log if it's a soft delete (not force delete)
63			if ($user->trashed()) {
64			UserActivity::create([
65			'user_id' => $user->id,
66			'username' => $user->username,
67			'activity_type' => 'deleted',
68			'description' => "User deleted: {$user->username}",
69			'metadata' => [
70			'email' => $user->email,
71			'deleted_by' => auth()->user()?->username ?? 'System',
72			],
73			]);
74			}
75			}
76
77			/**
78			* Handle the User "restored" event.
79			*/
80			public function restored(User $user): void
81			{
82			UserActivity::create([
83			'user_id' => $user->id,
84			'username' => $user->username,
85			'activity_type' => 'registered',
86			'description' => "User restored: {$user->username}",
87			'metadata' => [
88			'restored_by' => auth()->user()?->username ?? 'System',
89			],
90			]);
91			}
92
93			/**
94			* Handle the User "force deleted" event.
95			*/
96			public function forceDeleted(User $user): void
97			{
98			// Log permanent deletion
99			UserActivity::create([
100			'user_id' => null, // User no longer exists
101			'username' => $user->username,
102			'activity_type' => 'deleted',
103			'description' => "User permanently deleted: {$user->username}",
104			'metadata' => [
105			'email' => $user->email,
106			'deleted_by' => auth()->user()?->username ?? 'System',
107			'permanent' => true,
108			],
109			]);
110			}
111
112			/**
113			* Get role name by ID
114			*/
115			private function getRoleName(?int $roleId): string
116			{
117			if (! $roleId) {
			0 ignored issues – show Bug Best Practice introduced 2025-10-28 10:30 UTC by Report Bug Copy Issue Report The expression `$roleId` of type `integer\|null` is loosely compared to `false`; this is ambiguous if the integer can be 0. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
118			return 'None';
119			}
120
121			try {
122			$role = \Spatie\Permission\Models\Role::find($roleId);
123
124			return $role ? $role->name : "Role #{$roleId}";
125			} catch (\Exception $e) {
126			return "Role #{$roleId}";
127			}
128			}
129			}
130

NNTmux / newznab-tmux

Push — master ( e2afa6...f12f55 )

UserActivityObserver::deleted() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like