Blacklight\Releases::getBrowseRange()

Complexity

Conditions	10
Paths	192

Size

Total Lines	62
Code Lines	36

Duplication

Lines	0
Ratio	0 %

Importance

Changes	10
Bugs	5	Features	0

<?php
    public function getBrowseRange($page, $cat, $start, $num, $orderBy, int $maxAge = -1, array $excludedCats = [], int|string $groupName = -1, int $minSize = 0): mixed
    {
        $page = max(1, $page);
        $start = max(0, $start);

        $orderBy = $this->getBrowseOrder($orderBy);

        $query = self::query()
            ->with(['group', 'category', 'category.parent', 'video', 'video.episode', 'videoData', 'nfo', 'failed'])
            ->where('nzbstatus', NZB::NZB_ADDED)
            ->where('passwordstatus', $this->showPasswords());

        if ($cat) {
            $categories = Category::getCategorySearch($cat, null, true);
            // If categories is empty, we don't want to return anything.
            if (! empty($categories)) {
                // if we have more than one category, we need to use whereIn
                if (\count($categories) > 1) {

It seems like $categories can also be of type string; however, parameter $value of count() does only seem to accept Countable|array, maybe add an additional type check?

                    $query->whereIn('categories_id', $categories);
                } else {
                    $query->where('categories_id', $categories);
                }
            }
        }

        if ($maxAge > 0) {
            $query->where('postdate', '>', now()->subDays($maxAge));
        }

        if (! empty($excludedCats)) {
            $query->whereNotIn('categories_id', $excludedCats);
        }

        if ($groupName !== -1) {
            $query->whereHas('usenetGroup', function ($q) use ($groupName) {
                $q->where('name', $groupName);
            });
        }

        if ($minSize > 0) {
            $query->where('size', '>=', $minSize);
        }

        $query->orderBy($orderBy[0], $orderBy[1])
            ->skip($start)
            ->take($num);

        $releases = Cache::get(md5($query->toSql().$page));

Are you sure $query->toSql() of type Illuminate\Database\Eloquent\Builder|mixed|string can be used in concatenation?

        if ($releases !== null) {
            return $releases;
        }

        $sql = $query->get();
        if ($sql->isNotEmpty()) {
            $possibleRows = $this->getBrowseCount($cat, $maxAge, $excludedCats, $groupName);
            $sql[0]->_totalcount = $sql[0]->_totalrows = $possibleRows;
        }

        $expiresAt = now()->addMinutes(config('nntmux.cache_expiry_medium'));
        Cache::put(md5($query->toSql().$page), $sql, $expiresAt);

        return $sql;
    }