Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#2508)
by Cristian
14:30
created
src/app/Models/Traits/HasUploadFields.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
      */
76 76
     public function uploadMultipleFilesToDisk($value, $attribute_name, $disk, $destination_path)
77 77
     {
78
-        if (! is_array($this->{$attribute_name})) {
78
+        if (!is_array($this->{$attribute_name})) {
79 79
             $attribute_value = json_decode($this->{$attribute_name}, true) ?? [];
80 80
         } else {
81 81
             $attribute_value = $this->{$attribute_name};
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
         if ($files_to_clear) {
88 88
             foreach ($files_to_clear as $key => $filename) {
89 89
                 \Storage::disk($disk)->delete($filename);
90
-                $attribute_value = Arr::where($attribute_value, function ($value, $key) use ($filename) {
90
+                $attribute_value = Arr::where($attribute_value, function($value, $key) use ($filename) {
91 91
                     return $value != $filename;
92 92
                 });
93 93
             }
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
         //
33 33
         // It's done inside a middleware closure in order to have
34 34
         // the complete request inside the CrudPanel object.
35
-        $this->middleware(function ($request, $next) {
35
+        $this->middleware(function($request, $next) {
36 36
             $this->crud = app()->make('crud');
37 37
             $this->crud->setRequest($request);
38 38
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Buttons.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
         $otherButtons = collect([]);
25 25
 
26 26
         // we get the buttons that belong to the specified stack
27
-        $stackButtons = $this->buttons()->reject(function ($item) use ($stack, $otherButtons) {
27
+        $stackButtons = $this->buttons()->reject(function($item) use ($stack, $otherButtons) {
28 28
             if ($item->stack != $stack) {
29 29
                 // if the button does not belong to this stack we just add it for merging later
30 30
                 $otherButtons->push($item);
@@ -36,8 +36,8 @@  discard block
 block discarded – undo
36 36
         });
37 37
 
38 38
         // we parse the ordered buttons
39
-        collect($order)->each(function ($btnKey) use ($newButtons, $stackButtons) {
40
-            if (! $button = $stackButtons->where('name', $btnKey)->first()) {
39
+        collect($order)->each(function($btnKey) use ($newButtons, $stackButtons) {
40
+            if (!$button = $stackButtons->where('name', $btnKey)->first()) {
41 41
                 abort(500, 'Button name [«'.$btnKey.'»] not found.');
42 42
             }
43 43
             $newButtons->push($button);
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         // we add the remaining buttons to the end of the ordered ones
48 48
         if (count($newButtons) < count($stackButtons)) {
49 49
             foreach ($stackButtons as $button) {
50
-                if (! $newButtons->where('name', $button->name)->first()) {
50
+                if (!$newButtons->where('name', $button->name)->first()) {
51 51
                     $newButtons->push($button);
52 52
                 }
53 53
             }
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
          */
137 137
         $button = $this->buttons()->firstWhere('name', $name);
138 138
 
139
-        if (! $button) {
139
+        if (!$button) {
140 140
             abort(500, 'CRUD Button "'.$name.'" not found. Please check the button exists before you modify it.');
141 141
         }
142 142
 
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
      */
158 158
     public function removeButton($name, $stack = null)
159 159
     {
160
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
160
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
161 161
             return $stack == null ? $button->name == $name : ($button->stack == $stack) && ($button->name == $name);
162 162
         }));
163 163
     }
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
      */
169 169
     public function removeButtons($names, $stack = null)
170 170
     {
171
-        if (! empty($names)) {
171
+        if (!empty($names)) {
172 172
             foreach ($names as $name) {
173 173
                 $this->removeButton($name, $stack);
174 174
             }
@@ -182,14 +182,14 @@  discard block
 block discarded – undo
182 182
 
183 183
     public function removeAllButtonsFromStack($stack)
184 184
     {
185
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($stack) {
185
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($stack) {
186 186
             return $button->stack == $stack;
187 187
         }));
188 188
     }
189 189
 
190 190
     public function removeButtonFromStack($name, $stack)
191 191
     {
192
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
192
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
193 193
             return $button->name == $name && $button->stack == $stack;
194 194
         }));
195 195
     }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Settings.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@
 block discarded – undo
57 57
      */
58 58
     public function settings()
59 59
     {
60
-        return Arr::sort($this->settings, function ($value, $key) {
60
+        return Arr::sort($this->settings, function($value, $key) {
61 61
             return $key;
62 62
         });
63 63
     }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Fields.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
      */
62 62
     public function afterField($targetFieldName)
63 63
     {
64
-        $this->transformFields(function ($fields) use ($targetFieldName) {
64
+        $this->transformFields(function($fields) use ($targetFieldName) {
65 65
             return $this->moveField($fields, $targetFieldName, false);
66 66
         });
67 67
     }
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
      */
74 74
     public function beforeField($targetFieldName)
75 75
     {
76
-        $this->transformFields(function ($fields) use ($targetFieldName) {
76
+        $this->transformFields(function($fields) use ($targetFieldName) {
77 77
             return $this->moveField($fields, $targetFieldName, true);
78 78
         });
79 79
     }
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
      */
86 86
     public function removeField($name)
87 87
     {
88
-        $this->transformFields(function ($fields) use ($name) {
88
+        $this->transformFields(function($fields) use ($name) {
89 89
             Arr::forget($fields, $name);
90 90
 
91 91
             return $fields;
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
      */
100 100
     public function removeFields($array_of_names)
101 101
     {
102
-        if (! empty($array_of_names)) {
102
+        if (!empty($array_of_names)) {
103 103
             foreach ($array_of_names as $name) {
104 104
                 $this->removeField($name);
105 105
             }
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
     public function removeAllFields()
113 113
     {
114 114
         $current_fields = $this->getCurrentFields();
115
-        if (! empty($current_fields)) {
115
+        if (!empty($current_fields)) {
116 116
             foreach ($current_fields as $field) {
117 117
                 $this->removeField($field['name']);
118 118
             }
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
                 $jsonCastables = ['array', 'object', 'json'];
187 187
                 $fieldCasting = $casted_attributes[$field['name']];
188 188
 
189
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
189
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
190 190
                     try {
191 191
                         $data[$field['name']] = json_decode($data[$field['name']]);
192 192
                     } catch (\Exception $e) {
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
      */
216 216
     public function orderFields($order)
217 217
     {
218
-        $this->transformFields(function ($fields) use ($order) {
218
+        $this->transformFields(function($fields) use ($order) {
219 219
             return $this->applyOrderToFields($fields, $order);
220 220
         });
221 221
     }
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
     public function hasUploadFields()
243 243
     {
244 244
         $fields = $this->getFields();
245
-        $upload_fields = Arr::where($fields, function ($value, $key) {
245
+        $upload_fields = Arr::where($fields, function($value, $key) {
246 246
             return isset($value['upload']) && $value['upload'] == true;
247 247
         });
248 248
 
@@ -305,7 +305,7 @@  discard block
 block discarded – undo
305 305
         $alreadyLoaded = $this->getLoadedFieldTypes();
306 306
         $type = $this->getFieldTypeWithNamespace($field);
307 307
 
308
-        if (! in_array($type, $this->getLoadedFieldTypes(), true)) {
308
+        if (!in_array($type, $this->getLoadedFieldTypes(), true)) {
309 309
             $alreadyLoaded[] = $type;
310 310
             $this->setLoadedFieldTypes($alreadyLoaded);
311 311
 
@@ -346,7 +346,7 @@  discard block
 block discarded – undo
346 346
      */
347 347
     public function fieldTypeNotLoaded($field)
348 348
     {
349
-        return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
349
+        return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
350 350
     }
351 351
 
352 352
     /**
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
     {
83 83
         $all_relation_fields = $this->getRelationFields();
84 84
 
85
-        return Arr::where($all_relation_fields, function ($value, $key) {
85
+        return Arr::where($all_relation_fields, function($value, $key) {
86 86
             return isset($value['pivot']) && $value['pivot'];
87 87
         });
88 88
     }
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
      */
158 158
     private function createRelationsForItem($item, $formattedData)
159 159
     {
160
-        if (! isset($formattedData['relations'])) {
160
+        if (!isset($formattedData['relations'])) {
161 161
             return false;
162 162
         }
163 163
 
@@ -212,11 +212,11 @@  discard block
 block discarded – undo
212 212
                 $key = implode('.relations.', explode('.', $relationField['entity']));
213 213
                 $fieldData = Arr::get($relationData, 'relations.'.$key, []);
214 214
 
215
-                if (! array_key_exists('model', $fieldData)) {
215
+                if (!array_key_exists('model', $fieldData)) {
216 216
                     $fieldData['model'] = $relationField['model'];
217 217
                 }
218 218
 
219
-                if (! array_key_exists('parent', $fieldData)) {
219
+                if (!array_key_exists('parent', $fieldData)) {
220 220
                     $fieldData['parent'] = $this->getRelationModel($relationField['entity'], -1);
221 221
                 }
222 222
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Relationships.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
         }
25 25
 
26 26
         if (in_array($fieldName, array_column($relations, 'name'))) {
27
-            return array_filter($relations, function ($arr) use ($fieldName) {
27
+            return array_filter($relations, function($arr) use ($fieldName) {
28 28
                 if (isset($arr['name'])) {
29 29
                     return $arr['name'] == $fieldName;
30 30
                 }
Please login to merge, or discard this patch.
tests/Unit/Http/CrudControllerTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@
 block discarded – undo
21 21
         $app['router']->get('users/{id}/edit', "$controller@edit");
22 22
         $app['router']->put('users/{id}', "$controller@update");
23 23
 
24
-        $app->singleton('crud', function ($app) {
24
+        $app->singleton('crud', function($app) {
25 25
             return new CrudPanel($app);
26 26
         });
27 27
     }
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/FetchOperation.php 1 patch
Spacing   +4 added lines, -6 removed lines patch added patch discarded remove patch
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
45 45
         // otherwise assume the arguments are actually the configuration array
46 46
         $config = [];
47 47
 
48
-        if (! is_array($arg)) {
49
-            if (! class_exists($arg)) {
48
+        if (!is_array($arg)) {
49
+            if (!class_exists($arg)) {
50 50
                 return response()->json(['error' => 'Class: '.$arg.' does not exists'], 500);
51 51
             }
52 52
             $config['model'] = $arg;
@@ -66,8 +66,7 @@  discard block
 block discarded – undo
66 66
 
67 67
         if ($search_string === false) {
68 68
             return ($config['paginate'] !== false) ?
69
-            $config['query']->paginate($config['paginate']) :
70
-            $config['query']->get();
69
+            $config['query']->paginate($config['paginate']) : $config['query']->get();
71 70
         }
72 71
 
73 72
         $textColumnTypes = ['string', 'json_string', 'text'];
@@ -85,7 +84,6 @@  discard block
 block discarded – undo
85 84
 
86 85
         // return the results with or without pagination
87 86
         return ($config['paginate'] !== false) ?
88
-                    $config['query']->paginate($config['paginate']) :
89
-                    $config['query']->get();
87
+                    $config['query']->paginate($config['paginate']) : $config['query']->get();
90 88
     }
91 89
 }
Please login to merge, or discard this patch.