Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — add-update-command ( 52996a...7d33d9 )
by Pedro
14:43
created
src/app/Console/Commands/Upgrade/UpgradeContext.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 
74 74
         $fullPath = $this->basePath($relativePath);
75 75
 
76
-        if (! $this->files->exists($fullPath)) {
76
+        if (!$this->files->exists($fullPath)) {
77 77
             return null;
78 78
         }
79 79
 
@@ -86,13 +86,13 @@  discard block
 block discarded – undo
86 86
 
87 87
     public function composerJson(): array
88 88
     {
89
-        if (! empty($this->composerJson)) {
89
+        if (!empty($this->composerJson)) {
90 90
             return $this->composerJson;
91 91
         }
92 92
 
93 93
         $content = $this->readFile('composer.json');
94 94
 
95
-        if (! $content) {
95
+        if (!$content) {
96 96
             return $this->composerJson = [];
97 97
         }
98 98
 
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
 
136 136
     public function installedPackageVersion(string $package): ?string
137 137
     {
138
-        if (! InstalledVersions::isInstalled($package)) {
138
+        if (!InstalledVersions::isInstalled($package)) {
139 139
             return null;
140 140
         }
141 141
 
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 
145 145
     public function installedPackagePrettyVersion(string $package): ?string
146 146
     {
147
-        if (! InstalledVersions::isInstalled($package)) {
147
+        if (!InstalledVersions::isInstalled($package)) {
148 148
             return null;
149 149
         }
150 150
 
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
     {
156 156
         $pretty = $this->installedPackagePrettyVersion($package);
157 157
 
158
-        if (! $pretty) {
158
+        if (!$pretty) {
159 159
             return null;
160 160
         }
161 161
 
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
         foreach ($directories as $directory) {
184 184
             $absoluteDirectory = $this->resolvePath($directory);
185 185
 
186
-            if (! $this->files->isDirectory($absoluteDirectory)) {
186
+            if (!$this->files->isDirectory($absoluteDirectory)) {
187 187
                 continue;
188 188
             }
189 189
 
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
248 248
         $fullPath = $this->basePath($relativePath);
249 249
 
250 250
         try {
251
-            if (! $this->files->exists($fullPath)) {
251
+            if (!$this->files->exists($fullPath)) {
252 252
                 return true;
253 253
             }
254 254
 
@@ -310,7 +310,7 @@  discard block
 block discarded – undo
310 310
     {
311 311
         $extension = strtolower(pathinfo($filename, PATHINFO_EXTENSION));
312 312
 
313
-        if (! in_array($extension, $this->searchableExtensions, true)) {
313
+        if (!in_array($extension, $this->searchableExtensions, true)) {
314 314
             return true;
315 315
         }
316 316
 
Please login to merge, or discard this patch.
src/app/Console/Commands/Upgrade/UpgradeCommand.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
     {
23 23
         $format = $this->outputFormat();
24 24
 
25
-        if (! in_array($format, ['cli', 'json'], true)) {
25
+        if (!in_array($format, ['cli', 'json'], true)) {
26 26
             $this->errorBlock(sprintf('Unknown output format "%s". Supported formats: cli, json.', $format));
27 27
 
28 28
             return Command::INVALID;
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
                     $this->closeProgressBlock(strtoupper($fixResult->status->label()), $fixResult->status->color());
85 85
                     $this->printResultDetails($fixResult);
86 86
 
87
-                    if (! $fixResult->status->isFailure()) {
87
+                    if (!$fixResult->status->isFailure()) {
88 88
                         $this->progressBlock('Re-running '.$step->title());
89 89
 
90 90
                         try {
@@ -121,14 +121,14 @@  discard block
 block discarded – undo
121 121
     {
122 122
         $format = $this->outputFormat();
123 123
 
124
-        $hasFailure = collect($results)->contains(function ($entry) {
124
+        $hasFailure = collect($results)->contains(function($entry) {
125 125
             /** @var StepResult $result */
126 126
             $result = $entry['result'];
127 127
 
128 128
             return $result->status->isFailure();
129 129
         });
130 130
 
131
-        $warnings = collect($results)->filter(function ($entry) {
131
+        $warnings = collect($results)->filter(function($entry) {
132 132
             /** @var StepResult $result */
133 133
             $result = $entry['result'];
134 134
 
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
         if ($format === 'json') {
139 139
             $payload = [
140 140
                 'version' => $majorVersion,
141
-                'results' => collect($results)->map(function ($entry) {
141
+                'results' => collect($results)->map(function($entry) {
142 142
                     /** @var StepResult $result */
143 143
                     $result = $entry['result'];
144 144
 
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
             $this->note(sprintf('%d step(s) reported warnings.', $warnings->count()), 'yellow', 'yellow');
171 171
         }
172 172
 
173
-        if (! $hasFailure && $warnings->isEmpty()) {
173
+        if (!$hasFailure && $warnings->isEmpty()) {
174 174
             $this->note('All checks passed, you are ready to continue with the manual steps from the upgrade guide.', 'green', 'green');
175 175
         }
176 176
 
@@ -205,11 +205,11 @@  discard block
 block discarded – undo
205 205
             return false;
206 206
         }
207 207
 
208
-        if (! $this->input->isInteractive()) {
208
+        if (!$this->input->isInteractive()) {
209 209
             return false;
210 210
         }
211 211
 
212
-        if (! in_array($result->status, [StepStatus::Warning, StepStatus::Failed], true)) {
212
+        if (!in_array($result->status, [StepStatus::Warning, StepStatus::Failed], true)) {
213 213
             return false;
214 214
         }
215 215
 
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
     {
228 228
         $configProviderClass = sprintf('%s\\v%s\\UpgradeCommandConfig', __NAMESPACE__, $majorVersion);
229 229
 
230
-        if (! class_exists($configProviderClass)) {
230
+        if (!class_exists($configProviderClass)) {
231 231
             throw new RuntimeException(sprintf(
232 232
                 'Missing upgrade config provider for Backpack v%s. Please create %s.',
233 233
                 $majorVersion,
@@ -239,7 +239,7 @@  discard block
 block discarded – undo
239 239
             ? $this->laravel->make($configProviderClass)
240 240
             : new $configProviderClass();
241 241
 
242
-        if (! $provider instanceof UpgradeConfigInterface) {
242
+        if (!$provider instanceof UpgradeConfigInterface) {
243 243
             throw new RuntimeException(sprintf(
244 244
                 'Upgrade config provider [%s] must implement %s.',
245 245
                 $configProviderClass,
@@ -249,7 +249,7 @@  discard block
 block discarded – undo
249 249
 
250 250
         $steps = $provider->steps();
251 251
 
252
-        if (! is_array($steps)) {
252
+        if (!is_array($steps)) {
253 253
             throw new RuntimeException(sprintf(
254 254
                 'Upgrade config provider [%s] must return an array of step class names.',
255 255
                 $configProviderClass
Please login to merge, or discard this patch.
src/app/Console/Commands/Upgrade/v7/Steps/CheckThemeTablerConfigStep.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 
52 52
     public function canFix(StepResult $result): bool
53 53
     {
54
-        return $result->status === StepStatus::Warning && $this->currentContents !== null && ! empty($this->issues);
54
+        return $result->status === StepStatus::Warning && $this->currentContents !== null && !empty($this->issues);
55 55
     }
56 56
 
57 57
     public function fixMessage(StepResult $result): string
@@ -92,11 +92,11 @@  discard block
 block discarded – undo
92 92
 
93 93
         $updated = preg_replace('/^base_path/m', '        base_path', $updated);
94 94
 
95
-        if (! $changed) {
95
+        if (!$changed) {
96 96
             return StepResult::failure('Could not adjust Tabler config automatically.');
97 97
         }
98 98
 
99
-        if (! $this->context()->writeFile($this->relativePath, $updated)) {
99
+        if (!$this->context()->writeFile($this->relativePath, $updated)) {
100 100
             return StepResult::failure('Failed writing changes to config/backpack/theme-tabler.php.');
101 101
         }
102 102
 
Please login to merge, or discard this patch.
Console/Commands/Upgrade/v7/Steps/CheckShowOperationViewPublishedStep.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
17 17
 
18 18
     public function run(): StepResult
19 19
     {
20
-        if (! $this->context()->fileExists($this->relativePath)) {
20
+        if (!$this->context()->fileExists($this->relativePath)) {
21 21
             return StepResult::success('Show operation view is not published, package default will be used.');
22 22
         }
23 23
 
@@ -39,11 +39,11 @@  discard block
 block discarded – undo
39 39
 
40 40
     public function fix(StepResult $result): StepResult
41 41
     {
42
-        if (! $this->context()->fileExists($this->relativePath)) {
42
+        if (!$this->context()->fileExists($this->relativePath)) {
43 43
             return StepResult::skipped('Published show.blade.php was already removed.');
44 44
         }
45 45
 
46
-        if (! $this->context()->deleteFile($this->relativePath)) {
46
+        if (!$this->context()->deleteFile($this->relativePath)) {
47 47
             return StepResult::failure("Could not delete {$this->relativePath} automatically.");
48 48
         }
49 49
 
Please login to merge, or discard this patch.
Console/Commands/Upgrade/v7/Steps/CheckListOperationViewPublishedStep.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
17 17
 
18 18
     public function run(): StepResult
19 19
     {
20
-        if (! $this->context()->fileExists($this->relativePath)) {
20
+        if (!$this->context()->fileExists($this->relativePath)) {
21 21
             return StepResult::success('List operation view is not published, package default will be used.');
22 22
         }
23 23
 
@@ -39,11 +39,11 @@  discard block
 block discarded – undo
39 39
 
40 40
     public function fix(StepResult $result): StepResult
41 41
     {
42
-        if (! $this->context()->fileExists($this->relativePath)) {
42
+        if (!$this->context()->fileExists($this->relativePath)) {
43 43
             return StepResult::skipped('Published list.blade.php was already removed.');
44 44
         }
45 45
 
46
-        if (! $this->context()->deleteFile($this->relativePath)) {
46
+        if (!$this->context()->deleteFile($this->relativePath)) {
47 47
             return StepResult::failure("Could not delete {$this->relativePath} automatically.");
48 48
         }
49 49
 
Please login to merge, or discard this patch.
src/app/Console/Commands/Upgrade/v7/Steps/EnsureLaravelVersionStep.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -90,12 +90,12 @@  discard block
 block discarded – undo
90 90
         $section = $this->composerSection;
91 91
         $constraint = $this->suggestedConstraint;
92 92
 
93
-        $updated = $this->context()->updateComposerJson(function (array &$composer) use ($section, $constraint) {
93
+        $updated = $this->context()->updateComposerJson(function(array &$composer) use ($section, $constraint) {
94 94
             $composer[$section] = $composer[$section] ?? [];
95 95
             $composer[$section]['laravel/framework'] = $constraint;
96 96
         });
97 97
 
98
-        if (! $updated) {
98
+        if (!$updated) {
99 99
             return StepResult::failure('Could not update composer.json automatically.');
100 100
         }
101 101
 
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
             return false;
125 125
         }
126 126
 
127
-        if (! preg_match('/\d+/', $this->composerConstraint)) {
127
+        if (!preg_match('/\d+/', $this->composerConstraint)) {
128 128
             return false;
129 129
         }
130 130
 
@@ -178,6 +178,6 @@  discard block
 block discarded – undo
178 178
             return $normalized;
179 179
         }
180 180
 
181
-        return rtrim($normalized, ' ') . ' || ^12.0';
181
+        return rtrim($normalized, ' ').' || ^12.0';
182 182
     }
183 183
 }
Please login to merge, or discard this patch.
app/Console/Commands/Upgrade/v7/Steps/DetectDeprecatedWysiwygUsageStep.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -41,11 +41,11 @@  discard block
 block discarded – undo
41 41
 
42 42
     public function canFix(StepResult $result): bool
43 43
     {
44
-        if (! $result->status->isWarning()) {
44
+        if (!$result->status->isWarning()) {
45 45
             return false;
46 46
         }
47 47
 
48
-        return ! empty($this->crudControllerPaths());
48
+        return !empty($this->crudControllerPaths());
49 49
     }
50 50
 
51 51
     public function fixMessage(StepResult $result): string
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
                 continue;
78 78
             }
79 79
 
80
-            if (! $this->context()->writeFile($path, $updatedContents)) {
80
+            if (!$this->context()->writeFile($path, $updatedContents)) {
81 81
                 return StepResult::failure("Could not update {$path} automatically.");
82 82
             }
83 83
 
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
         foreach ($patterns as $pattern => $replacement) {
109 109
             $contents = preg_replace_callback(
110 110
                 $pattern,
111
-                function (array $matches) use (&$replacementCount, $replacement) {
111
+                function(array $matches) use (&$replacementCount, $replacement) {
112 112
                     $replacementCount++;
113 113
 
114 114
                     return $replacement($matches);
@@ -134,19 +134,19 @@  discard block
 block discarded – undo
134 134
     private function wysiwygPatterns(): array
135 135
     {
136 136
         return [
137
-            '~->type\((["\'])wysiwyg\1\)~' => function (array $matches) {
137
+            '~->type\((["\'])wysiwyg\1\)~' => function(array $matches) {
138 138
                 return '->type('.$matches[1].'ckeditor'.$matches[1].')';
139 139
             },
140
-            '~(["\']type["\']\s*=>\s*)(["\'])wysiwyg\2~' => function (array $matches) {
140
+            '~(["\']type["\']\s*=>\s*)(["\'])wysiwyg\2~' => function(array $matches) {
141 141
                 return $matches[1].$matches[2].'ckeditor'.$matches[2];
142 142
             },
143
-            '~(CRUD::(?:addField|field|addColumn|column)\(\s*)(["\'])wysiwyg\2~' => function (array $matches) {
143
+            '~(CRUD::(?:addField|field|addColumn|column)\(\s*)(["\'])wysiwyg\2~' => function(array $matches) {
144 144
                 return $matches[1].$matches[2].'ckeditor'.$matches[2];
145 145
             },
146
-            '~($this->crud->(?:addField|field|addColumn|column)\(\s*)(["\'])wysiwyg\2~' => function (array $matches) {
146
+            '~($this->crud->(?:addField|field|addColumn|column)\(\s*)(["\'])wysiwyg\2~' => function(array $matches) {
147 147
                 return $matches[1].$matches[2].'ckeditor'.$matches[2];
148 148
             },
149
-            '~($crud->(?:addField|field|addColumn|column)\(\s*)(["\'])wysiwyg\2~' => function (array $matches) {
149
+            '~($crud->(?:addField|field|addColumn|column)\(\s*)(["\'])wysiwyg\2~' => function(array $matches) {
150 150
                 return $matches[1].$matches[2].'ckeditor'.$matches[2];
151 151
             },
152 152
         ];
Please login to merge, or discard this patch.
Console/Commands/Upgrade/v7/Steps/CheckShowOperationComponentConfigStep.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
             return StepResult::skipped('show.php config file is not published, core defaults already use the new datagrid component.');
28 28
         }
29 29
 
30
-        if (! str_contains($contents, "'component'")) {
30
+        if (!str_contains($contents, "'component'")) {
31 31
             $this->missingComponent = true;
32 32
 
33 33
             return StepResult::warning(
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
             . '    // Which component to use for displaying the Show page?'
72 72
             . $newline
73 73
             . "    'component' => 'bp-datagrid', // options: bp-datagrid, bp-datalist, or a custom component alias"
74
-            . $newline. $newline;
74
+            . $newline.$newline;
75 75
 
76 76
         $updatedContents = preg_replace($pattern, $replacement, $contents, 1, $replacements);
77 77
 
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
             return StepResult::failure('Could not update show.php automatically.');
80 80
         }
81 81
 
82
-        if (! $this->context()->writeFile($this->relativePath, $updatedContents)) {
82
+        if (!$this->context()->writeFile($this->relativePath, $updatedContents)) {
83 83
             return StepResult::failure('Could not save the updated show.php configuration.');
84 84
         }
85 85
 
Please login to merge, or discard this patch.
Commands/Upgrade/v7/Steps/EnsureFirstPartyAddonsAreCompatibleStep.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
                 continue;
27 27
             }
28 28
 
29
-            if (! $this->matchesExpectedConstraint($constraint, $expectedConstraint)) {
29
+            if (!$this->matchesExpectedConstraint($constraint, $expectedConstraint)) {
30 30
                 $this->mismatched[] = [
31 31
                     'package' => $package,
32 32
                     'current' => $constraint,
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 
79 79
     public function canFix(StepResult $result): bool
80 80
     {
81
-        return $result->status === StepStatus::Warning && ! empty($this->mismatched);
81
+        return $result->status === StepStatus::Warning && !empty($this->mismatched);
82 82
     }
83 83
 
84 84
     public function fixMessage(StepResult $result): string
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 
95 95
         $mismatched = $this->mismatched;
96 96
 
97
-        $updated = $this->context()->updateComposerJson(function (array &$composer) use ($mismatched) {
97
+        $updated = $this->context()->updateComposerJson(function(array &$composer) use ($mismatched) {
98 98
             foreach ($mismatched as $item) {
99 99
                 $section = $item['section'] ?? 'require';
100 100
                 $composer[$section] = $composer[$section] ?? [];
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
             }
103 103
         });
104 104
 
105
-        if (! $updated) {
105
+        if (!$updated) {
106 106
             return StepResult::failure('Could not update composer.json automatically.');
107 107
         }
108 108
 
Please login to merge, or discard this patch.