Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Failed
Push — revamp-tabs ( e2fe97 )
by Pedro
11:02
created
src/app/Console/Commands/Themes/InstallsTheme.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
         }
72 72
 
73 73
         // Display general error in case it failed
74
-        if (! $this->isInstalled()) {
74
+        if (!$this->isInstalled()) {
75 75
             $this->errorProgressBlock();
76 76
             $this->note('For further information please check the log file.');
77 77
             $this->note('You can also follow the manual installation process documented on Github.');
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
         $this->progressBlock('Publish theme config file');
85 85
 
86 86
         // manually include the provider in the run-time
87
-        if (! class_exists(self::$addon['provider'])) {
87
+        if (!class_exists(self::$addon['provider'])) {
88 88
             include self::$addon['provider_path'] ?? self::$addon['path'].'/src/AddonServiceProvider.php';
89 89
             app()->register(self::$addon['provider']);
90 90
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudField.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
      */
227 227
     public function subfields($subfields)
228 228
     {
229
-        $callAttributeMacro = ! isset($this->attributes['subfields']);
229
+        $callAttributeMacro = !isset($this->attributes['subfields']);
230 230
         $this->attributes['subfields'] = $subfields;
231 231
         $this->attributes = $this->crud()->makeSureFieldHasNecessaryAttributes($this->attributes);
232 232
         if ($callAttributeMacro) {
@@ -276,7 +276,7 @@  discard block
 block discarded – undo
276 276
         // append the field name to the rule name of validationMessages array.
277 277
         // eg: ['required => 'This field is required']
278 278
         // will be transformed into: ['field_name.required' => 'This field is required]
279
-        $this->crud()->setValidationFromArray([], array_merge(...array_map(function ($rule, $message) {
279
+        $this->crud()->setValidationFromArray([], array_merge(...array_map(function($rule, $message) {
280 280
             return [$this->attributes['name'].'.'.$rule => $message];
281 281
         }, array_keys($messages), $messages)));
282 282
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudButton.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -299,7 +299,7 @@  discard block
 block discarded – undo
299 299
     private function getViewPathsWithFallbacks()
300 300
     {
301 301
         $type = $this->name;
302
-        $paths = array_map(function ($item) use ($type) {
302
+        $paths = array_map(function($item) use ($type) {
303 303
             return $item.'.'.$type;
304 304
         }, ViewNamespaces::getFor('buttons'));
305 305
 
@@ -467,7 +467,7 @@  discard block
 block discarded – undo
467 467
 
468 468
         $itemExists = $this->collection()->contains('name', $this->name);
469 469
 
470
-        if (! $itemExists) {
470
+        if (!$itemExists) {
471 471
             $this->crud()->addCrudButton($this);
472 472
             if ($this->position == 'beginning') {
473 473
                 $this->before($this->collection()->first()->name);
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/FieldsProtectedMethods.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
             return ['name' => $field];
116 116
         }
117 117
 
118
-        if (is_array($field) && ! isset($field['name'])) {
118
+        if (is_array($field) && !isset($field['name'])) {
119 119
             abort(500, 'All fields must have their name defined');
120 120
         }
121 121
 
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
187 187
         }
188 188
         // if there's a model defined, but no attribute
189 189
         // guess an attribute using the identifiableAttribute functionality in CrudTrait
190
-        if (isset($field['model']) && ! isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
190
+        if (isset($field['model']) && !isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
191 191
             $field['attribute'] = (new $field['model']())->identifiableAttribute();
192 192
         }
193 193
 
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
      */
204 204
     protected function makeSureFieldHasLabel($field)
205 205
     {
206
-        if (! isset($field['label'])) {
206
+        if (!isset($field['label'])) {
207 207
             $name = str_replace(',', ' ', $field['name']);
208 208
             $name = str_replace('_id', '', $name);
209 209
             $field['label'] = mb_ucfirst(str_replace('_', ' ', $name));
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
      */
222 222
     protected function makeSureFieldHasType($field)
223 223
     {
224
-        if (! isset($field['type'])) {
224
+        if (!isset($field['type'])) {
225 225
             $field['type'] = isset($field['relation_type']) ? $this->inferFieldTypeFromRelationType($field['relation_type']) : $this->inferFieldTypeFromDbColumnType($field['name']);
226 226
         }
227 227
 
@@ -254,12 +254,12 @@  discard block
 block discarded – undo
254 254
      */
255 255
     protected function makeSureSubfieldsHaveNecessaryAttributes($field)
256 256
     {
257
-        if (! isset($field['subfields'])) {
257
+        if (!isset($field['subfields'])) {
258 258
             return $field;
259 259
         }
260 260
 
261 261
         foreach ($field['subfields'] as $key => $subfield) {
262
-            if (empty($subfield) || ! isset($subfield['name'])) {
262
+            if (empty($subfield) || !isset($subfield['name'])) {
263 263
                 abort(500, 'Subfield name can\'t be empty');
264 264
             }
265 265
 
@@ -270,7 +270,7 @@  discard block
 block discarded – undo
270 270
 
271 271
             $subfield['parentFieldName'] = $field['name'];
272 272
 
273
-            if (! isset($field['model'])) {
273
+            if (!isset($field['model'])) {
274 274
                 // we're inside a simple 'repeatable' with no model/relationship, so
275 275
                 // we assume all subfields are supposed to be text fields
276 276
                 $subfield['type'] = $subfield['type'] ?? 'text';
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
     {
325 325
         // if a tab was mentioned, we should enable it
326 326
         if (isset($field['tab'])) {
327
-            if (! $this->tabsEnabled()) {
327
+            if (!$this->tabsEnabled()) {
328 328
                 $this->enableTabs();
329 329
             }
330 330
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Update.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         }
48 48
 
49 49
         // always have a hidden input for the entry id
50
-        if (! array_key_exists('id', $fields)) {
50
+        if (!array_key_exists('id', $fields)) {
51 51
             $fields['id'] = [
52 52
                 'name'  => $entry->getKeyName(),
53 53
                 'value' => $entry->getKey(),
@@ -72,12 +72,12 @@  discard block
 block discarded – undo
72 72
         $fieldEntity = $field['entity'] ?? false;
73 73
         $fakeField = $field['fake'] ?? false;
74 74
 
75
-        if ($fieldEntity && ! $fakeField) {
75
+        if ($fieldEntity && !$fakeField) {
76 76
             return $this->getModelAttributeValueFromRelationship($model, $field);
77 77
         }
78 78
 
79 79
         if ($this->holdsMultipleInputs($field['name'])) {
80
-            $result = array_map(function ($item) use ($model) {
80
+            $result = array_map(function($item) use ($model) {
81 81
                 return $model->{$item};
82 82
             }, explode(',', $field['name']));
83 83
 
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
     {
100 100
         [$relatedModel, $relationMethod] = $this->getModelAndMethodFromEntity($model, $field);
101 101
 
102
-        if (! method_exists($relatedModel, $relationMethod)) {
102
+        if (!method_exists($relatedModel, $relationMethod)) {
103 103
             return $relatedModel->{$relationMethod};
104 104
         }
105 105
 
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
                     $model = $this->setupRelatedModelLocale($model);
119 119
                     // when subfields are NOT set we don't need to get any more values
120 120
                     // we just return the plain models as we only need the ids
121
-                    if (! isset($field['subfields'])) {
121
+                    if (!isset($field['subfields'])) {
122 122
                         $result->push($model);
123 123
 
124 124
                         continue;
@@ -146,13 +146,13 @@  discard block
 block discarded – undo
146 146
                 break;
147 147
             case 'HasOne':
148 148
             case 'MorphOne':
149
-                if (! method_exists($relatedModel, $relationMethod)) {
149
+                if (!method_exists($relatedModel, $relationMethod)) {
150 150
                     return;
151 151
                 }
152 152
 
153 153
                 $model = $relatedModel->{$relationMethod};
154 154
 
155
-                if (! $model) {
155
+                if (!$model) {
156 156
                     return;
157 157
                 }
158 158
 
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
 
234 234
         $relationArray = explode('.', $relationEntity);
235 235
 
236
-        $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function ($obj, $method) {
236
+        $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function($obj, $method) {
237 237
             // if the string ends with `_id` we strip it out
238 238
             $method = Str::endsWith($method, '_id') ? Str::replaceLast('_id', '', $method) : $method;
239 239
 
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
260 260
             // if the subfield name does not contain a dot we just need to check
261 261
             // if it has subfields and return the result accordingly.
262 262
             foreach ((array) $subfield['name'] as $name) {
263
-                if (! Str::contains($name, '.')) {
263
+                if (!Str::contains($name, '.')) {
264 264
                     // when subfields are present, $relatedModel->{$name} returns a model instance
265 265
                     // otherwise returns the model attribute.
266 266
                     if ($relatedModel->{$name}) {
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Support/MacroableWithAttributes.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -47,8 +47,8 @@
 block discarded – undo
47 47
                                         ->filter(fn ($item) => isset($item[$macro]));
48 48
 
49 49
                 $subfieldsWithMacros->each(
50
-                    function ($item) use ($subfieldsWithMacros, $macro) {
51
-                        $config = ! is_array($item[$macro]) ? [] : $item[$macro];
50
+                    function($item) use ($subfieldsWithMacros, $macro) {
51
+                        $config = !is_array($item[$macro]) ? [] : $item[$macro];
52 52
                         if ($subfieldsWithMacros->last() === $item) {
53 53
                             $this->{$macro}($config, $item);
54 54
                         } else {
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Validation.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
      */
67 67
     public function setValidation($classOrRulesArray = false, $messages = [], $attributes = [])
68 68
     {
69
-        if (! $classOrRulesArray) {
69
+        if (!$classOrRulesArray) {
70 70
             $this->setValidationFromFields();
71 71
         } elseif (is_array($classOrRulesArray)) {
72 72
             $this->setValidationFromArray($classOrRulesArray, $messages, $attributes);
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
             return $this->checkRequestValidity($extendedRules, $extendedMessages, $extendedAttributes, $formRequest);
148 148
         }
149 149
 
150
-        return ! empty($rules) ? $this->checkRequestValidity($rules, $messages, $attributes) : $this->getRequest();
150
+        return !empty($rules) ? $this->checkRequestValidity($rules, $messages, $attributes) : $this->getRequest();
151 151
     }
152 152
 
153 153
     /**
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
                 if (is_string($validationRules)) {
196 196
                     $validationRules = explode('|', $validationRules);
197 197
                 }
198
-                if (! is_array($validationRules)) {
198
+                if (!is_array($validationRules)) {
199 199
                     $validationRules = [$validationRules];
200 200
                 }
201 201
                 foreach ($validationRules as $rule) {
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
238 238
      */
239 239
     public function isRequired($inputKey)
240 240
     {
241
-        if (! $this->hasOperationSetting('requiredFields')) {
241
+        if (!$this->hasOperationSetting('requiredFields')) {
242 242
             return false;
243 243
         }
244 244
 
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
     {
260 260
         [$rules, $messages, $attributes] = $this->getValidationDataFromField($field, $parent);
261 261
 
262
-        if (! empty($rules)) {
262
+        if (!empty($rules)) {
263 263
             $this->setValidation($rules, $messages, $attributes);
264 264
         }
265 265
     }
@@ -274,10 +274,10 @@  discard block
 block discarded – undo
274 274
     {
275 275
         $messages = [];
276 276
         collect($fields)
277
-            ->filter(function ($value, $key) {
277
+            ->filter(function($value, $key) {
278 278
                 // only keep fields where 'validationMessages' OR there are subfields
279 279
                 return array_key_exists('validationMessages', $value) || array_key_exists('subfields', $value);
280
-            })->each(function ($item, $key) use (&$messages) {
280
+            })->each(function($item, $key) use (&$messages) {
281 281
                 if (isset($item['validationMessages'])) {
282 282
                     foreach ($item['validationMessages'] as $rule => $message) {
283 283
                         $messages[$key.'.'.$rule] = $message;
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
285 285
                 }
286 286
                 // add messages from subfields
287 287
                 if (array_key_exists('subfields', $item)) {
288
-                    $subfieldsWithValidationMessages = array_filter($item['subfields'], function ($subfield) {
288
+                    $subfieldsWithValidationMessages = array_filter($item['subfields'], function($subfield) {
289 289
                         return array_key_exists('validationRules', $subfield);
290 290
                     });
291 291
 
@@ -310,16 +310,16 @@  discard block
 block discarded – undo
310 310
     {
311 311
         $attributes = [];
312 312
         collect($fields)
313
-            ->filter(function ($value, $key) {
313
+            ->filter(function($value, $key) {
314 314
                 // only keep fields where 'validationAttribute' exists OR there are subfields
315 315
                 return array_key_exists('validationAttribute', $value) || array_key_exists('subfields', $value);
316
-            })->each(function ($item, $key) use (&$attributes) {
316
+            })->each(function($item, $key) use (&$attributes) {
317 317
                 if (isset($item['validationAttribute'])) {
318 318
                     $attributes[$key] = $item['validationAttribute'];
319 319
                 }
320 320
                 // add attributes from subfields
321 321
                 if (array_key_exists('subfields', $item)) {
322
-                    $subfieldsWithValidationAttribute = array_filter($item['subfields'], function ($subfield) {
322
+                    $subfieldsWithValidationAttribute = array_filter($item['subfields'], function($subfield) {
323 323
                         return array_key_exists('validationAttribute', $subfield);
324 324
                     });
325 325
 
@@ -341,10 +341,10 @@  discard block
 block discarded – undo
341 341
     private function getValidationRulesFromFieldsAndSubfields($fields)
342 342
     {
343 343
         $rules = collect($fields)
344
-            ->filter(function ($value, $key) {
344
+            ->filter(function($value, $key) {
345 345
                 // only keep fields where 'validationRules' OR there are subfields
346 346
                 return array_key_exists('validationRules', $value) || array_key_exists('subfields', $value);
347
-            })->map(function ($item, $key) {
347
+            })->map(function($item, $key) {
348 348
                 $validationRules = [];
349 349
                 // only keep the rules, not the entire field definition
350 350
                 if (isset($item['validationRules'])) {
@@ -352,7 +352,7 @@  discard block
 block discarded – undo
352 352
                 }
353 353
                 // add validation rules for subfields
354 354
                 if (array_key_exists('subfields', $item)) {
355
-                    $subfieldsWithValidation = array_filter($item['subfields'], function ($subfield) {
355
+                    $subfieldsWithValidation = array_filter($item['subfields'], function($subfield) {
356 356
                         return array_key_exists('validationRules', $subfield);
357 357
                     });
358 358
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Buttons.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
         $otherButtons = collect([]);
25 25
 
26 26
         // we get the buttons that belong to the specified stack
27
-        $stackButtons = $this->buttons()->reject(function ($item) use ($stack, $otherButtons) {
27
+        $stackButtons = $this->buttons()->reject(function($item) use ($stack, $otherButtons) {
28 28
             if ($item->stack != $stack) {
29 29
                 // if the button does not belong to this stack we just add it for merging later
30 30
                 $otherButtons->push($item);
@@ -36,8 +36,8 @@  discard block
 block discarded – undo
36 36
         });
37 37
 
38 38
         // we parse the ordered buttons
39
-        collect($order)->each(function ($btnKey) use ($newButtons, $stackButtons) {
40
-            if (! $button = $stackButtons->where('name', $btnKey)->first()) {
39
+        collect($order)->each(function($btnKey) use ($newButtons, $stackButtons) {
40
+            if (!$button = $stackButtons->where('name', $btnKey)->first()) {
41 41
                 abort(500, 'Button name [«'.$btnKey.'»] not found.');
42 42
             }
43 43
             $newButtons->push($button);
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         // we add the remaining buttons to the end of the ordered ones
48 48
         if (count($newButtons) < count($stackButtons)) {
49 49
             foreach ($stackButtons as $button) {
50
-                if (! $newButtons->where('name', $button->name)->first()) {
50
+                if (!$newButtons->where('name', $button->name)->first()) {
51 51
                     $newButtons->push($button);
52 52
                 }
53 53
             }
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
          */
117 117
         $button = $this->buttons()->firstWhere('name', $name);
118 118
 
119
-        if (! $button) {
119
+        if (!$button) {
120 120
             abort(500, 'CRUD Button "'.$name.'" not found. Please ensure the button exists before you modify it.');
121 121
         }
122 122
 
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
      */
138 138
     public function removeButton($name, $stack = null)
139 139
     {
140
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
140
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
141 141
             return $stack == null ? $button->name == $name : ($button->stack == $stack) && ($button->name == $name);
142 142
         }));
143 143
     }
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
      */
149 149
     public function removeButtons($names, $stack = null)
150 150
     {
151
-        if (! empty($names)) {
151
+        if (!empty($names)) {
152 152
             foreach ($names as $name) {
153 153
                 $this->removeButton($name, $stack);
154 154
             }
@@ -162,14 +162,14 @@  discard block
 block discarded – undo
162 162
 
163 163
     public function removeAllButtonsFromStack($stack)
164 164
     {
165
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($stack) {
165
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($stack) {
166 166
             return $button->stack == $stack;
167 167
         }));
168 168
     }
169 169
 
170 170
     public function removeButtonFromStack($name, $stack)
171 171
     {
172
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
172
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
173 173
             return $button->name == $name && $button->stack == $stack;
174 174
         }));
175 175
     }
@@ -190,15 +190,15 @@  discard block
 block discarded – undo
190 190
         $destinationKey = $this->getButtonKey($destination);
191 191
         $newDestinationKey = ($where == 'before' ? $destinationKey : $destinationKey + 1);
192 192
 
193
-        $newButtons = $this->buttons()->filter(function ($value, $key) use ($target) {
193
+        $newButtons = $this->buttons()->filter(function($value, $key) use ($target) {
194 194
             return $value->name != $target;
195 195
         });
196 196
 
197
-        if (! $targetButton) {
197
+        if (!$targetButton) {
198 198
             return;
199 199
         }
200 200
 
201
-        if (! $destinationButton) {
201
+        if (!$destinationButton) {
202 202
             return;
203 203
         }
204 204
 
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
 
208 208
         $newButtons = $firstSlice->push($targetButton);
209 209
 
210
-        $lastSlice->each(function ($item, $key) use ($newButtons) {
210
+        $lastSlice->each(function($item, $key) use ($newButtons) {
211 211
             $newButtons->push($item);
212 212
         });
213 213
 
@@ -266,7 +266,7 @@  discard block
 block discarded – undo
266 266
     /**
267 267
      * Add a new button to the current CRUD operation.
268 268
      */
269
-    public function button(string|array $nameOrAttributes): CrudButton
269
+    public function button(string | array $nameOrAttributes): CrudButton
270 270
     {
271 271
         return new CrudButton($nameOrAttributes);
272 272
     }
Please login to merge, or discard this patch.
src/app/Library/Uploaders/SingleBase64Image.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
         $value = $value ?? CRUD::getRequest()->get($this->getName());
15 15
         $previousImage = $this->getPreviousFiles($entry);
16 16
 
17
-        if (! $value && $previousImage) {
17
+        if (!$value && $previousImage) {
18 18
             Storage::disk($this->getDisk())->delete($previousImage);
19 19
 
20 20
             return null;
Please login to merge, or discard this patch.