Laravel-Backpack / CRUD

src/app/Console/Commands/Upgrade/v7/Steps/CheckFileManagerPublishedViewsStep.php

Spacing +7 added lines, -7 removed lines

@@ -27,18 +27,18 @@ 
         $this->legacyFiles = [];
         $this->legacyDirectoryDetected = false;
 
-        if (! $this->context()->hasComposerPackage('backpack/filemanager')) {
+        if (!$this->context()->hasComposerPackage('backpack/filemanager')) {
             return StepResult::success('File Manager add-on not detected; no published views to review.');
         }
 
-        if (! $this->context()->fileExists(self::LEGACY_VIEWS_DIRECTORY)) {
+        if (!$this->context()->fileExists(self::LEGACY_VIEWS_DIRECTORY)) {
             return StepResult::success('No File Manager views found in resources/views/vendor/elfinder.');
         }
 
         $filesystem = new Filesystem();
         $absoluteDirectory = $this->context()->basePath(self::LEGACY_VIEWS_DIRECTORY);
 
-        if (! $filesystem->isDirectory($absoluteDirectory)) {
+        if (!$filesystem->isDirectory($absoluteDirectory)) {
             return StepResult::success('No File Manager views found in resources/views/vendor/elfinder.');
         }
 
@@ -59,7 +59,7 @@ 
 
     public function canFix(StepResult $result): bool
     {
-        if (! $result->status->isWarning()) {
+        if (!$result->status->isWarning()) {
             return false;
         }
 
@@ -73,12 +73,12 @@ 
 
     public function fix(StepResult $result): StepResult
     {
-        if (! $this->legacyDirectoryDetected) {
+        if (!$this->legacyDirectoryDetected) {
             return StepResult::skipped('Legacy File Manager directory no longer present.');
         }
 
         foreach ($this->legacyFiles as $path) {
-            if (! $this->context()->deleteFile($path)) {
+            if (!$this->context()->deleteFile($path)) {
                 return StepResult::failure("Could not delete {$path} automatically.");
             }
         }
@@ -86,7 +86,7 @@ 
         $filesystem = new Filesystem();
         $absoluteDirectory = $this->context()->basePath(self::LEGACY_VIEWS_DIRECTORY);
 
-        if ($filesystem->isDirectory($absoluteDirectory) && ! $filesystem->deleteDirectory($absoluteDirectory)) {
+        if ($filesystem->isDirectory($absoluteDirectory) && !$filesystem->deleteDirectory($absoluteDirectory)) {
             return StepResult::failure('Could not delete resources/views/vendor/elfinder automatically.');
         }
 

src/app/Console/Commands/Upgrade/v7/Steps/CheckShowOperationComponentConfigStep.php

Spacing +4 added lines, -4 removed lines

@@ -36,11 +36,11 @@ 
     {
         $this->missingComponent = false;
 
-        if (! $this->configs->configFilesPublished()) {
+        if (!$this->configs->configFilesPublished()) {
             return StepResult::skipped('show.php config file is not published, core defaults already use the new datagrid component.');
         }
 
-        if (! $this->configs->publishedFileContainsKey($this->operationFilename, 'component')) {
+        if (!$this->configs->publishedFileContainsKey($this->operationFilename, 'component')) {
             $this->missingComponent = true;
 
             return StepResult::warning(
@@ -63,7 +63,7 @@ 
 
     public function fix(StepResult $result): StepResult
     {
-        if (! $this->configs->configFilesPublished()) {
+        if (!$this->configs->configFilesPublished()) {
             return StepResult::skipped('show.php config file is not published, core defaults already use the new datagrid component.');
         }
 
@@ -77,7 +77,7 @@ 
 
         $error = null;
 
-        if (! $this->configs->addKeyToConfigFile($this->operationFilename, $snippet, $error)) {
+        if (!$this->configs->addKeyToConfigFile($this->operationFilename, $snippet, $error)) {
             return StepResult::failure($error ?? 'Could not update show.php automatically.');
         }
 

src/app/Console/Commands/Upgrade/Support/ConfigFilesHelper.php

Spacing +37 added lines, -37 removed lines

@@ -36,7 +36,7 @@ 
             return;
         }
 
-        if (! isset($this->publishedRoot)) {
+        if (!isset($this->publishedRoot)) {
             return;
         }
 
@@ -59,7 +59,7 @@ 
     {
         $absolutePath = $this->resolvePublishedPath($path);
 
-        if (! is_file($absolutePath)) {
+        if (!is_file($absolutePath)) {
             return null;
         }
 
@@ -89,7 +89,7 @@ 
         if (is_array($current)) {
             if (is_array($expectedValue)) {
                 foreach ($expectedValue as $value) {
-                    if (! in_array($value, $current, true)) {
+                    if (!in_array($value, $current, true)) {
                         return false;
                     }
                 }
@@ -133,7 +133,7 @@ 
 
         $updated = preg_replace_callback(
             $pattern,
-            function (array $matches) use ($newValue, &$changed) {
+            function(array $matches) use ($newValue, &$changed) {
                 $existing = trim($matches['value']);
                 $quote = $existing[0] ?? null;
 
@@ -156,7 +156,7 @@ 
             1
         );
 
-        if ($updated === null || ! $changed) {
+        if ($updated === null || !$changed) {
             return false;
         }
 
@@ -181,7 +181,7 @@ 
 
         $updated = preg_replace_callback(
             $pattern,
-            function (array $matches) use ($valueExpression) {
+            function(array $matches) use ($valueExpression) {
                 $position = strpos($matches[0], $valueExpression);
                 $indentation = $position === false ? '' : substr($matches[0], 0, $position);
 
@@ -211,7 +211,7 @@ 
 
     public function analyzeConfigFile(string $path): ?array
     {
-        if (! is_file($path)) {
+        if (!is_file($path)) {
             return null;
         }
 
@@ -302,7 +302,7 @@ 
 
             $missingKeys = $analysis['missing_keys'] ?? [];
 
-            if (! empty($missingKeys)) {
+            if (!empty($missingKeys)) {
                 $missingKeysPerFile[$displayPath] = $missingKeys;
             }
 
@@ -321,16 +321,16 @@ 
                     continue;
                 }
 
-                if (! isset($entriesByKey[$key])) {
+                if (!isset($entriesByKey[$key])) {
                     $entriesByKey[$key] = $entry;
                 }
 
-                if (! isset($collectedEntries[$key])) {
+                if (!isset($collectedEntries[$key])) {
                     $collectedEntries[$key] = $entry;
                 }
             }
 
-            if (! empty($entriesByKey)) {
+            if (!empty($entriesByKey)) {
                 $topLevelEntriesPerFile[$displayPath] = array_values($entriesByKey);
                 $topLevelMissingKeysPerFile[$displayPath] = array_keys($entriesByKey);
             }
@@ -378,7 +378,7 @@ 
 
     public function loadConfigArray(string $path): ?array
     {
-        if (! is_file($path)) {
+        if (!is_file($path)) {
             return null;
         }
 
@@ -436,7 +436,7 @@ 
             throw new \InvalidArgumentException('Published directory path must not be empty.');
         }
 
-        $this->publishedIsFile = ! is_dir($this->publishedRoot);
+        $this->publishedIsFile = !is_dir($this->publishedRoot);
         $this->configFiles = [];
     }
 
@@ -448,7 +448,7 @@ 
             throw new \InvalidArgumentException('Package directory path must not be empty.');
         }
 
-        $this->packageIsFile = ! is_dir($this->packageRoot);
+        $this->packageIsFile = !is_dir($this->packageRoot);
         $this->configFiles = [];
     }
 
@@ -498,7 +498,7 @@ 
                 $normalized[] = rtrim($line, "\r");
             }
 
-            if (! empty($normalized)) {
+            if (!empty($normalized)) {
                 $blocks[] = implode(PHP_EOL, $normalized);
             }
         }
@@ -542,7 +542,7 @@ 
         $after = substr($contents, $closingPosition);
 
         $configArray = $this->loadPublishedConfig($path);
-        $shouldEnsureTrailingComma = $configArray === null ? true : ! empty($configArray);
+        $shouldEnsureTrailingComma = $configArray === null ? true : !empty($configArray);
 
         if ($shouldEnsureTrailingComma) {
             $before = $this->ensureTrailingComma($before);
@@ -557,7 +557,7 @@ 
 
         $updated = $before.$snippet.$after;
 
-        if (! $this->writePublishedFile($path, $updated)) {
+        if (!$this->writePublishedFile($path, $updated)) {
             $error = sprintf('Could not update %s automatically.', $this->publishedRelativePath($path));
 
             return false;
@@ -595,7 +595,7 @@ 
             return false;
         }
 
-        if (! $this->writePublishedFile($path, $updatedContents)) {
+        if (!$this->writePublishedFile($path, $updatedContents)) {
             $error = sprintf('Could not save the updated %s configuration.', $this->publishedRelativePath($path));
 
             return false;
@@ -672,7 +672,7 @@ 
             break;
         }
 
-        if (! $modified) {
+        if (!$modified) {
             return $before;
         }
 
@@ -689,7 +689,7 @@ 
     {
         $packagePath = $this->packagePathFor($path);
 
-        if (! is_file($packagePath)) {
+        if (!is_file($packagePath)) {
             return [];
         }
 
@@ -709,7 +709,7 @@ 
             $line = rtrim($lines[$index], "\r");
             $trimmed = ltrim($line);
 
-            if (! $withinConfigArray) {
+            if (!$withinConfigArray) {
                 if (preg_match('/return\s*\[/', $trimmed)) {
                     $withinConfigArray = true;
                 }
@@ -725,7 +725,7 @@ 
             if ($this->isBlockCommentStart($trimmed)) {
                 $pendingComments[] = $line;
 
-                while (! str_contains($trimmed, '*/') && $index + 1 < $lineCount) {
+                while (!str_contains($trimmed, '*/') && $index + 1 < $lineCount) {
                     $index++;
                     $line = rtrim($lines[$index], "\r");
                     $trimmed = ltrim($line);
@@ -742,13 +742,13 @@ 
                 continue;
             }
 
-            if ($trimmed === '' && ! empty($pendingComments)) {
+            if ($trimmed === '' && !empty($pendingComments)) {
                 $pendingComments[] = $line;
                 $index++;
                 continue;
             }
 
-            if (! preg_match('/^([\'"])\s*(.+?)\1\s*=>/', $trimmed, $matches)) {
+            if (!preg_match('/^([\'"])\s*(.+?)\1\s*=>/', $trimmed, $matches)) {
                 $pendingComments = [];
                 $index++;
                 continue;
@@ -760,7 +760,7 @@ 
             $valueDepth = $this->calculateBracketDelta($line);
             $hasTerminatingComma = $this->lineHasTerminatingComma($line);
 
-            while (($valueDepth > 0 || ! $hasTerminatingComma) && $index + 1 < $lineCount) {
+            while (($valueDepth > 0 || !$hasTerminatingComma) && $index + 1 < $lineCount) {
                 $index++;
                 $line = rtrim($lines[$index], "\r");
                 $entryLines[] = $line;
@@ -787,7 +787,7 @@ 
         $files = [];
 
         foreach ($definitions as $definition) {
-            if (! is_string($definition)) {
+            if (!is_string($definition)) {
                 continue;
             }
 
@@ -975,7 +975,7 @@ 
         $current = $config;
 
         foreach ($segments as $segment) {
-            if (! is_array($current) || ! array_key_exists($segment, $current)) {
+            if (!is_array($current) || !array_key_exists($segment, $current)) {
                 return null;
             }
 
@@ -1047,13 +1047,13 @@ 
         for ($i = 0; $i < $length; $i++) {
             $char = $line[$i];
 
-            if ($char === '\'' && ! $inDouble && ! $this->isCharacterEscaped($line, $i)) {
-                $inSingle = ! $inSingle;
+            if ($char === '\'' && !$inDouble && !$this->isCharacterEscaped($line, $i)) {
+                $inSingle = !$inSingle;
                 continue;
             }
 
-            if ($char === '"' && ! $inSingle && ! $this->isCharacterEscaped($line, $i)) {
-                $inDouble = ! $inDouble;
+            if ($char === '"' && !$inSingle && !$this->isCharacterEscaped($line, $i)) {
+                $inDouble = !$inDouble;
                 continue;
             }
 
@@ -1088,17 +1088,17 @@ 
         for ($i = 0; $i < $length; $i++) {
             $char = $line[$i];
 
-            if ($char === '\'' && ! $inDouble) {
-                if (! $this->isCharacterEscaped($line, $i)) {
-                    $inSingle = ! $inSingle;
+            if ($char === '\'' && !$inDouble) {
+                if (!$this->isCharacterEscaped($line, $i)) {
+                    $inSingle = !$inSingle;
                 }
 
                 continue;
             }
 
-            if ($char === '"' && ! $inSingle) {
-                if (! $this->isCharacterEscaped($line, $i)) {
-                    $inDouble = ! $inDouble;
+            if ($char === '"' && !$inSingle) {
+                if (!$this->isCharacterEscaped($line, $i)) {
+                    $inDouble = !$inDouble;
                 }
 
                 continue;

src/app/Console/Commands/Upgrade/UpgradeCommand.php

Spacing +27 added lines, -27 removed lines

@@ -94,10 +94,10 @@ 
             if ($this->shouldOfferFix($step, $result)) {
                 $options = $step->fixOptions($result);
 
-                if (! empty($options)) {
+                if (!empty($options)) {
                     [$choiceMap, $defaultLabel] = $this->normalizeFixOptions($options);
 
-                    if (! empty($choiceMap)) {
+                    if (!empty($choiceMap)) {
                         $question = trim($step->fixMessage($result));
                         $question = $question !== '' ? $question : 'Select an automatic fix option';
                         $selectedLabel = $this->choice('  '.$question, array_keys($choiceMap), $defaultLabel);
@@ -111,7 +111,7 @@ 
                             $this->closeProgressBlock(strtoupper($fixResult->status->label()), $fixResult->status->color());
                             $this->printResultDetails($fixResult);
 
-                            if (! $fixResult->status->isFailure()) {
+                            if (!$fixResult->status->isFailure()) {
                                 $this->progressBlock('Re-running '.$step->title());
 
                                 try {
@@ -141,7 +141,7 @@ 
                         $this->closeProgressBlock(strtoupper($fixResult->status->label()), $fixResult->status->color());
                         $this->printResultDetails($fixResult);
 
-                        if (! $fixResult->status->isFailure()) {
+                        if (!$fixResult->status->isFailure()) {
                             $this->progressBlock('Re-running '.$step->title());
 
                             try {
@@ -186,14 +186,14 @@ 
     ): int {
         $resultsCollection = collect($results);
 
-        $hasFailure = $resultsCollection->contains(function ($entry) {
+        $hasFailure = $resultsCollection->contains(function($entry) {
             /** @var StepResult $result */
             $result = $entry['result'];
 
             return $result->status->isFailure();
         });
 
-        $warnings = $resultsCollection->filter(function ($entry) {
+        $warnings = $resultsCollection->filter(function($entry) {
             /** @var StepResult $result */
             $result = $entry['result'];
 
@@ -201,7 +201,7 @@ 
         });
 
         $failedTitles = $resultsCollection
-            ->filter(function ($entry) {
+            ->filter(function($entry) {
                 /** @var StepResult $result */
                 $result = $entry['result'];
 
@@ -220,7 +220,7 @@ 
             $this->note('At least one step reported a failure. Review the messages above before continuing.', 'red', 'red');
         }
 
-        if (! $hasFailure && $warnings->isEmpty()) {
+        if (!$hasFailure && $warnings->isEmpty()) {
             $this->note('All checks passed, you are ready to continue with the manual steps from the upgrade guide.', 'green', 'green');
         }
 
@@ -246,7 +246,7 @@ 
             $postUpgradeCommands = ($config)::postUpgradeCommands();
         }
 
-        if ($expectedVersionInstalled && ! $hasFailure && ! empty($postUpgradeCommands)) {
+        if ($expectedVersionInstalled && !$hasFailure && !empty($postUpgradeCommands)) {
             $this->note("Now that you have {$versionLabel} installed, don't forget to run the following commands:", 'green', 'green');
 
             foreach ($postUpgradeCommands as $command) {
@@ -281,11 +281,11 @@ 
 
     protected function shouldOfferFix(Step $step, StepResult $result): bool
     {
-        if (! $this->input->isInteractive()) {
+        if (!$this->input->isInteractive()) {
             return false;
         }
 
-        if (! in_array($result->status, [StepStatus::Warning, StepStatus::Failed], true)) {
+        if (!in_array($result->status, [StepStatus::Warning, StepStatus::Failed], true)) {
             return false;
         }
 
@@ -315,7 +315,7 @@ 
                 $value = is_string($key) ? $key : $label;
             }
 
-            if (! is_string($label)) {
+            if (!is_string($label)) {
                 continue;
             }
 
@@ -333,7 +333,7 @@ 
             }
         }
 
-        if ($defaultLabel === null && ! empty($choices)) {
+        if ($defaultLabel === null && !empty($choices)) {
             $defaultLabel = array_key_first($choices);
         }
 
@@ -350,11 +350,11 @@ 
 
         $configProviderClass = sprintf('%s\\%s\\UpgradeCommandConfig', __NAMESPACE__, $descriptor['namespace']);
 
-        if (! class_exists($configProviderClass)) {
+        if (!class_exists($configProviderClass)) {
             $this->manuallyLoadConfigDirectory($descriptor);
         }
 
-        if (! class_exists($configProviderClass)) {
+        if (!class_exists($configProviderClass)) {
             throw new RuntimeException(sprintf(
                 'Missing upgrade config provider for Backpack %s. Please create %s.',
                 $descriptor['label'],
@@ -366,7 +366,7 @@ 
             ? $this->laravel->make($configProviderClass)
             : new $configProviderClass();
 
-        if (! $provider instanceof UpgradeConfigInterface) {
+        if (!$provider instanceof UpgradeConfigInterface) {
             throw new RuntimeException(sprintf(
                 'Upgrade config provider [%s] must implement %s.',
                 $configProviderClass,
@@ -376,7 +376,7 @@ 
 
         $steps = $provider->steps();
 
-        if (! is_array($steps)) {
+        if (!is_array($steps)) {
             throw new RuntimeException(sprintf(
                 'Upgrade config provider [%s] must return an array of step class names.',
                 $configProviderClass
@@ -428,7 +428,7 @@ 
                 $singleDescriptor = $sorted[0];
                 $singleConfig = $this->resolveConfigForDescriptor($singleDescriptor);
 
-                if (! $this->descriptorHasSteps($singleConfig)) {
+                if (!$this->descriptorHasSteps($singleConfig)) {
                     if ($this->displayDescriptorDescription($singleDescriptor, $singleConfig)) {
                         $this->newLine();
                     }
@@ -446,7 +446,7 @@ 
                 $hasSteps = $this->descriptorHasSteps($config);
                 $summary = $hasSteps ? $this->descriptorChoiceSummary($descriptor, $config) : null;
 
-                if (! $hasSteps) {
+                if (!$hasSteps) {
                     if ($this->displayDescriptorDescription($descriptor, $config)) {
                         $this->newLine();
                     }
@@ -552,13 +552,13 @@ 
             return $this->descriptorChoiceSummaries[$key];
         }
 
-        if (! $config instanceof UpgradeConfigSummaryInterface) {
+        if (!$config instanceof UpgradeConfigSummaryInterface) {
             return $this->descriptorChoiceSummaries[$key] = null;
         }
 
         $summary = $config->upgradeCommandSummary();
 
-        if (! is_string($summary)) {
+        if (!is_string($summary)) {
             return $this->descriptorChoiceSummaries[$key] = null;
         }
 
@@ -597,7 +597,7 @@ 
 
         try {
             $description($this);
-        } catch (\ArgumentCountError|\TypeError $exception) {
+        } catch (\ArgumentCountError | \TypeError $exception) {
             if ($description instanceof \Closure) {
                 $description->call($this);
 
@@ -628,7 +628,7 @@ 
 
             $configPath = $directory.DIRECTORY_SEPARATOR.'UpgradeCommandConfig.php';
 
-            if (! $filesystem->exists($configPath)) {
+            if (!$filesystem->exists($configPath)) {
                 continue;
             }
 
@@ -688,7 +688,7 @@ 
     {
         $list = array_values($descriptors);
 
-        usort($list, function (array $a, array $b) use ($direction) {
+        usort($list, function(array $a, array $b) use ($direction) {
             $comparison = version_compare($a['comparable'], $b['comparable']);
 
             return $direction === 'desc' ? -$comparison : $comparison;
@@ -728,7 +728,7 @@ 
     protected function installedBackpackPrettyVersion(): ?string
     {
         try {
-            if (! InstalledVersions::isInstalled('backpack/crud')) {
+            if (!InstalledVersions::isInstalled('backpack/crud')) {
                 return null;
             }
         } catch (OutOfBoundsException $exception) {
@@ -781,7 +781,7 @@ 
 
     protected function segmentsToComparable(array $segments): string
     {
-        return implode('.', array_map(static function ($segment) {
+        return implode('.', array_map(static function($segment) {
             return (string) (int) $segment;
         }, $segments));
     }
@@ -799,7 +799,7 @@ 
 
         $stepsPath = $basePath.DIRECTORY_SEPARATOR.'Steps';
 
-        if (! $filesystem->isDirectory($stepsPath)) {
+        if (!$filesystem->isDirectory($stepsPath)) {
             return;
         }
 

src/app/Console/Commands/Upgrade/v7/Steps/CheckThemeTablerConfigStep.php

Spacing +4 added lines, -4 removed lines

@@ -77,7 +77,7 @@ 
 
     public function fixOptions(StepResult $result): array
     {
-        if (! $this->needsPublish || $this->acceptedNewStyle) {
+        if (!$this->needsPublish || $this->acceptedNewStyle) {
             return [];
         }
 
@@ -101,7 +101,7 @@ 
 
     public function fix(StepResult $result): StepResult
     {
-        if (! $this->needsPublish) {
+        if (!$this->needsPublish) {
             return StepResult::skipped('Tabler theme config already published.');
         }
 
@@ -129,7 +129,7 @@ 
 
         $packagePath = $this->configs->packageConfigPath($this->configFilename);
 
-        if (! is_file($packagePath)) {
+        if (!is_file($packagePath)) {
             return StepResult::failure('Could not publish config/backpack/theme-tabler.php automatically.');
         }
 
@@ -139,7 +139,7 @@ 
             return StepResult::failure('Could not read the default Tabler config to publish it automatically.');
         }
 
-        if (! $this->configs->writePublishedFile($this->configFilename, $defaultContents)) {
+        if (!$this->configs->writePublishedFile($this->configFilename, $defaultContents)) {
             return StepResult::failure('Failed writing changes to config/backpack/theme-tabler.php.');
         }