Issues in MenuItemTest.php - New Issues - Inspection of "[AllBundle] Fix risky tests (#2407)" - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c5c436...b453a3 )

by Ruud

created 2019-03-22 10:39 UTC

MenuBundle/Tests/unit/Entity/MenuItemTest.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\MenuBundle\Tests\Entity;

use Doctrine\Common\Collections\ArrayCollection;
use Kunstmaan\MenuBundle\Entity\BaseMenuItem;
use Kunstmaan\MenuBundle\Entity\Menu;
use Kunstmaan\MenuBundle\Entity\MenuItem;
use Kunstmaan\NodeBundle\Entity\Node;
use Kunstmaan\NodeBundle\Entity\NodeTranslation;
use PHPUnit\Framework\TestCase;
use Symfony\Component\Validator\Context\ExecutionContext;
use Symfony\Component\Validator\Violation\ConstraintViolationBuilder;

class MenuItemTest extends TestCase
{
    public function testGetSetParent()
    {
        $son = new MenuItem();
        $daddy = new MenuItem();

        $son->setParent($daddy);
        $this->assertInstanceOf(MenuItem::class, $son->getParent());
    }

    public function testGetSetChildren()
    {
        $daddy = new MenuItem();
        $son = new MenuItem();
        $daughter = new MenuItem();

        $daddy->setChildren(new ArrayCollection([$son, $daughter]));
        $this->assertInstanceOf(ArrayCollection::class, $son->getChildren());
    }

    public function testBaseClassMethods()
    {
        $item = new MenuItem();
        $menu = new Menu();
        $nodeTranslation = new NodeTranslation();

        $item->setMenu($menu);
        $item->setType('Rubber Chicken');
        $item->setNodeTranslation($nodeTranslation);
        $item->setTitle('Buy Bitcoin Cash!');
        $item->setUrl('https://nasa.gov');
        $item->setNewWindow(true);
        $item->setLft(5);
        $item->setLvl(6);
        $item->setRgt(7);

        $this->assertInstanceOf(Menu::class, $item->getMenu());
        $this->assertEquals('Rubber Chicken', $item->getType());
        $this->assertInstanceOf(NodeTranslation::class, $item->getNodeTranslation());
        $this->assertEquals('Buy Bitcoin Cash!', $item->getTitle());
        $this->assertEquals('https://nasa.gov', $item->getUrl());
        $this->assertTrue($item->isNewWindow());
        $this->assertEquals(5, $item->getLft());
        $this->assertEquals(6, $item->getLvl());
        $this->assertEquals(7, $item->getRgt());
    }

    public function testGetDisplayUrl()
    {
        $item = new MenuItem();
        $nodeTranslation = new NodeTranslation();

        $nodeTranslation->setUrl('https://nasa.gov');
        $item->setType(BaseMenuItem::TYPE_PAGE_LINK);
        $item->setUrl('https://bitcoinwisdom.com');
        $item->setNodeTranslation($nodeTranslation);

        $this->assertEquals('https://nasa.gov', $item->getDisplayUrl());

        $item->setType(BaseMenuItem::TYPE_URL_LINK);
        $this->assertEquals('https://bitcoinwisdom.com', $item->getDisplayUrl());
    }

    public function testGetDisplayTitle()
    {
        $item = new MenuItem();
        $nodeTranslation = new NodeTranslation();

        $nodeTranslation->setTitle('Node');
        $item->setType(BaseMenuItem::TYPE_PAGE_LINK);
        $item->setNodeTranslation($nodeTranslation);
        $this->assertEquals('Node', $item->getDisplayTitle());

        $item->setTitle('Hello');
        $this->assertEquals('Hello', $item->getDisplayTitle());

        $item->setType(BaseMenuItem::TYPE_URL_LINK);
        $this->assertEquals('Hello', $item->getDisplayTitle());
    }

    public function testIsOnline()
    {
        $item = new MenuItem();
        $nodeTranslation = new NodeTranslation();
        $node = new Node();
        $node->setDeleted(false);
        $nodeTranslation->setOnline(false);
        $nodeTranslation->setNode($node);
        $item->setNodeTranslation($nodeTranslation);

        $this->assertFalse($item->isOnline());

        $item->setType(BaseMenuItem::TYPE_URL_LINK);
        $this->assertTrue($item->isOnline());

        $item->setType(BaseMenuItem::TYPE_PAGE_LINK);
        $this->assertFalse($item->isOnline());

        $nodeTranslation->setOnline(true);
        $this->assertTrue($item->isOnline());
    }

    public function testValidateEntity()
    {
        $nodeTranslation = $this->createMock(NodeTranslation::class);
        $item = new MenuItem();
        $item->setType(MenuItem::TYPE_PAGE_LINK);
        $item->setNodeTranslation($nodeTranslation);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $item->setTitle('Title');
        $item->setUrl('Url');

        $violationBuilder = $this->getMockBuilder(ConstraintViolationBuilder::class)
            ->disableOriginalConstructor()
            ->getMock();

        $violationBuilder->expects($this->never())
            ->method('atPath')
            ->will($this->returnValue($violationBuilder));

        $violationBuilder->expects($this->never())
            ->method('addViolation')
            ->will($this->returnValue(true));

        $context = $this->getMockBuilder(ExecutionContext::class)
            ->disableOriginalConstructor()
            ->getMock();

        $context->expects($this->never())
        ->method('buildViolation')
        ->will($this->returnValue($violationBuilder));

        $item->validateEntity($context);
        $item->setType(MenuItem::TYPE_URL_LINK);
        $item->validateEntity($context);
    }
}


1		<?php
2
3		namespace Kunstmaan\MenuBundle\Tests\Entity;
4
5		use Doctrine\Common\Collections\ArrayCollection;
6		use Kunstmaan\MenuBundle\Entity\BaseMenuItem;
7		use Kunstmaan\MenuBundle\Entity\Menu;
8		use Kunstmaan\MenuBundle\Entity\MenuItem;
9		use Kunstmaan\NodeBundle\Entity\Node;
10		use Kunstmaan\NodeBundle\Entity\NodeTranslation;
11		use PHPUnit\Framework\TestCase;
12		use Symfony\Component\Validator\Context\ExecutionContext;
13		use Symfony\Component\Validator\Violation\ConstraintViolationBuilder;
14
15		class MenuItemTest extends TestCase
16		{
17		public function testGetSetParent()
18		{
19		$son = new MenuItem();
20		$daddy = new MenuItem();
21
22		$son->setParent($daddy);
23		$this->assertInstanceOf(MenuItem::class, $son->getParent());
24		}
25
26		public function testGetSetChildren()
27		{
28		$daddy = new MenuItem();
29		$son = new MenuItem();
30		$daughter = new MenuItem();
31
32		$daddy->setChildren(new ArrayCollection([$son, $daughter]));
33		$this->assertInstanceOf(ArrayCollection::class, $son->getChildren());
34		}
35
36		public function testBaseClassMethods()
37		{
38		$item = new MenuItem();
39		$menu = new Menu();
40		$nodeTranslation = new NodeTranslation();
41
42		$item->setMenu($menu);
43		$item->setType('Rubber Chicken');
44		$item->setNodeTranslation($nodeTranslation);
45		$item->setTitle('Buy Bitcoin Cash!');
46		$item->setUrl('https://nasa.gov');
47		$item->setNewWindow(true);
48		$item->setLft(5);
49		$item->setLvl(6);
50		$item->setRgt(7);
51
52		$this->assertInstanceOf(Menu::class, $item->getMenu());
53		$this->assertEquals('Rubber Chicken', $item->getType());
54		$this->assertInstanceOf(NodeTranslation::class, $item->getNodeTranslation());
55		$this->assertEquals('Buy Bitcoin Cash!', $item->getTitle());
56		$this->assertEquals('https://nasa.gov', $item->getUrl());
57		$this->assertTrue($item->isNewWindow());
58		$this->assertEquals(5, $item->getLft());
59		$this->assertEquals(6, $item->getLvl());
60		$this->assertEquals(7, $item->getRgt());
61		}
62
63	View Code Duplication	public function testGetDisplayUrl()
64		{
65		$item = new MenuItem();
66		$nodeTranslation = new NodeTranslation();
67
68		$nodeTranslation->setUrl('https://nasa.gov');
69		$item->setType(BaseMenuItem::TYPE_PAGE_LINK);
70		$item->setUrl('https://bitcoinwisdom.com');
71		$item->setNodeTranslation($nodeTranslation);
72
73		$this->assertEquals('https://nasa.gov', $item->getDisplayUrl());
74
75		$item->setType(BaseMenuItem::TYPE_URL_LINK);
76		$this->assertEquals('https://bitcoinwisdom.com', $item->getDisplayUrl());
77		}
78
79	View Code Duplication	public function testGetDisplayTitle()
80		{
81		$item = new MenuItem();
82		$nodeTranslation = new NodeTranslation();
83
84		$nodeTranslation->setTitle('Node');
85		$item->setType(BaseMenuItem::TYPE_PAGE_LINK);
86		$item->setNodeTranslation($nodeTranslation);
87		$this->assertEquals('Node', $item->getDisplayTitle());
88
89		$item->setTitle('Hello');
90		$this->assertEquals('Hello', $item->getDisplayTitle());
91
92		$item->setType(BaseMenuItem::TYPE_URL_LINK);
93		$this->assertEquals('Hello', $item->getDisplayTitle());
94		}
95
96		public function testIsOnline()
97		{
98		$item = new MenuItem();
99		$nodeTranslation = new NodeTranslation();
100		$node = new Node();
101		$node->setDeleted(false);
102		$nodeTranslation->setOnline(false);
103		$nodeTranslation->setNode($node);
104		$item->setNodeTranslation($nodeTranslation);
105
106		$this->assertFalse($item->isOnline());
107
108		$item->setType(BaseMenuItem::TYPE_URL_LINK);
109		$this->assertTrue($item->isOnline());
110
111		$item->setType(BaseMenuItem::TYPE_PAGE_LINK);
112		$this->assertFalse($item->isOnline());
113
114		$nodeTranslation->setOnline(true);
115		$this->assertTrue($item->isOnline());
116		}
117
118		public function testValidateEntity()
119		{
120		$nodeTranslation = $this->createMock(NodeTranslation::class);
121		$item = new MenuItem();
122		$item->setType(MenuItem::TYPE_PAGE_LINK);
123		$item->setNodeTranslation($nodeTranslation);
		0 ignored issues – show Documentation introduced 2019-03-22 07:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$nodeTranslation` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Kunstmaan\NodeBun...Entity\NodeTranslation>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
124		$item->setTitle('Title');
125		$item->setUrl('Url');
126
127		$violationBuilder = $this->getMockBuilder(ConstraintViolationBuilder::class)
128		->disableOriginalConstructor()
129		->getMock();
130
131		$violationBuilder->expects($this->never())
132		->method('atPath')
133		->will($this->returnValue($violationBuilder));
134
135		$violationBuilder->expects($this->never())
136		->method('addViolation')
137		->will($this->returnValue(true));
138
139		$context = $this->getMockBuilder(ExecutionContext::class)
140		->disableOriginalConstructor()
141		->getMock();
142
143		$context->expects($this->never())
144		->method('buildViolation')
145		->will($this->returnValue($violationBuilder));
146
147		$item->validateEntity($context);
148		$item->setType(MenuItem::TYPE_URL_LINK);
149		$item->validateEntity($context);
150		}
151		}
152

Kunstmaan / KunstmaanBundlesCMS

Push — master ( c5c436...b453a3 )

MenuBundle/Tests/unit/Entity/MenuItemTest.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like