Issues in DoctrineDBALAdapterTest.php - Fixed Issues - Inspection of "[NodeBundle] Allow duplicate with children (#2686..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 06c1ce...67d37c )

by Jeroen

created 2020-06-12 09:11 UTC

unit/AdminList/Helper/DoctrineDBALAdapterTest.php (1 issue)

Showing only issues like (Show All)

mismatching argument types.

Documentation Minor

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\AdminListBundle\Tests\AdminList;

use Doctrine\DBAL\Query\QueryBuilder;
use Doctrine\DBAL\Statement;
use Kunstmaan\AdminListBundle\Helper\DoctrineDBALAdapter;
use PHPUnit\Framework\TestCase;

/**
 * Class AdminListTest
 */
class DoctrineDBALAdapterTest extends TestCase
{
    /**
     * @expectedException \LogicException
     * @expectedExceptionMessage The $countField must contain a table alias in the string.
     */
    public function testConstructorWithIncorrectCountField()
    {
        $qb = $this->createMock(QueryBuilder::class);
        new DoctrineDBALAdapter($qb, 'somefield');
    }

    public function testGetQueryBuilder()
    {
        $qb = $this->createMock(QueryBuilder::class);
        $qb->expects($this->once())->method('getType')->willReturn(QueryBuilder::SELECT);
        $adapter = new DoctrineDBALAdapter($qb, 'table.somefield');

        $this->assertInstanceOf(QueryBuilder::class, $adapter->getQueryBuilder());
    }

    /**
     * @expectedException \LogicException
     * @expectedExceptionMessage Only SELECT queries can be paginated.
     */
    public function testConstructorThrowsAnotherException()
    {
        $qb = $this->createMock(QueryBuilder::class);
        $qb->expects($this->once())->method('getType')->willReturn(QueryBuilder::DELETE);

        new DoctrineDBALAdapter($qb, 'table.somefield');
    }

    public function testGetSlice()
    {
        $length = 3;

        $statement = $this->createMock(Statement::class);
        $statement->expects($this->once())->method('fetchAll')->willReturn([1, 2, 3]);
        $qb = $this->createMock(QueryBuilder::class);
        $qb->expects($this->once())->method('getType')->willReturn(QueryBuilder::SELECT);
        $qb->expects($this->once())->method('setFirstResult')->willReturn($qb);
        $qb->expects($this->once())->method('setMaxResults')->with($length)->willReturn($qb);
        $qb->expects($this->once())->method('execute')->willReturn($statement);

        $adapter = new DoctrineDBALAdapter($qb, 'table.somefield');
        $result = $adapter->getSlice(0, $length);
        $this->assertCount($length, $result);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testNbResults()
    {
        $statement = $this->createMock(Statement::class);
        $statement->expects($this->once())->method('fetchColumn')->with(0)->willReturn([1, 2, 3]);
        $qb = $this->createMock(QueryBuilder::class);
        $qb->expects($this->once())->method('getType')->willReturn(QueryBuilder::SELECT);
        $qb->expects($this->once())->method('select')->willReturn($qb);
        $qb->expects($this->once())->method('orderBy')->willReturn($qb);
        $qb->expects($this->once())->method('setMaxResults')->with(1)->willReturn($qb);
        $qb->expects($this->once())->method('execute')->willReturn($statement);

        $adapter = new DoctrineDBALAdapter($qb, 'table.somefield');
        $result = $adapter->getNbResults();
        $this->assertCount(3, $result);
    }

    public function testNbResultsWithZeroResults()
    {
        $statement = $this->createMock(Statement::class);
        $statement->expects($this->once())->method('fetchColumn')->with(0)->willReturn(null);
        $qb = $this->createMock(QueryBuilder::class);
        $qb->expects($this->once())->method('getType')->willReturn(QueryBuilder::SELECT);
        $qb->expects($this->once())->method('select')->willReturn($qb);
        $qb->expects($this->once())->method('orderBy')->willReturn($qb);
        $qb->expects($this->once())->method('setMaxResults')->with(1)->willReturn($qb);
        $qb->expects($this->once())->method('execute')->willReturn($statement);

        $adapter = new DoctrineDBALAdapter($qb, 'table.somefield');
        $result = $adapter->getNbResults();
        $this->assertSame(0, $result);
    }
}


1			<?php
2
3			namespace Kunstmaan\AdminListBundle\Tests\AdminList;
4
5			use Doctrine\DBAL\Query\QueryBuilder;
6			use Doctrine\DBAL\Statement;
7			use Kunstmaan\AdminListBundle\Helper\DoctrineDBALAdapter;
8			use PHPUnit\Framework\TestCase;
9
10			/**
11			* Class AdminListTest
12			*/
13			class DoctrineDBALAdapterTest extends TestCase
14			{
15			/**
16			* @expectedException \LogicException
17			* @expectedExceptionMessage The $countField must contain a table alias in the string.
18			*/
19			public function testConstructorWithIncorrectCountField()
20			{
21			$qb = $this->createMock(QueryBuilder::class);
22			new DoctrineDBALAdapter($qb, 'somefield');
23			}
24
25			public function testGetQueryBuilder()
26			{
27			$qb = $this->createMock(QueryBuilder::class);
28			$qb->expects($this->once())->method('getType')->willReturn(QueryBuilder::SELECT);
29			$adapter = new DoctrineDBALAdapter($qb, 'table.somefield');
30
31			$this->assertInstanceOf(QueryBuilder::class, $adapter->getQueryBuilder());
32			}
33
34			/**
35			* @expectedException \LogicException
36			* @expectedExceptionMessage Only SELECT queries can be paginated.
37			*/
38			public function testConstructorThrowsAnotherException()
39			{
40			$qb = $this->createMock(QueryBuilder::class);
41			$qb->expects($this->once())->method('getType')->willReturn(QueryBuilder::DELETE);
42
43			new DoctrineDBALAdapter($qb, 'table.somefield');
44			}
45
46			public function testGetSlice()
47			{
48			$length = 3;
49
50			$statement = $this->createMock(Statement::class);
51			$statement->expects($this->once())->method('fetchAll')->willReturn([1, 2, 3]);
52			$qb = $this->createMock(QueryBuilder::class);
53			$qb->expects($this->once())->method('getType')->willReturn(QueryBuilder::SELECT);
54			$qb->expects($this->once())->method('setFirstResult')->willReturn($qb);
55			$qb->expects($this->once())->method('setMaxResults')->with($length)->willReturn($qb);
56			$qb->expects($this->once())->method('execute')->willReturn($statement);
57
58			$adapter = new DoctrineDBALAdapter($qb, 'table.somefield');
59			$result = $adapter->getSlice(0, $length);
60			$this->assertCount($length, $result);
			0 ignored issues – show Documentation introduced 2019-05-15 14:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$result` is of type `array\|object<Traversable>`, but the function expects a `object<Countable>\|object...nit\Framework\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
61			}
62
63			public function testNbResults()
64			{
65			$statement = $this->createMock(Statement::class);
66			$statement->expects($this->once())->method('fetchColumn')->with(0)->willReturn([1, 2, 3]);
67			$qb = $this->createMock(QueryBuilder::class);
68			$qb->expects($this->once())->method('getType')->willReturn(QueryBuilder::SELECT);
69			$qb->expects($this->once())->method('select')->willReturn($qb);
70			$qb->expects($this->once())->method('orderBy')->willReturn($qb);
71			$qb->expects($this->once())->method('setMaxResults')->with(1)->willReturn($qb);
72			$qb->expects($this->once())->method('execute')->willReturn($statement);
73
74			$adapter = new DoctrineDBALAdapter($qb, 'table.somefield');
75			$result = $adapter->getNbResults();
76			$this->assertCount(3, $result);
77			}
78
79			public function testNbResultsWithZeroResults()
80			{
81			$statement = $this->createMock(Statement::class);
82			$statement->expects($this->once())->method('fetchColumn')->with(0)->willReturn(null);
83			$qb = $this->createMock(QueryBuilder::class);
84			$qb->expects($this->once())->method('getType')->willReturn(QueryBuilder::SELECT);
85			$qb->expects($this->once())->method('select')->willReturn($qb);
86			$qb->expects($this->once())->method('orderBy')->willReturn($qb);
87			$qb->expects($this->once())->method('setMaxResults')->with(1)->willReturn($qb);
88			$qb->expects($this->once())->method('execute')->willReturn($statement);
89
90			$adapter = new DoctrineDBALAdapter($qb, 'table.somefield');
91			$result = $adapter->getNbResults();
92			$this->assertSame(0, $result);
93			}
94			}
95

Kunstmaan / KunstmaanBundlesCMS

Push — master ( 06c1ce...67d37c )

unit/AdminList/Helper/DoctrineDBALAdapterTest.php (1 issue)

Showing only issues like (Show All)

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like