Issues in index.js (master) - Issues in master - Jinzulen/TenorJS - Measure and Improve Code Quality continuously with Scrutinizer

Issues (3)

index.js (3 issues)

Labels

Severity

/**
 * @author Jinzulen
 * @license Apache 2.0
 * 
 * TenorJS - Lightweight NodeJS wrapper around the Tenor.com API.
 */
const Utilities = require("./src/Tools/Utilities");

exports.client = function (Credentials)
{
      const Filters      = ["off", "low", "medium", "high"],
            MediaFilters = ["gif", "mp4", "nanomp4", "nanogif", "tinymp4", "tinygif"];


      /**
       * Credentials checks.
       */
      if (!Credentials.Key || !Credentials.Locale || !Credentials.Filter)
      {
            throw new Error ("Client configuration is not complete; please ensure all configuration parameters are satisfied (Key, Locale, Filter).");
      }
      
      /**
       * Set default date format if user has set none.
       */
      if (!Credentials.DateFormat) Credentials.DateFormat = "D/MM/YYYY - H:mm:ss A";
if (a > 0)
    b = 42;

      /**
       * Check if the set content filter level abides by the available options.
       */
      if (!Filters.includes(Credentials.Filter.toLowerCase())) throw new Error ("Content filter level has to be one of these options: off, low, medium, high.");
if (a > 0)
    b = 42;

      /**
       * Set API gateway and set content filter to lowercase.
       */
      Credentials.Gate   = "https://tenor.googleapis.com/v2";
      Credentials.Filter = Credentials.Filter.toLowerCase();

      /**
       * Check status of TenorJS config.
       */
      Utilities.checkConfig(JSON.stringify(Credentials));

      return require("./src")(Credentials);
};

1			/**
2			* @author Jinzulen
3			* @license Apache 2.0
4			*
5			* TenorJS - Lightweight NodeJS wrapper around the Tenor.com API.
6			*/
7			const Utilities = require("./src/Tools/Utilities");
8
9			exports.client = function (Credentials)
10			{
11			const Filters = ["off", "low", "medium", "high"],
12			MediaFilters = ["gif", "mp4", "nanomp4", "nanogif", "tinymp4", "tinygif"];
			0 ignored issues – show Unused Code introduced 2022-08-11 03:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this The constant `MediaFilters` seems to be never used. Consider removing it. Loading history...
13
14			/**
15			* Credentials checks.
16			*/
17			if (!Credentials.Key \|\| !Credentials.Locale \|\| !Credentials.Filter)
18			{
19			throw new Error ("Client configuration is not complete; please ensure all configuration parameters are satisfied (Key, Locale, Filter).");
20			}
21
22			/**
23			* Set default date format if user has set none.
24			*/
25			if (!Credentials.DateFormat) Credentials.DateFormat = "D/MM/YYYY - H:mm:ss A";
			0 ignored issues – show Coding Style Best Practice introduced 2019-02-20 00:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
26
27			/**
28			* Check if the set content filter level abides by the available options.
29			*/
30			if (!Filters.includes(Credentials.Filter.toLowerCase())) throw new Error ("Content filter level has to be one of these options: off, low, medium, high.");
			0 ignored issues – show Coding Style Best Practice introduced 2019-02-20 02:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
31
32			/**
33			* Set API gateway and set content filter to lowercase.
34			*/
35			Credentials.Gate = "https://tenor.googleapis.com/v2";
36			Credentials.Filter = Credentials.Filter.toLowerCase();
37
38			/**
39			* Check status of TenorJS config.
40			*/
41			Utilities.checkConfig(JSON.stringify(Credentials));
42
43			return require("./src")(Credentials);
44			};

Jinzulen / TenorJS

Issues (3)

index.js (3 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like