HexMakina / kadro

StateAgent.class.php

Spacing +10 added lines, -10 removed lines

@@ -11,7 +11,7 @@ 
   // $options : https://www.php.net/manual/fr/session.configuration.php
   public function __construct($options)
   {
-    if(isset($options['session_name']))
+    if (isset($options['session_name']))
     {
       session_name($options['session_name']);
       unset($options['session_name']);
@@ -32,28 +32,28 @@ 
     return isset($_SESSION[$this->index_filter][$filter_name]) && strlen(''.$_SESSION[$this->index_filter][$filter_name]) > 0;
   }
 
-  public function filters($filter_name=null, $value=null)
+  public function filters($filter_name = null, $value = null)
   {
-    if(is_null($filter_name))
+    if (is_null($filter_name))
       return $_SESSION[$this->index_filter];
 
-    if(!is_null($value))
+    if (!is_null($value))
       $_SESSION[$this->index_filter][$filter_name] = $value;
 
     return $_SESSION[$this->index_filter][$filter_name] ?? null;
   }
 
-  public function reset_filters($filter_name=null)
+  public function reset_filters($filter_name = null)
   {
-    if(is_null($filter_name))
-      $_SESSION[$this->index_filter]=[];
+    if (is_null($filter_name))
+      $_SESSION[$this->index_filter] = [];
     else
       unset($_SESSION[$this->index_filter][$filter_name]);
   }
 
   public function operator_id($setter = null)
   {
-    if(!is_null($setter))
+    if (!is_null($setter))
       $_SESSION[$this->index_operator] = ['id' => $setter, 'set_on' => time()];
 
     return $_SESSION[$this->index_operator]['id'] ?? null;
@@ -68,10 +68,10 @@ 
   public function destroy() : bool
   {
 
-    if(ini_get("session.use_cookies"))
+    if (ini_get("session.use_cookies"))
     {
       $params = session_get_cookie_params();
-      setcookie(session_name(), '', time() - 42000,
+      setcookie(session_name(), '', time()-42000,
         $params["path"], $params["domain"],
         $params["secure"], $params["httponly"]
       );

Auth/Permissionability.class.php

Spacing +16 added lines, -16 removed lines

@@ -8,17 +8,17 @@ 
 
   public function permission_names()
   {
-    if(property_exists($this, 'permission_names'))
+    if (property_exists($this, 'permission_names'))
     {
       return explode(',', $this->permission_names);
     }
-    elseif(property_exists($this, 'permission_ids'))
+    elseif (property_exists($this, 'permission_ids'))
     {
       $ids = explode(',', $this->permission_ids);
       $ret = [];
       $permissions = Permission::get_many_by_AIPK($ids);
-      foreach($permissions as $id => $p)
-        $ret[]="$p";
+      foreach ($permissions as $id => $p)
+        $ret[] = "$p";
       return $ret;
     }
     
@@ -31,16 +31,16 @@ 
   public function permissions()
   {
     
-    if(!is_null($this->permissions))
+    if (!is_null($this->permissions))
       return $this->permissions;
     $permission_unique_keys = null;
-    if(property_exists($this, 'permission_names'))
+    if (property_exists($this, 'permission_names'))
     {
       $permission_unique_keys = explode(',', $this->permission_names);
       // vd(Permission::table()->select());
       $this->permissions = Permission::retrieve(Permission::table()->select()->aw_string_in('name', $permission_unique_keys));
     }
-    elseif(property_exists($this, 'permission_ids'))
+    elseif (property_exists($this, 'permission_ids'))
     {
       $permission_unique_keys = explode(',', $this->permission_ids);
       $this->permissions = Permission::retrieve(Permission::table()->select()->aw_numeric_in('id', $permission_unique_keys));
@@ -56,40 +56,40 @@ 
   public function has_permission($p) : bool
   {
     // new instances or inactive operators, none shall pass
-    if($this->is_new() === true || $this->is_active()  === false)
+    if ($this->is_new() === true || $this->is_active() === false)
       return false;
     
     $permission_name = $permission_id = null;
-    if(is_subclass_of($p, '\HexMakina\kadro\Auth\Permission'))
+    if (is_subclass_of($p, '\HexMakina\kadro\Auth\Permission'))
     {
       $permission_name = $p->get('name');
       $permission_id = $p->get_id();
     }
-    elseif(preg_match('/[0-9]+/', $p))
+    elseif (preg_match('/[0-9]+/', $p))
       $permission_id = $p;
     else
       $permission_name = $p;
 
 
-    if(!is_null($this->get('permission_names')) && !is_null($permission_name))
+    if (!is_null($this->get('permission_names')) && !is_null($permission_name))
     {
       return strpos($this->get('permission_names'), $permission_name) !== false;
     }
-    elseif(!is_null($this->get('permission_ids')) && !is_null($permission_id))
+    elseif (!is_null($this->get('permission_ids')) && !is_null($permission_id))
     {
       return strpos($this->get('permission_ids'), $permission_id) !== false;
     }
-    elseif(!is_null($permission_name))
+    elseif (!is_null($permission_name))
     {
-      if(method_exists($this, $permission_name) && $this->$permission_name() == true)
+      if (method_exists($this, $permission_name) && $this->$permission_name() == true)
       {
         return true;
       }
-      elseif(property_exists($this, $permission_name) && $this->$permission_name == true)
+      elseif (property_exists($this, $permission_name) && $this->$permission_name == true)
       {
         return true;
       }
-      elseif(ACL::match($this, $permission_name) === true)
+      elseif (ACL::match($this, $permission_name) === true)
       {
         return true;
       }

PSR4Autoloader.class.php

Spacing +6 added lines, -6 removed lines

@@ -40,9 +40,9 @@ 
   {
   	$dir_content = FileSystem::preg_scandir($base_dir, '/^[A-Z]{1}[A-Za-z]+(?!\.class.\.php)$/');
     
-  	foreach($dir_content as $res)
+  	foreach ($dir_content as $res)
   	{
-  		if(is_dir($fullpath = $base_dir.'/'.$res))
+  		if (is_dir($fullpath = $base_dir.'/'.$res))
   		{
   			$this->addNamespace('HexMakina\kadro\\'.$res, $fullpath);
         $this->addNamespaceTree($fullpath);
@@ -54,10 +54,10 @@ 
   {
     
     // normalize namespace prefix
-    $prefix = trim($prefix, '\\') . '\\';
+    $prefix = trim($prefix, '\\').'\\';
 
     // normalize the base directory with a trailing separator
-    $base_dir = rtrim($base_dir, DIRECTORY_SEPARATOR) . '/';
+    $base_dir = rtrim($base_dir, DIRECTORY_SEPARATOR).'/';
 
     // initialize the namespace prefix array
     if (isset($this->prefixes[$prefix]) === false) {
@@ -90,10 +90,10 @@ 
     while (false !== $pos = strrpos($prefix, '\\')) 
     {
       // retain the trailing namespace separator in the prefix
-      $prefix = substr($class, 0, $pos + 1);
+      $prefix = substr($class, 0, $pos+1);
       // var_dump("prefix: $prefix");
       // the rest is the relative class name
-      $relative_class = substr($class, $pos + 1);
+      $relative_class = substr($class, $pos+1);
       // try to load a mapped file for the prefix and relative class
       
       $mapped_file = $this->loadMappedFile($prefix, $relative_class);

Router/AltoRouter.php

Spacing +18 added lines, -18 removed lines

@@ -36,7 +36,7 @@ 
 	  * @param string $basePath
 	  * @param array $matchTypes
 	  */
-	public function __construct( $routes = array(), $basePath = '', $matchTypes = array() ) {
+	public function __construct($routes = array(), $basePath = '', $matchTypes = array()) {
 		$this->addRoutes($routes);
 		$this->setBasePath($basePath);
 		$this->addMatchTypes($matchTypes);
@@ -63,11 +63,11 @@ 
 	 * @author Koen Punt
 	 * @throws Exception
 	 */
-	public function addRoutes($routes){
-		if(!is_array($routes) && !$routes instanceof Traversable) {
+	public function addRoutes($routes) {
+		if (!is_array($routes) && !$routes instanceof Traversable) {
 			throw new \Exception('Routes should be an array or an instance of Traversable');
 		}
-		foreach($routes as $route) {
+		foreach ($routes as $route) {
 			call_user_func_array(array($this, 'map'), $route);
 		}
 	}
@@ -102,8 +102,8 @@ 
 
 		$this->routes[] = array($method, $route, $target, $name);
 
-		if($name) {
-			if(isset($this->namedRoutes[$name])) {
+		if ($name) {
+			if (isset($this->namedRoutes[$name])) {
 				throw new \Exception("Can not redeclare route '{$name}'");
 			} else {
 				$this->namedRoutes[$name] = $route;
@@ -127,7 +127,7 @@ 
 	public function generate($routeName, array $params = array()) {
 
 		// Check if named route exists
-		if(!isset($this->namedRoutes[$routeName])) {
+		if (!isset($this->namedRoutes[$routeName])) {
 			throw new \Exception("Route '{$routeName}' does not exist.");
 		}
 
@@ -135,21 +135,21 @@ 
 		$route = $this->namedRoutes[$routeName];
 
 		// prepend base path to route url again
-		$url = $this->basePath . $route;
+		$url = $this->basePath.$route;
 
 		if (preg_match_all('`(/|\.|)\[([^:\]]*+)(?::([^:\]]*+))?\](\?|)`', $route, $matches, PREG_SET_ORDER)) {
 
-			foreach($matches as $match) {
+			foreach ($matches as $match) {
 				list($block, $pre, $type, $param, $optional) = $match;
 
 				if ($pre) {
 					$block = substr($block, 1);
 				}
 
-				if(isset($params[$param])) {
+				if (isset($params[$param])) {
 					$url = str_replace($block, $params[$param], $url);
 				} elseif ($optional) {
-					$url = str_replace($pre . $block, '', $url);
+					$url = str_replace($pre.$block, '', $url);
 				}
 			}
 
@@ -171,7 +171,7 @@ 
 		$match = false;
 
 		// set Request Url if it isn't passed as parameter
-		if($requestUrl === null) {
+		if ($requestUrl === null) {
 			$requestUrl = isset($_SERVER['REQUEST_URI']) ? $_SERVER['REQUEST_URI'] : '/';
 		}
 
@@ -184,11 +184,11 @@ 
 		}
 
 		// set Request Method if it isn't passed as a parameter
-		if($requestMethod === null) {
+		if ($requestMethod === null) {
 			$requestMethod = isset($_SERVER['REQUEST_METHOD']) ? $_SERVER['REQUEST_METHOD'] : 'GET';
 		}
 
-		foreach($this->routes as $handler) {
+		foreach ($this->routes as $handler) {
 			list($methods, $route, $target, $name) = $handler;
 			$method_match = (stripos($methods, $requestMethod) !== false);
 
@@ -200,7 +200,7 @@ 
 				$match = true;
 			} elseif (isset($route[0]) && $route[0] === '@') {
 				// @ regex delimiter
-				$pattern = '`' . substr($route, 1) . '`u';
+				$pattern = '`'.substr($route, 1).'`u';
 				$match = preg_match($pattern, $requestUrl, $params) === 1;
 			} elseif (($position = strpos($route, '[')) === false) {
 				// No params in url, do string comparison
@@ -217,8 +217,8 @@ 
 			if ($match) {
 
 				if ($params) {
-					foreach($params as $key => $value) {
-						if(is_numeric($key)) unset($params[$key]);
+					foreach ($params as $key => $value) {
+						if (is_numeric($key)) unset($params[$key]);
 					}
 				}
 
@@ -239,7 +239,7 @@ 
 		if (preg_match_all('`(/|\.|)\[([^:\]]*+)(?::([^:\]]*+))?\](\?|)`', $route, $matches, PREG_SET_ORDER)) {
 
 			$matchTypes = $this->matchTypes;
-			foreach($matches as $match) {
+			foreach ($matches as $match) {
 				list($block, $pre, $type, $param, $optional) = $match;
 
 				if (isset($matchTypes[$type])) {

Controllers/Interfaces/DisplayController.class.php

Spacing +2 added lines, -2 removed lines

@@ -42,9 +42,9 @@
            returns null
    */
    
-   public function viewport($key=null, $value=null, $coercion=false);
+   public function viewport($key = null, $value = null, $coercion = false);
 
-   public function display($custom_template = null, $standalone=false);
+   public function display($custom_template = null, $standalone = false);
 
 }
 

Controllers/Paginator.class.php

Spacing +13 added lines, -13 removed lines

@@ -11,36 +11,36 @@
   	global $smarty;
 
     $pages_max_on_each_side = 3;
-    $pages_max_displayed = $pages_max_on_each_side*2+1;
+    $pages_max_displayed = $pages_max_on_each_side * 2+1;
 
     // are we paginating ?
 
-    if(is_null($this->box('StateAgent')->filters('results_per_page')))
+    if (is_null($this->box('StateAgent')->filters('results_per_page')))
       return;
 
     $pages_range    = intval($this->box('StateAgent')->filters('results_per_page'));
     $pages_total    = $pages_range > 0 ? intval(ceil($records_total / $pages_range)) : 1;
     $pages_current  = intval($this->box('StateAgent')->filters('page'));
 
-    if($pages_current >= $pages_total)
+    if ($pages_current >= $pages_total)
       $pages_current = $pages_total;
 
-    $pages_first = ($pages_current <= $pages_max_on_each_side)? 1 : $pages_current - $pages_max_on_each_side;
+    $pages_first = ($pages_current <= $pages_max_on_each_side) ? 1 : $pages_current-$pages_max_on_each_side;
 
-    $pages_last = $pages_current + $pages_max_on_each_side;
+    $pages_last = $pages_current+$pages_max_on_each_side;
 
-    if($pages_last < $pages_max_displayed) // add the missing pages to fullfill $pages_max_displayed
+    if ($pages_last < $pages_max_displayed) // add the missing pages to fullfill $pages_max_displayed
       $pages_last += $pages_max_displayed-$pages_last;
 
-    if($pages_last > $pages_total) // $pages_max_displayed greater than the total of pages
+    if ($pages_last > $pages_total) // $pages_max_displayed greater than the total of pages
       $pages_last = $pages_total;
 
-  	$this->viewport("pages_total",     $pages_total);
-  	$this->viewport("pages_first",     $pages_first);
-    $this->viewport("pages_previous",  $pages_current <= 1 ? $pages_total : $pages_current - 1);
-  	$this->viewport("pages_current",   $pages_current);
-  	$this->viewport("pages_next",      $pages_current >= $pages_total ? 1 : $pages_current + 1);
-  	$this->viewport("pages_last",      $pages_last);
+  	$this->viewport("pages_total", $pages_total);
+  	$this->viewport("pages_first", $pages_first);
+    $this->viewport("pages_previous", $pages_current <= 1 ? $pages_total : $pages_current-1);
+  	$this->viewport("pages_current", $pages_current);
+  	$this->viewport("pages_next", $pages_current >= $pages_total ? 1 : $pages_current+1);
+  	$this->viewport("pages_last", $pages_last);
   }
 
 }

Controllers/KadroController.class.php

Spacing +45 added lines, -45 removed lines

@@ -2,7 +2,7 @@ 
 
 namespace HexMakina\kadro\Controllers;
 
-use \Psr\Container\{ContainerInterface,ContainerExceptionInterface,NotFoundExceptionInterface};
+use \Psr\Container\{ContainerInterface, ContainerExceptionInterface, NotFoundExceptionInterface};
 
 use \HexMakina\kadro\Auth\{OperatorInterface, AccessRefusedException};
 use \HexMakina\kadro\Router\RouterInterface;
@@ -15,7 +15,7 @@ 
 
   protected $route_back = null;
 
-  public function __toString(){ return get_called_class();}
+  public function __toString() { return get_called_class(); }
 
   // -------- Controller Container
   public function set_container(ContainerInterface $container)
@@ -29,9 +29,9 @@ 
   }
 
   // shortcut for (un)boxing
-  public function box($key, $instance=null)
+  public function box($key, $instance = null)
   {
-    if(!is_null($instance))
+    if (!is_null($instance))
       $this->container->register($key, $instance);
 
     // dd($this->container->get($key));
@@ -61,32 +61,32 @@ 
     return true; // security by default
   }
 
-  public function authorize($permission=null)
+  public function authorize($permission = null)
   {
     // if(!$this->requires_operator() || is_null($permission))
-    if(!$this->requires_operator())
+    if (!$this->requires_operator())
       return true;
 
     $operator = $this->operator();
-    if(is_null($operator) || $operator->is_new() || !$operator->is_active())
+    if (is_null($operator) || $operator->is_new() || !$operator->is_active())
       throw new AccessRefusedException();
 
-    if(!is_null($permission) && !$operator->has_permission($permission))
+    if (!is_null($permission) && !$operator->has_permission($permission))
       throw new AccessRefusedException();
 
     return true;
   }
 
-  public function viewport($key=null, $value=null, $coercion=false)
+  public function viewport($key = null, $value = null, $coercion = false)
   {
     // no key, returns all
-    if(is_null($key))
+    if (is_null($key))
       return $this->template_variables;
 
     // got key, got null value, returns $[$key]
-    if(is_null($value))
+    if (is_null($value))
     {
-      if($coercion === true) // break rule 1 ?
+      if ($coercion === true) // break rule 1 ?
         $this->template_variables[$key] = null;
 
       return $this->template_variables[$key] ?? null;
@@ -94,7 +94,7 @@ 
 
     // got key, got value
     // sets or coerces $[$key]=$value and returns $[$key]
-    if(!isset($this->template_variables[$key]) || $coercion === true)
+    if (!isset($this->template_variables[$key]) || $coercion === true)
       $this->template_variables[$key] = $value;
 
     return $this->template_variables[$key] ?? null;
@@ -106,22 +106,22 @@ 
 
     $custom_template = null;
 
-    if(method_exists($this, 'prepare'))
+    if (method_exists($this, 'prepare'))
     	$this->prepare();
 
-  	if(method_exists($this, $method = $this->router()->target_method()))
+  	if (method_exists($this, $method = $this->router()->target_method()))
     {
       $custom_template = $this->$method();
     }
 
-    if(method_exists($this, 'conclude'))
+    if (method_exists($this, 'conclude'))
     	$this->conclude();
 
-    if(method_exists($this, 'display'))
+    if (method_exists($this, 'display'))
     	$template = $this->display($custom_template);
   }
 
-  public function conclude(){}
+  public function conclude() {}
 
   public function prepare()
   {
@@ -130,14 +130,14 @@ 
 
   private function trim_request_data()
   {
-    array_walk_recursive($_GET, function(&$value){$value = trim($value);});
-    array_walk_recursive($_REQUEST, function(&$value){$value = trim($value);});
+    array_walk_recursive($_GET, function(&$value) {$value = trim($value); });
+    array_walk_recursive($_REQUEST, function(&$value) {$value = trim($value); });
 
-    if($this->router()->submits())
-      array_walk_recursive($_POST, function(&$value){$value = trim($value);});
+    if ($this->router()->submits())
+      array_walk_recursive($_POST, function(&$value) {$value = trim($value); });
   }
 
-  public function display($custom_template = null, $standalone=false)
+  public function display($custom_template = null, $standalone = false)
   {
     $smarty = $this->box('template_engine');
 
@@ -149,15 +149,15 @@ 
 
 
   	$this->viewport('file_root', $this->router()->file_root());
-  	$this->viewport('view_path', $this->router()->file_root() . $this->box('settings.smarty.template_path').'app/');
+  	$this->viewport('view_path', $this->router()->file_root().$this->box('settings.smarty.template_path').'app/');
   	$this->viewport('web_root', $this->router()->web_root());
-  	$this->viewport('view_url', $this->router()->web_root() . $this->box('settings.smarty.template_path'));
-  	$this->viewport('images_url', $this->router()->web_root() . $this->box('settings.smarty.template_path') . 'images/');
+  	$this->viewport('view_url', $this->router()->web_root().$this->box('settings.smarty.template_path'));
+  	$this->viewport('images_url', $this->router()->web_root().$this->box('settings.smarty.template_path').'images/');
 
-    foreach($this->viewport() as $template_var_name => $value)
+    foreach ($this->viewport() as $template_var_name => $value)
       $smarty->assign($template_var_name, $value);
 
-    if($standalone === false)
+    if ($standalone === false)
     {
       $smarty->display(sprintf('%s|%s', $this->box('settings.smarty.template_inclusion_path'), $template));
     }
@@ -180,32 +180,32 @@ 
     $controller_template_path = $this->template_base();
     $templates = [];
 
-    if(!empty($custom_template))
+    if (!empty($custom_template))
     {
       // 1. check for custom template in the current controller directory
-      $templates ['custom_3']= sprintf('%s/%s.html', $controller_template_path, $custom_template);
+      $templates ['custom_3'] = sprintf('%s/%s.html', $controller_template_path, $custom_template);
       // 2. check for custom template formatted as controller/view
-      $templates ['custom_2']= $custom_template.'.html';
-      $templates ['custom_1']= '_layouts/'.$custom_template.'.html';
+      $templates ['custom_2'] = $custom_template.'.html';
+      $templates ['custom_1'] = '_layouts/'.$custom_template.'.html';
     }
 
-    if(!empty($this->router()->target_method()))
+    if (!empty($this->router()->target_method()))
     {
       // 1. check for template in controller-related directory
-      $templates ['target_1']= sprintf('%s/%s.html', $controller_template_path, $this->router()->target_method());
+      $templates ['target_1'] = sprintf('%s/%s.html', $controller_template_path, $this->router()->target_method());
       // 2. check for template in app-related directory
-      $templates ['target_2']= sprintf('_layouts/%s.html', $this->router()->target_method());
+      $templates ['target_2'] = sprintf('_layouts/%s.html', $this->router()->target_method());
       // 3. check for template in kadro directory
-      $templates ['target_3']= sprintf('%s.html', $this->router()->target_method());
+      $templates ['target_3'] = sprintf('%s.html', $this->router()->target_method());
     }
 
-    $templates ['default_3']= sprintf('%s/edit.html', $controller_template_path);
-    $templates ['default_4']= 'edit.tpl';
+    $templates ['default_3'] = sprintf('%s/edit.html', $controller_template_path);
+    $templates ['default_4'] = 'edit.tpl';
     $templates = array_unique($templates);
 
-    while(!is_null($tpl_path = array_shift($templates)))
+    while (!is_null($tpl_path = array_shift($templates)))
     {
-      if($smarty->templateExists($tpl_path))
+      if ($smarty->templateExists($tpl_path))
         return $tpl_path;
     }
 
@@ -226,21 +226,21 @@ 
    * route_back($route_name [,$route_params]), sets $route_back using route_factory()
    *
    */
-  public function route_back($route_name=null, $route_params=[]) : string
+  public function route_back($route_name = null, $route_params = []) : string
 	{
-    if(is_null($route_name))
+    if (is_null($route_name))
 		  return $this->route_back ?? $this->router()->prehop(RouterInterface::ROUTE_HOME_NAME);
 
     return $this->route_back = $this->route_factory($route_name, $route_params);
 	}
 
-  public function route_factory($route_name=null, $route_params=[]) : string
+  public function route_factory($route_name = null, $route_params = []) : string
   {
     $route = null;
 
-    if(is_string($route_name) && !empty($route_name))
+    if (is_string($route_name) && !empty($route_name))
     {
-      if($this->router()->route_exists($route_name))
+      if ($this->router()->route_exists($route_name))
         $route = $this->router()->prehop($route_name, $route_params);
       else
         $route = $route_name;

Controllers/Abilities/__DEL__PictureManager.class.php

Spacing +45 added lines, -45 removed lines

@@ -11,35 +11,35 @@ 
 {
   use FileManager;
   
-  public function filenames($replace_by_thumbs_if_exists=false) : array
+  public function filenames($replace_by_thumbs_if_exists = false) : array
   {
     $picture_directory = $this->build_path_to_directory();
     $thumbnail_directory = $picture_directory;
 
-		if(!file_exists($picture_directory) && mkdir($picture_directory) === false)
+		if (!file_exists($picture_directory) && mkdir($picture_directory) === false)
 			return [];
 
-    $filenames = self::preg_scandir($picture_directory, '/^[0-9]+_[0-9]+\.[a-zA-Z]+/');// ID_SEQUENCENUMBER.ext
+    $filenames = self::preg_scandir($picture_directory, '/^[0-9]+_[0-9]+\.[a-zA-Z]+/'); // ID_SEQUENCENUMBER.ext
 
     sort($filenames);
     return $filenames;
   }
 
-  public function filepathes($replace_by_thumbs_if_exists=false)
+  public function filepathes($replace_by_thumbs_if_exists = false)
   {
     $filenames = $this->filenames($replace_by_thumbs_if_exists);
     $filepathes = [];
-    foreach($filenames as $filename)
+    foreach ($filenames as $filename)
       $filepathes[] = $this->locate_thumbnail($filename);
 
     return $filepathes;
   }
 
-  public function file_uris($replace_by_thumbs_if_exists=false)
+  public function file_uris($replace_by_thumbs_if_exists = false)
   {
     $filenames = $this->filenames($replace_by_thumbs_if_exists);
     $uris = [];
-    foreach($filenames as $filename)
+    foreach ($filenames as $filename)
       $uris[] = $this->locate_file($filename);
 
     dd($uris);
@@ -55,7 +55,7 @@ 
       'image/gif' => 'imagecreatefromgif',
     );
     $mime = mime_content_type($filepath);
-    if(array_key_exists($mime, $picture_mime_to_gd_create_function))
+    if (array_key_exists($mime, $picture_mime_to_gd_create_function))
       return true;
     return $mime;
   }
@@ -63,22 +63,22 @@ 
 
   public function upload()
   {
-    if(!array_key_exists($this->get_type(), $_FILES))
+    if (!array_key_exists($this->get_type(), $_FILES))
       throw new \Exception($this->get_type()." not found in _FILES");
 
-    if(!array_key_exists('size', $_FILES[$this->get_type()]) || $_FILES[$this->get_type()]['size'] == 0)
+    if (!array_key_exists('size', $_FILES[$this->get_type()]) || $_FILES[$this->get_type()]['size'] == 0)
       throw new \Exception('uploaded file has no size');
 
-    if(($file_type = self::is_picture_file($_FILES[$this->get_type()]['tmp_name'])) !== true)
+    if (($file_type = self::is_picture_file($_FILES[$this->get_type()]['tmp_name'])) !== true)
       throw new \Exception('data sent is not an image but a '.$file_type.'');
 
-    $filepath = $this->build_filename() . '.' . self::file_ext($_FILES[$this->get_type()]['name']);
+    $filepath = $this->build_filename().'.'.self::file_ext($_FILES[$this->get_type()]['name']);
     $filepath = $this->locate_file($filepath);
 
-		if(file_exists($filepath))
+		if (file_exists($filepath))
       throw new \Exception($this->get_type()." new path '$filepath' already exists");
 
-		if(copy($_FILES[$this->get_type()]['tmp_name'], $filepath) === false)
+		if (copy($_FILES[$this->get_type()]['tmp_name'], $filepath) === false)
 			throw new \Exception(" cant copy ".$_FILES[$this->get_type()]['name']." to ($filepath)");
 
     $this->make_thumbnail($filepath);
@@ -86,7 +86,7 @@ 
 
   public function download($url)
   {
-    $filepath = $this->build_filename() . '.' . self::file_ext($url);
+    $filepath = $this->build_filename().'.'.self::file_ext($url);
     $filepath = $this->locate_file($filepath);
 
     \qivive\Curlyb::fetch($url, $filepath);
@@ -101,7 +101,7 @@ 
 		$cover_iri = null;
 
 		$mime_type = mime_content_type($filepath);
-		switch($mime_type)
+		switch ($mime_type)
 		{
 			case 'image/jpeg':
 			case 'image/pjpeg':
@@ -117,21 +117,21 @@ 
 			break;
 		}
 
-		if(!is_null($cover_iri))
+		if (!is_null($cover_iri))
 		{
-			$width = imagesx( $cover_iri );
-			$height = imagesy( $cover_iri );
+			$width = imagesx($cover_iri);
+			$height = imagesy($cover_iri);
 
 			// calculate thumbnail size
       
 			$new_width = $settings[get_class($this->pmi)::model_type()][$this->get_type()]['thumbnail']['width'];
-			$new_height = floor( $height * ( $new_width / $width ) );
+			$new_height = floor($height * ($new_width / $width));
 
 			// create a new temporary image
 			$thumb_iri = imagecreatetruecolor($new_width, $new_height);
 
 			// copy and resize old image into new image
-			imagecopyresized( $thumb_iri, $cover_iri, 0, 0, 0, 0, $new_width, $new_height, $width, $height );
+			imagecopyresized($thumb_iri, $cover_iri, 0, 0, 0, 0, $new_width, $new_height, $width, $height);
 
 			// save thumbnail into a file
       imagejpeg($thumb_iri, $this->locate_thumbnail(pathinfo($filepath, PATHINFO_BASENAME)));
@@ -142,16 +142,16 @@ 
   {
     $filenames = $this->filenames();
 
-    foreach($filenames as $filename)
+    foreach ($filenames as $filename)
 				$this->remove($filename);
 
     $directory = $this->build_path_to_directory();
-		if(file_exists($directory) === true)
+		if (file_exists($directory) === true)
     {
-      if(is_dir($directory) === false)
+      if (is_dir($directory) === false)
         throw new \Exception($this->get_type()."' directory '$directory' is not a directory");
 
-   		if(rmdir($directory) === false)
+   		if (rmdir($directory) === false)
   			throw new \Exception("rmdir($directory) failed like a bitch");
     }
     else trigger_error($this->get_type()." $directory doesn't exist", E_USER_WARNING);
@@ -162,27 +162,27 @@ 
     // removing a picture, and maybe a thumbnail? build the $pathes array accordingly
     $pathes = [];
     $pathes[$this->get_type()] = $this->locate_file($picture_filename);
-    $pathes[$this->get_type() . ' thumbnail'] = $this->locate_thumbnail($picture_filename);
+    $pathes[$this->get_type().' thumbnail'] = $this->locate_thumbnail($picture_filename);
 
     $deleted = [];
     $still_walking = [];
-    foreach($pathes as $what => $path)
+    foreach ($pathes as $what => $path)
     {
       $error = null;
-  		if(!file_exists($path))
+  		if (!file_exists($path))
         $error = 'file does not exist';
-      elseif(unlink($path)===false)
+      elseif (unlink($path) === false)
         $error = 'unlink() failed';
 
-      if(is_null($error))
-        $deleted[]= $what;
+      if (is_null($error))
+        $deleted[] = $what;
       else
       {
         trigger_error(__FUNCTION__." '$picture_filename' ($what @ $path) impossible because ", E_USER_NOTICE);
-        $still_walking[]=$what;
+        $still_walking[] = $what;
       }
     }
-    return count($still_walking)===0;
+    return count($still_walking) === 0;
   }
 
   public function locate_thumbnail($filename)
@@ -196,11 +196,11 @@ 
     return $settings['thumbnail']['file_prefix'].''.pathinfo($picture_basename, PATHINFO_FILENAME).'.jpg';
   }
 
-  public static function file_info($absolute_path_to_picture, $what=null)
+  public static function file_info($absolute_path_to_picture, $what = null)
   {
-    $ret = parent::file_info($absolute_path_to_picture, $what=null);
+    $ret = parent::file_info($absolute_path_to_picture, $what = null);
 
-    if(is_array($ret))
+    if (is_array($ret))
     {
       $t = getimagesize($absolute_path_to_picture);
       $ret['width'] = $t[0];
@@ -218,7 +218,7 @@ 
   }
 
 
-  public static function uri_for($item, $picture_type, $thumbnail=true)
+  public static function uri_for($item, $picture_type, $thumbnail = true)
   {
     global $settings;
     $pi_manager = new PictureManager($item, $picture_type);
@@ -226,24 +226,24 @@ 
 		$pictures = $pi_manager->filenames();
 
     $item_model_type = get_class($item)::model_type();
-    if(count($pictures)===0)
+    if (count($pictures) === 0)
       return $settings[$item_model_type][$picture_type]['generic_picture'];
 
-		if($settings[$item_model_type][$picture_type]['cycle_on_load'])
+		if ($settings[$item_model_type][$picture_type]['cycle_on_load'])
 			$filename = $pictures[array_rand($pictures, 1)];
 		else
 			$filename = array_shift($pictures);
 
-    return $thumbnail===true ? $pi_manager->locate_thumbnail($filename) : $pi_manager->locate_file($filename);
+    return $thumbnail === true ? $pi_manager->locate_thumbnail($filename) : $pi_manager->locate_file($filename);
   }
 
   public function last_index()
   {
     $last_index = 0;
-    if(count($filenames = $this->filenames()) > 0)
+    if (count($filenames = $this->filenames()) > 0)
     {
       $last_filename = array_pop($filenames); // last cover name FIXME sort should be done here, check cost if sort already done
-      if(preg_match('/[0-9]+\_([0-9]+)\.[a-z]+/', $last_filename, $last_index) !== 1)
+      if (preg_match('/[0-9]+\_([0-9]+)\.[a-z]+/', $last_filename, $last_index) !== 1)
         throw new \Exception("FAILED_COMPUTING_NEW_INDEX_USING_REGEX");
 
       $last_index = $last_index[1];
@@ -257,9 +257,9 @@ 
     return sprintf('%s%s.jpg', $settings['thumbnail']['file_prefix'], pathinfo($picture_basename, PATHINFO_FILENAME));
   }
 
-  public function build_filename($index=null)
+  public function build_filename($index = null)
   {
-    if(is_null($index))
+    if (is_null($index))
       $index = $this->last_index()+1;
 
     return $this->pmi->id.'_'.sprintf("%'.09d", $index); // prepend bean id
@@ -278,7 +278,7 @@ 
     $new_thumbname_path = $this->locate_file($this->build_thumb_filename($new_filename_path)); //move current to zero
     $this->rename($selected_thumbname_path, $new_thumbname_path);
 
-    for($i=$filename_index-1; $i>=0; --$i)
+    for ($i = $filename_index-1; $i >= 0; --$i)
     {
       $move_this = $this->locate_file($files[$i]);
       $to_that = $this->locate_file($files[$i+1]);

Controllers/Breadcrumb.class.php

Spacing +2 added lines, -2 removed lines

@@ -11,9 +11,9 @@
     return $this->breadcrumbs;
   }
   
-  public function breadcrumb($show, $route=null)
+  public function breadcrumb($show, $route = null)
   {
-    $this->breadcrumbs[]= ['show' => $show, 'route' => $route];
+    $this->breadcrumbs[] = ['show' => $show, 'route' => $route];
   }
   
   public function reset_breadcrumbs() : array