HaaseIT / HCSF

src/Controller/Shop/Shoppingcart.php

Doc Comments +3 added lines, -3 removed lines

@@ -224,7 +224,7 @@ 
     }
 
     /**
-     * @return bool
+     * @return false|null
      */
     private function doCheckout()
     {
@@ -329,7 +329,7 @@ 
     }
 
     /**
-     * @param $iInsertID
+     * @param string $iInsertID
      * @param $sMailbody_us
      * @param $sMailbody_they
      * @param $aImagesToSend
@@ -376,7 +376,7 @@ 
     }
 
     /**
-     * @param $field
+     * @param string $field
      * @return string
      */
     private function getPostValue($field)

src/Controller/Shop/Updatecart.php

Doc Comments +1 added lines, -1 removed lines

@@ -118,7 +118,7 @@
     }
 
     /**
-     * @param $sReply
+     * @param string $sReply
      * @param array $aMore
      */
     private function replyToCartUpdate($sReply, $aMore = []) {

src/Helper.php

Doc Comments +6 added lines

@@ -214,6 +214,9 @@ 
         return $aP;
     }
 
+    /**
+     * @param Page $P
+     */
     private static function getDebug($aP, $P)
     {
         if (!empty($_POST)) {
@@ -260,6 +263,9 @@ 
         return $sLang;
     }
 
+    /**
+     * @param string $purpose
+     */
     public static function getPurifier($purpose)
     {
         $purifier_config = \HTMLPurifier_Config::createDefault();

src/UserPage.php

Doc Comments +3 added lines

@@ -85,6 +85,9 @@
         return $hResult->execute();
     }
 
+    /**
+     * @param string $sPagekeytoadd
+     */
     public function insert($sPagekeytoadd) {
         $aData = [
             'cb_key' => $sPagekeytoadd,

Braces +3 added lines, -1 removed lines

@@ -56,7 +56,9 @@
                 $hResult->fetch();
 
                 if ($this->cb_pagetype !== 'shorturl') {
-                    if (!$bReturnRaw) $this->cb_pageconfig = json_decode($this->cb_pageconfig);
+                    if (!$bReturnRaw) {
+                        $this->cb_pageconfig = json_decode($this->cb_pageconfig);
+                    }
                     $this->oPayload = $this->getPayload();
                 }
             }

src/Controller/Admin/Shop/Itemgroupadmin.php

Braces +27 added lines, -9 removed lines

@@ -81,7 +81,9 @@ 
                 ];
                 $sql = DBTools::buildPSInsertQuery($aData, 'itemgroups_text');
                 $hResult = $this->db->prepare($sql);
-                foreach ($aData as $sKey => $sValue) $hResult->bindValue(':'.$sKey, $sValue);
+                foreach ($aData as $sKey => $sValue) {
+                    $hResult->bindValue(':'.$sKey, $sValue);
+                }
                 $hResult->execute();
                 header('Location: /_admin/itemgroupadmin.html?gid='.$iGID.'&action=editgroup');
                 die();
@@ -107,14 +109,20 @@ 
                 $sGNo = filter_var($_REQUEST["no"], FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW);
                 $sImg = filter_var($_REQUEST["img"], FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW);
 
-                if (strlen($sName) < 3) $aErr["nametooshort"] = true;
-                if (strlen($sGNo) < 3) $aErr["grouptooshort"] = true;
+                if (strlen($sName) < 3) {
+                    $aErr["nametooshort"] = true;
+                }
+                if (strlen($sGNo) < 3) {
+                    $aErr["grouptooshort"] = true;
+                }
                 if (count($aErr) == 0) {
                     $sql = 'SELECT itmg_no FROM itemgroups_base WHERE itmg_no = :no';
                     $hResult = $this->db->prepare($sql);
                     $hResult->bindValue(':no', $sGNo);
                     $hResult->execute();
-                    if ($hResult->rowCount() > 0) $aErr["duplicateno"] = true;
+                    if ($hResult->rowCount() > 0) {
+                        $aErr["duplicateno"] = true;
+                    }
                 }
                 if (count($aErr) == 0) {
                     $aData = [
@@ -124,7 +132,9 @@ 
                     ];
                     $sql = DBTools::buildPSInsertQuery($aData, 'itemgroups_base');
                     $hResult = $this->db->prepare($sql);
-                    foreach ($aData as $sKey => $sValue) $hResult->bindValue(':'.$sKey, $sValue);
+                    foreach ($aData as $sKey => $sValue) {
+                        $hResult->bindValue(':'.$sKey, $sValue);
+                    }
                     $hResult->execute();
                     $iLastInsertID = $this->db->lastInsertId();
                     header('Location: /_admin/itemgroupadmin.html?action=editgroup&added&gid='.$iLastInsertID);
@@ -161,7 +171,9 @@ 
         $hResult->execute();
         $iNumRows = $hResult->rowCount();
 
-        if ($iNumRows > 0) return 'duplicateno';
+        if ($iNumRows > 0) {
+            return 'duplicateno';
+        }
 
         $aData = [
             'itmg_name' => filter_var($_REQUEST["name"], FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW),
@@ -194,7 +206,9 @@ 
             ];
             $sql = DBTools::buildPSUpdateQuery($aData, 'itemgroups_text', 'itmgt_id');
             $hResult = $this->db->prepare($sql);
-            foreach ($aData as $sKey => $sValue) $hResult->bindValue(':' . $sKey, $sValue);
+            foreach ($aData as $sKey => $sValue) {
+                $hResult->bindValue(':' . $sKey, $sValue);
+            }
             $hResult->execute();
         }
 
@@ -237,11 +251,15 @@ 
         $sql = 'SELECT * FROM itemgroups_base '
             . 'LEFT OUTER JOIN itemgroups_text ON itemgroups_base.itmg_id = itemgroups_text.itmgt_pid'
             . ' AND itemgroups_text.itmgt_lang = :lang';
-        if ($iGID != '') $sql .= ' WHERE itmg_id = :gid';
+        if ($iGID != '') {
+            $sql .= ' WHERE itmg_id = :gid';
+        }
         $sql .= ' ORDER BY itmg_no';
         $hResult = $this->db->prepare($sql);
         $hResult->bindValue(':lang', HelperConfig::$lang);
-        if ($iGID != '') $hResult->bindValue(':gid', $iGID);
+        if ($iGID != '') {
+            $hResult->bindValue(':gid', $iGID);
+        }
         $hResult->execute();
 
         $aGroups = $hResult->fetchAll();

src/Shop/Items.php

Braces +7 added lines, -5 removed lines

@@ -86,8 +86,7 @@ 
             if (!is_array($mItemno)) {
                 $hResult->bindValue(':itemno', $mItemno, \PDO::PARAM_STR);
             }
-        }
-        elseif (isset($_REQUEST["searchtext"]) && strlen($_REQUEST["searchtext"]) > 2) {
+        } elseif (isset($_REQUEST["searchtext"]) && strlen($_REQUEST["searchtext"]) > 2) {
             $sSearchtext = filter_var(trim($_REQUEST["searchtext"]), FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW);
             if (isset($_REQUEST["artnoexact"])) {
                 $hResult->bindValue(':searchtext', $sSearchtext, \PDO::PARAM_STR);
@@ -114,8 +113,9 @@ 
                 $sql .= 'item_base.itm_no = :itemno';
             }
         } elseif (isset($_REQUEST["searchtext"]) && \strlen($_REQUEST["searchtext"]) > 2) {
-            if (isset($_REQUEST["artnoexact"])) $sql .= 'item_base.itm_no = :searchtext';
-            else {
+            if (isset($_REQUEST["artnoexact"])) {
+                $sql .= 'item_base.itm_no = :searchtext';
+            } else {
                 $sql .= '(item_base.itm_no LIKE :searchtextwild1 OR itm_name LIKE :searchtextwild2';
                 $sql .= ' OR itml_name_override LIKE :searchtextwild3 OR itml_text1 LIKE :searchtextwild4';
                 $sql .= ' OR itml_text2 LIKE :searchtextwild5)';
@@ -123,7 +123,9 @@ 
         } else {
             if (is_array($mItemIndex)) {
                 $sql .= "(";
-                foreach ($mItemIndex as $sAIndex) $sql .= "itm_index LIKE '%".filter_var($sAIndex, FILTER_SANITIZE_SPECIAL_CHARS)."%' OR ";
+                foreach ($mItemIndex as $sAIndex) {
+                    $sql .= "itm_index LIKE '%".filter_var($sAIndex, FILTER_SANITIZE_SPECIAL_CHARS)."%' OR ";
+                }
                 $sql = \HaaseIT\Toolbox\Tools::cutStringend($sql, 4);
                 $sql .= ")";
             } else {

src/Router.php

Braces +6 added lines, -2 removed lines

@@ -116,9 +116,13 @@
                     If the last part of the path doesn't include a dot (.) and is not empty, apend a slash.
                     If there is already a slash at the end, the last part of the path array will be empty.
                      */
-                    if (mb_strpos($aPath[count($aPath) - 1], '.') === false && $aPath[count($aPath) - 1] != '') $this->sPath .= '/';
+                    if (mb_strpos($aPath[count($aPath) - 1], '.') === false && $aPath[count($aPath) - 1] != '') {
+                        $this->sPath .= '/';
+                    }
 
-                    if ($this->sPath[strlen($this->sPath) - 1] == '/') $this->sPath .= 'index.html';
+                    if ($this->sPath[strlen($this->sPath) - 1] == '/') {
+                        $this->sPath .= 'index.html';
+                    }
 
                     $this->P = new UserPage($this->serviceManager, $this->sPath);
                 }

src/Customer/Helper.php

Doc Comments +11 added lines

@@ -27,6 +27,9 @@ 
 
 class Helper
 {
+    /**
+     * @param string $sLang
+     */
     public static function validateCustomerForm($sLang, $aErr = [], $bEdit = false)
     {
         if (!isset($_POST["email"]) || !\filter_var($_POST["email"], FILTER_VALIDATE_EMAIL)) {
@@ -92,6 +95,11 @@ 
         return '';
     }
 
+    /**
+     * @param string $sKeyConfig
+     * @param string $sKeyForm
+     * @param boolean $aUserData
+     */
     public static function getCustomerFormDefaultValue($sKeyConfig, $sKeyForm, $aUserData) {
         $sDefaultValue = self::getUserData($sKeyConfig, $aUserData);
         if (!$sDefaultValue && isset($_SESSION["formsave_addrform"][$sKeyForm])) {
@@ -101,6 +109,9 @@ 
         return $sDefaultValue;
     }
 
+    /**
+     * @param string $sLang
+     */
     public static function buildCustomerForm($sLang, $sPurpose = 'none', $sErr = '', $aUserData = false)
     {
         $sDefaultCountry = self::getCustomerFormDefaultValue('cust_country', "country", $aUserData);

src/Controller/Shop/Myorders.php

Braces +3 added lines, -6 removed lines

@@ -160,14 +160,11 @@
 
                 if ($aRow["o_paymentmethod"] === 'prepay') {
                     $sPaymentmethod = $this->textcats->T("order_paymentmethod_prepay");
-                }
-                elseif ($aRow["o_paymentmethod"] === 'paypal') {
+                } elseif ($aRow["o_paymentmethod"] === 'paypal') {
                     $sPaymentmethod = $this->textcats->T("order_paymentmethod_paypal");
-                }
-                elseif ($aRow["o_paymentmethod"] === 'debit') {
+                } elseif ($aRow["o_paymentmethod"] === 'debit') {
                     $sPaymentmethod = $this->textcats->T("order_paymentmethod_debit");
-                }
-                elseif ($aRow["o_paymentmethod"] === 'invoice') {
+                } elseif ($aRow["o_paymentmethod"] === 'invoice') {
                     $sPaymentmethod = $this->textcats->T("order_paymentmethod_invoice");
                 } else {
                     $sPaymentmethod = ucwords($aRow["o_paymentmethod"]);