App\Http\Controllers\DemoController::reviewApplications()

Complexity

Conditions	1
Paths	1

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

0

<?php
    public function reviewApplications()
    {
        $jobPoster = factory(JobPoster::class)->state('closed')->create();
        $applications = factory(JobApplication::class, 10)->create([

The opening parenthesis of a multi-line function call should be the last content on the line.

            'job_poster_id' => $jobPoster->id
        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

        $jobPoster->job_applications()->saveMany($applications);
        $applications->load(['veteran_status', 'citizenship_declaration']);
        return view('manager/review_applications', [

The expression return view('manager/review_applications', array('jobs_l10n' => Illuminate\Support\Facades\Lang::get('manager/job_index'), 'job' => $jobPoster, 'applications' => $applications)) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

The opening parenthesis of a multi-line function call should be the last content on the line.

            /*Localization Strings*/
            'jobs_l10n' => Lang::get('manager/job_index'),

            /* Data */
            'job' => $jobPoster,
            'applications' => $applications,
        ]);