App\Services\Validation\WorkSamplesValidator

Complexity

Total Complexity

1

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	validate()	0	17	1

<?php

Missing file doc comment

namespace App\Services\Validation; 

class WorkSamplesValidator

Missing doc comment for class WorkSamplesValidator

{
/* 
 *
 */


public function validate(Request $request, Applicant $applicant)

The type App\Services\Validation\Request was not found. Did you mean Request? If so, make sure to prefix the type with \.

The parameter $applicant is not used and could be removed.

You must use "/**" style comments for a function comment

  {

Opening brace indented incorrectly; expected 0 spaces, found 2

        $request->validate([

The opening parenthesis of a multi-line function call should be the last content on the line.

            'work_samples[:template][:id][name]' => [
                'required', // Project must have a name.
             ],   
            'work_samples[:template][:id][file_type_id] ' => [
                'required', // Project type should be required.
            ],
            'work_samples[:template][:id][url]' => [
                'url:required', //  The work might not be hosted online depending on the nature of it. i.e. senstiive data/international work/NDA's etc. Maybe revise the required URL rule? Consider making it nullable.
            ],
            'work_samples[:template][:id][description]' => [
                'nullable',
                'string',
                'max:4000' // Allows the applicant to be descriptive with a rather generous paragraph but not so descriptive that the hiring manager will have to contend with a page of text. 
            ]
           
        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

       }

Closing brace indented incorrectly; expected 0 spaces, found 7

}