App\Services\Validation\ReferencesValidator

Complexity

Total Complexity

1

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	validate()	0	16	1

<?php

Missing file doc comment

namespace App\Services\Validation;

class ReferencesValidator 

Missing doc comment for class ReferencesValidator

{

Expected 0 spaces before opening brace; 1 found

/* 
*
*/

  public function validate(Request $request, Applicant $applicant)

The parameter $applicant is not used and could be removed.

The type App\Services\Validation\Request was not found. Did you mean Request? If so, make sure to prefix the type with \.

You must use "/**" style comments for a function comment

    {

Opening brace indented incorrectly; expected 2 spaces, found 4

        $request->validate([

The opening parenthesis of a multi-line function call should be the last content on the line.

            'references[:template][:id][name]' => [
                'required',      // Name of Reference shoud be required.
            ],
            'references[:template][:id][relationship_id]' => [
                'required', // Your Relationship should be required. 
            ],
            'references[:template][:id][email]' => [
                'email:required', // Maybe don't make email required incase applicant only has another form of contact info for this reference (Like phone number?) Potentially open this up for more forms of contacting the reference.
            ],
            'references[:template][:id][description]' => [
                'nullable',
                'string',
                'max:4000' // Allows the applicant to be descriptive with a rather generous paragraph but not so descriptive that the hiring manager will have to contend with a page of text. 
            ]
            
        ]);            

For multi-line function calls, the closing parenthesis should be on a new line.

        
    }

Closing brace indented incorrectly; expected 2 spaces, found 4

}