Issues in CustomerDeliveryAddress.php - New Issues - Inspection of "Improved tests and general cleanup (#39)" - FriendsOfApi/billogram - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 168b8f...f2b799 )

by Tobias

created 2017-08-27 16:53 UTC

src/Model/Customer/CustomerDeliveryAddress.php (1 issue)

Labels

Duplication 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Billogram\Model\Customer;

use Billogram\Model\CreatableFromArray;

/**
 * @author Ibrahim Hizeoui <[email protected]>
 */
class CustomerDeliveryAddress implements CreatableFromArray

{
    /**
     * @var string
     */
    private $name;

    /**
     * @var string
     */
    private $streetAddress;

    /**
     * @var string
     */
    private $careOf;

    /**
     * @var string
     */
    private $zipCode;

    /**
     * @var string
     */
    private $city;

    /**
     * @var string
     */
    private $country;

    /**
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * @param string $name
     *
     * @return CustomerDeliveryAddress
     */
    public function withName(string $name)
    {
        $new = clone $this;
        $new->name = $name;

        return $new;
    }

    /**
     * @return string
     */
    public function getStreetAddress()
    {
        return $this->streetAddress;
    }

    /**
     * @param string $streetAddress
     *
     * @return CustomerDeliveryAddress
     */
    public function withStreetAddress(string $streetAddress)
    {
        $new = clone $this;
        $new->streetAddress = $streetAddress;

        return $new;
    }

    /**
     * @return string
     */
    public function getCareOf()
    {
        return $this->careOf;
    }

    /**
     * @param string $careOf
     *
     * @return CustomerDeliveryAddress
     */
    public function withCareOf(string $careOf)
    {
        $new = clone $this;
        $new->zipCode = $careOf;

        return $new;
    }

    /**
     * @return string
     */
    public function getZipCode()
    {
        return $this->zipCode;
    }

    /**
     * @param string $zipCode
     *
     * @return CustomerDeliveryAddress
     */
    public function withZipCode(string $zipCode)
    {
        $new = clone $this;
        $new->zipCode = $zipCode;

        return $new;
    }

    /**
     * @return string
     */
    public function getCity()
    {
        return $this->city;
    }

    /**
     * @param string $city
     *
     * @return CustomerDeliveryAddress
     */
    public function withCity(string $city)
    {
        $new = clone $this;
        $new->city = $city;

        return $new;
    }

    /**
     * @return string
     */
    public function getCountry()
    {
        return $this->country;
    }

    /**
     * @param string $country
     *
     * @return CustomerDeliveryAddress
     */
    public function withCountry(string $country)
    {
        $new = clone $this;
        $new->country = $country;

        return $new;
    }

    public function toArray()
    {
        $data = [];
        if ($this->name !== null) {
            $data['name'] = $this->name;
        }
        if ($this->streetAddress !== null) {
            $data['street_address'] = $this->streetAddress;
        }
        if ($this->careOf !== null) {
            $data['careof'] = $this->careOf;
        }
        if ($this->zipCode !== null) {
            $data['zipcode'] = $this->zipCode;
        }
        if ($this->city !== null) {
            $data['city'] = $this->city;
        }
        if ($this->country !== null) {
            $data['country'] = $this->country;
        }

        return $data;
    }

    /**
     * Create an API response object from the HTTP response from the API server.
     *
     * @param array $data
     *
     * @return self
     */
    public static function createFromArray(array $data)
    {
        $customerDeliveryAddress = new self();
        $customerDeliveryAddress->name = $data['name'] ?? null;
        $customerDeliveryAddress->streetAddress = $data['street_address'] ?? null;
        $customerDeliveryAddress->careOf = $data['careof'] ?? null;
        $customerDeliveryAddress->zipCode = $data['zipcode'] ?? null;
        $customerDeliveryAddress->city = $data['city'] ?? null;
        $customerDeliveryAddress->country = $data['country'] ?? null;

        return $customerDeliveryAddress;
    }
}


1			<?php
2
3			namespace Billogram\Model\Customer;
4
5			use Billogram\Model\CreatableFromArray;
6
7			/**
8			* @author Ibrahim Hizeoui <[email protected]>
9			*/
10		View Code Duplication	class CustomerDeliveryAddress implements CreatableFromArray
			0 ignored issues – show Duplication introduced 2017-08-01 13:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
11			{
12			/**
13			* @var string
14			*/
15			private $name;
16
17			/**
18			* @var string
19			*/
20			private $streetAddress;
21
22			/**
23			* @var string
24			*/
25			private $careOf;
26
27			/**
28			* @var string
29			*/
30			private $zipCode;
31
32			/**
33			* @var string
34			*/
35			private $city;
36
37			/**
38			* @var string
39			*/
40			private $country;
41
42			/**
43			* @return string
44			*/
45			public function getName()
46			{
47			return $this->name;
48			}
49
50			/**
51			* @param string $name
52			*
53			* @return CustomerDeliveryAddress
54			*/
55			public function withName(string $name)
56			{
57			$new = clone $this;
58			$new->name = $name;
59
60			return $new;
61			}
62
63			/**
64			* @return string
65			*/
66			public function getStreetAddress()
67			{
68			return $this->streetAddress;
69			}
70
71			/**
72			* @param string $streetAddress
73			*
74			* @return CustomerDeliveryAddress
75			*/
76			public function withStreetAddress(string $streetAddress)
77			{
78			$new = clone $this;
79			$new->streetAddress = $streetAddress;
80
81			return $new;
82			}
83
84			/**
85			* @return string
86			*/
87			public function getCareOf()
88			{
89			return $this->careOf;
90			}
91
92			/**
93			* @param string $careOf
94			*
95			* @return CustomerDeliveryAddress
96			*/
97			public function withCareOf(string $careOf)
98			{
99			$new = clone $this;
100			$new->zipCode = $careOf;
101
102			return $new;
103			}
104
105			/**
106			* @return string
107			*/
108			public function getZipCode()
109			{
110			return $this->zipCode;
111			}
112
113			/**
114			* @param string $zipCode
115			*
116			* @return CustomerDeliveryAddress
117			*/
118			public function withZipCode(string $zipCode)
119			{
120			$new = clone $this;
121			$new->zipCode = $zipCode;
122
123			return $new;
124			}
125
126			/**
127			* @return string
128			*/
129			public function getCity()
130			{
131			return $this->city;
132			}
133
134			/**
135			* @param string $city
136			*
137			* @return CustomerDeliveryAddress
138			*/
139			public function withCity(string $city)
140			{
141			$new = clone $this;
142			$new->city = $city;
143
144			return $new;
145			}
146
147			/**
148			* @return string
149			*/
150			public function getCountry()
151			{
152			return $this->country;
153			}
154
155			/**
156			* @param string $country
157			*
158			* @return CustomerDeliveryAddress
159			*/
160			public function withCountry(string $country)
161			{
162			$new = clone $this;
163			$new->country = $country;
164
165			return $new;
166			}
167
168	2		public function toArray()
169			{
170	2		$data = [];
171	2		if ($this->name !== null) {
172	2		$data['name'] = $this->name;
173			}
174	2		if ($this->streetAddress !== null) {
175	2		$data['street_address'] = $this->streetAddress;
176			}
177	2		if ($this->careOf !== null) {
178	2		$data['careof'] = $this->careOf;
179			}
180	2		if ($this->zipCode !== null) {
181	2		$data['zipcode'] = $this->zipCode;
182			}
183	2		if ($this->city !== null) {
184	2		$data['city'] = $this->city;
185			}
186	2		if ($this->country !== null) {
187	2		$data['country'] = $this->country;
188			}
189
190	2		return $data;
191			}
192
193			/**
194			* Create an API response object from the HTTP response from the API server.
195			*
196			* @param array $data
197			*
198			* @return self
199			*/
200	4		public static function createFromArray(array $data)
201			{
202	4		$customerDeliveryAddress = new self();
203	4		$customerDeliveryAddress->name = $data['name'] ?? null;
204	4		$customerDeliveryAddress->streetAddress = $data['street_address'] ?? null;
205	4		$customerDeliveryAddress->careOf = $data['careof'] ?? null;
206	4		$customerDeliveryAddress->zipCode = $data['zipcode'] ?? null;
207	4		$customerDeliveryAddress->city = $data['city'] ?? null;
208	4		$customerDeliveryAddress->country = $data['country'] ?? null;
209
210	4		return $customerDeliveryAddress;
211			}
212			}
213

FriendsOfApi / billogram

Push — master ( 168b8f...f2b799 )

src/Model/Customer/CustomerDeliveryAddress.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like