Passed
Push — master ( c2d8e3...289151 )
by Jeroen
06:06
created

default/forms/admin/site/set_maintenance_mode.php (1 issue)

1
<?php
2
/**
3
 * Form body for setting robots.txt
4
 */
5
6
$site = elgg_get_site_entity();
7
$mode = (int) elgg_get_config('elgg_maintenance_mode', null);
8
9
$message = $site->getPrivateSetting('elgg_maintenance_message');
10
if (!$message) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $message of type null|string is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

In PHP, under loose comparison (like ==, or !=, or switch conditions), values of different types might be equal.

For string values, the empty string '' is a special case, in particular the following results might be unexpected:

''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
Loading history...
11
	$message = elgg_echo('admin:maintenance_mode:default_message');
12
}
13
14
echo elgg_view('output/longtext', [
15
	'value' => elgg_echo('admin:maintenance_mode:instructions'),
16
]);
17
18
echo elgg_view_field([
19
	'#type' => 'select',
20
	'#label' => elgg_echo('admin:maintenance_mode:mode_label'),
21
	'name' => 'mode',
22
	'options_values' => [
23
		'1' => elgg_echo('on'),
24
		'0' => elgg_echo('off'),
25
	],
26
	'value' => $mode,
27
]);
28
29
echo elgg_view_field([
30
	'#type' => 'longtext',
31
	'#label' => elgg_echo('admin:maintenance_mode:message_label'),
32
	'name' => 'message',
33
	'id' => 'message',
34
	'value' => $message,
35
]);
36
37
$footer = elgg_view_field([
38
	'#type' => 'submit',
39
	'value' => elgg_echo('save'),
40
]);
41
42
elgg_set_form_footer($footer);
43