View GitHub Repository Elgg

Schedule Inspection
Subscribe
Passed
Push — master ( c0a3a7...3b84a4 )
by Jeroen
58:51
created

views/default/page/components/column/excerpt.php (1 issue)

← previous file next file →
Showing only issues like (Show All)

Checks if the types of the passed arguments in a function/method call are compatible.

Bug Minor
1 
<?php
2 
/**
3 
 * Render an excerpt of the description
4 
 *
5 
 * @uses $vars['item']      The item being rendered
6 
 * @uses $vars['item_vars'] Vars received from the page/components/table view
7 
 * @uses $vars['type']      The item type or ""
8 
 * @uses $vars['length']    The excerpt length
9 
 */
10 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
$item = $vars['item'];

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                
/* @var ElggEntity $item */

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
$length = elgg_extract('length', $vars, 250);

            


            
                                                        
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
$description = $item->description;

            


            
                                                        
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                
echo elgg_get_excerpt($description, $excerpt_length);

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                        

                                        
It seems like $description can also be of type array; however, parameter $text of elgg_get_excerpt() does only seem to accept string, maybe add an additional type check?
                                                                                                                                                                                           (
                                     Ignorable by Annotation
                                )
                                

                                    
 If this is a false-positive, you can also ignore this issue in your code via the ignore-type   annotation

                                    

                                        

                                            18
                                            
                                                
echo elgg_get_excerpt(/** @scrutinizer ignore-type */ $description, $excerpt_length);

                                        

                                                                            

                                

                                                                                                                                                                                                                                    

                    
                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    19