Elgg / Elgg

mod/web_services/classes/ErrorResult.php

<?php
/**
 * ErrorResult
 * The error result class.
 *
 * @package    Elgg.Core
 * @subpackage WebServicesAPI
 */
class ErrorResult extends GenericResult {
	// Fail with no specific code
	public static $RESULT_FAIL = -1 ;

	public static $RESULT_FAIL_APIKEY_DISABLED = -30;
	public static $RESULT_FAIL_APIKEY_INACTIVE = -31;
	public static $RESULT_FAIL_APIKEY_INVALID = -32;

	// Invalid, expired or missing auth token
	public static $RESULT_FAIL_AUTHTOKEN = -20;

	/**
	 * A new error result
	 *
	 * @param string    $message   Message
	 * @param int       $code      Error Code
	 * @param Exception $exception Exception object
	 *
	 * @return void
	 */
	public function __construct($message, $code = "", Exception $exception = null) {
		if ($code == "") {
			$code = ErrorResult::$RESULT_FAIL;
		}

		if ($exception != null) {
			$this->setResult($exception->__toString());
		}

		$this->setStatusCode($code, $message);

It seems like $code can also be of type string; however, parameter $status of GenericResult::setStatusCode() does only seem to accept integer, maybe add an additional type check?

	}

	/**
	 * Get a new instance of the ErrorResult.
	 *
	 * @param string    $message   Message
	 * @param int       $code      Code
	 * @param Exception $exception Optional exception for generating a stack trace.
	 *
	 * @return ErrorResult
	 */
	public static function getInstance($message, $code = "", Exception $exception = null) {
		// Return a new error object.
		return new ErrorResult($message, $code, $exception);

It seems like $code can also be of type string; however, parameter $code of ErrorResult::__construct() does only seem to accept integer, maybe add an additional type check?

	}
}