Elgg / Elgg

mod/uservalidationbyemail/actions/uservalidationbyemail/validate.php

<?php
/**
 * Validate a user or users by guid
 */

$user_guids = get_input('user_guids');
$error = false;

if (!$user_guids) {
	return elgg_error_response(elgg_echo('uservalidationbyemail:errors:unknown_users'));
}

$access = access_show_hidden_entities(true);

foreach ($user_guids as $guid) {
	$user = get_entity($guid);
	if (!$user instanceof ElggUser) {
		$error = true;
		continue;
	}

	// only validate if not validated
	$user->setValidationStatus(true, 'manual');
	
	if ($user->isValidated() !== false || !($user->enable())) {
		$error = true;
		continue;
	}
}

access_show_hidden_entities($access);

if (count($user_guids) == 1) {

It seems like $user_guids can also be of type string; however, parameter $var of count() does only seem to accept Countable|array, maybe add an additional type check?

	$message_txt = elgg_echo('uservalidationbyemail:messages:validated_user');
	$error_txt = elgg_echo('uservalidationbyemail:errors:could_not_validate_user');
} else {
	$message_txt = elgg_echo('uservalidationbyemail:messages:validated_users');
	$error_txt = elgg_echo('uservalidationbyemail:errors:could_not_validate_users');
}

if ($error) {
	return elgg_error_response($error_txt);
}

return elgg_ok_response('', $message_txt);