The expression $result of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an
empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using empty(..) or !empty(...) instead.
Loading history...
104
return 0;
105
}
106
107
1
return (int) $result->total;
108
}
109
110
/**
111
* Apply numeric calculation to a column
112
*
113
* @param string $function Calculation, e.g. max, min, avg
114
* @param string $property Property name
115
* @param string $property_type Property type
116
*
117
* @return int|float
118
*/
119
public function calculate($function, $property, $property_type = null) {
120
throw new \LogicException(__METHOD__ . ' not implemented');
121
}
122
123
/**
124
* Fetch rows
125
*
126
* @param int $limit Number of rows to fetch
127
* @param int $offset Index of the first row
128
* @param callable|false $callback Callback function to run database rows through
129
*
130
* @return \ElggData[]|false
131
*/
132
2
public function get($limit = null, $offset = null, $callback = null) {
The expression $limit of type null|integer is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.
In PHP, under loose comparison (like ==, or !=, or switch conditions),
values of different types might be equal.
For integer values, zero is a special case, in particular the following
results might be unexpected:
0==false// true0==null// true123==false// false123==null// false// It is often better to use strict comparison0===false// false0===null// false
Loading history...
144
$qb->setMaxResults($limit);
145
$qb->setFirstResult($offset);
146
}
147
148
2
$qb->orderBy('time_created', 'DESC');
149
150
2
return _elgg_services()->db->getData($qb);
151
}
152
153
/**
154
* Apply correct execution method based on calculation, count or other criteria
Elgg /
Elgg
Ismayil Khayredinov
Loading history...
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using
empty(..)or! empty(...)instead.