Elgg / Elgg

mod/profile/actions/profile/edit.php

<?php
/**
 * Elgg profile edit action
 *
 */

elgg_make_sticky_form('profile:edit');

$guid = get_input('guid');
$owner = get_entity($guid);

It seems like $guid can also be of type string; however, parameter $guid of get_entity() does only seem to accept integer, maybe add an additional type check?

if (!($owner instanceof ElggUser) || !$owner->canEdit()) {
	return elgg_error_response(elgg_echo('profile:noaccess'));
}

// grab the defined profile field names and their load the values from POST.
// each field can have its own access, so sort that too.
$input = [];
$accesslevel = get_input('accesslevel');

if (!is_array($accesslevel)) {
	$accesslevel = [];
}

$profile_fields = elgg_get_config('profile_fields');
foreach ($profile_fields as $shortname => $valuetype) {
	$value = get_input($shortname);
	
	if ($value === null) {
		// only submitted profile fields should be updated
		continue;
	}
	
	// the decoding is a stop gap to prevent && showing up in profile fields
	// because it is escaped on both input (get_input()) and output (view:output/text). see #561 and #1405.
	// must decode in utf8 or string corruption occurs. see #1567.
	if (is_array($value)) {
		array_walk_recursive($value, function(&$v) {
			$v = elgg_html_decode($v);
		});
	} else {
		$value = elgg_html_decode($value);
	}
	
	// convert tags fields to array values
	if ($valuetype == 'tags') {
		$value = string_to_tag_array($value);
	}

	if ($value && $valuetype == 'url' && !preg_match('~^https?\://~i', $value)) {

It seems like $value can also be of type array; however, parameter $subject of preg_match() does only seem to accept string, maybe add an additional type check?

		$value = "http://$value";
	}

	if ($valuetype == 'email' && !empty($value) && !is_email_address($value)) {

It seems like $value can also be of type array; however, parameter $address of is_email_address() does only seem to accept string, maybe add an additional type check?

		return elgg_error_response(elgg_echo('profile:invalid_email', [elgg_echo("profile:{$shortname}")]));
	}
	
	$input[$shortname] = $value;
}

// display name is handled separately
$name = strip_tags(get_input('name'));
if ($name) {
	if (elgg_strlen($name) > 50) {
		return elgg_error_response(elgg_echo('user:name:fail'));
	} elseif ($owner->name !== $name) {
		$owner->name = $name;
	}
}

if (empty($input)) {
	return elgg_ok_response('', '', $owner->getUrl());
}

// go through custom fields
// fetch default access level for the user for use in fallback cases
$user_default_access = get_default_access($owner);

foreach ($input as $shortname => $value) {
	$owner->deleteAnnotations("profile:$shortname");

	// for BC, keep storing fields in MD, but we'll read annotations only
	elgg_delete_metadata([
		'guid' => $owner->guid,
		'metadata_name' => $shortname,
		'limit' => false
	]);
	
	if (!is_null($value) && ($value !== '')) {
		// only create metadata for non empty values (0 is allowed) to prevent metadata records
		// with empty string values #4858
		
		if (isset($accesslevel[$shortname])) {
			$access_id = (int) $accesslevel[$shortname];
		} else {
			// this should never be executed since the access level should always be set
			$access_id = $user_default_access;
		}

		if (!is_array($value)) {
			$value = [$value];
		}
		foreach ($value as $interval) {
			create_annotation($owner->guid, "profile:$shortname", $interval, 'text', $owner->guid, $access_id);

The function create_annotation() has been deprecated: 3.0

		}

		// for BC, keep storing fields in MD, but we'll read annotations only
		$owner->$shortname = $value;
	}
}

$owner->save();

// Notify of profile update
elgg_trigger_event('profileupdate', $owner->type, $owner);

elgg_clear_sticky_form('profile:edit');

return elgg_ok_response('', elgg_echo("profile:saved"), $owner->getUrl());