The expression $row of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an
empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using empty(..) or !empty(...) instead.
Loading history...
40
throw new InstallationException("Multiple sites detected in table: '{$prefix}{$table}'. Can't upgrade the database.");
41
}
42
}
43
}
44
45
/**
46
* Removes site guid from legacy 2.x tables
47
*/
48
public function up() {
49
50
$this->validate();
51
52
if ($this->hasTable('access_collections')) {
53
$table = $this->table('access_collections');
54
55
if ($table->hasIndex('site_guid')) {
56
$table->removeIndexByName('site_guid');
57
}
58
59
if ($table->hasColumn('site_guid')) {
60
$table->removeColumn('site_guid');
61
}
62
63
$table->save();
64
}
65
66
if ($this->hasTable('api_users')) {
67
$table = $this->table('api_users');
68
69
if ($table->hasColumn('site_guid')) {
70
$table->removeColumn('site_guid');
71
}
72
73
$table->save();
74
}
75
76
if ($this->hasTable('config')) {
77
$table = $this->table('config', [
78
'primary_key' => ["name"],
79
]);
80
81
if ($table->hasIndex('site_guid')) {
82
$table->removeIndexByName('site_guid');
83
}
84
85
if ($table->hasColumn('site_guid')) {
86
$table->removeColumn('site_guid');
87
}
88
89
$table->save();
90
}
91
92
if ($this->hasTable('entities')) {
93
$table = $this->table('entities');
94
95
if ($table->hasIndex('site_guid')) {
96
$table->removeIndexByName('site_guid');
97
}
98
99
if ($table->hasColumn('site_guid')) {
100
$table->removeColumn('site_guid');
101
}
102
103
$table->save();
104
}
105
106
if ($this->hasTable('users_apisessions')) {
107
$table = $this->table('users_apisessions');
108
109
if ($table->hasIndex('site_guid')) {
110
$table->removeIndexByName('site_guid');
111
}
112
113
if ($table->hasColumn('site_guid')) {
114
$table->removeColumn('site_guid');
115
}
116
117
if ($table->hasIndex('user_guid')) {
118
$table->removeIndex('user_guid');
119
}
120
121
$table->addIndex(['user_guid'], [
122
'name' => "user_guid",
123
'unique' => false,
124
]);
125
126
$table->save();
127
}
128
129
if ($this->hasTable('entity_relationships')) {
130
// Remove member_of_site relaitonship following site_guid removal
Elgg /
Elgg
Ismayil Khayredinov
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using
empty(..)or! empty(...)instead.