EventSerialization::serialize() - Code Metrics - Inspection of "Merge pull request #11567 from mrclay/11563_routes" - Elgg/Elgg - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c0a3a7...3b84a4 )

by Jeroen

created 2018-01-08 10:08 UTC

EventSerialization::serialize() A

↳ Parent: EventSerialization

Complexity

Conditions	4
Paths	6

Size

Total Lines	16
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	4

Importance

Changes

Metric	Value
cc	4
eloc	12
nc	6
nop	0
dl	0
loc	16
rs	9.2
c	0
b	0
f	0
ccs	12
cts	12
cp	1
crap	4

<?php

namespace Elgg\Notifications;

use ElggData;
use ElggEntity;
use stdClass;

/**
 * Allow events to be (un)serialized
 */
trait EventSerialization {
	
	/**
	 * Serializes event object for database storage
	 * @return string
	 */
	public function serialize() {
		$data = new stdClass();
		$data->action = $this->action;
		if ($this->object instanceof ElggData) {
			if ($this->object instanceof ElggEntity) {
				$data->object_id = $this->object->guid;
			} else {
				$data->object_id = $this->object->id;
			}
			$data->object_type = $this->object->getType();
			$data->object_subtype = $this->object->getSubtype();
		}
		if ($this->actor) {
			$data->actor_guid = $this->actor->guid;
		}
		return serialize($data);
	}

	/**
	 * Unserializes the event object stored in the database
	 *
	 * @param string $serialized Serialized string
	 * @return string
	 */
	public function unserialize($serialized) {
		$data = unserialize($serialized);
		if (isset($data->action)) {
			$this->action = $data->action;

		}
		if (isset($data->object_id) && isset($data->object_type)) {
			switch ($data->object_type) {
				case 'object' :
				case 'user' :
				case 'group' :
				case 'site' :
					$this->object = get_entity($data->object_id);

					break;
				case 'annotation' :
					$this->object = elgg_get_annotation_from_id($data->object_id);
					break;
				case 'metadata' :
					$this->object = elgg_get_metadata_from_id($data->object_id);
					break;
				case 'relationship' :
					$this->object = get_relationship($data->object_id);
			}
		}
		
		if (isset($data->actor_guid)) {
			$this->actor = get_entity($data->actor_guid);

		}
	}

}


1		<?php
2
3		namespace Elgg\Notifications;
4
5		use ElggData;
6		use ElggEntity;
7		use stdClass;
8
9		/**
10		* Allow events to be (un)serialized
11		*/
12		trait EventSerialization {
13
14		/**
15		* Serializes event object for database storage
16		* @return string
17		*/
18	49	public function serialize() {
19	49	$data = new stdClass();
20	49	$data->action = $this->action;
21	49	if ($this->object instanceof ElggData) {
22	49	if ($this->object instanceof ElggEntity) {
23	28	$data->object_id = $this->object->guid;
24		} else {
25	21	$data->object_id = $this->object->id;
26		}
27	49	$data->object_type = $this->object->getType();
28	49	$data->object_subtype = $this->object->getSubtype();
29		}
30	49	if ($this->actor) {
31	49	$data->actor_guid = $this->actor->guid;
32		}
33	49	return serialize($data);
34		}
35
36		/**
37		* Unserializes the event object stored in the database
38		*
39		* @param string $serialized Serialized string
40		* @return string
41		*/
42	36	public function unserialize($serialized) {
43	36	$data = unserialize($serialized);
44	36	if (isset($data->action)) {
45	36	$this->action = $data->action;
		1 ignored issue – show Bug Best Practice introduced 2017-10-16 06:19 UTC by Report Bug Copy Issue Report The property `action` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
46		}
47	36	if (isset($data->object_id) && isset($data->object_type)) {
48	36	switch ($data->object_type) {
49		case 'object' :
50		case 'user' :
51		case 'group' :
52		case 'site' :
53	18	$this->object = get_entity($data->object_id);
		1 ignored issue – show Bug Best Practice introduced 2017-10-16 06:19 UTC by Report Bug Copy Issue Report The property `object` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
54	18	break;
55		case 'annotation' :
56	6	$this->object = elgg_get_annotation_from_id($data->object_id);
57	6	break;
58		case 'metadata' :
59	6	$this->object = elgg_get_metadata_from_id($data->object_id);
60	6	break;
61		case 'relationship' :
62	6	$this->object = get_relationship($data->object_id);
63		}
64		}
65
66	36	if (isset($data->actor_guid)) {
67	36	$this->actor = get_entity($data->actor_guid);
		1 ignored issue – show Bug Best Practice introduced 2017-10-16 06:19 UTC by Report Bug Copy Issue Report The property `actor` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
68		}
69	36	}
70
71		}
72

Elgg / Elgg

Push — master ( c0a3a7...3b84a4 )

EventSerialization::serialize() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like