EGroupware / egroupware

api/src/Framework/CssIncludes.php

Braces +8 added lines, -2 removed lines

@@ -107,14 +107,20 @@
 		$max_modified = 0;
 		//no more dynamic minifying: $debug_minify = $GLOBALS['egw_info']['server']['debug_minify'] === 'True';
 		$base_path = $GLOBALS['egw_info']['server']['webserver_url'];
-		if ($base_path[0] != '/') $base_path = parse_url($base_path, PHP_URL_PATH);
+		if ($base_path[0] != '/')
+		{
+			$base_path = parse_url($base_path, PHP_URL_PATH);
+		}
 		$css_files = '';
 		foreach(self::$files as $path)
 		{
 			foreach(self::resolve_css_includes($path) as $path)
 			{
 				list($file,$query) = explode('?',$path,2);
-				if (($mod = filemtime(EGW_SERVER_ROOT.$file)) > $max_modified) $max_modified = $mod;
+				if (($mod = filemtime(EGW_SERVER_ROOT.$file)) > $max_modified)
+				{
+					$max_modified = $mod;
+				}
 
 				// do NOT include app.css or categories.php, as it changes from app to app
 				//no more dynamic minifying: if ($debug_minify || substr($path, -8) == '/app.css' || substr($file,-14) == 'categories.php')

api/src/Framework/About.php

Braces +53 added lines, -21 removed lines

@@ -168,7 +168,11 @@ 
 				}
 			}
 		}
-		if (!isset($setup_info[$app]) || !is_array($setup_info[$app])) return null;	// app got eg. removed in filesystem
+		if (!isset($setup_info[$app]) || !is_array($setup_info[$app]))
+		{
+			return null;
+		}
+		// app got eg. removed in filesystem
 
 		$app_info  = array_merge($GLOBALS['egw_info']['apps'][$app], $setup_info[$app]);
 
@@ -191,7 +195,10 @@ 
 		{
 			$ret['author'] = $this->_getHtmlPersonalInfo($setup_info[$app], 'author');
 			$ret['maintainer'] = $this->_getHtmlPersonalInfo($setup_info[$app], 'maintainer');
-			if ($app_info['version'] != $setup_info[$app]['version']) $ret['version'] .= ' ('.$setup_info[$app]['version'].')';
+			if ($app_info['version'] != $setup_info[$app]['version'])
+			{
+				$ret['version'] .= ' ('.$setup_info[$app]['version'].')';
+			}
 			$ret['license'] = $setup_info[$app]['license'];
 			$ret['description'] = $setup_info[$app]['description'];
 			$ret['note'] = $setup_info[$app]['note'];
@@ -216,39 +223,54 @@ 
 	{
 		$authors = array();
 			// get the author(s)
-			if ($setup_info[$f]) {
+			if ($setup_info[$f])
+			{
 				// author is set
-				if (!is_array($setup_info[$f])) {
+				if (!is_array($setup_info[$f]))
+				{
 					// author is no array
 					$authors[0]['name'] = $setup_info[$f];
-					if ($setup_info[$f.'_email']) {
+					if ($setup_info[$f.'_email'])
+					{
 						$authors[0]['email'] = $setup_info[$f.'_email'];
 					}
-					if ($setup_info[$f.'_url']) {
+					if ($setup_info[$f.'_url'])
+					{
 						$authors[0]['url'] = $setup_info[$f.'_url'];
 					}
 
-				} else {
+				}
+				else
+				{
 					// author is array
-					if ($setup_info[$f]['name']) {
+					if ($setup_info[$f]['name'])
+					{
 						// only one author
 						$authors[0]['name'] = $setup_info[$f]['name'];
-						if ($setup_info[$f]['email']) {
+						if ($setup_info[$f]['email'])
+						{
 							$authors[0]['email'] = $setup_info[$f]['email'];
 						}
-						if ($setup_info[$f]['url']) {
+						if ($setup_info[$f]['url'])
+						{
 							$authors[0]['url'] = $setup_info[$f]['url'];
 						}
-					} else {
+					}
+					else
+					{
 						// may be more authors
-						foreach (array_keys($setup_info[$f]) as $number) {
-							if ($setup_info[$f][$number]['name']) {
+						foreach (array_keys($setup_info[$f]) as $number)
+						{
+							if ($setup_info[$f][$number]['name'])
+							{
 									$authors[$number]['name'] = $setup_info[$f][$number]['name'];
 							}
-							if ($setup_info[$f][$number]['email']) {
+							if ($setup_info[$f][$number]['email'])
+							{
 									$authors[$number]['email'] = $setup_info[$f][$number]['email'];
 							}
-							if ($setup_info[$f][$number]['url']) {
+							if ($setup_info[$f][$number]['url'])
+							{
 									$authors[$number]['url'] = $setup_info[$f][$number]['url'];
 							}
 						}
@@ -258,15 +280,19 @@ 
 
 		// html format authors
 		$s = '';
-		foreach ($authors as $author) {
-			if ($s != '') {
+		foreach ($authors as $author)
+		{
+			if ($s != '')
+			{
 					$s .= '<br />';
 			}
 			$s .= lang('name').': '.$author['name'];
-			if ($author['email']) {
+			if ($author['email'])
+			{
 					$s .= '<br />'.lang('email').': <a href="mailto:'.$author['email'].'">'.$author['email'].'</a>';
 			}
-			if ($author['url']) {
+			if ($author['url'])
+			{
 					$s .= '<br />'.lang('url').': <a href="'.$author['url'].'" target="_blank">'.$author['url'].'</a>';
 			}
 		}
@@ -300,8 +326,14 @@ 
 
 		if (isset(self::$knownLicenses[strtoupper($name)]))
 		{
-			if (empty($url)) $url = self::$knownLicenses[$name=strtoupper($name)][0];
-			if (empty($title)) $title = self::$knownLicenses[$name=strtoupper($name)][1];
+			if (empty($url))
+			{
+				$url = self::$knownLicenses[$name=strtoupper($name)][0];
+			}
+			if (empty($title))
+			{
+				$title = self::$knownLicenses[$name=strtoupper($name)][1];
+			}
 		}
 
 		return array(

api/src/Framework/Bundle.php

Braces +22 added lines, -5 removed lines

@@ -74,7 +74,11 @@ 
 		$query = null;
 		foreach($js_includes as $file)
 		{
-			if ($file == '/api/js/jsapi/egw.js') continue;	// loaded via own tag, and we must not load it twice!
+			if ($file == '/api/js/jsapi/egw.js')
+			{
+				continue;
+			}
+			// loaded via own tag, and we must not load it twice!
 
 			if (!isset($to_include[$file]))
 			{
@@ -133,17 +137,27 @@ 
 	{
 		$debug_minify = $GLOBALS['egw_info']['server']['debug_minify'] === 'True';
 		// ignore not existing minurl
-		if (!empty($minurl) && !file_exists(EGW_SERVER_ROOT.$minurl)) $minurl = null;
+		if (!empty($minurl) && !file_exists(EGW_SERVER_ROOT.$minurl))
+		{
+			$minurl = null;
+		}
 		$to_include_first = $to_include = $to_minify = array();
 		$max_modified = 0;
 		$query = null;
 		foreach($js_includes as $path)
 		{
-			if ($path == '/api/js/jsapi/egw.js') continue; // Leave egw.js out of bundle
+			if ($path == '/api/js/jsapi/egw.js')
+			{
+				continue;
+			}
+			// Leave egw.js out of bundle
 			unset($query);
 			list($path,$query) = explode('?',$path,2);
 			$mod = filemtime(EGW_SERVER_ROOT.$path);
-			if ($mod > $max_modified) $max_modified = $mod;
+			if ($mod > $max_modified)
+			{
+				$max_modified = $mod;
+			}
 
 			// ckeditor must be included before bundled files, as they depend on it!
 			if (strpos($path,'/ckeditor/ckeditor.js') !== false)
@@ -182,7 +196,10 @@ 
 			// need to include minified javascript before not minified stuff like jscalendar-setup, as it might depend on it
 			array_unshift($to_include, $path);
 		}
-		if ($to_include_first) $to_include = array_merge($to_include_first, $to_include);
+		if ($to_include_first)
+		{
+			$to_include = array_merge($to_include_first, $to_include);
+		}
 		//error_log(__METHOD__."("./*array2string($js_includes).*/", $max_modified, $minurl) returning ".array2string($to_include));
 		return $to_include;
 	}

api/src/Framework/Extra.php

Braces +4 added lines, -1 removed lines

@@ -164,9 +164,12 @@
 	{
 		// adding links of refreshed entry, to give others apps more information about necessity to refresh
 		if (isset(self::$extra['refresh-opener']) && count(self::$extra['refresh-opener']) <= 8 &&	// do not run twice
-			!empty(self::$extra['refresh-opener'][1]) && !empty(self::$extra['refresh-opener'][2]))	// app/id given
+			!empty(self::$extra['refresh-opener'][1]) && !empty(self::$extra['refresh-opener'][2]))
+		{
+			// app/id given
 		{
 			$links = Link::get_links(self::$extra['refresh-opener'][1], self::$extra['refresh-opener'][2]);
+		}
 			$apps = array();
 			foreach($links as $link)
 			{

api/src/Framework/Minimal.php

Braces +9 added lines, -2 removed lines

@@ -47,7 +47,10 @@ 
 	function header(array $extra=array())
 	{
 		// make sure header is output only once
-		if (self::$header_done) return '';
+		if (self::$header_done)
+		{
+			return '';
+		}
 		self::$header_done = true;
 
 		// js stuff is not needed by login page or in popups
@@ -135,7 +138,11 @@ 
 	function footer()
 	{
 		static $footer_done=0;
-		if ($footer_done++) return;	// prevent multiple footers, not sure we still need this (RalfBecker)
+		if ($footer_done++)
+		{
+			return;
+		}
+		// prevent multiple footers, not sure we still need this (RalfBecker)
 
 		return "</body>\n</html>\n";	// close body and html tag, eg. for popups
 	}

api/src/autoload.php

Braces +9 added lines, -2 removed lines

@@ -37,7 +37,11 @@ 
 spl_autoload_register(function($class)
 {
 	$parts = explode('\\', $class);
-	if (array_shift($parts) != 'EGroupware') return;	// not our prefix
+	if (array_shift($parts) != 'EGroupware')
+	{
+		return;
+	}
+	// not our prefix
 
 	$app = lcfirst(array_shift($parts));
 	$base = EGW_INCLUDE_ROOT.'/'.$app.'/src/';
@@ -63,7 +67,10 @@ 
 spl_autoload_register(function($class)
 {
 	// fixing warnings generated by php 5.3.8 is_a($obj) trying to autoload huge strings
-	if (strlen($class) > 64 || strpos($class, '.') !== false) return;
+	if (strlen($class) > 64 || strpos($class, '.') !== false)
+	{
+		return;
+	}
 
 	$components = explode('_',$class);
 	$app = array_shift($components);

api/src/Ldap/ServerInfo.php

Braces +2 added lines, -1 removed lines

@@ -218,7 +218,8 @@
 					{
 						if(($info = ldap_get_entries($ds, $sr)))
 						{
-							if($info[0]['objectclasses']) {
+							if($info[0]['objectclasses'])
+							{
 								for($i=0; $i<$info[0]['objectclasses']['count']; $i++)
 								{
 									$matches = null;

api/src/Json/Exception/InvalidName.php

Braces +3 added lines, -1 removed lines

@@ -20,4 +20,6 @@
  *
  * As you get this only by an error in the code or during development, the message does not need to be translated
  */
-class InvalidName extends Exception\NoPermission { }
+class InvalidName extends Exception\NoPermission
+{
+}

api/src/Json/Request.php

Braces +16 added lines, -4 removed lines

@@ -42,7 +42,10 @@ 
 	public static function isJSONRequest($set=null)
 	{
 		$ret = self::$_hadJSONRequest;
-		if (isset($set)) self::$_hadJSONRequest = $set;
+		if (isset($set))
+		{
+			self::$_hadJSONRequest = $set;
+		}
 		return $ret;
 	}
 
@@ -60,7 +63,10 @@ 
 		// Remember that we currently are in a JSON request - e.g. used in the redirect code
 		self::$_hadJSONRequest = true;
 
-		if (get_magic_quotes_gpc()) $input_data = stripslashes($input_data);
+		if (get_magic_quotes_gpc())
+		{
+			$input_data = stripslashes($input_data);
+		}
 
 		$json_data = json_decode($input_data,true);
 		if (is_array($json_data) && isset($json_data['request']) && isset($json_data['request']['parameters']) && is_array($json_data['request']['parameters']))
@@ -100,9 +106,12 @@ 
 	 */
 	public function handleRequest($menuaction, array $parameters)
 	{
-		if (strpos($menuaction,'::') !== false && strpos($menuaction,'.') === false)	// static method name app_something::method
+		if (strpos($menuaction,'::') !== false && strpos($menuaction,'.') === false)
+		{
+			// static method name app_something::method
 		{
 			@list($className,$functionName,$handler) = explode('::',$menuaction);
+		}
 			if (substr($className, 0, 11) == 'EGroupware\\')
 			{
 				list(,$appName) = explode('\\', strtolower($className));
@@ -179,6 +188,9 @@ 
 			Api\Translation::convert($parameters, 'utf-8'));
 
 		// check if we have push notifications, if notifications app available
-		if (class_exists('notifications_push')) notifications_push::get();
+		if (class_exists('notifications_push'))
+		{
+			notifications_push::get();
+		}
 	}
 }