View GitHub Repository ec-cube

Schedule Inspection
Subscribe
Completed
Pull Request — experimental/3.1 (#2431)
by chihiro
106:09
created
Status
Category
Toggle Patches
src/Eccube/Service/PurchaseFlow/ItemCollection.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch 
@@ -31,7 +31,7 @@  discard block
 
 block discarded – undo
31 31 
     public function getProductClasses()
32 32 
     {
33 33 
         return $this->filter(
34 
-            function (ItemInterface $ShipmentItem) {
34 
+            function(ItemInterface $ShipmentItem) {
35 35 
                 return $ShipmentItem->isProduct();
36 36 
             });
37 37 
     }
 
@@ -39,7 +39,7 @@  discard block
 
 block discarded – undo
39 39 
     public function getDeliveryFees()
40 40 
     {
41 41 
         return $this->filter(
42 
-            function (ItemInterface $ShipmentItem) {
42 
+            function(ItemInterface $ShipmentItem) {
43 43 
                 return $ShipmentItem->isDeliveryFee();
44 44 
             });
45 45 
     }
 
@@ -47,7 +47,7 @@  discard block
 
 block discarded – undo
47 47 
     public function getCharges()
48 48 
     {
49 49 
         return $this->filter(
50 
-            function (ItemInterface $ShipmentItem) {
50 
+            function(ItemInterface $ShipmentItem) {
51 51 
                 return $ShipmentItem->isCharge();
52 52 
             });
53 53 
     }
 
@@ -55,7 +55,7 @@  discard block
 
 block discarded – undo
55 55 
     public function getDiscounts()
56 56 
     {
57 57 
         return $this->filter(
58 
-            function (ItemInterface $ShipmentItem) {
58 
+            function(ItemInterface $ShipmentItem) {
59 59 
                 return $ShipmentItem->isDiscount();
60 60 
             });
61 61 
     }
 
@@ -68,7 +68,7 @@  discard block
 
 block discarded – undo
68 68 
     public function hasProductByName($productName)
69 69 
     {
70 70 
         $ShipmentItems = $this->filter(
71 
-            function (ItemInterface $ShipmentItem) use ($productName) {
71 
+            function(ItemInterface $ShipmentItem) use ($productName) {
72 72 
                 /* @var ShipmentItem $ShipmentItem */
73 73 
                 return $ShipmentItem->getProductName() == $productName;
74 74 
             });
 
@@ -85,7 +85,7 @@  discard block
 
 block discarded – undo
85 85 
      */
86 86 
     public function hasItemByOrderItemType($OrderItemType)
87 87 
     {
88 
-        $filteredItems = $this->filter(function (ItemInterface $ShipmentItem) use ($OrderItemType) {
88 
+        $filteredItems = $this->filter(function(ItemInterface $ShipmentItem) use ($OrderItemType) {
89 89 
             /* @var ShipmentItem $ShipmentItem */
90 90 
             return $ShipmentItem->getOrderItemType() && $ShipmentItem->getOrderItemType()->getId() == $OrderItemType->getId();
91 91 
         });
 
@@ -101,7 +101,7 @@  discard block
 
 block discarded – undo
101 101 
     public function sort()
102 102 
     {
103 103 
         $Items = $this->toArray();
104 
-        usort($Items, function (ItemInterface $a, ItemInterface $b) {
104 
+        usort($Items, function(ItemInterface $a, ItemInterface $b) {
105 105 
             if ($a->getOrderItemType() === $b->getOrderItemType()) {
106 106 
                 return ($a->getId() < $b->getId()) ? -1 : 1;
107 107 
             } elseif ($a->isProduct()) {
Please login to merge, or discard this patch.
src/Eccube/Service/PurchaseFlow/PurchaseFlowResult.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -53,7 +53,7 @@  discard block
 
 block discarded – undo
53 53 
      */
54 54 
     public function getErrors()
55 55 
     {
56 
-        return array_filter($this->processResults, function (ProcessResult $processResult) {
56 
+        return array_filter($this->processResults, function(ProcessResult $processResult) {
57 57 
             return $processResult->isError();
58 58 
         });
59 59 
     }
 
@@ -63,7 +63,7 @@  discard block
 
 block discarded – undo
63 63 
      */
64 64 
     public function getWarning()
65 65 
     {
66 
-        return array_filter($this->processResults, function (ProcessResult $processResult) {
66 
+        return array_filter($this->processResults, function(ProcessResult $processResult) {
67 67 
             return $processResult->isWarning();
68 68 
         });
69 69 
     }
Please login to merge, or discard this patch.
src/Eccube/Form/Type/PriceType.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -65,7 +65,7 @@
 
 block discarded – undo
65 65 
      */
66 66 
     public function configureOptions(OptionsResolver $resolver)
67 67 
     {
68 
-        $constraints = function (Options $options) {
68 
+        $constraints = function(Options $options) {
69 69 
             $constraints = [];
70 70
71 71 
             // requiredがtrueに指定されている場合, NotBlankを追加
Please login to merge, or discard this patch.