Inspection of "Daily Inspection: Close TODO" - Dolibarr/dolibarr - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop (aac48b)

unknown

created 2025-11-22 16:35 UTC

Status

Braces +6 added lines, -2 removed lines patch added patch discarded remove patch

@@ -71,9 +71,13 @@
 block discarded – undo
 	{
 		$moreCss = $this->getInputCss($fieldInfos, $moreCss);
 		$moreAttrib = trim((string) $moreAttrib);
-		if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
+		if (empty($moreAttrib)) {
+			$moreAttrib = ' ' . $moreAttrib;
+		}
 		$placeHolder = $fieldInfos->inputPlaceholder;
-		if (!empty($placeHolder)) $placeHolder = ' placeholder="' . dolPrintHTMLForAttribute($placeHolder) . '"';
+		if (!empty($placeHolder)) {
+			$placeHolder = ' placeholder="' . dolPrintHTMLForAttribute($placeHolder) . '"';
+		}
 		$autoFocus = $fieldInfos->inputAutofocus ? ' autofocus' : '';
 		$htmlName = $keyPrefix . $key . $keySuffix;
 

Please login to merge, or discard this patch.

htdocs/core/class/fields/checkboxfield.class.php 1 patch

Braces +6 added lines, -2 removed lines patch added patch discarded remove patch

@@ -70,7 +70,9 @@  discard block
 block discarded – undo
 
 		$moreCss = $this->getInputCss($fieldInfos, $moreCss);
 		$moreAttrib = trim((string) $moreAttrib);
-		if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
+		if (empty($moreAttrib)) {
+			$moreAttrib = ' ' . $moreAttrib;
+		}
 		$htmlName = $keyPrefix . $key . $keySuffix;
 		$values = $this->isEmptyValue($fieldInfos, $value) ? array() : (is_string($value) ? explode(',', $value) : (is_array($value) ? $value: array($value)));
 
@@ -201,7 +203,9 @@  discard block
 block discarded – undo
 
 		if (GETPOSTISSET($htmlName)) {
 			$values = GETPOST($htmlName, 'array');
-			if (is_array($values)) $values = implode(',', $values);
+			if (is_array($values)) {
+				$values = implode(',', $values);
+			}
 		} else {
 			$values = $defaultValue;
 		}

Please login to merge, or discard this patch.

htdocs/core/class/fields/chkbxlstfield.class.php 1 patch

Braces +9 added lines, -3 removed lines patch added patch discarded remove patch

@@ -53,7 +53,9 @@  discard block
 block discarded – undo
 
 		$moreCss = $this->getInputCss($fieldInfos, $moreCss);
 		$moreAttrib = trim((string) $moreAttrib);
-		if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
+		if (empty($moreAttrib)) {
+			$moreAttrib = ' ' . $moreAttrib;
+		}
 		$htmlName = $keyPrefix . $key . $keySuffix;
 		$values = $this->isEmptyValue($fieldInfos, $value) ? array() : (is_string($value) ? explode(',', $value) : (is_array($value) ? $value: array($value)));
 
@@ -84,7 +86,9 @@  discard block
 block discarded – undo
 
 		$moreCss = $this->getInputCss($fieldInfos, $moreCss);
 		$moreAttrib = trim((string) $moreAttrib);
-		if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
+		if (empty($moreAttrib)) {
+			$moreAttrib = ' ' . $moreAttrib;
+		}
 		$htmlName = $keyPrefix . $key . $keySuffix;
 		$values = $this->isEmptyValue($fieldInfos, $value) ? array() : (is_string($value) ? explode(',', $value) : (is_array($value) ? $value: array($value)));
 
@@ -217,7 +221,9 @@  discard block
 block discarded – undo
 
 		if (GETPOSTISSET($htmlName)) {
 			$values = GETPOST($htmlName, 'array');
-			if (is_array($values)) $values = implode(',', $values);
+			if (is_array($values)) {
+				$values = implode(',', $values);
+			}
 		} else {
 			$values = $defaultValue;
 		}

Please login to merge, or discard this patch.

htdocs/public/webportal/tpl/card-edit-properties.tpl.php 1 patch

Braces +6 added lines, -2 removed lines patch added patch discarded remove patch

@@ -56,9 +56,13 @@
 block discarded – undo
 		}
 
 		$label_class = 'labelfield fieldname_' . $fieldKey; // titlefieldcreate
-		if (!empty($fieldInfos->tdCss)) $label_class .= $fieldInfos->tdCss;
+		if (!empty($fieldInfos->tdCss)) {
+			$label_class .= $fieldInfos->tdCss;
+		}
 		$value_class = 'valuefield fieldname_' . $fieldKey; // valuefieldcreate
-		if (!empty($fieldInfos->viewCss)) $value_class .= $fieldInfos->viewCss;
+		if (!empty($fieldInfos->viewCss)) {
+			$value_class .= $fieldInfos->viewCss;
+		}
 
 		$label = is_string($fieldInfos->label) ? $langs->trans($fieldInfos->label) : $fieldInfos->label;
 		print $formCard->form->printFieldCell($fieldKey, $label, $input, [

Please login to merge, or discard this patch.

htdocs/public/webportal/tpl/card-view-properties.tpl.php 1 patch

Braces +6 added lines, -2 removed lines patch added patch discarded remove patch

@@ -63,9 +63,13 @@
 block discarded – undo
 					}
 
 					$label_class = 'labelfield fieldname_' . $fieldKey;
-					if (!empty($fieldInfos->tdCss)) $label_class .= $fieldInfos->tdCss;
+					if (!empty($fieldInfos->tdCss)) {
+						$label_class .= $fieldInfos->tdCss;
+					}
 					$value_class = 'valuefield fieldname_' . $fieldKey;
-					if (!empty($fieldInfos->viewCss)) $value_class .= $fieldInfos->viewCss;
+					if (!empty($fieldInfos->viewCss)) {
+						$value_class .= $fieldInfos->viewCss;
+					}
 
 					$label = is_string($fieldInfos->label) ? $langs->trans($fieldInfos->label) : $fieldInfos->label;
 					print $formCard->form->printFieldCell($fieldKey, '<strong>' . $label . '</strong>', $input, [

Please login to merge, or discard this patch.

htdocs/core/class/fields/phonefield.class.php 1 patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -71,7 +71,9 @@
 block discarded – undo
 	{
 		$moreCss = $this->getInputCss($fieldInfos, $moreCss);
 		$moreAttrib = trim((string) $moreAttrib);
-		if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
+		if (empty($moreAttrib)) {
+			$moreAttrib = ' ' . $moreAttrib;
+		}
 		$autoFocus = $fieldInfos->inputAutofocus ? ' autofocus' : '';
 		$htmlName = $keyPrefix . $key . $keySuffix;
 

Please login to merge, or discard this patch.

htdocs/core/class/fields/ipfield.class.php 1 patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -71,7 +71,9 @@
 block discarded – undo
 	{
 		$moreCss = $this->getInputCss($fieldInfos, $moreCss);
 		$moreAttrib = trim((string) $moreAttrib);
-		if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
+		if (empty($moreAttrib)) {
+			$moreAttrib = ' ' . $moreAttrib;
+		}
 		$autoFocus = $fieldInfos->inputAutofocus ? ' autofocus' : '';
 		$htmlName = $keyPrefix . $key . $keySuffix;
 

Please login to merge, or discard this patch.

htdocs/core/class/fields/urlfield.class.php 1 patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -71,7 +71,9 @@
 block discarded – undo
 	{
 		$moreCss = $this->getInputCss($fieldInfos, $moreCss);
 		$moreAttrib = trim((string) $moreAttrib);
-		if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
+		if (empty($moreAttrib)) {
+			$moreAttrib = ' ' . $moreAttrib;
+		}
 		$autoFocus = $fieldInfos->inputAutofocus ? ' autofocus' : '';
 		$htmlName = $keyPrefix . $key . $keySuffix;
 

Please login to merge, or discard this patch.

htdocs/core/class/fields/passwordfield.class.php 1 patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -71,7 +71,9 @@
 block discarded – undo
 	{
 		$moreCss = $this->getInputCss($fieldInfos, $moreCss);
 		$moreAttrib = trim((string) $moreAttrib);
-		if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
+		if (empty($moreAttrib)) {
+			$moreAttrib = ' ' . $moreAttrib;
+		}
 		$autoFocus = $fieldInfos->inputAutofocus ? ' autofocus' : '';
 		$htmlName = $keyPrefix . $key . $keySuffix;
 

Please login to merge, or discard this patch.

		@@ -71,9 +71,13 @@
		block discarded – undo
71	71	{
72	72	$moreCss = $this->getInputCss($fieldInfos, $moreCss);
73	73	$moreAttrib = trim((string) $moreAttrib);
74		- if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
	74	+ if (empty($moreAttrib)) {
	75	+ $moreAttrib = ' ' . $moreAttrib;
	76	+ }
75	77	$placeHolder = $fieldInfos->inputPlaceholder;
76		- if (!empty($placeHolder)) $placeHolder = ' placeholder="' . dolPrintHTMLForAttribute($placeHolder) . '"';
	78	+ if (!empty($placeHolder)) {
	79	+ $placeHolder = ' placeholder="' . dolPrintHTMLForAttribute($placeHolder) . '"';
	80	+ }
77	81	$autoFocus = $fieldInfos->inputAutofocus ? ' autofocus' : '';
78	82	$htmlName = $keyPrefix . $key . $keySuffix;
79	83

		@@ -71,7 +71,9 @@
		block discarded – undo
71	71	{
72	72	$moreCss = $this->getInputCss($fieldInfos, $moreCss);
73	73	$moreAttrib = trim((string) $moreAttrib);
74		- if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
	74	+ if (empty($moreAttrib)) {
	75	+ $moreAttrib = ' ' . $moreAttrib;
	76	+ }
75	77	$autoFocus = $fieldInfos->inputAutofocus ? ' autofocus' : '';
76	78	$htmlName = $keyPrefix . $key . $keySuffix;
77	79

		@@ -71,7 +71,9 @@
		block discarded – undo
71	71	{
72	72	$moreCss = $this->getInputCss($fieldInfos, $moreCss);
73	73	$moreAttrib = trim((string) $moreAttrib);
74		- if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
	74	+ if (empty($moreAttrib)) {
	75	+ $moreAttrib = ' ' . $moreAttrib;
	76	+ }
75	77	$autoFocus = $fieldInfos->inputAutofocus ? ' autofocus' : '';
76	78	$htmlName = $keyPrefix . $key . $keySuffix;
77	79

		@@ -71,7 +71,9 @@
		block discarded – undo
71	71	{
72	72	$moreCss = $this->getInputCss($fieldInfos, $moreCss);
73	73	$moreAttrib = trim((string) $moreAttrib);
74		- if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
	74	+ if (empty($moreAttrib)) {
	75	+ $moreAttrib = ' ' . $moreAttrib;
	76	+ }
75	77	$autoFocus = $fieldInfos->inputAutofocus ? ' autofocus' : '';
76	78	$htmlName = $keyPrefix . $key . $keySuffix;
77	79

		@@ -71,7 +71,9 @@
		block discarded – undo
71	71	{
72	72	$moreCss = $this->getInputCss($fieldInfos, $moreCss);
73	73	$moreAttrib = trim((string) $moreAttrib);
74		- if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
	74	+ if (empty($moreAttrib)) {
	75	+ $moreAttrib = ' ' . $moreAttrib;
	76	+ }
75	77	$autoFocus = $fieldInfos->inputAutofocus ? ' autofocus' : '';
76	78	$htmlName = $keyPrefix . $key . $keySuffix;
77	79

		@@ -70,7 +70,9 @@ discard block
		block discarded – undo
70	70
71	71	$moreCss = $this->getInputCss($fieldInfos, $moreCss);
72	72	$moreAttrib = trim((string) $moreAttrib);
73		- if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
	73	+ if (empty($moreAttrib)) {
	74	+ $moreAttrib = ' ' . $moreAttrib;
	75	+ }
74	76	$htmlName = $keyPrefix . $key . $keySuffix;
75	77	$values = $this->isEmptyValue($fieldInfos, $value) ? array() : (is_string($value) ? explode(',', $value) : (is_array($value) ? $value: array($value)));
76	78
		@@ -201,7 +203,9 @@ discard block
		block discarded – undo
201	203
202	204	if (GETPOSTISSET($htmlName)) {
203	205	$values = GETPOST($htmlName, 'array');
204		- if (is_array($values)) $values = implode(',', $values);
	206	+ if (is_array($values)) {
	207	+ $values = implode(',', $values);
	208	+ }
205	209	} else {
206	210	$values = $defaultValue;
207	211	}

		@@ -53,7 +53,9 @@ discard block
		block discarded – undo
53	53
54	54	$moreCss = $this->getInputCss($fieldInfos, $moreCss);
55	55	$moreAttrib = trim((string) $moreAttrib);
56		- if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
	56	+ if (empty($moreAttrib)) {
	57	+ $moreAttrib = ' ' . $moreAttrib;
	58	+ }
57	59	$htmlName = $keyPrefix . $key . $keySuffix;
58	60	$values = $this->isEmptyValue($fieldInfos, $value) ? array() : (is_string($value) ? explode(',', $value) : (is_array($value) ? $value: array($value)));
59	61
		@@ -84,7 +86,9 @@ discard block
		block discarded – undo
84	86
85	87	$moreCss = $this->getInputCss($fieldInfos, $moreCss);
86	88	$moreAttrib = trim((string) $moreAttrib);
87		- if (empty($moreAttrib)) $moreAttrib = ' ' . $moreAttrib;
	89	+ if (empty($moreAttrib)) {
	90	+ $moreAttrib = ' ' . $moreAttrib;
	91	+ }
88	92	$htmlName = $keyPrefix . $key . $keySuffix;
89	93	$values = $this->isEmptyValue($fieldInfos, $value) ? array() : (is_string($value) ? explode(',', $value) : (is_array($value) ? $value: array($value)));
90	94
		@@ -217,7 +221,9 @@ discard block
		block discarded – undo
217	221
218	222	if (GETPOSTISSET($htmlName)) {
219	223	$values = GETPOST($htmlName, 'array');
220		- if (is_array($values)) $values = implode(',', $values);
	224	+ if (is_array($values)) {
	225	+ $values = implode(',', $values);
	226	+ }
221	227	} else {
222	228	$values = $defaultValue;
223	229	}

		@@ -56,9 +56,13 @@
		block discarded – undo
56	56	}
57	57
58	58	$label_class = 'labelfield fieldname_' . $fieldKey; // titlefieldcreate
59		- if (!empty($fieldInfos->tdCss)) $label_class .= $fieldInfos->tdCss;
	59	+ if (!empty($fieldInfos->tdCss)) {
	60	+ $label_class .= $fieldInfos->tdCss;
	61	+ }
60	62	$value_class = 'valuefield fieldname_' . $fieldKey; // valuefieldcreate
61		- if (!empty($fieldInfos->viewCss)) $value_class .= $fieldInfos->viewCss;
	63	+ if (!empty($fieldInfos->viewCss)) {
	64	+ $value_class .= $fieldInfos->viewCss;
	65	+ }
62	66
63	67	$label = is_string($fieldInfos->label) ? $langs->trans($fieldInfos->label) : $fieldInfos->label;
64	68	print $formCard->form->printFieldCell($fieldKey, $label, $input, [

		@@ -63,9 +63,13 @@
		block discarded – undo
63	63	}
64	64
65	65	$label_class = 'labelfield fieldname_' . $fieldKey;
66		- if (!empty($fieldInfos->tdCss)) $label_class .= $fieldInfos->tdCss;
	66	+ if (!empty($fieldInfos->tdCss)) {
	67	+ $label_class .= $fieldInfos->tdCss;
	68	+ }
67	69	$value_class = 'valuefield fieldname_' . $fieldKey;
68		- if (!empty($fieldInfos->viewCss)) $value_class .= $fieldInfos->viewCss;
	70	+ if (!empty($fieldInfos->viewCss)) {
	71	+ $value_class .= $fieldInfos->viewCss;
	72	+ }
69	73
70	74	$label = is_string($fieldInfos->label) ? $langs->trans($fieldInfos->label) : $fieldInfos->label;
71	75	print $formCard->form->printFieldCell($fieldKey, '<strong>' . $label . '</strong>', $input, [

Dolibarr / dolibarr

Branch — develop (aac48b)

Status

Category

Braces +6 added lines, -2 removed lines patch added patch discarded remove patch

Braces +6 added lines, -2 removed lines patch added patch discarded remove patch

Braces +9 added lines, -3 removed lines patch added patch discarded remove patch

Braces +6 added lines, -2 removed lines patch added patch discarded remove patch

Braces +6 added lines, -2 removed lines patch added patch discarded remove patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch