Passed
Push — master ( e4a382...56087c )
by Daimona
01:45
created
includes/TaskManager.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme;
4 4
 
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 	 * @param string|null $name Only used in MODE_TASK and MODE_SUBTASK
53 53
 	 * @return TaskResult
54 54
 	 */
55
-	public function run( string $mode, string $name = null ) : TaskResult {
55
+	public function run ( string $mode, string $name = null ) : TaskResult {
56 56
 		$this->provider = new TaskDataProvider;
57 57
 
58 58
 		if ( $mode === self::MODE_COMPLETE ) {
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 	 *
70 70
 	 * @return TaskResult
71 71
 	 */
72
-	protected function runAllTasks() : TaskResult {
72
+	protected function runAllTasks () : TaskResult {
73 73
 		$orderedList = [
74 74
 			'update-list',
75 75
 			'start-new',
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 	 * @param string $name
92 92
 	 * @return TaskResult
93 93
 	 */
94
-	protected function runTask( string $name ) : TaskResult {
94
+	protected function runTask ( string $name ) : TaskResult {
95 95
 		if ( !isset( self::TASKS_MAP[ $name ] ) ) {
96 96
 			throw new \InvalidArgumentException( "'$name' is not a valid task." );
97 97
 		}
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
 	 * @param string $name
107 107
 	 * @return TaskResult
108 108
 	 */
109
-	protected function runSubtask( string $name ) : TaskResult {
109
+	protected function runSubtask ( string $name ) : TaskResult {
110 110
 		if ( !isset( self::SUBTASKS_MAP[ $name ] ) ) {
111 111
 			throw new \InvalidArgumentException( "'$name' is not a valid subtask." );
112 112
 		}
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
 	 * @param string $class
122 122
 	 * @return Task
123 123
 	 */
124
-	private function getTaskInstance( string $class ) : Task {
124
+	private function getTaskInstance ( string $class ) : Task {
125 125
 		return new $class( $this->provider );
126 126
 	}
127 127
 
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
 	 * @param string $class
132 132
 	 * @return Subtask
133 133
 	 */
134
-	private function getSubtaskInstance( string $class ) : Subtask {
134
+	private function getSubtaskInstance ( string $class ) : Subtask {
135 135
 		return new $class( $this->provider );
136 136
 	}
137 137
 }
Please login to merge, or discard this patch.
includes/Wiki/Page/PageBotList.php 1 patch
Spacing   +11 added lines, -13 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Wiki\Page;
4 4
 
@@ -11,7 +11,7 @@  discard block
 block discarded – undo
11 11
 	/**
12 12
 	 * @private Use self::get()
13 13
 	 */
14
-	public function __construct() {
14
+	public function __construct () {
15 15
 		parent::__construct( Config::getInstance()->get( 'list-title' ) );
16 16
 	}
17 17
 
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
 	 *
21 21
 	 * @return self
22 22
 	 */
23
-	public static function get() : self {
23
+	public static function get () : self {
24 24
 		static $instance = null;
25 25
 		if ( $instance === null ) {
26 26
 			$instance = new self;
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 	 * @param string[] $groups
33 33
 	 * @return int|null
34 34
 	 */
35
-	public static function getOverrideTimestamp( array $groups ) : ?int {
35
+	public static function getOverrideTimestamp ( array $groups ) : ?int {
36 36
 		if ( array_intersect_key( $groups, [ 'override-perm' => true, 'override' => true ] ) ) {
37 37
 			// A one-time override takes precedence
38 38
 			$date = $groups[ 'override' ] ?? $groups[ 'override-perm' ];
@@ -47,17 +47,15 @@  discard block
 block discarded – undo
47 47
 	 * @param array $groups
48 48
 	 * @return int
49 49
 	 */
50
-	public static function getValidFlagTimestamp( array $groups ): int {
51
-		$checkuser = isset( $groups['checkuser'] ) ?
52
-			\DateTime::createFromFormat( 'd/m/Y', $groups['checkuser'] )->getTimestamp() :
53
-			0;
54
-		$bureaucrat = isset( $groups['bureaucrat'] ) ?
55
-			\DateTime::createFromFormat( 'd/m/Y', $groups['bureaucrat'] )->getTimestamp() :
56
-			0;
50
+	public static function getValidFlagTimestamp ( array $groups ): int {
51
+		$checkuser = isset( $groups[ 'checkuser' ] ) ?
52
+			\DateTime::createFromFormat( 'd/m/Y', $groups[ 'checkuser' ] )->getTimestamp() : 0;
53
+		$bureaucrat = isset( $groups[ 'bureaucrat' ] ) ?
54
+			\DateTime::createFromFormat( 'd/m/Y', $groups[ 'bureaucrat' ] )->getTimestamp() : 0;
57 55
 
58 56
 		$timestamp = max( $bureaucrat, $checkuser );
59 57
 		if ( $timestamp === 0 ) {
60
-			$timestamp = \DateTime::createFromFormat( 'd/m/Y', $groups['sysop'] )->getTimestamp();
58
+			$timestamp = \DateTime::createFromFormat( 'd/m/Y', $groups[ 'sysop' ] )->getTimestamp();
61 59
 		}
62 60
 		return $timestamp;
63 61
 	}
@@ -67,7 +65,7 @@  discard block
 block discarded – undo
67 65
 	 *
68 66
 	 * @return array[]
69 67
 	 */
70
-	public function getAdminsList() : array {
68
+	public function getAdminsList () : array {
71 69
 		return json_decode( $this->getContent(), true );
72 70
 	}
73 71
 }
Please login to merge, or discard this patch.
includes/Wiki/Page/PageRiconferma.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Wiki\Page;
4 4
 
@@ -13,7 +13,7 @@  discard block
 block discarded – undo
13 13
 	private $supportSection = 3;
14 14
 	private $opposeSection = 4;
15 15
 	/** @var array Counts of votes for each section */
16
-	private $sectionCounts = [];
16
+	private $sectionCounts = [ ];
17 17
 
18 18
 	// Possible outcomes of a vote
19 19
 	const OUTCOME_OK = 0;
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 	/**
30 30
 	 * @param string $title
31 31
 	 */
32
-	public function __construct( string $title ) {
32
+	public function __construct ( string $title ) {
33 33
 		parent::__construct( $title );
34 34
 		$this->supportSection = $this->isVote() ? 3 : 0;
35 35
 		$this->opposeSection = $this->isVote() ? 4 : 3;
@@ -40,8 +40,8 @@  discard block
 block discarded – undo
40 40
 	 *
41 41
 	 * @return User
42 42
 	 */
43
-	public function getUser() : User {
44
-		$name = explode( '/', $this->title )[2];
43
+	public function getUser () : User {
44
+		$name = explode( '/', $this->title )[ 2 ];
45 45
 		return new User( $name );
46 46
 	}
47 47
 
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
 	 *
51 51
 	 * @return int
52 52
 	 */
53
-	public function getNum() : int {
53
+	public function getNum () : int {
54 54
 		$bits = explode( '/', $this->getTitle() );
55 55
 		return intval( end( $bits ) );
56 56
 	}
@@ -60,8 +60,8 @@  discard block
 block discarded – undo
60 60
 	 *
61 61
 	 * @return string
62 62
 	 */
63
-	public function getUserNum() : string {
64
-		return explode( '/', $this->getTitle(), 3 )[2];
63
+	public function getUserNum () : string {
64
+		return explode( '/', $this->getTitle(), 3 )[ 2 ];
65 65
 	}
66 66
 
67 67
 	/**
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 	 *
70 70
 	 * @return string
71 71
 	 */
72
-	public function getBaseTitle() : string {
72
+	public function getBaseTitle () : string {
73 73
 		// @phan-suppress-next-line PhanTypeMismatchArgumentInternal Phan bug
74 74
 		return substr( $this->getTitle(), 0, strrpos( $this->getTitle(), '/' ) );
75 75
 	}
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
 	 *
80 80
 	 * @return int
81 81
 	 */
82
-	public function getOpposingCount() : int {
82
+	public function getOpposingCount () : int {
83 83
 		return $this->getCountForSection( $this->opposeSection );
84 84
 	}
85 85
 
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 	 * @return int
90 90
 	 * @throws \BadMethodCallException
91 91
 	 */
92
-	public function getSupportCount() : int {
92
+	public function getSupportCount () : int {
93 93
 		if ( !$this->isVote() ) {
94 94
 			throw new \BadMethodCallException( 'Cannot get support for a non-vote page.' );
95 95
 		}
@@ -102,13 +102,13 @@  discard block
 block discarded – undo
102 102
 	 * @param int $secNum
103 103
 	 * @return int
104 104
 	 */
105
-	protected function getCountForSection( int $secNum ) : int {
105
+	protected function getCountForSection ( int $secNum ) : int {
106 106
 		if ( !isset( $this->sectionCounts[ $secNum ] ) ) {
107 107
 			$content = $this->controller->getPageContent( $this->title, $secNum );
108 108
 			// Let's hope that this is good enough...
109
-			$this->sectionCounts[$secNum] = preg_match_all( "/^\# *(?![# *]|\.\.\.$)/m", $content );
109
+			$this->sectionCounts[ $secNum ] = preg_match_all( "/^\# *(?![# *]|\.\.\.$)/m", $content );
110 110
 		}
111
-		return $this->sectionCounts[$secNum];
111
+		return $this->sectionCounts[ $secNum ];
112 112
 	}
113 113
 
114 114
 	/**
@@ -116,9 +116,9 @@  discard block
 block discarded – undo
116 116
 	 *
117 117
 	 * @return int
118 118
 	 */
119
-	protected function getQuorum() : int {
119
+	protected function getQuorum () : int {
120 120
 		$reg = "!soddisfare il \[\[[^|\]]+\|quorum]] di '''(\d+) voti'''!";
121
-		return intval( $this->getMatch( $reg )[1] );
121
+		return intval( $this->getMatch( $reg )[ 1 ] );
122 122
 	}
123 123
 
124 124
 	/**
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
 	 *
127 127
 	 * @return bool
128 128
 	 */
129
-	public function hasOpposition() : bool {
129
+	public function hasOpposition () : bool {
130 130
 		return $this->getOpposingCount() >= self::REQUIRED_OPPOSE;
131 131
 	}
132 132
 
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
 	 * @return int One of the OUTCOME_* constants
137 137
 	 * @throws \BadMethodCallException
138 138
 	 */
139
-	public function getOutcome() : int {
139
+	public function getOutcome () : int {
140 140
 		if ( !$this->isVote() ) {
141 141
 			throw new \BadMethodCallException( 'Cannot get outcome for a non-vote page.' );
142 142
 		}
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
 	 * @throws \BadMethodCallException
157 157
 	 * @throws \LogicException
158 158
 	 */
159
-	public function getOutcomeText() : string {
159
+	public function getOutcomeText () : string {
160 160
 		if ( !$this->isVote() ) {
161 161
 			throw new \BadMethodCallException( 'No need for an outcome text.' );
162 162
 		}
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
 	 *
191 191
 	 * @return bool
192 192
 	 */
193
-	public function isVote() : bool {
193
+	public function isVote () : bool {
194 194
 		$sectionReg = '/<!-- SEZIONE DA UTILIZZARE PER/';
195 195
 		return !$this->matches( $sectionReg );
196 196
 	}
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
 	 *
201 201
 	 * @return int
202 202
 	 */
203
-	public function getCreationTimestamp() : int {
203
+	public function getCreationTimestamp () : int {
204 204
 		return $this->controller->getPageCreationTS( $this->title );
205 205
 	}
206 206
 	/**
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
 	 *
209 209
 	 * @return int
210 210
 	 */
211
-	public function getEndTimestamp() : int {
211
+	public function getEndTimestamp () : int {
212 212
 		if ( $this->isVote() ) {
213 213
 			$reg = "!La votazione ha inizio il.+ alle ore ([\d:]+) e ha termine il (.+) alla stessa ora!";
214 214
 			list( , $hours, $day ) = $this->getMatch( $reg );
Please login to merge, or discard this patch.
includes/Logger.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme;
4 4
 
@@ -11,7 +11,7 @@  discard block
 block discarded – undo
11 11
 	/**
12 12
 	 * @inheritDoc
13 13
 	 */
14
-	public function log( $level, $message, array $context = [] ) {
14
+	public function log ( $level, $message, array $context = [ ] ) {
15 15
 		printf( "%s [%s] - %s\n", date( 'd M H:i:s' ), $level, $message );
16 16
 	}
17 17
 }
Please login to merge, or discard this patch.
includes/Bot.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme;
4 4
 
@@ -11,7 +11,7 @@  discard block
 block discarded – undo
11 11
 
12 12
 	const VERSION = 1.0;
13 13
 
14
-	public function __construct() {
14
+	public function __construct () {
15 15
 		$this->logger = new Logger;
16 16
 	}
17 17
 
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 	 * @param string $mode
22 22
 	 * @param string|null $name
23 23
 	 */
24
-	private function run( string $mode = TaskManager::MODE_COMPLETE, string $name = null ) {
24
+	private function run ( string $mode = TaskManager::MODE_COMPLETE, string $name = null ) {
25 25
 		$activity = $mode === TaskManager::MODE_COMPLETE ? TaskManager::MODE_COMPLETE : "$mode $name";
26 26
 		$this->logger->info( "Running $activity" );
27 27
 		$manager = new TaskManager;
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
 	/**
38 38
 	 * Entry point for the whole process
39 39
 	 */
40
-	public function runAll() {
40
+	public function runAll () {
41 41
 		$this->run();
42 42
 	}
43 43
 
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
 	 *
47 47
 	 * @param string $task
48 48
 	 */
49
-	public function runTask( string $task ) {
49
+	public function runTask ( string $task ) {
50 50
 		$this->run( TaskManager::MODE_TASK, $task );
51 51
 	}
52 52
 
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 	 *
56 56
 	 * @param string $subtask
57 57
 	 */
58
-	public function runSubtask( string $subtask ) {
58
+	public function runSubtask ( string $subtask ) {
59 59
 		$this->run( TaskManager::MODE_SUBTASK, $subtask );
60 60
 	}
61 61
 }
Please login to merge, or discard this patch.
includes/Message.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme;
4 4
 
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
 	/**
29 29
 	 * @param string $key
30 30
 	 */
31
-	public function __construct( string $key ) {
31
+	public function __construct ( string $key ) {
32 32
 		$this->key = $key;
33 33
 		$this->value = Config::getInstance()->getWikiMessage( $key );
34 34
 	}
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
 	 * @param array $args
38 38
 	 * @return self
39 39
 	 */
40
-	public function params( array $args ) : self {
40
+	public function params ( array $args ) : self {
41 41
 		$this->value = strtr( $this->value, $args );
42 42
 		return $this;
43 43
 	}
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
 	/**
46 46
 	 * @return string
47 47
 	 */
48
-	public function text() : string {
48
+	public function text () : string {
49 49
 		$this->parsePlurals();
50 50
 		return $this->value;
51 51
 	}
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 	/**
54 54
 	 * Replace {{$plur|<amount>|sing|plur}}
55 55
 	 */
56
-	protected function parsePlurals() {
56
+	protected function parsePlurals () {
57 57
 		$reg = '!\{\{\$plur\|(?P<amount>\d+)\|(?P<sing>[^}|]+)\|(?P<plur>[^|}]+)}}!';
58 58
 
59 59
 		if ( preg_match( $reg, $this->value ) === 0 ) {
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
 		$this->value = preg_replace_callback(
63 63
 			$reg,
64 64
 			function ( $matches ) {
65
-				return intval( $matches['amount'] ) > 1 ? trim( $matches['plur'] ) : trim( $matches['sing'] );
65
+				return intval( $matches[ 'amount' ] ) > 1 ? trim( $matches[ 'plur' ] ) : trim( $matches[ 'sing' ] );
66 66
 			},
67 67
 			$this->value
68 68
 		);
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
 	 * @param int $timestamp
75 75
 	 * @return string
76 76
 	 */
77
-	public static function getTimeWithArticle( int $timestamp ) : string {
77
+	public static function getTimeWithArticle ( int $timestamp ) : string {
78 78
 		$oldLoc = setlocale( LC_TIME, 'it_IT', 'Italian_Italy', 'Italian' );
79 79
 		$timeString = strftime( '%e %B alle %R', $timestamp );
80 80
 		// Remove the left space if day has a single digit
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 	 * @param string $timeString
92 92
 	 * @return int
93 93
 	 */
94
-	public static function getTimestampFromLocalTime( string $timeString ) : int {
94
+	public static function getTimestampFromLocalTime ( string $timeString ) : int {
95 95
 		$englishTime = str_ireplace(
96 96
 			array_values( self::MONTHS ),
97 97
 			array_keys( self::MONTHS ),
@@ -110,12 +110,12 @@  discard block
 block discarded – undo
110 110
 	 * @param string $emptyText
111 111
 	 * @return string
112 112
 	 */
113
-	public static function commaList( array $data, string $emptyText = 'nessuno' ) : string {
113
+	public static function commaList ( array $data, string $emptyText = 'nessuno' ) : string {
114 114
 		if ( count( $data ) > 1 ) {
115 115
 			$last = array_pop( $data );
116 116
 			$ret = implode( ', ', $data ) . " e $last";
117 117
 		} elseif ( $data ) {
118
-			$ret = (string)$data[0];
118
+			$ret = (string)$data[ 0 ];
119 119
 		} else {
120 120
 			$ret = $emptyText;
121 121
 		}
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
 		return $ret;
124 124
 	}
125 125
 
126
-	public function __toString() {
126
+	public function __toString () {
127 127
 		return $this->text();
128 128
 	}
129 129
 }
Please login to merge, or discard this patch.
includes/TaskDataProvider.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme;
4 4
 
@@ -14,16 +14,16 @@  discard block
 block discarded – undo
14 14
 	/** @var array[] */
15 15
 	private $processUsers;
16 16
 	/** @var PageRiconferma[] */
17
-	private $createdPages = [];
17
+	private $createdPages = [ ];
18 18
 
19 19
 	/**
20 20
 	 * Get a list of users to execute tasks on.
21 21
 	 *
22 22
 	 * @return array[]
23 23
 	 */
24
-	public function getUsersToProcess() : array {
24
+	public function getUsersToProcess () : array {
25 25
 		if ( $this->processUsers === null ) {
26
-			$this->processUsers = [];
26
+			$this->processUsers = [ ];
27 27
 			foreach ( PageBotList::get()->getAdminsList() as $user => $groups ) {
28 28
 				if ( $this->shouldAddUser( $groups ) ) {
29 29
 					$this->processUsers[ $user ] = $groups;
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 	 * @param array[] $groups
41 41
 	 * @return bool
42 42
 	 */
43
-	private function shouldAddUser( array $groups ) : bool {
43
+	private function shouldAddUser ( array $groups ) : bool {
44 44
 		$override = true;
45 45
 		$timestamp = PageBotList::getOverrideTimestamp( $groups );
46 46
 
@@ -59,10 +59,10 @@  discard block
 block discarded – undo
59 59
 	 *
60 60
 	 * @return PageRiconferma[]
61 61
 	 */
62
-	public function getOpenPages() : array {
62
+	public function getOpenPages () : array {
63 63
 		static $list = null;
64 64
 		if ( $list === null ) {
65
-			$list = [];
65
+			$list = [ ];
66 66
 			$mainTitle = $this->getConfig()->get( 'main-page-title' );
67 67
 			$params = [
68 68
 				'action' => 'query',
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 			$pages = RequestBase::newFromParams( $params )->execute()->query->pages;
77 77
 			foreach ( reset( $pages )->templates as $page ) {
78 78
 				if ( preg_match( "!$titleReg\/[^\/]+\/\d!", $page->title ) ) {
79
-					$list[] = new PageRiconferma( $page->title );
79
+					$list[ ] = new PageRiconferma( $page->title );
80 80
 				}
81 81
 			}
82 82
 		}
@@ -89,13 +89,13 @@  discard block
 block discarded – undo
89 89
 	 *
90 90
 	 * @return PageRiconferma[]
91 91
 	 */
92
-	public function getPagesToClose() : array {
92
+	public function getPagesToClose () : array {
93 93
 		static $list = null;
94 94
 		if ( $list === null ) {
95
-			$list = [];
95
+			$list = [ ];
96 96
 			foreach ( $this->getOpenPages() as $page ) {
97 97
 				if ( time() > $page->getEndTimestamp() ) {
98
-					$list[] = $page;
98
+					$list[ ] = $page;
99 99
 				}
100 100
 			}
101 101
 		}
@@ -107,22 +107,22 @@  discard block
 block discarded – undo
107 107
 	 *
108 108
 	 * @param string $name
109 109
 	 */
110
-	public function removeUser( string $name ) {
110
+	public function removeUser ( string $name ) {
111 111
 		unset( $this->processUsers[ $name ] );
112 112
 	}
113 113
 
114 114
 	/**
115 115
 	 * @return PageRiconferma[]
116 116
 	 */
117
-	public function getCreatedPages() : array {
117
+	public function getCreatedPages () : array {
118 118
 		return $this->createdPages;
119 119
 	}
120 120
 
121 121
 	/**
122 122
 	 * @param PageRiconferma $page
123 123
 	 */
124
-	public function addCreatedPages( PageRiconferma $page ) {
125
-		$this->createdPages[] = $page;
124
+	public function addCreatedPages ( PageRiconferma $page ) {
125
+		$this->createdPages[ ] = $page;
126 126
 	}
127 127
 
128 128
 	/**
@@ -132,8 +132,8 @@  discard block
 block discarded – undo
132 132
 	 * @param PageRiconferma[] $pages
133 133
 	 * @return bool[]
134 134
 	 */
135
-	public function getGroupOutcomes( string $group, array $pages ) : array {
136
-		$ret = [];
135
+	public function getGroupOutcomes ( string $group, array $pages ) : array {
136
+		$ret = [ ];
137 137
 		foreach ( $pages as $page ) {
138 138
 			$user = $page->getUser();
139 139
 			if ( $user->inGroup( $group ) ) {
Please login to merge, or discard this patch.
includes/Task/UpdateList.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Task;
4 4
 
@@ -19,15 +19,15 @@  discard block
 block discarded – undo
19 19
 	/**
20 20
 	 * @inheritDoc
21 21
 	 */
22
-	protected function getSubtasksMap(): array {
22
+	protected function getSubtasksMap (): array {
23 23
 		// Everything is done here.
24
-		return [];
24
+		return [ ];
25 25
 	}
26 26
 
27 27
 	/**
28 28
 	 * @inheritDoc
29 29
 	 */
30
-	public function runInternal() : int {
30
+	public function runInternal () : int {
31 31
 		$this->actualList = $this->getActualAdmins();
32 32
 		$this->botList = PageBotList::get()->getAdminsList();
33 33
 
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 	/**
54 54
 	 * @return array
55 55
 	 */
56
-	protected function getActualAdmins() : array {
56
+	protected function getActualAdmins () : array {
57 57
 		$this->getLogger()->debug( 'Retrieving admins - API' );
58 58
 		$params = [
59 59
 			'action' => 'query',
@@ -71,8 +71,8 @@  discard block
 block discarded – undo
71 71
 	 * @param \stdClass $data
72 72
 	 * @return array
73 73
 	 */
74
-	protected function extractAdmins( \stdClass $data ) : array {
75
-		$ret = [];
74
+	protected function extractAdmins ( \stdClass $data ) : array {
75
+		$ret = [ ];
76 76
 		$blacklist = $this->getConfig()->get( 'exclude-admins' );
77 77
 		foreach ( $data->query->allusers as $u ) {
78 78
 			if ( in_array( $u->name, $blacklist ) ) {
@@ -89,16 +89,16 @@  discard block
 block discarded – undo
89 89
 	 *
90 90
 	 * @return array[]
91 91
 	 */
92
-	protected function getMissingGroups() : array {
93
-		$missing = [];
92
+	protected function getMissingGroups () : array {
93
+		$missing = [ ];
94 94
 		foreach ( $this->actualList as $adm => $groups ) {
95
-			$curMissing = array_diff_key( $groups, $this->botList[$adm] ?? [] );
95
+			$curMissing = array_diff_key( $groups, $this->botList[ $adm ] ?? [ ] );
96 96
 
97 97
 			foreach ( $curMissing as $group ) {
98 98
 				try {
99 99
 					$missing[ $adm ][ $group ] = $this->getFlagDate( $adm, $group );
100 100
 				} catch ( TaskException $e ) {
101
-					$this->errors[] = $e->getMessage();
101
+					$this->errors[ ] = $e->getMessage();
102 102
 				}
103 103
 			}
104 104
 		}
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
 	 * @return string
114 114
 	 * @throws TaskException
115 115
 	 */
116
-	protected function getFlagDate( string $admin, string $group ) : string {
116
+	protected function getFlagDate ( string $admin, string $group ) : string {
117 117
 		$this->getLogger()->info( "Retrieving $group flag date for $admin" );
118 118
 
119 119
 		$url = DEFAULT_URL;
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
 	 * @param string $group
149 149
 	 * @return string|null
150 150
 	 */
151
-	private function extractTimestamp( \stdClass $data, string $group ) : ?string {
151
+	private function extractTimestamp ( \stdClass $data, string $group ) : ?string {
152 152
 		$ts = null;
153 153
 		foreach ( $data->query->logevents as $entry ) {
154 154
 			if ( isset( $entry->params ) ) {
@@ -167,8 +167,8 @@  discard block
 block discarded – undo
167 167
 	 *
168 168
 	 * @return array[]
169 169
 	 */
170
-	protected function getExtraGroups() : array {
171
-		$extra = [];
170
+	protected function getExtraGroups () : array {
171
+		$extra = [ ];
172 172
 		foreach ( $this->botList as $name => $groups ) {
173 173
 			// These are not groups
174 174
 			unset( $groups[ 'override' ], $groups[ 'override-perm' ] );
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
 	 * @param array[] $extra
189 189
 	 * @return array[]
190 190
 	 */
191
-	protected function getNewContent( array $missing, array $extra ) : array {
191
+	protected function getNewContent ( array $missing, array $extra ) : array {
192 192
 		$newContent = $this->botList;
193 193
 		foreach ( $newContent as $user => $groups ) {
194 194
 			if ( isset( $missing[ $user ] ) ) {
@@ -213,15 +213,15 @@  discard block
 block discarded – undo
213 213
 	 * @param array[] $newContent
214 214
 	 * @return array[]
215 215
 	 */
216
-	protected function removeOverrides( array $newContent ) : array {
217
-		$removed = [];
216
+	protected function removeOverrides ( array $newContent ) : array {
217
+		$removed = [ ];
218 218
 		foreach ( $newContent as $user => $groups ) {
219 219
 			$ts = PageBotList::getValidFlagTimestamp( $groups );
220
-			if ( isset( $groups['override'] ) && ( date( 'd/m', $ts ) ===
220
+			if ( isset( $groups[ 'override' ] ) && ( date( 'd/m', $ts ) ===
221 221
 				date( 'd/m', strtotime( '- 1 days' ) ) )
222 222
 			) {
223 223
 				unset( $newContent[ $user ][ 'override' ] );
224
-				$removed[] = $user;
224
+				$removed[ ] = $user;
225 225
 			}
226 226
 		}
227 227
 
Please login to merge, or discard this patch.
includes/Task/Subtask/FailedUpdates.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Task\Subtask;
4 4
 
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
 	/**
16 16
 	 * @inheritDoc
17 17
 	 */
18
-	public function runInternal() : int {
18
+	public function runInternal () : int {
19 19
 		$failed = $this->getFailures();
20 20
 		if ( $failed ) {
21 21
 			$bureaucrats = array_keys( $this->getDataProvider()->getGroupOutcomes( 'bureaucrat', $failed ) );
@@ -35,12 +35,12 @@  discard block
 block discarded – undo
35 35
 	 *
36 36
 	 * @return PageRiconferma[]
37 37
 	 */
38
-	private function getFailures() : array {
39
-		$ret = [];
38
+	private function getFailures () : array {
39
+		$ret = [ ];
40 40
 		$allPages = $this->getDataProvider()->getPagesToClose();
41 41
 		foreach ( $allPages as $page ) {
42 42
 			if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
43
-				$ret[] = $page;
43
+				$ret[ ] = $page;
44 44
 			}
45 45
 		}
46 46
 		return $ret;
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
 	/**
50 50
 	 * @param string[] $users
51 51
 	 */
52
-	protected function updateBurList( array $users ) {
52
+	protected function updateBurList ( array $users ) {
53 53
 		$this->getLogger()->info( 'Updating bureaucrats list.' );
54 54
 
55 55
 		$this->getLogger()->info( 'Updating bur list. Removing: ' . implode( ', ', $users ) );
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
 	 *
75 75
 	 * @param PageRiconferma[] $pages
76 76
 	 */
77
-	protected function requestRemoval( array $pages ) {
77
+	protected function requestRemoval ( array $pages ) {
78 78
 		$this->getLogger()->info(
79 79
 			'Requesting removal on meta for: ' . implode( ', ', $pages )
80 80
 		);
@@ -113,16 +113,16 @@  discard block
 block discarded – undo
113 113
 	 *
114 114
 	 * @param PageRiconferma[] $pages
115 115
 	 */
116
-	protected function updateAnnunci( array $pages ) {
116
+	protected function updateAnnunci ( array $pages ) {
117 117
 		$this->getLogger()->info( 'Updating annunci' );
118 118
 		$section = 1;
119 119
 
120
-		$names = [];
120
+		$names = [ ];
121 121
 		$text = '';
122 122
 		$msg = $this->msg( 'annunci-text' );
123 123
 		foreach ( $pages as $page ) {
124 124
 			$user = $page->getUser()->getName();
125
-			$names[] = $user;
125
+			$names[ ] = $user;
126 126
 			$text .= $msg->params( [ '$user' => $user ] )->text();
127 127
 		}
128 128
 
@@ -154,17 +154,17 @@  discard block
 block discarded – undo
154 154
 	 *
155 155
 	 * @param PageRiconferma[] $pages
156 156
 	 */
157
-	protected function updateUltimeNotizie( array $pages ) {
157
+	protected function updateUltimeNotizie ( array $pages ) {
158 158
 		$this->getLogger()->info( 'Updating ultime notizie' );
159 159
 		$notiziePage = new Page( $this->getConfig()->get( 'ultimenotizie-page-title' ) );
160 160
 
161
-		$names = [];
161
+		$names = [ ];
162 162
 		$text = '';
163 163
 		$msg = $this->msg( 'ultimenotizie-text' );
164 164
 		foreach ( $pages as $page ) {
165 165
 			$user = $page->getUser()->getName();
166 166
 			$title = $page->getTitle();
167
-			$names[] = $user;
167
+			$names[ ] = $user;
168 168
 			$text .= $msg->params( [ '$user' => $user, '$title' => $title ] )->text();
169 169
 		}
170 170
 
Please login to merge, or discard this patch.