Daimona / BotRiconferme

includes/Task/Task.php

Spacing +5 added lines, -5 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -14,13 +14,13 @@ 
 	 *
 	 * @return string[]
 	 */
-	abstract protected function getSubtasksMap() : array;
+	abstract protected function getSubtasksMap () : array;
 
 	/**
 	 * @param string $subtask Defined in self::SUBTASKS_MAP
 	 * @return TaskResult
 	 */
-	protected function runSubtask( string $subtask ) : TaskResult {
+	protected function runSubtask ( string $subtask ) : TaskResult {
 		$map = $this->getSubtasksMap();
 		if ( !isset( $map[ $subtask ] ) ) {
 			throw new \InvalidArgumentException( "'$subtask' is not a valid task." );
@@ -33,7 +33,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	final public function getOperationName(): string {
+	final public function getOperationName (): string {
 		return 'task';
 	}
 
@@ -43,7 +43,7 @@ 
 	 * @param string $class
 	 * @return Subtask
 	 */
-	private function getSubtaskInstance( string $class ) : Subtask {
+	private function getSubtaskInstance ( string $class ) : Subtask {
 		/** @var Subtask $ret */
 		$ret = new $class(
 			$this->getLogger(),

includes/Task/TaskBase.php

Spacing +7 added lines, -7 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -14,7 +14,7 @@ 
  */
 abstract class TaskBase extends ContextSource {
 	/** @var string[] */
-	protected $errors = [];
+	protected $errors = [ ];
 	/** @var TaskDataProvider */
 	protected $dataProvider;
 
@@ -26,7 +26,7 @@ 
 	 * @param TaskDataProvider $dataProvider
 	 * @param MessageProvider $mp
 	 */
-	final public function __construct(
+	final public function __construct (
 		LoggerInterface $logger,
 		Wiki $wiki,
 		TaskDataProvider $dataProvider,
@@ -41,7 +41,7 @@ 
 	 *
 	 * @return TaskResult
 	 */
-	final public function run() : TaskResult {
+	final public function run () : TaskResult {
 		$class = ( new \ReflectionClass( $this ) )->getShortName();
 		$opName = $this->getOperationName();
 		$this->getLogger()->info( "Starting $opName $class" );
@@ -72,19 +72,19 @@ 
 	 *
 	 * @return int One of the STATUS_* constants
 	 */
-	abstract protected function runInternal() : int;
+	abstract protected function runInternal () : int;
 
 	/**
 	 * How this operation should be called in logs
 	 *
 	 * @return string
 	 */
-	abstract public function getOperationName() : string;
+	abstract public function getOperationName () : string;
 
 	/**
 	 * @return TaskDataProvider
 	 */
-	protected function getDataProvider() : TaskDataProvider {
+	protected function getDataProvider () : TaskDataProvider {
 		return $this->dataProvider;
 	}
 }

includes/Exception/CannotLoginException.php

Spacing +1 added lines, -1 removed lines

@@ -1,4 +1,4 @@
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Exception;
 

includes/Exception/MessageNotFoundException.php

Spacing +1 added lines, -1 removed lines

@@ -1,4 +1,4 @@
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Exception;
 

includes/Exception/MessagesPageDoesNotExistException.php

Spacing +1 added lines, -1 removed lines

@@ -1,4 +1,4 @@
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Exception;
 

includes/MessageProvider.php

Spacing +5 added lines, -5 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types = 1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -20,7 +20,7 @@ 
 	 * @param Wiki $wiki
 	 * @param string $msgTitle
 	 */
-	public function __construct( Wiki $wiki, string $msgTitle ) {
+	public function __construct ( Wiki $wiki, string $msgTitle ) {
 		$this->wiki = $wiki;
 		$this->msgTitle = $msgTitle;
 	}
@@ -28,7 +28,7 @@ 
 	/**
 	 * @throws MessagesPageDoesNotExistException
 	 */
-	private function grabWikiMessages() : void {
+	private function grabWikiMessages () : void {
 		if ( self::$messages !== null ) {
 			return;
 		}
@@ -45,12 +45,12 @@ 
 	 * @return Message
 	 * @throws MessageNotFoundException
 	 */
-	public function getMessage( string $key ) : Message {
+	public function getMessage ( string $key ) : Message {
 		$this->grabWikiMessages();
 		if ( !isset( self::$messages[ $key ] ) ) {
 			throw new MessageNotFoundException( "Message '$key' does not exist." );
 		}
 		// @phan-suppress-next-line PhanTypeArraySuspiciousNullable
-		return new Message( self::$messages[$key] );
+		return new Message( self::$messages[ $key ] );
 	}
 }

includes/Wiki/LoginInfo.php

Spacing +4 added lines, -4 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Wiki;
 
@@ -15,7 +15,7 @@ 
 	 * @param string $username
 	 * @param string $password
 	 */
-	public function __construct( string $username, string $password ) {
+	public function __construct ( string $username, string $password ) {
 		$this->username = $username;
 		$this->password = $password;
 	}
@@ -23,14 +23,14 @@ 
 	/**
 	 * @return string
 	 */
-	public function getUsername() : string {
+	public function getUsername () : string {
 		return $this->username;
 	}
 
 	/**
 	 * @return string
 	 */
-	public function getPassword() : string {
+	public function getPassword () : string {
 		return $this->password;
 	}
 }

includes/Wiki/Wiki.php

Spacing +18 added lines, -18 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Wiki;
 
@@ -32,7 +32,7 @@ 
 	 * @param LoggerInterface $logger
 	 * @param string $domain The URL of the wiki, if different from default
 	 */
-	public function __construct( LoggerInterface $logger, string $domain = DEFAULT_URL ) {
+	public function __construct ( LoggerInterface $logger, string $domain = DEFAULT_URL ) {
 		$this->logger = $logger;
 		$this->domain = $domain;
 	}
@@ -40,7 +40,7 @@ 
 	/**
 	 * @param LoginInfo $li
 	 */
-	public function setLoginInfo( LoginInfo $li ) : void {
+	public function setLoginInfo ( LoginInfo $li ) : void {
 		// FIXME This should be in the constructor, and it should not depend on config
 		$this->loginInfo = $li;
 	}
@@ -48,14 +48,14 @@ 
 	/**
 	 * @return LoginInfo
 	 */
-	public function getLoginInfo() : LoginInfo {
+	public function getLoginInfo () : LoginInfo {
 		return $this->loginInfo;
 	}
 
 	/**
 	 * @param bool $bot
 	 */
-	public function setEditsAsBot( bool $bot ) : void {
+	public function setEditsAsBot ( bool $bot ) : void {
 		// FIXME same as setLoginInfo
 		$this->botEdits = $bot;
 	}
@@ -63,7 +63,7 @@ 
 	/**
 	 * @return bool
 	 */
-	public function getEditsAsBot() : bool {
+	public function getEditsAsBot () : bool {
 		return $this->botEdits;
 	}
 
@@ -76,7 +76,7 @@ 
 	 * @throws MissingPageException
 	 * @throws MissingSectionException
 	 */
-	public function getPageContent( string $title, int $section = null ) : string {
+	public function getPageContent ( string $title, int $section = null ) : string {
 		$msg = "Retrieving content of $title" . ( $section !== null ? ", section $section" : '' );
 		$this->logger->debug( $msg );
 		$params = [
@@ -88,7 +88,7 @@ 
 		];
 
 		if ( $section !== null ) {
-			$params['rvsection'] = $section;
+			$params[ 'rvsection' ] = $section;
 		}
 
 		$req = $this->buildRequest( $params );
@@ -98,7 +98,7 @@ 
 			throw new MissingPageException( $title );
 		}
 
-		$mainSlot = $page->revisions[0]->slots->main;
+		$mainSlot = $page->revisions[ 0 ]->slots->main;
 
 		if ( $section !== null && isset( $mainSlot->nosuchsection ) ) {
 			throw new MissingSectionException( $title, $section );
@@ -112,7 +112,7 @@ 
 	 * @param array $params
 	 * @throws EditException
 	 */
-	public function editPage( array $params ) : void {
+	public function editPage ( array $params ) : void {
 		$this->login();
 
 		$params = [
@@ -121,7 +121,7 @@ 
 		] + $params;
 
 		if ( $this->getEditsAsBot() ) {
-			$params['bot'] = 1;
+			$params[ 'bot' ] = 1;
 		}
 
 		$res = $this->buildRequest( $params )->setPost()->execute();
@@ -139,7 +139,7 @@ 
 	 * Login wrapper. Checks if we're already logged in and clears tokens cache
 	 * @throws LoginException
 	 */
-	public function login() : void {
+	public function login () : void {
 		if ( $this->loginInfo === null ) {
 			throw new CannotLoginException( 'Missing login data' );
 		}
@@ -169,7 +169,7 @@ 
 
 		self::$loggedIn = true;
 		// Clear tokens cache
-		$this->tokens = [];
+		$this->tokens = [ ];
 		$this->logger->info( 'Login succeeded' );
 	}
 
@@ -179,7 +179,7 @@ 
 	 * @param string $type
 	 * @return string
 	 */
-	public function getToken( string $type ) : string {
+	public function getToken ( string $type ) : string {
 		if ( !isset( $this->tokens[ $type ] ) ) {
 			$params = [
 				'action' => 'query',
@@ -202,7 +202,7 @@ 
 	 * @param string $title
 	 * @return int
 	 */
-	public function getPageCreationTS( string $title ) : int {
+	public function getPageCreationTS ( string $title ) : int {
 		$params = [
 			'action' => 'query',
 			'prop' => 'revisions',
@@ -215,7 +215,7 @@ 
 
 		$res = $this->buildRequest( $params )->execute();
 		$data = $res->query->pages;
-		return strtotime( reset( $data )->revisions[0]->timestamp );
+		return strtotime( reset( $data )->revisions[ 0 ]->timestamp );
 	}
 
 	/**
@@ -224,7 +224,7 @@ 
 	 * @param string $title
 	 * @param string $reason
 	 */
-	public function protectPage( string $title, string $reason ) : void {
+	public function protectPage ( string $title, string $reason ) : void {
 		$this->logger->info( "Protecting page $title" );
 		$this->login();
 
@@ -245,7 +245,7 @@ 
 	 * @param array $params
 	 * @return RequestBase
 	 */
-	private function buildRequest( array $params ) : RequestBase {
+	private function buildRequest ( array $params ) : RequestBase {
 		return RequestBase::newFromParams( $params )->setUrl( $this->domain );
 	}
 }

includes/Logger/WikiLogger.php

Spacing +6 added lines, -6 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Logger;
 
@@ -29,7 +29,7 @@ 
 	 * @param string $summary
 	 * @param string $minlevel
 	 */
-	public function __construct( Page $logPage, string $summary, $minlevel = LogLevel::INFO ) {
+	public function __construct ( Page $logPage, string $summary, $minlevel = LogLevel::INFO ) {
 		$this->minLevel = $this->levelToInt( $minlevel );
 		$this->logPage = $logPage;
 		$this->summary = $summary;
@@ -39,16 +39,16 @@ 
 	 * @inheritDoc
 	 * @suppress PhanUnusedPublicMethodParameter
 	 */
-	public function log( $level, $message, array $context = [] ) :void {
+	public function log ( $level, $message, array $context = [ ] ) :void {
 		if ( $this->levelToInt( $level ) >= $this->minLevel ) {
-			$this->buffer[] = $this->getFormattedMessage( $level, $message );
+			$this->buffer[ ] = $this->getFormattedMessage( $level, $message );
 		}
 	}
 
 	/**
 	 * @return string
 	 */
-	protected function getOutput() : string {
+	protected function getOutput () : string {
 		$line = str_repeat( '-', 80 );
 		return "\n\n" . implode( "\n", $this->buffer ) . "\n$line\n\n";
 	}
@@ -56,7 +56,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function flush() : void {
+	public function flush () : void {
 		if ( $this->buffer ) {
 			$this->logPage->edit( [
 				'appendtext' => $this->getOutput(),